Commit graph

119 commits

Author SHA1 Message Date
Jeff Morriss
75c3c92f19 Add a "-build" argument to checkAPIs.pl. Use that argument when building
from makefiles (and thus from the buildbot).

The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.

As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.

svn path=/trunk/; revision=41943
2012-04-04 20:46:49 +00:00
Jeff Morriss
b21b495f9f Don't generate the conformance file for exported types when building the
dissector; instead built it only when the separate target (generate_export)
is built.

Built generate_export when building "all".

This prevents the exp_*.cnf files from being regenerated each time another one
of the exp_*.cnf files (which the current dissector depends on) has changed
(despite the fact that the exported types does not depe

Also fix the CLEANFILES definition so it actually cleans things.

svn path=/trunk/; revision=39421
2011-10-14 10:22:01 +00:00
Jeff Morriss
cf012d27b1 Build the ASN.1 dissectors directly into epan/dissectors (rather than building
them and then copying them over).  The "all" target to builds these dissectors
now (instead of "generate_files" and/or "copy_files").

asn2wrs's "-O" option now means "the dissector goes in this directory" (rather
than "all output goes in this directory"); it also means that the "-s" (single
output file) option is now required.

Fix things up so that it's possible to build all of the ASN.1 dissectors in
one shot.

Fix building of conformance files when doing out-of-source-tree builds.


Unfortunately "make all" in the asn1 directory always builds something--I think
because of circular depedencies.

svn path=/trunk/; revision=39333
2011-10-10 02:31:11 +00:00
Chris Maynard
352cc7a410 Fix bug 5848, "https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848", which was apparently introduced with r27287 (http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-h225.c?r1=26698&r2=27287). Regenerate the packet-h225.c dissector. Patch from ericn1234@yahoo.com.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848

svn path=/trunk/; revision=38399
2011-08-07 20:50:31 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman
ae7d471ebe Make the changes from:
Use value_string_ext fcns to access certain value_string arrays;
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.
In the source files of the as2wrs generated dissectors.

svn path=/trunk/; revision=34803
2010-11-07 20:51:16 +00:00
Jeff Morriss
81da8e0b6b Use find_or_create_conversation() in some ASN.1 dissectors
svn path=/trunk/; revision=32791
2010-05-13 18:55:31 +00:00
Tomas Kukosa
05d418eba8 H.225.0 updated to version 7 (2009-12)
svn path=/trunk/; revision=32672
2010-05-05 13:14:41 +00:00
Bill Meier
f8b92f8d0b #include <stdio.h> not needed.
svn path=/trunk/; revision=32405
2010-04-06 17:01:14 +00:00
Bill Meier
97d3a8bb10 Remove two unused global variables (one of which was causing a gcc -Wshadow warning).
svn path=/trunk/; revision=31690
2010-01-26 23:43:48 +00:00
Anders Broman
ba8d7bd919 Get rid of check_col();
svn path=/trunk/; revision=31544
2010-01-17 12:19:02 +00:00
Anders Broman
04d526a914 check_col.diff
Remove redundant calls to check_col() in the template files and regenerate.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31521
2010-01-13 21:27:44 +00:00
Kovarththanan Rajaratnam
7ab993bee7 Remove unused NEED_PACKET_PROTO_H variable
svn path=/trunk/; revision=30409
2009-10-08 17:26:57 +00:00
Kovarththanan Rajaratnam
65c53fedb6 Don't guard col_append_str with check_col
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam
c19f7978db Sanitize epan includes
svn path=/trunk/; revision=29500
2009-08-21 20:32:50 +00:00
Kovarththanan Rajaratnam
ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Gerald Combs
931a750908 Add a couple of pointer checks.
svn path=/trunk/; revision=29301
2009-08-05 00:36:27 +00:00
Stig Bjørlykke
f8166804a8 From Kovarththanan Rajaratnam:
More asn1/* header field info cleanup

svn path=/trunk/; revision=28826
2009-06-24 01:40:54 +00:00
Stig Bjørlykke
6f2d887850 From Kovarththanan Rajaratnam via bug 3548:
More header_field_info cleanup in the asn1 cnf files.

Dissectors will be regenerated later.

svn path=/trunk/; revision=28782
2009-06-20 18:33:33 +00:00
Tomas Kukosa
c0af52c979 Fix Bug 3219: avoid overwriting H.323 callIdentifier value when CallIdentifier type is called from another dissector, e.g. H.450
svn path=/trunk/; revision=27287
2009-01-22 19:48:12 +00:00
Tomas Kukosa
bfdccf3f9d - update H.245 to v14 (06/2008)
- use #.MODULE_EXPORT to avoid conflict between TransportAddress from H.225 and H.245
- regenerate H.323 family dissectors 

svn path=/trunk/; revision=26739
2008-11-10 13:31:16 +00:00
Bill Meier
017f36d61b Minor cleanup mostly related to proto_reg_handoff
Remove code for unused handles;
 Localize handles to proto_reg_handoff as appropriate;
 Localize "saved_prefs" to proto_reg_handoff;
 In some cases: move "once-only" code in proto_reg_handoff
  so that it's executed only the first time thru 
  proto_reg_handoff;
 Properly delete/add port when pref changed (packet_ulp);

svn path=/trunk/; revision=26697
2008-11-04 22:01:35 +00:00
Tomas Kukosa
7d1c30c417 Get rid of next few warnings (dissect_per_choice needs signed value parameter)
svn path=/trunk/; revision=25840
2008-07-26 19:07:04 +00:00
Tomas Kukosa
1644e4138a Get rid of few warnings (unused generated code, signed/unsigned mismatch)
svn path=/trunk/; revision=25839
2008-07-26 15:28:04 +00:00
Anders Broman
45b3155321 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25335
2008-05-21 05:41:39 +00:00
Tomas Kukosa
27a531e06a more sophisticated H245 OLC handling focusing on more reliable T.38 establishment
svn path=/trunk/; revision=24043
2008-01-09 13:30:31 +00:00
Tomas Kukosa
7529f33437 support for additionally SIZE constrained Typereference
the support is only semiautomated as this feature does not occur very often
use this feature for the TBCD-STRING in the H.225 dissector

svn path=/trunk/; revision=23958
2007-12-28 10:42:44 +00:00
Jörg Mayer
3d22aa561b asn1/*/Makefile.nmake were not part of the source package.
Spotted by Tomas Kukosa.

svn path=/trunk/; revision=23921
2007-12-19 10:02:50 +00:00
Gerald Combs
7d5b4af5d0 Make sure h225_pi is never NULL.
svn path=/trunk/; revision=23568
2007-11-24 19:13:54 +00:00
Gerald Combs
b8c7fa9bc6 Don't dereference a NULL pointer.
svn path=/trunk/; revision=23438
2007-11-12 20:02:24 +00:00
Anders Broman
43700969a6 Use oid_add_from_string for adding names.
(gsmmap and inap does not compile at the moment).

svn path=/trunk/; revision=23324
2007-10-31 21:24:16 +00:00
Tomas Kukosa
44800d2c5a H.460 new dissector implemented (H.460.2-H.460.22)
H.225
 - change RysMessage_vals to h225_Rasmessage_vals
 - use #.PDU directive for H323-UserInformation and RasMessage instead of implementing it by hands
 - register RasMessage_PDU as "h225.ras" dissector for calling it from H.460
asn2wrs make PDUs exportable

svn path=/trunk/; revision=23226
2007-10-18 13:35:57 +00:00
Tomas Kukosa
286f231eb9 new H.323 dissector
- Generic Extensible Framework helper
  - Annex M1 (QSIG over H.323)
  - Annex M4
  - Annex R
H.225/H.245 support for Generic Extensible Framework (GEF)
H.235 register MIKEY into new H.225/H.245 GEF tables
regenerate H.225,H.245,H.235,H.450,H.450-ROS,T.35 from new makefiles

svn path=/trunk/; revision=23216
2007-10-17 10:25:21 +00:00
Jörg Mayer
c2d0c8fa31 - Fix svn:ignore for all directories
- gsmmap: uncomment -s option in gsmmap.cnf
- Fix cyclic dependencies:
  + Remove EXPORT_CNF from dependencies for cnf files
  + Replace all INCLUDE ...-exp.cnf with IMPORT ...-exp.cnf

svn path=/trunk/; revision=23202
2007-10-16 13:59:40 +00:00
Tomas Kukosa
5ba3d8aaaa - add missing h450-ros and q932-ros clean rules to asn1/Makefile.nmake
- solve h225<->h235 cyclic dependency with usage of -E option and #.IMPORT directive

svn path=/trunk/; revision=23189
2007-10-15 18:44:53 +00:00
Tomas Kukosa
6115b7601d better solution for different submake calling on Windows and Linux
svn path=/trunk/; revision=23131
2007-10-10 10:25:09 +00:00
Tomas Kukosa
1b04a660e5 next step to solve dependency generation
svn path=/trunk/; revision=23130
2007-10-10 08:42:19 +00:00
Tomas Kukosa
20078dd04a solution for different submake calling on Windows and Linux
only one dissector is committed to test it

svn path=/trunk/; revision=23128
2007-10-10 08:14:36 +00:00
Jörg Mayer
cbea431415 Add some dependencies
svn path=/trunk/; revision=23103
2007-10-09 01:23:21 +00:00
Jörg Mayer
077819f008 convert to new Makefile structure
svn path=/trunk/; revision=23085
2007-10-07 21:07:33 +00:00
Tomas Kukosa
e461d0d0e8 export more types from H.225.0 and H.245 which will be necessary for H.460.x, H.323 (Annex M,R), H.501
svn path=/trunk/; revision=23069
2007-10-05 07:44:03 +00:00
Tomas Kukosa
138050c4ea improvements in ROS handling in Q.932 and H.450
move common ROS code into ros/ros-*.cnf files

svn path=/trunk/; revision=22936
2007-09-24 11:01:53 +00:00
Luis Ontanon
00c5e48a17 get users of oid_resolv to use the new oids, rollout packet-snmp.c
svn path=/trunk/; revision=22651
2007-08-25 01:14:24 +00:00
Jörg Mayer
b312e64f6a get_ber_length doesn't need the tree argument, get rid of it.
Rebuild asn1 dissectors.

svn path=/trunk/; revision=22627
2007-08-24 07:12:04 +00:00
Tomas Kukosa
31e3747eab get rid of few warnings
svn path=/trunk/; revision=21933
2007-05-25 11:40:32 +00:00
Anders Broman
1cf1f16391 Split out common asn1 stuff to asn1.h and include that where needed.
svn path=/trunk/; revision=21635
2007-05-01 22:05:11 +00:00
Tomas Kukosa
cfc38cfdbd use new possibility to set #.EXPORTS flag for whole directive
svn path=/trunk/; revision=21469
2007-04-18 10:52:46 +00:00
Tomas Kukosa
a91eb30021 H.225.0 updated to 05/2006, Amendment 1 01/2007
svn path=/trunk/; revision=20807
2007-02-14 08:08:44 +00:00
Tomas Kukosa
9a36b34d03 fix registration H.225 over TLS
svn path=/trunk/; revision=20449
2007-01-16 07:53:46 +00:00
Ulf Lamping
647533a5ef put every python script name into "" so the call won't fail on Win32 native python.
The problem is the slash in e.g.:

 @$(PYTHON) ../../tools/make-dissector-reg.py

is interpreted as an option instead of being part of the path.

I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.

svn path=/trunk/; revision=19730
2006-10-29 17:19:52 +00:00