c34bf9cb64
Get rid of the CRs at the ends of lines (GCC was upset by at least some
...
of them).
svn path=/trunk/; revision=7733
2003-05-24 20:49:58 +00:00
dcc9976c13
Fix more string-related nits found by Timo Sirainen/
...
svn path=/trunk/; revision=7732
2003-05-24 19:51:48 +00:00
356ddbd284
Fix instances where the return value of snprintf() was being checked for -1,
...
but not for <buf_size> or greater. Discovered by Timo Sirainen.
svn path=/trunk/; revision=7731
2003-05-24 17:45:10 +00:00
4d5243dcc7
Timo Sirainen discovered that snprintf() returning -1 wasn't being handled
...
properly. Use a GString instead.
svn path=/trunk/; revision=7730
2003-05-24 16:54:42 +00:00
74ed47db18
From Brad Hards, DISTCC protocol dissector.
...
Added TCP desegmentation to the dissector.
svn path=/trunk/; revision=7729
2003-05-24 12:22:52 +00:00
86cee26f99
Note that we should probably do PPP Multilink reassembly.
...
svn path=/trunk/; revision=7728
2003-05-24 08:43:18 +00:00
0d855d0ebc
Adding support for GSSAPI GSS_Wrap tokens and refactoring the routine
...
that was already there.
svn path=/trunk/; revision=7727
2003-05-24 05:05:26 +00:00
f94c7971a5
Add an API to get the dissector name from a dissector handle.
...
svn path=/trunk/; revision=7726
2003-05-23 22:09:36 +00:00
8a1947f01d
Commit the changes to allow us to dissect GSSAPI GetMIC tokens.
...
However, it is now clear in the dissection tree for NFSv4 with RPCSEC_GSS
security in use that the naming is just wrong :-(
svn path=/trunk/; revision=7725
2003-05-23 18:34:58 +00:00
8df9b98bfc
First changes to properly support RFC1964 so that GSSAPI GetMIC and other
...
tokens can be handled.
Really, dissect-spnego-krb5 or whatever, should be renamed to something like
dissect-gssapi-tokens or dissect-gssapi-rfc1964 ...
svn path=/trunk/; revision=7724
2003-05-23 17:46:06 +00:00
d3913cfdb1
Move the base64_decode() function somewhere where other dissectors can
...
use it.
svn path=/trunk/; revision=7723
2003-05-23 05:25:19 +00:00
07ab324c4e
I don't think there is any such thing as a pointer to a policy handle.
...
Just dissect them in place.
svn path=/trunk/; revision=7722
2003-05-23 05:20:58 +00:00
e75d49c848
Fix typo in name of ett for krb5 auth verifier.
...
svn path=/trunk/; revision=7721
2003-05-23 05:11:03 +00:00
dc815d6f4c
Quieten some unused variable warnings.
...
svn path=/trunk/; revision=7720
2003-05-23 05:06:49 +00:00
c2036f97f1
Initialise sid_str in case dissect_nt_sid() can't return a string
...
representation for the sid.
svn path=/trunk/; revision=7719
2003-05-23 01:45:27 +00:00
a4f0cdaba4
Remove some accidentally commited debugging strings.
...
svn path=/trunk/; revision=7718
2003-05-22 21:39:44 +00:00
9ebbe1fb1f
A small fix to NFSv4 to properly decode the secinfo response array, the array
...
of secinfo flavors returned.
svn path=/trunk/; revision=7717
2003-05-22 21:37:54 +00:00
e2ceb7ce64
Put in some missing contributor addresses.
...
svn path=/trunk/; revision=7716
2003-05-22 20:33:04 +00:00
77fe92c28d
A small fix to packet-rpc.c noticed by Tony Schene.
...
Fixes a mistake I introduced ...
I am still seeing malformed packets on secinfo stuff, which I hope to fix
soon.
svn path=/trunk/; revision=7715
2003-05-22 17:11:18 +00:00
e6359f68ee
remove unused include that was added by mistake
...
svn path=/trunk/; revision=7714
2003-05-22 11:58:54 +00:00
1909e86e15
Add snooping of sid->domain mapping from POLICY_ACCOUNT_DOMAIN_INFO structures
...
svn path=/trunk/; revision=7713
2003-05-22 11:48:28 +00:00
5feaba4955
make dissect_nt_sid() return a sid string that also contains the proper name for the sid.
...
this prettifies some dcerpc interfaces
svn path=/trunk/; revision=7712
2003-05-22 11:32:06 +00:00
5512ef4745
Rearrange sid snooping a bit.
...
Add snooping of sid->domain mapping for POLICY_DNS_DOMAIN_INFO
svn path=/trunk/; revision=7711
2003-05-22 11:03:15 +00:00
439183fa07
Update with J Bruce Field's changes to support RPCSEC_GSS.
...
svn path=/trunk/; revision=7710
2003-05-22 05:49:23 +00:00
75f18ecfee
Make one QIP infolevel specify a sid hf field and update the embryonic sid snooping framework to handle the new hw name
...
svn path=/trunk/; revision=7709
2003-05-21 10:39:19 +00:00
14f5d761c1
Change the interface to dissect_nt_sid so that we can provide a hf field to use
...
to describe the sid instead of the default smb.sid one
svn path=/trunk/; revision=7708
2003-05-21 10:16:10 +00:00
8271c6a106
Change the interface to dissect_ndr_nt_SID to take the extra parameter hf_sid
...
if the caller wants something else instead of "smb.sid"
svn path=/trunk/; revision=7707
2003-05-21 10:06:29 +00:00
1cedc6aab9
Change the interface to dissect_ndr_nt_PSID to take one extra parameter which if !=-1 is a hf field for the sid to use instead of the default smb.sid one.
...
svn path=/trunk/; revision=7706
2003-05-21 09:34:54 +00:00
524a84b5e9
If the reported length of the TCP packet is less than the TCP header
...
length, we can't get the segment length (although we can at least try to
dissect the header). If that's the case, put in Ronnie's "short
segment" note.
Also, put into the information we pass to TCP taps an indication of
whether the segment length is valid or not.
svn path=/trunk/; revision=7705
2003-05-21 06:28:03 +00:00
3847052a87
If we're inside an error packet, don't assume we know the length of the
...
TCP segment, as we might not have the entire segment.
svn path=/trunk/; revision=7704
2003-05-21 05:57:24 +00:00
5bd844f8b4
If we were handed a fragmented packet, don't do anything that depends on
...
knowing the actual length of the packet, as we don't know that length
(IP fragments don't contain the length of the full packet - you don't
know how big the reassembled packet is until you reassemble it).
We don't have to worry about dissecting the TCP header in them, though.
svn path=/trunk/; revision=7703
2003-05-21 05:43:27 +00:00
413228f109
Make dissect_rpc_opaque_data available and allow it to take a dissection
...
routine ...
I am not happy with the signature for it as yet, though.
svn path=/trunk/; revision=7702
2003-05-21 02:48:40 +00:00
3d65182245
From Miha Jemec: clean up and simplify the RTP dissector and tap code.
...
svn path=/trunk/; revision=7701
2003-05-20 21:22:59 +00:00
50766c96ad
Lump TCPIPtrace and UCX$TRACE together and add TCPtrace to the mix.
...
svn path=/trunk/; revision=7700
2003-05-20 20:26:05 +00:00
e634bd0856
From Martin Warnes: fix to check the "XXXtrace" part of the per-packet
...
line, not the "RCV packet" part, so that we recognize files even if they
don't have an "RCV packet" line in the first 200 lines.
svn path=/trunk/; revision=7699
2003-05-20 20:17:03 +00:00
49b51db7f2
Do not decode the full tcp header if the reported length is less than 20
...
or the reported tcp header length.
This is probably caused either by a very very short capture length or by
nmap or someone playing firewall fragment games to the tcp flags field.
svn path=/trunk/; revision=7698
2003-05-20 10:14:20 +00:00
552b1bbe7f
Clean "dissect_rpc_opaque_data()" up a bit; for example, there's no need
...
to do a "proto_tree_add_string_hidden()" to add the string data to the
protocol tree, given that we explicitly add it as a non-hidden item
(regardless of whether it's string data or binary data).
svn path=/trunk/; revision=7697
2003-05-20 07:56:46 +00:00
e1d0bb0329
Fix even more indentation.
...
svn path=/trunk/; revision=7696
2003-05-20 07:38:55 +00:00
5b9c797797
Fix more indentation.
...
svn path=/trunk/; revision=7695
2003-05-20 07:37:37 +00:00
3e9ae3f138
Fix indentation.
...
svn path=/trunk/; revision=7694
2003-05-20 07:35:09 +00:00
42d3c64449
Timo Sirainen pointed out a few problems with string handling in the
...
BGP code. Replace many strings with GStrings.
svn path=/trunk/; revision=7693
2003-05-20 03:01:21 +00:00
f921aee54d
From Martin Warnes: support for VMS UCX$TRACE output in wiretap.
...
svn path=/trunk/; revision=7692
2003-05-19 20:58:18 +00:00
5ed9fd0ca9
From Motonori Shindo: update to support
...
draft-ietf-idr-bgp-ext-communities rather than
draft-ramachandra-bgp-ext-communities, and get rid of unused
MAX_SIZE_OF_EXT_COM_NAMES #define.
svn path=/trunk/; revision=7691
2003-05-19 20:36:49 +00:00
1915f6ec0c
From Olivier Biot: fix incorrect tvbuff definition in the WTP PDU
...
concatenation situation. Now the WSP dissector wanting to display the
entire PDU will stick to the sub-tvbuff boundaries in the data highlight
pane.
svn path=/trunk/; revision=7690
2003-05-19 20:23:29 +00:00
e02354fab2
Fix a -z io,users,ip calculations bug.
...
stats were calculated for the wrong direction.
From Martin Visser
svn path=/trunk/; revision=7689
2003-05-19 11:16:29 +00:00
7a132e5b48
More tvb_get_nstringz0() fixes. Timo Sirainen pointed out that Bad
...
Things can happen if we pass a zero buffer length to tvb_get_nstringz0().
Throw an exception if this happens.
In various dissectors make sure the tvb_get_nstringz0()'s buffer length
is greater than zero.
svn path=/trunk/; revision=7688
2003-05-19 03:23:12 +00:00
a53a260f3c
Note that the output format list is displayed by the "-h" flag.
...
svn path=/trunk/; revision=7687
2003-05-17 17:05:12 +00:00
11b8e719f5
Add the list of output file format specs to Tethereal's man page.
...
At some point we should probably add the list automatically, like we do
the filter fields.
svn path=/trunk/; revision=7686
2003-05-17 17:02:02 +00:00
926c61b11c
Update the tcp sequence analysis to understand and decode properly
...
the rather brilliant keep-alive packets solaris use.
Solaris does not do RFC793 keepalives at all, instead they do a quite
brilliant workalike that gies them reliable keepalives.
svn path=/trunk/; revision=7685
2003-05-16 10:35:19 +00:00
be8c81fc84
Tap SMB packets before we call the dissecotrs so that even if there
...
is an exception (i.e. short packet) the tap listener will still
be alled.
svn path=/trunk/; revision=7684
2003-05-16 10:24:13 +00:00
Guy Harris