Commit Graph

362 Commits

Author SHA1 Message Date
Ronnie Sahlberg bef8e01fcd fix small bug that gets offset confused for CHOICE { } OPTIONAL if there were no arms that matched
svn path=/trunk/; revision=12425
2004-10-28 11:35:43 +00:00
Guy Harris ea673ada7a The offset to the first IFD in a TIFF file is 4 bytes long, not 2 bytes
long.

The offset is relative to the first byte of the TIFF structure, which is
after the "Exif\0" *and* the extra byte after "Exif\0".

Loop over all IFDs.

Sanity check the offset to the first IFD and the offset in each IFD to
the next IFD.

svn path=/trunk/; revision=12424
2004-10-28 07:50:07 +00:00
Guy Harris 21e7c6bc78 "dissect_MAP_Dialogue()" returns no value; declare its return value as
"void".

Fix a typo in the MAP Dialogue dissector template .h file.

Re-generate the MAP Dialogue dissector files and set svn:keywords to Id
and svn:eol-style to native for them.

svn path=/trunk/; revision=12419
2004-10-27 21:16:18 +00:00
Anders Broman 9315137a65 Add a MapDialouge dissector ( can be tested with the file gsm-ss-01.snoop )
svn path=/trunk/; revision=12416
2004-10-27 20:17:38 +00:00
Anders Broman 784fece9c0 Improve OID dissection and make it possible to call an "OID" Dissector for Dialougedata parameter.
svn path=/trunk/; revision=12413
2004-10-27 20:04:56 +00:00
Anders Broman 0510221c29 Make it possible to register a string for an OID in the hash table.
svn path=/trunk/; revision=12412
2004-10-27 19:59:44 +00:00
Guy Harris 948d61bae1 Check to make sure we don't give a protocol tree item a negative length.
Clean up indentation.

If we dissect an octet string and then re-dissect it as a particular
type of data, don't use the end offset from the re-dissection as the
offset of the end of the octet string - just use the result of
"dissect_per_octet_string()".

svn path=/trunk/; revision=12406
2004-10-27 10:02:45 +00:00
Guy Harris 816267f2c1 Don't have two variables, in different scopes in the same routine, have
the same name.

Fix up alignment.

svn path=/trunk/; revision=12400
2004-10-27 02:52:40 +00:00
Guy Harris 685bbf7b35 Encapsulate into a macro the idiom
if(offset&0x07){
		offset=(offset&0xfffffff8)+8;
	}

for byte-aligning a bit offset.

svn path=/trunk/; revision=12399
2004-10-27 02:34:30 +00:00
Guy Harris e8727b5615 Fix the file name in the initial comment.
svn path=/trunk/; revision=12397
2004-10-26 18:41:25 +00:00
Gerald Combs 7053cbed3b Rename the "boolean" enum to "val_boolean" lest the Microsoft compiler let
its displeasure be known.

svn path=/trunk/; revision=12396
2004-10-26 16:08:16 +00:00
Ronnie Sahlberg ec0752c135 new cms dissector based on updated and cleaned up conformance and template file.
use the nice #.REGISTER directive instead of doing it by hand.


svn path=/trunk/; revision=12393
2004-10-26 13:53:30 +00:00
Guy Harris 4011ff29b7 Add a "data" item to the opt_info structure, containing a "const void
*".  For val_u_byte, if non-null, it points to a "value_string" table to
be used to interpret the value.  Replace "toggle" and "yes_no" with
"boolean, and have the "data" pointer point to a "struct
true_false_string" to be used to interpret the value.

The NetBIOS-over-TCP/IP Node Type option can now be a regular val_u_byte
value, with the appropriate value_string table.

Construct the item for DHCP options by initializing it without the value
and appending the value to the item's string with
"proto_item_append_text()".

svn path=/trunk/; revision=12391
2004-10-26 07:00:23 +00:00
Guy Harris 671cd939ae Make yes_no work in "dissect_netware_ip_suboption()" the way it works
elsewhere, and replace "struct o63_opt_info" with "struct opt_info".

svn path=/trunk/; revision=12390
2004-10-25 23:25:59 +00:00
Guy Harris 32539c3e28 "struct o43pxeclient_opt_info" and "struct o43cablelabs_opt_info" look
just like "struct opt_info", except for the name of the "enum
field_type" field; use "opt_info" instead of them.  Rename the
equivalent field in "struct o63_opt_info", as well, with an eye towards
changing "struct opt_info" to be able to replace "struct o63_opt_info"
as well.

svn path=/trunk/; revision=12389
2004-10-25 09:31:13 +00:00
Guy Harris ec3230d492 Remove val_s_long as it's unimplemented and unused - put it back if it's
ever necessary.

Make some options, that have only one IPv4 address, use ipv4 rather than
ipv4_list.

Add val_u_short_list, and have val_u_short accept one and only one
16-bit integer.  Give options the appropriate type.

Shuffle the types a bit in the enum, and shuffle the cases for types
around to match the order in the enum.

svn path=/trunk/; revision=12388
2004-10-25 08:56:39 +00:00
Guy Harris b140c74433 Rename "ipv4" to "ipv4_list", as it's used for lists of IPv4 addresses,
and add a separate "ipv4"; use that in the dissector for Netware IP
options.

Add a "presence" option type, for options with no value whose presence
is significant; use that in the dissector for Netware IP options.

svn path=/trunk/; revision=12387
2004-10-25 08:33:39 +00:00
Guy Harris a7b17234c3 Pass to the the routines that dissect suboption lists the offset of the
end of the option, and have them do bounds checking.  Also, in some
places, check the suboption length.

In "dissect_netware_ip_suboption()", process the suboption length
(which, according to RFC 2242, is present in all suboptions), and use
val_u_byte rather than val_u_short for 1-byte options.

svn path=/trunk/; revision=12386
2004-10-25 08:17:11 +00:00
Guy Harris e08ef66cfe Restructure the DHCP option parsing a bit, to make it a bit clearer -
and fix some bugs that this made a bit more obvious.  Add checks of the
option length.

Clean up white space.

svn path=/trunk/; revision=12385
2004-10-24 22:53:06 +00:00
Guy Harris 7b1b2d0b1a Don't display the FQDN in the FQDN option if the length of the FQDN is
zero.

Clean up some field names and descriptions.

svn path=/trunk/; revision=12384
2004-10-24 10:30:03 +00:00
Guy Harris b248485905 Fix the length used for the name in the FQDN option.
svn path=/trunk/; revision=12383
2004-10-24 10:18:16 +00:00
Ronnie Sahlberg 97a6dc74e7 make SEQUENCE OF and CHOICE handle indefinite length encodings
svn path=/trunk/; revision=12382
2004-10-24 03:51:27 +00:00
Guy Harris f6881b345f From Yaniv Kaul: name some more interface calls.
svn path=/trunk/; revision=12381
2004-10-24 01:29:03 +00:00
Guy Harris cbbdf75b4d Remove the include of <epan/prefs.h> from files that don't call any
preference routines.

svn path=/trunk/; revision=12380
2004-10-23 09:20:39 +00:00
Guy Harris 02c9bf57f4 Put the name, as well as the value, of the family and subfamily fields
into the protocol tree item that contains them.

svn path=/trunk/; revision=12379
2004-10-23 08:37:21 +00:00
Guy Harris 7e0170ffbf From Josh Bailey: fix the fetch of the IPDC payload length, it's only 10
bits long.

svn path=/trunk/; revision=12378
2004-10-22 18:03:21 +00:00
Guy Harris bd23f6f1a8 From Alejandro Vaquero: start T.38 conversations for SDP sessions.
"T38" -> "T.38" in the T.38 dissector.

svn path=/trunk/; revision=12374
2004-10-22 06:19:00 +00:00
Guy Harris 1a4033c65e From Francisco Alcoba: declare the tap data as static, so it's still
there when the tap is called (which happens after dissection is
complete).

svn path=/trunk/; revision=12373
2004-10-22 06:05:03 +00:00
Guy Harris 21a7962e28 Include "Makefile.common" in the list of files to put into the
distribution.

Don't use ":=" - not all versions of make necessarily support it, and,
even for those that do, it doesn't mean the same thing in all versions
(it means something different in Solaris make than in GNU make, for
example).

svn path=/trunk/; revision=12371
2004-10-22 02:05:53 +00:00
Guy Harris a87394e71e At least some versions of the OS X NFS client (and possibly some if not
all other BSD NFS clients) retransmit on different ports from the port
on which the original request was set, so have the RPC "conversation"
for connectionless protocols use only the source address and destination
port.

Use NO_ADDR_B and NO_PORT_B when looking up the conversation in those
cases, and use NO_ADDR2 and NO_PORT2 when creating the conversation in
those cases, to make it clearer that we're only using one address and
port.

svn path=/trunk/; revision=12362
2004-10-20 23:38:31 +00:00
Anders Broman ff755ba49c From Jacques, Olivier: - Fixing enums recognition when an XML dictionary is used (was OK with fixed dictionaries)
svn path=/trunk/; revision=12350
2004-10-19 19:29:08 +00:00
Guy Harris 8995a7ab6b Squelch a compiler warning.
svn path=/trunk/; revision=12343
2004-10-18 17:21:31 +00:00
Guy Harris 915fe77f75 From Laurent Constantin: fix a (presumed) cut-and-pasteo.
svn path=/trunk/; revision=12342
2004-10-18 17:17:38 +00:00
Gerald Combs d7d9c6be54 From Olivier Jacques: Add #defines to disable XML validation.
svn path=/trunk/; revision=12340
2004-10-18 14:58:32 +00:00
Gerald Combs d6a2182535 Fix some include problems and compiler warnings pointed out by Thomas Anders.
svn path=/trunk/; revision=12339
2004-10-18 14:37:43 +00:00
Gerald Combs 7e6c4fec40 From Thomas Anders:
- change DHCP option 122 dissection to use official RFC 3495/3594 wording
  (if bootp.pkt.ccc.protocol_version preference setting is 2 or 3)
- update CableLabs specification references
- some minor cleanup (option 43 also) 

svn path=/trunk/; revision=12338
2004-10-18 14:24:25 +00:00
Gerald Combs fa01ccd18c One more item from CableLabs: Add conversation support to the Kerberos
UDP dissector.

svn path=/trunk/; revision=12337
2004-10-18 13:58:20 +00:00
Guy Harris ee26f8b9bb From Alejandro Vaquero: in the RTP analysis code, don't analyze packets
that have an RTP version other than 2.

svn path=/trunk/; revision=12332
2004-10-17 22:14:47 +00:00
Anders Broman 8df4148db6 Update some SIP headers from http://www.iana.org/assignments/sip-parameters.
svn path=/trunk/; revision=12331
2004-10-17 21:57:04 +00:00
Guy Harris 5dbaf6c29e From Rene Pilz: make DTAP be dissected for a GPRS LLC SAPI of 1.
svn path=/trunk/; revision=12330
2004-10-17 11:10:08 +00:00
Guy Harris 8566564c59 From Rene Pilz: add a preference to ignore the cipher bit, in case
captures have unciphered data with the cipher bit set.

svn path=/trunk/; revision=12329
2004-10-17 11:04:28 +00:00
Guy Harris 236123a94b From Thomas Anders: DHCP option 6 enhancements:
- add full support for upcoming PacketCable 1.5
- fix bug regarding MTA/CM Device Capabilities Length
- PacketCable MTA: fix bug regarding RSVP and UGS-AD options
- make presentation more compact (similar to other TLV data dissectors)
- change some descriptions and variables to (hopefully) make more sense
  to DOCSIS/PacketCable users

svn path=/trunk/; revision=12325
2004-10-17 02:36:32 +00:00
Guy Harris 6d53294988 "ssn_range" needs to be a copy of "global_ssn_range", so that it's not
freed if "global_ssn_range" is changed because the preference was
changed.

svn path=/trunk/; revision=12321
2004-10-17 00:48:37 +00:00
Guy Harris 727ad67453 Remove the fixed maximum number of subranges in a range_t; dynamically
allocate them to be large enough.

Add checks that the numbers in the range fit in a guint32.

Check the validity of a range before saving or printing, and report
errors in an alert box.

Clean up white space.

svn path=/trunk/; revision=12320
2004-10-16 23:32:24 +00:00
Ronnie Sahlberg de1bcd5d88 make the SEQUENCE dissection helper understand and handle Indefinite Length
svn path=/trunk/; revision=12319
2004-10-16 12:53:09 +00:00
Guy Harris 64394fdef2 Fix a typo.
svn path=/trunk/; revision=12312
2004-10-16 07:39:37 +00:00
Guy Harris cde0733be8 Clena up a few things.
Squelch a compiler warning.

svn path=/trunk/; revision=12311
2004-10-16 05:59:24 +00:00
Jörg Mayer 429ede32f8 Add support for draft-ietf-dhc-fqdn-option-07.txt
svn path=/trunk/; revision=12309
2004-10-16 02:04:08 +00:00
Jörg Mayer db564c5096 Change Client Identifier display a bit to better handle non-hw identifiers of length 7
svn path=/trunk/; revision=12308
2004-10-16 00:19:07 +00:00
Gerald Combs 536cfec083 Fix a cut-and-paste error.
svn path=/trunk/; revision=12306
2004-10-15 19:02:47 +00:00