Commit Graph

79 Commits

Author SHA1 Message Date
Anders Broman bbf4437af0 From Wido Kelling:
Add Dissection of newly released PNIO IEC 61158 Version 2.3.
From me use ENC_BIG_ENDIAN.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6154

svn path=/trunk/; revision=38249
2011-07-29 05:36:57 +00:00
Guy Harris c34b796445 Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
representation.  Use it rather than a raw 0x10.

Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".

Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.

Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().

Clean up white space.

svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
Anders Broman 3826755b0a From Roland Knall:
implement a named dissector for the PN/IO sub-protocol for
Profinet, as well as a heuristic dissector ("pn_io"), other protocols can
attach too.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6062

svn path=/trunk/; revision=37882
2011-07-03 19:25:34 +00:00
Alexis La Goutte ed3a223400 From http://www.wireshark.org/lists/wireshark-dev/201104/msg00231.html
Always use the returned tree value of proto_tree_add_subtree (and not the item!)

svn path=/trunk/; revision=36801
2011-04-22 13:07:11 +00:00
Alexis La Goutte 83aea790d4 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36772
2011-04-21 16:01:03 +00:00
Alexis La Goutte ab38454697 Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36754
2011-04-21 13:32:11 +00:00
Jörg Mayer 8efd127f31 CID 1162: Not really used variable
svn path=/trunk/; revision=36724
2011-04-19 21:15:58 +00:00
Jeff Morriss 2d9d0900c5 From ToddS via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5299 :
In profinet plugin, there is a dissection based on whether the read data
returned is expected to contain a single or multiple blocks. Currently, the
I&M0FilterData case assumes only a single block is returned. Profinet specifies
two optional additional blocks.

This change moves I&M0FilterData to expect multiple blocks to correct decode
the optional information.

svn path=/trunk/; revision=34523
2010-10-15 17:10:29 +00:00
Anders Broman 5984fb4888 From Yu Zhang:
MRP packet is not correctly parsed in PROFINET multiple write record request.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5267

svn path=/trunk/; revision=34358
2010-10-04 06:16:45 +00:00
Stig Bjørlykke 25dcd066b6 From Hannes Diethelm via bug 4525:
Corrected values for IdentInfo (which was obviously wrong)

svn path=/trunk/; revision=31978
2010-02-24 08:22:33 +00:00
Bill Meier c033a08313 Fix some gcc -Wshadow warnings.
svn path=/trunk/; revision=31724
2010-01-28 23:53:27 +00:00
Ulf Lamping 06e6441c9e add "reserved for profiles" comments
svn path=/trunk/; revision=30811
2009-11-04 00:07:54 +00:00
Anders Broman 03c3b66945 From Benjamin Meyer:
UserData in Profinet ProcessAlarm declared as UserStructIdentifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4195

svn path=/trunk/; revision=30808
2009-11-03 20:11:19 +00:00
Anders Broman ecbe3c28f3 From Matthias FRANK:
PROFIDrive parameter requests not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4193

svn path=/trunk/; revision=30804
2009-11-03 12:30:59 +00:00
Anders Broman d0a15b4473 From Matthias FRANK:
PROFISafe F-Parameter record not decoded in PROFINET dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4192
From me remove check_col();

svn path=/trunk/; revision=30801
2009-11-02 18:09:46 +00:00
Stig Bjørlykke 8248955d7d Renamed tvb_new -> new_tvb to avoid name collision.
svn path=/trunk/; revision=30617
2009-10-19 14:36:26 +00:00
Anders Broman b95ab896f7 From Benjamin Meyer:
Profinet PDIRFrameData field FrameDetails not decoded
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4091

svn path=/trunk/; revision=30321
2009-10-04 19:34:48 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam 124faf721c Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO
svn path=/trunk/; revision=30089
2009-09-23 14:52:01 +00:00
Kovarththanan Rajaratnam 633bb05380 Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL
svn path=/trunk/; revision=30088
2009-09-23 14:43:23 +00:00
Gerald Combs 9bc8469d96 Remove a couple of unused variables.
svn path=/trunk/; revision=29286
2009-08-03 23:50:55 +00:00
Anders Broman 617077e94a From Benjamin Meyer:
Profinet dissector does not decode all defined error codes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753

svn path=/trunk/; revision=29150
2009-07-21 06:08:45 +00:00
Stig Bjørlykke 7881d1ccd7 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28970
2009-07-07 09:00:33 +00:00
Michael Tüxen 9518d53ab4 Make the compiler on Mac OS X happy...
svn path=/trunk/; revision=28934
2009-07-03 10:29:45 +00:00
Ulf Lamping d180d37c8d update to the latest PROFINET drafts
(defragmentation of RT fragments "FRAG-PDU" is still not implemented)

svn path=/trunk/; revision=28932
2009-07-03 09:12:43 +00:00
Stig Bjørlykke 2bba6be84f From Kovarththanan Rajaratnam via bug 3548:
Cleanup header_field_info in plugins.

svn path=/trunk/; revision=28771
2009-06-18 23:22:10 +00:00
Ulf Lamping dcdda03610 update to the latest PROTINET changes:
- add SubFrameBlock dissection
- add subframe heuristics and dissection
- update frame id "layout"
- raise plugin version to 0.2.4

crc16 algorithm copied from Linux sources (GPL V2 only!)

svn path=/trunk/; revision=27748
2009-03-16 21:40:00 +00:00
Bill Meier 9a3563e807 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
Stig Bjørlykke e4e7334be0 From Jim Young (bug 3105):
Trivial patch to change two C++ style comments to standard C style comments.

svn path=/trunk/; revision=26944
2008-12-09 13:42:00 +00:00
Ulf Lamping 4f46066fa0 add missing version check for new block
svn path=/trunk/; revision=26917
2008-12-04 21:26:35 +00:00
Ulf Lamping 6e0a9d6df0 add block dissections:
- PDIRBeginEndData
- PDIRData V1.1

svn path=/trunk/; revision=26916
2008-12-04 20:52:11 +00:00
Jeff Morriss 309f7503e5 Get rid of C++/C99 style comments--not all compilers support them
svn path=/trunk/; revision=23608
2007-11-26 18:55:17 +00:00
Ulf Lamping 5c901658e7 add FSParameterBlock and ARFSUDataAdjust blocks
svn path=/trunk/; revision=23140
2007-10-10 18:33:21 +00:00
Ulf Lamping 37d9fc37da - add DomainName fields for PDInterfaceMrpDataAdjust and PDInterfaceMrpDataReal
- lower expert info level if AR wasn't found

svn path=/trunk/; revision=23106
2007-10-09 05:39:48 +00:00
Stig Bjørlykke 87cffefe2f Added parentheses to make the buildbot happy.
svn path=/trunk/; revision=23065
2007-10-03 19:35:32 +00:00
Ulf Lamping 2a8f9b4c99 check version of each block and don't try to dissect a block if the version is not as expected (to avoid "miss-dissections")
svn path=/trunk/; revision=23064
2007-10-03 18:02:27 +00:00
Ulf Lamping c3131594a8 update to latest IEC draft
svn path=/trunk/; revision=23041
2007-10-02 05:04:35 +00:00
Ulf Lamping 33f27f437f slightly better summary of IODWriteRes and don't repeat AR info for each IODWriteRes_header
svn path=/trunk/; revision=22970
2007-09-25 21:56:43 +00:00
Ulf Lamping b0f5c26ebf update to latest draft:
- add PDSyncData block with Version 1.2
- add IOXBlockReq/s ids 0x116, 0x117, 0x8116 and 0x8117

svn path=/trunk/; revision=22734
2007-08-30 02:14:36 +00:00
Ulf Lamping 3a0c285065 fix return types, hopefully this will make the osx buildbot happy
svn path=/trunk/; revision=22531
2007-08-16 22:45:36 +00:00
Ulf Lamping 4b215597ae experimental feature: dissector filters
add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI


svn path=/trunk/; revision=22530
2007-08-16 22:03:10 +00:00
Ulf Lamping 2d11b0813e mark some parameters as unused
svn path=/trunk/; revision=22445
2007-08-03 20:07:06 +00:00
Ulf Lamping 12aed7290c - add PDInterfaceFSUDataAdjust block
- start to implement an AR conversation handler

svn path=/trunk/; revision=22444
2007-08-03 19:29:34 +00:00
Ulf Lamping 85e09ecdd5 fix unused parameter warning by adding _U_
svn path=/trunk/; revision=22400
2007-07-25 08:38:31 +00:00
Ulf Lamping 9f2478f46c from HPfrommer@hilscher.com:
I’ve fixed a bug in the Profinet-Dissector 
(plugins/profinet/packet-dcerpc-pn-io.c).

In PROFINET IO DCE RPC write-requests, only the first IR frame dataset 
in PDIRFrameData was dissected.

I’ve fixed the problem, now all IR frame datasets are dissected into 
individual sub-trees.

svn path=/trunk/; revision=22398
2007-07-24 21:15:34 +00:00
Ulf Lamping 94b3dbf3f6 add dissection of blocks:
{ 0x021E, "CheckSyncDifference"},
	{ 0x021F, "CheckMAUTypeDifference"},

svn path=/trunk/; revision=22385
2007-07-23 20:07:51 +00:00
Ulf Lamping 0104002d2e Add PN-IO FSHelloBlock and PN-DCP Device/AliasName
svn path=/trunk/; revision=21298
2007-04-02 05:18:31 +00:00
Stephen Fisher cdf47e536b Add -Werror when using GCC only to the Makefile.am of the base
directory and most of the plugins to match the same command 
put in the Makefile.nmake files for Windows compliations.  Fix
a few warnings when compiling under gcc 3.4.4 on FreeBSD.  Create
new automake file variable called USING_GCC in configure.in and
wiretap/configure.in to acomplish the above -Werror addition. 


svn path=/trunk/; revision=21127
2007-03-22 23:03:39 +00:00
Ulf Lamping c3bf838051 as Jeff made empty field names "illegal", he changed the way PN-IO and PN-PTCP showed their blocks in an unwanted way - fix it
svn path=/trunk/; revision=21019
2007-03-11 12:07:43 +00:00
Jeff Morriss 62596bffb3 Fix bug 552:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552

by enforcing that header fields have names of length > 0.  This should fix
the display of those fields and also make them filterable (which was the
subject of the bug).  Abbreviations are (still) optional: if they are empty
then the field is not filterable.

Update README.developer with this information.

Add header field names in several dissectors where they were missing.

In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.

Also remove trailing white space from all the files checked in.

svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00