Commit Graph

16572 Commits

Author SHA1 Message Date
Guy Harris bbed650915 Do some more length checking to avoid a dissector bug error. Should fix
bug 6564.

svn path=/trunk/; revision=39831
2011-11-14 18:42:11 +00:00
Bill Meier eed8e49aff Very minor cleanup: remove some unneeded #includes & some trailing whitespace
svn path=/trunk/; revision=39830
2011-11-14 18:19:14 +00:00
Anders Broman 34ea886454 [-Wunused-but-set-variable]
svn path=/trunk/; revision=39829
2011-11-14 17:35:04 +00:00
Anders Broman fa5c7f85aa packet-sip.c:1412: warning: 'uri_param_end_offset' may be used uninitialized in this function
svn path=/trunk/; revision=39828
2011-11-14 17:27:18 +00:00
Anders Broman c46bda538d From Johan Wåhl:
- dissect Route and Via header.
- Dissect URI parameters.

svn path=/trunk/; revision=39827
2011-11-14 17:10:49 +00:00
Martin Mathieson 8df10bb4b5 Add remaining UMTS RLC primitive parameters preceding RLC payload.
svn path=/trunk/; revision=39826
2011-11-14 12:22:54 +00:00
Anders Broman 75afa0bd3f Fix Id tag.
svn path=/trunk/; revision=39824
2011-11-14 08:24:47 +00:00
Bill Meier a42a82ed1d Don't use generic shared function/typedef/struct names;
Remove unneeded #includes;
Cleanup trailing whitespace.

svn path=/trunk/; revision=39823
2011-11-13 23:33:47 +00:00
Guy Harris a6ccc83e22 If we set "column.hidden" on the command line but don't set
"column.format" in a later argument, make sure we mark the appropriate
existing columns as hidden.

As part of cleaning up the infrastructure for doing this, store the COL_
code for a column in a fmt_data structure rather than a pointer to the
raw column format string; this simplifies some code.

Have a routine to return whether a column is visible, not hidden, as
it's used to set a "visible" flag.

svn path=/trunk/; revision=39822
2011-11-13 22:51:49 +00:00
Guy Harris c32a5e7d8b As we're no longer checking whether we're constructing the Info column,
we can't bail out early on dissection merely because we're not
constructing the protocol tree, as that would mean we wouldn't construct
the Info column unless we're constructing a protocol tree.

Clean up indentation.

svn path=/trunk/; revision=39821
2011-11-13 22:44:51 +00:00
Gerald Combs a22d69fd72 [Automatic manuf, services and enterprise-numbers update for 2011-11-13]
svn path=/trunk/; revision=39818
2011-11-13 15:03:25 +00:00
Guy Harris 833908d49b The sum of a guint16 and 2 does not necessarily fit in a guint16. Put
it into a gint, instead.  This should fix bug 6572, by preventing an
infinite loop if the sum in question is 0 modulo 2^16.

svn path=/trunk/; revision=39817
2011-11-13 01:38:46 +00:00
Bill Meier 9b715d6a99 Various additional fixes ....
svn path=/trunk/; revision=39815
2011-11-12 23:25:29 +00:00
Bill Meier d9e9f429da Fix a formatting error.
svn path=/trunk/; revision=39814
2011-11-12 23:03:30 +00:00
Bill Meier 29986f07ed Fix some compile errors and rework some code.
svn path=/trunk/; revision=39813
2011-11-12 22:26:06 +00:00
Michael Tüxen 0f1ddc857b Fix compilation if HAVE_LIBGCRYPT is not defined.
svn path=/trunk/; revision=39812
2011-11-12 22:03:55 +00:00
Guy Harris 5692f59337 Update URL.
svn path=/trunk/; revision=39811
2011-11-12 21:16:43 +00:00
Bill Meier d38970f73f Remove some unneeded 'if(pinfo)' tests;
Remove some unneeded forward refs.

svn path=/trunk/; revision=39809
2011-11-12 20:17:43 +00:00
Bill Meier f5d913ac84 Fix 2 typos.
svn path=/trunk/; revision=39808
2011-11-12 20:14:26 +00:00
Bill Meier ba8f3f4195 Remove unneeded code.
svn path=/trunk/; revision=39807
2011-11-12 19:45:21 +00:00
Bill Meier cbb32e6b00 Fix 2 typos
svn path=/trunk/; revision=39806
2011-11-12 19:27:07 +00:00
Anders Broman af25c3e77b From Holger Pfrommer:
Enhancement of Hilscher Analyzer Dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6082

svn path=/trunk/; revision=39804
2011-11-12 18:01:38 +00:00
Anders Broman fa7ea2ea34 fix [-Wunused-but-set-variable]
svn path=/trunk/; revision=39803
2011-11-12 12:37:38 +00:00
Anders Broman 264975e29c Add a cast.
svn path=/trunk/; revision=39801
2011-11-12 11:27:41 +00:00
Alexis La Goutte 292a5b6f93 From Mariusz Okrój and Sebastien Vincent via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6225
Enhance XMPP Dissector

XMPP is communication protocol that is based on XML.

Existing Jabber dissector has only few filtering possibilities and displays packets in inconvenient way.

This dissector is a result of cooperation with Jitsi community as Google Summer of Code project (http://www.jitsi.org/index.php/GSOC2011/XmppWireshark).

From me :
Add Mariusz Okrój in AUTHORS File
Add Modelines information

svn path=/trunk/; revision=39799
2011-11-12 10:51:01 +00:00
Guy Harris ac507aa5e7 Add some checks for "character not found"; this should fix some
fuzz-testing failures we're seeing.

svn path=/trunk/; revision=39795
2011-11-11 19:07:11 +00:00
Stig Bjørlykke a0cbfab6bf Fixed abbrev for "Channel rate and type".
Bug reported by damker.

svn path=/trunk/; revision=39794
2011-11-11 13:25:48 +00:00
Guy Harris c356d4f2c1 Get rid of an unused function (dissect_hnbap_AccessResult()).
svn path=/trunk/; revision=39789
2011-11-10 23:28:28 +00:00
Guy Harris 6b1284fa7c Get rid of the last remnants of the "check the syntax of capture
filters" preference; now that we always build with threads, we do the
syntax checking in a separate thread, so it doesn't hang the UI, and we
no longer have UI to change it but we were still trying to fetch the
value of the non-existent checkbox for it and getting a warning printed.

(We still check for it when reading, so that we don't print warnings if
it's present.)

svn path=/trunk/; revision=39788
2011-11-10 23:02:42 +00:00
Anders Broman ec8806bc8e Set info col for new messages.
svn path=/trunk/; revision=39787
2011-11-10 21:44:46 +00:00
Anders Broman 06419848af Update HNBAP to V10.1.0 (2011-06)
svn path=/trunk/; revision=39786
2011-11-10 21:38:15 +00:00
Anders Broman 1f9b1347d6 From Martin Kaiser:
RSASSA-PSS support for X.509 certificates.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6541

svn path=/trunk/; revision=39785
2011-11-10 20:52:44 +00:00
Anders Broman e5de258768 packet-sip.c:1442: warning: 'c' may be used uninitialized in this function
svn path=/trunk/; revision=39783
2011-11-10 20:38:07 +00:00
Anders Broman 5d97a01889 -Improve dissection of auth items
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6553)
- Add parameter items to the tree for some  often trunkated lines.

svn path=/trunk/; revision=39782
2011-11-10 20:16:17 +00:00
Anders Broman 4c379bc979 From Dirk:
CAPWAP dissector tries to allocate -1 bytes of memory during reassembly.
- changed to return offset.

svn path=/trunk/; revision=39779
2011-11-10 06:07:16 +00:00
Guy Harris 835647751c prefs_reset() has to reset the dissector preferences to their defaults,
as we don't save to a preferences file preference values that are equal
to their defaults, so if you change profiles, a preference that has a
non-default value in the old profile and a default value in the new
profile, so that it's *not* in the preference file for the new profile,
will not be set to the right value unless we reset all protocol
preferences to their defaults first.

svn path=/trunk/; revision=39777
2011-11-10 00:53:48 +00:00
Bill Meier 30cee99009 Fix a number of proto_tree_add_item() encoding args.
svn path=/trunk/; revision=39774
2011-11-09 17:33:18 +00:00
Bill Meier a25e421a10 Fix some [-Wunused-but-set-variable] warnings
(in some cases by changing proto_tree_add_item() to use
  what appears to be the correct 'tree' arg);
Do whitespace cleanup.

svn path=/trunk/; revision=39772
2011-11-09 02:48:51 +00:00
Bill Meier 9799f94861 Fix some [-Wunused-but-set-variable] warnings;
Trailing whitespace cleanup.

svn path=/trunk/; revision=39771
2011-11-09 01:35:26 +00:00
Chris Maynard 23193d4747 In the unlikely case that there are no ops, don't append anything. Also, comma-separate them.
svn path=/trunk/; revision=39770
2011-11-08 23:08:12 +00:00
Anders Broman 8d28d1d8cb Try to fix defined but not used warnings.
svn path=/trunk/; revision=39766
2011-11-08 19:30:51 +00:00
Chris Maynard 647c5c0b27 packet_info's in_error_pkt is now a bitfield like in_gre_pkt.
svn path=/trunk/; revision=39764
2011-11-08 18:39:11 +00:00
Stephen Fisher 6de2561c69 Fix message_type defined but unused compiler warning/error. There are 3
more problems that I'll mail to -dev.


svn path=/trunk/; revision=39763
2011-11-08 18:15:39 +00:00
Anders Broman 999b8451cb packet-sbc-ap-template.c:138: warning: unused variable 'offset'
svn path=/trunk/; revision=39762
2011-11-08 18:06:18 +00:00
Anders Broman 0e57cff4dc Get rid of set-but-not-used warnings.
svn path=/trunk/; revision=39761
2011-11-08 17:39:01 +00:00
Anders Broman a45b165df6 Add a dissector for http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-00
svn path=/trunk/; revision=39760
2011-11-08 17:36:12 +00:00
Anders Broman 35ac513981 Use the correct length for the NAS message container.
svn path=/trunk/; revision=39759
2011-11-08 17:31:23 +00:00
Anders Broman de5f417b99 Add SBc Application Part (SBc-AP) to build.
svn path=/trunk/; revision=39758
2011-11-08 17:28:55 +00:00
Chris Maynard d55d8781b8 Improve ICMP conversation tracking, especially when capturing on multiple interfaces and one of them is a GRE tunnel. Resolves bug 5770, which was reopened.
svn path=/trunk/; revision=39757
2011-11-08 17:25:22 +00:00
Gerald Combs f019a92c28 Remove a duplicate "TID" found by checkAPIs.pl.
svn path=/trunk/; revision=39755
2011-11-08 16:49:49 +00:00