Commit Graph

82369 Commits

Author SHA1 Message Date
Guy Harris 119667d886 doc: fix the macOS build.
BUNDLE_RESOURCE_SHARE_MAN[14]_FILES shouold *not* have the generate_
prefixes; names with those prefixes are fake targets, not names of files
that we generate, so attempting to copy files with those names fails.

It should, however, have "doc/" before the names of the man pages, as
they're generated into the doc directory of the top-level build
directory.
2021-10-14 00:30:08 -07:00
Guy Harris 79920cbc5f dumpcap: do all packet counting in capture_loop_wrote_one_packet().
We need to update global_ld.inpkts_to_sync_pipe as soon as we've written
a packet to the current capture file.  If we're writing to multiple
files, then, if we delay counting until after we switch to another file,
the packet-count message we send to the parent before switching won't
include the packet, and the first packet-count message we send to the
parent *after* switching *will* include the packet, which could mean the
parent will try to read more packets than there are in the new file, in
which case it'll get an EOF and, at least in the case of TShark, treat
that as an error and stop capturing.

This should fix issue #17654.

While we're at it, don't send a "we have no packets" packet-count
message even for the packet-count message we send just before switching
files.
2021-10-13 17:18:50 -07:00
Gerald Combs 74747c4d2f CMake: Try to make our man page builds faster.
Depend on our generator targets instead of the generated files, which
allows parallel builds outside of Ninja. Don't reserve JRE memory when
building HTML and man page targets. This reduces the "docs" target build
time on my Windows VM here from over two minutes to under one.
2021-10-13 23:10:35 +00:00
Chuck Craft 1e18f79373 captype: add options to Usage: and man page 2021-10-13 22:54:20 +00:00
Vadim Yanitskiy 30863e5298 GSM A-bis/RSL: dissect some more Osmocom specific IEs 2021-10-13 18:10:49 +00:00
Vadim Yanitskiy 278dcc83ea GSM A-bis/RSL: add a checkbox for Osmocom specific definitions 2021-10-13 18:10:49 +00:00
Vadim Yanitskiy 91f050cd82 GSM A-bis/RSL: fix wrong tree/length in dissect_rsl_ie_message_id() 2021-10-13 18:10:49 +00:00
Gerald Combs 2236009e21 Packaging: Add captype to the Windows installers.
Add captype and its documentation to the NSIS and WiX packages.
2021-10-13 17:54:02 +00:00
Gerald Combs acaaad150b BT HCI_ISO: Don't overrun our reassembly buffer.
Fixes #17649.
2021-10-13 17:36:13 +00:00
Ben Huddleston 79ed34e1c6 couchbase: Add Subdoc replace body with xattr opcode
Change-Id: Icce8f7a30caf0d52c01b20b8535a1f157a1e4f56
2021-10-13 15:55:13 +00:00
Ben Huddleston 7fa7aa8191 couchbase: Add ReviveDocument subdoc flag
Change-Id: I914f4aae11b4c459a6db0d7b18ab81b73747fd58
2021-10-13 15:55:13 +00:00
Ben Huddleston 0e019290ef couchbase: Add new subdoc error codes
Change-Id: I7d5350d1a590e8c5a2b87f4cc0d815d5da63a2f1
2021-10-13 15:55:13 +00:00
Stig Bjørlykke bb0b4ad4b3 eNode-B: Fix check for eri_enb_log_magic
Files not having the eri_enb_log_magic should not be opened as a
eNode-B raw log file format.
2021-10-13 12:06:44 +02:00
Joakim Karlsson 9cc514957f gprscdr: Update to 3GPP TS 32.298 V17.0.0 2021-10-13 08:29:20 +00:00
Anders Broman db80da2adc SIP: 200 ok put resp to method in info col 2021-10-13 09:25:41 +02:00
Joakim Karlsson 4887894a15 pfcp: Update to 3GPP TS 29.244 V17.2.0 2021-10-13 06:02:34 +00:00
Chuck Craft a3625ec9f6 extcap: reword error message referencing captype
There exists a program called "captype" but it's not used here.
2021-10-13 05:03:31 +00:00
John Thacker c6e44fb00c BT-uTP: Track conversations
Add endpoint type for uTP connection IDs.
Manage uTP conversations, creating generated stream ID to filter
on both sides of a conversation.
Display more information in INFO column, similar to TCP.
This is some progress towards #8792.
2021-10-13 04:37:21 +00:00
Martin Mathieson abcadce44f BPV7: Address check_static.py issues
epan/dissectors/packet-bpv7.c (00000000000010d0 T bp_block_canonical_free) is not referred to so could be static?
epan/dissectors/packet-bpv7.c (0000000000000e50 T bp_creation_ts_new) is not referred to so could be static?

One function was not called at all - the other only in this dissector so could be static.
2021-10-13 04:21:31 +00:00
Brian Sipos 01e858e0a3 BP: Fix crashes on invalid fuzzed inputs 2021-10-12 23:15:50 +00:00
Chuck Craft ade523d7ba docs: -z stats - bootp now dhcp; not all in man page 2021-10-12 21:17:25 +00:00
Chuck Craft 07143b1c47 docs: -z stats - bootp now dhcp; not all in man page 2021-10-12 21:17:25 +00:00
Chuck Craft 1998e7f34b capinfos: man page typos; add longopts to Usage:
The verbiage for first/last packets and start/end times seem
to not be consistent. Changing will also require a change to
Capture File Statistics in the Wireshark Gui. Future MR.
2021-10-12 20:35:15 +00:00
David Perry fd076e6ca8 Proposed rewording of filter tooltips
For #16186. Proposed changes to the tooltips which appear when a filter
expression is potentially problematic.

Rename references to "User's Guide" to "Help" since the link to the
User's Guide in the Help menu is just called *Contents*.

Name specific sections within the help which pertain to the warning
tooltip being shown. Gives first-time users some help in finding the
right part of the sizeable User's Guide.
2021-10-12 06:54:25 +00:00
Chuck Craft fefad2e7cf dumpcap: double received count when using threads
Closes #17089
2021-10-12 06:37:46 +00:00
John Thacker 634650f1e4 TCP: Follow: Don't treat placeholder value 0 as a real ACK number
Since the wraparound aware GT_SEQ is used, passing in 0 for the
ACK number can result in thinking that bytes are missing and
dropping frames from the follow stream tap.
2021-10-12 04:09:11 +00:00
Eugene Adell f6b0de6b12 TCP: Port reuse ends with false Retransmissions
In rare circumstances when a connection could not established on
the first try, succeeding in establishing it later would generate
many Retransmissions. Closes 17616.
2021-10-12 03:52:01 +00:00
Gerald Combs ed98abe208 BT-DHT: Exit a loop.
Always make sure our offset advances in dissect_bencoded_list.
Fixes #17651.
2021-10-12 03:35:32 +00:00
Gerald Combs 643fbe52ae Docs: Use Asciidoctor to copy ws.css.
Use the `copycss` attribute in the release notes and FAQ to copy ws.css
to the right location.
2021-10-12 01:02:53 +00:00
João Valverde 07371d4557 dfilter: Split tostr() into debug and pretty print 2021-10-11 21:55:45 +00:00
João Valverde 5dd90e3b30 dfilter: Cache stnode_tostr()
This avoids having to save/free the pointer for each tostr()
invocation (or leak memory).
2021-10-11 21:55:45 +00:00
Guy Harris c2b6a27e97 autosar_nm: get rid of unused protocol IDs.
We fetch the protocol IDs for several protocols, but use none of them.
Get rid of them.
2021-10-11 20:44:41 +00:00
Balint Reczey 9f92da75b8 wsutil: Provide static inline g_memdup2 in glib-compat.h to not export it
Shared libraries should not export symbols exported by other libraries to avoid
collisions.

Fixes #17645.
2021-10-11 21:51:35 +02:00
Lin Sun fdd1a82ed9 packet-btmesh: fix build without GCRYPT 2021-10-11 19:10:41 +00:00
João Valverde 5481bffa5c proto: Check for reserved keywords in filter names 2021-10-11 19:15:26 +01:00
Gerald Combs 11c58e78f7 Qt: More new-style signals+slot conversions. 2021-10-11 17:03:21 +00:00
Gerald Combs e5bcf6b402 Qt: Use new-style signals+slots in more places. 2021-10-11 16:32:49 +00:00
Dr. Lars Völker 7f9b8874b5 BPSEC, BPv7, COSE: Bugfix MacOS build
The usage of PRIi64 and PRIu64 may lead to failed builds on MacOS - at
least it did for me.

This patch fixes this.
2021-10-11 11:58:23 +02:00
Chuck Craft 92ab6d0704 Rawshark: is not a CamelCase word 2021-10-11 08:03:31 +00:00
Martin Mathieson a5df18e51e Fix some spelling errors 2021-10-11 04:44:49 +00:00
Gerald Combs ab34ebbc7b [Automatic update for 2021-10-10]
Update manuf, services enterprise numbers, translations, and other items.
2021-10-10 23:00:00 +00:00
João Valverde 041aa24a37 ftypes: Rewrite FT_PROTOCOL comparison operator
For efficiency do the comparison in a single function call
instead of trying to preserving exactly the previous semantics.

Still I tried not to deviate much.
2021-10-10 20:48:29 +00:00
João Valverde 13e9e7199c ftypes: Use an order function to compare ftypes
All the order operators can be defined in terms of 'lt'
and 'eq' so use that to reduce the number of required
methods from 6 to 2.

Further reduce to one by combining those two into a single
function that has memcmp semantics: negative return is
"less than", positive is "greater than" and zero is equal.
2021-10-10 20:48:29 +00:00
Gerald Combs 6299a66a92 Revert "GitLab CI: Add an "Update Numbers" job."
This reverts commit f773bb4391. Maybe some
other time.
2021-10-10 20:32:28 +00:00
Dr. Lars Völker 9aa87dae84 TECMP: Bugfix: TECMP should not decode NULL frames
Null frames are frames with invalid data. This patches makes sure that
the invalid data is not further dissected.

Closes #17644

Bug present since Wireshark 3.4.
2021-10-10 20:16:13 +00:00
Dr. Lars Völker 0d276b47d1 AUTOSAR NM: Bugfix: wrong filters for user defined elements
When UDP-NM was renamed into AUTOSAR-NM (as well as filename changed)
the author of that patch missed the dynamic filters. This patch fixes
this oversight and makes sure all filters of AUTOSAR NM start with
"autosar-nm.".

Fixes #17643
2021-10-10 20:00:15 +00:00
Balint Reczey ba4bec7d09 debian: Report upstream and package version instead of git revision 2021-10-10 19:26:17 +00:00
Balint Reczey 6617c7fc5d debian/rules: Don't pass --parallel to dh, it is the default now 2021-10-10 19:26:17 +00:00
Balint Reczey a1d964fa1c debian/rules: Turn on BUILD_corbaidl2wrs to ship idl2wrs man page 2021-10-10 19:26:17 +00:00
Balint Reczey a9c1d1ac9e debian: Bump compat level to 12 keeping backports in mind 2021-10-10 19:26:17 +00:00