"Edit -> Display Filters..." menu item, as per Ulf Lamping - there's
apparently some problem wherein &args doesn't get passed properly to the
callback.
svn path=/trunk/; revision=8819
any string pointed to by the preference variable - as the value we set
it to is allocated, we should free it after registering the preference.
The register routine is called only once - don't worry about whether
"gbl_diameterDictionary" is null or not.
Get rid of a duplicate credit entry in the man page.
svn path=/trunk/; revision=8813
ENOENT when trying to open the SNACC file, and the file we're trying to
open is the default file, don't print a warning.
Fix some typoes.
svn path=/trunk/; revision=8806
It is thus relatively common that a data segment and its ACK being swapped in the capture file.
Therefore, drop the condition that a segment must not have been acked yet in the detection of OutOfOrder segments.
Second, fix a bug where we didnt keep track of the ack numbers properly for relative sequence number analysis.
svn path=/trunk/; revision=8800
pointer arguments to "proto_tree_add_XXX" functions are copied - if you
allocated a buffer for one of them (e.g., a string), and you don't free
that buffer when you're done with it, you'll leak memory.
svn path=/trunk/; revision=8796
Add dissection code for the following additional SCSI commands:
- Start/Stop Unit
- Write Buffer
- Send Diagnostics
Don't copy the product serial number to a buffer before printing
it.
svn path=/trunk/; revision=8795
a button that brings up the Create Filter dialog box. While it works, the
problem is that it also acts as an Enter keypress as far as the start_stat
button is concerned.
Probably needs a small fix.
svn path=/trunk/; revision=8782
return "<no file>" if there is no file loaded yet instead of crashing in io-stat
io-stat only print the label for the top tick on the y axis to make it look less cluttered
svn path=/trunk/; revision=8781
greater than the alphabet length.
Just use "proto_tree_add_item()" if you have a range of bytes, of known
length, that are to be added as an item - that handles both FT_STRING
and FT_BYTES, including null-terminating the string value.
svn path=/trunk/; revision=8779
moved some variables to the structure where they belonged instead of where they
currently were and reduced the complexity of the code
Fast Retransmission:
Ethereal not tries to detect and flag FastRetransmissions:
The heuristics for this check is:
>=3 dupacks in other direction
this semgent is what the dupacks are asking for
it arrived within 10ms of the last dupack (10ms should be short enough to not confuse with real RTOs)
OutOfOrder segments
Previously all segments that did not advance the right edge of the window was flagged as retransmission now ethereal will try to flag segments that are merely reordered as OutOfOrder segments insteaD
tHE HEURISTICS ARE:
it has not been ACKed yet
we have not seen it before
it arrived within 4ms of the segment immediately to the right in the window
svn path=/trunk/; revision=8775
swap the "captured length" and "length" fields, to the open-file code;
store a tri-state (definitely swapped, definitely not swapped, maybe
swapped) value in the per-capture-file-format information for libpcap
format, and use that when processing packets.
svn path=/trunk/; revision=8774
1, TunnellingProtocol_id is a CHOICE not a SEQUENCE
2, change some values to be FT_STRING instead of FT_BYTES
3, update dissect_per_octet_String to always 0 terminate all FT_STRINGs
(if necessary in a temporary buffer) before passing them on to proto_tree_add_string() since that function did not want to handle FT_STRING or FT_STRINGZ othervise.
svn path=/trunk/; revision=8771