Commit Graph

7501 Commits

Author SHA1 Message Date
Gerald Combs b2f936ff24 Fix several buffer and integer overflow issues discovered by Timo Sirainen.
tvbuff.c:

  Lots of existing code assumes that you can safely do the following:

    #define MAX_BUF 64
    guint8 *buf[MAX_BUF];
    ...

    tvb_get_nstringz0 (tvb, offset, MAX_BUF, buf, &bytes_copied);

  In reality, tvb_get_nstringz*() can potentially write one byte past
  "buf".  Modify _tvb_get_nstringz() not to do that.

packet-ppp.c:

  Check for a valid BAP suboption length.

packet-mount.c:

  Fix a possible integer overflow in dissect_group().

svn path=/trunk/; revision=7590
2003-04-28 04:03:26 +00:00
Guy Harris 4b4b030e51 From Matthijs Melchior: fix "asn1_bits_decode()", and make its API more
closely resemble that of other decode routines.

svn path=/trunk/; revision=7589
2003-04-28 00:31:26 +00:00
Guy Harris 4915f5e6a2 Note some weirdness seen in some captures, where the direction flag in
the SMB isn't set on replies.

svn path=/trunk/; revision=7588
2003-04-27 23:52:11 +00:00
Guy Harris 6c5fa1820b From Lars Roland: document the "mgcp,rtd" tap for Ethereal, and improve
the documentation for that tap for Tethereal.

svn path=/trunk/; revision=7587
2003-04-27 21:52:24 +00:00
Guy Harris 03446b0756 From Lars Roland: add routines to use when creating statistics windows
(at least with GTK+ 1.2[.x]), and make the MGCP statistics routine use
them.  The routines use a GtkCList and make it scrollable.

svn path=/trunk/; revision=7586
2003-04-27 21:50:59 +00:00
Guy Harris b27230342d Use "tvb_format_text()" to format the string in "cb_str_postprocess()",
to avoid problems with non-printable characters.

svn path=/trunk/; revision=7585
2003-04-27 21:48:46 +00:00
Laurent Deniel 4e9e699536 Replace some unchecked malloc calls by g_malloc.
svn path=/trunk/; revision=7584
2003-04-27 20:57:58 +00:00
Richard Sharpe 5f98b6206f Update some more names ...
svn path=/trunk/; revision=7583
2003-04-27 17:46:15 +00:00
Jörg Mayer 1032b043e8 Newer build tools generate the following warning:
Makefile.am:99: `YFLAGS' is a user variable, you should not override it;
Makefile.am:99: use `AM_YFLAGS' instead.

Fix it in the proposed way.

svn path=/trunk/; revision=7582
2003-04-27 09:16:36 +00:00
Richard Sharpe 1834fb882a Add support for level 102 info ...
svn path=/trunk/; revision=7581
2003-04-27 06:23:16 +00:00
Richard Sharpe dd570bd1fd Let's have the correct name for this sucker.
svn path=/trunk/; revision=7580
2003-04-27 06:16:57 +00:00
Richard Sharpe 127d506e0f Add mode info levels for NetWkstaGetInfo. Praise be for MSDN :-)
svn path=/trunk/; revision=7579
2003-04-27 06:11:45 +00:00
Ronnie Sahlberg 0ffdb95a21 Added decoding of EnumServicesStatus request packets
svn path=/trunk/; revision=7578
2003-04-27 06:05:43 +00:00
Ronnie Sahlberg 027bf69613 Added function QueryServiceLockStatus
svn path=/trunk/; revision=7577
2003-04-27 04:38:10 +00:00
Tim Potter fea3d754fd Call dissect_nt_status() instead of dissect_ndr_uint32() when dissecting
return status codes.

svn path=/trunk/; revision=7576
2003-04-27 04:33:10 +00:00
Ronnie Sahlberg 02226d31e7 Added decoding of the two functions LockServiceDatabase and UnlockServiceDatabase
svn path=/trunk/; revision=7575
2003-04-27 02:33:02 +00:00
Ronnie Sahlberg 512bd13eab Added dissectors for the functions : OpenSCManager and CloseServiceHandle
svn path=/trunk/; revision=7574
2003-04-27 02:03:19 +00:00
Guy Harris 3e857b5789 Clean up the example for the "-m" flag.
svn path=/trunk/; revision=7573
2003-04-27 00:50:06 +00:00
Ronnie Sahlberg bca3332efd Not all strings in MS interfaces are unicode.
Rename cb_str_postprocess which handles unicode strings to cb_wstr_postprocess.

Add cb_str_postprocess which handles ASCII strings

svn path=/trunk/; revision=7572
2003-04-27 00:49:14 +00:00
Guy Harris 6df423d0be From Matthijs Melchior:
-  added option -m to set maximum packet length
-  added option -T to generate TCP headers
-  UDP headers now have a correct checksum
-  default capture timestamp is current time, usec field counts packets
-  UDP and TCP headers are mutually exclusive
-  changed etherenet addresses, now sends from 1 -> 2 ....

svn path=/trunk/; revision=7571
2003-04-27 00:41:52 +00:00
Guy Harris db6c77bf48 Fix a typo.
svn path=/trunk/; revision=7570
2003-04-27 00:34:27 +00:00
Guy Harris be87d6c418 Put the new "-z" examples in boldface. (pod2man warns you about that.)
Wrap some paragraphs to 80 columns.

svn path=/trunk/; revision=7569
2003-04-26 05:38:07 +00:00
Richard Sharpe c03272a8f5 Finish the dissection of what we know here. My, Ronnie has made this easy.
svn path=/trunk/; revision=7568
2003-04-26 00:44:21 +00:00
Tim Potter 6eca21154b New DCERPC pipe for Windows service control. Implemented only stubs so far.
svn path=/trunk/; revision=7567
2003-04-26 00:19:24 +00:00
Richard Sharpe b0c8b2da88 Begin to parse wkssvc stuff ...
svn path=/trunk/; revision=7566
2003-04-26 00:00:30 +00:00
Guy Harris a7b02e051a Show the URL of the I-D giving information on Kerberos-over-TCP.
svn path=/trunk/; revision=7565
2003-04-25 21:30:42 +00:00
Guy Harris 0e48f176af From Tony Schene: Kerberos-over-TCP support.
svn path=/trunk/; revision=7564
2003-04-25 21:29:19 +00:00
Guy Harris 0c743e4338 From Tony Schene: after freeing saved authentication mechanism strings
in the "auth_info_items" list, and free all the items in that list, we
need to null out the pointer to that list to indicate that it's been
emptied out.

svn path=/trunk/; revision=7563
2003-04-25 21:19:10 +00:00
Guy Harris bef46400df From Tony Schene: initial stub Kerberos kadmin support.
svn path=/trunk/; revision=7562
2003-04-25 21:09:37 +00:00
Guy Harris c1b7eb399a From Lars Roland:
Filter dialog for the MGCP statistics tap.

	Routines for building GUI table displays for statistics taps.

	Use the timestats.c routines in the SMB statistics tap.

svn path=/trunk/; revision=7561
2003-04-25 20:54:18 +00:00
Guy Harris 3b39429a6f From Greg Morris:
1. Some NCP's that displayed the file/directory path in the
	   summary window would display blank lines on Windows based
	   machines.  This was due to unicode or non-displayable
	   characters contained in the character string being added to
	   the column data.  I made a change to format/strip out
	   non-displayable characters prior to adding to the column
	   data.

	2. Moved ncp_req_hash_value struct to packet-ncp-int.h so that
	   I can use it within a future dissector (NMAS).

Clean up white space.

svn path=/trunk/; revision=7560
2003-04-25 20:36:29 +00:00
Guy Harris d7bbbacc6d From Greg Morris:
NCP 123,62 did not display value for the set command. Set default
	value to guint32.

	Add some stuff for the Novell Modular Authentication Service.

svn path=/trunk/; revision=7559
2003-04-25 20:33:16 +00:00
Gerald Combs bbe13fd78c Obscure email addresses and update entries.
svn path=/trunk/; revision=7558
2003-04-25 15:04:32 +00:00
Gerald Combs 51226f411c Initialize hf_bgp_cluster_list.
svn path=/trunk/; revision=7557
2003-04-25 14:44:43 +00:00
Guy Harris cbb30c24ed Fix a compiler warning.
svn path=/trunk/; revision=7556
2003-04-25 05:50:20 +00:00
Guy Harris 2da983bb7b Declare as "extern" the exported functions, as this file is, when we
build some tables for plugins, used with the function names actually
referring to function pointer variables, which are not automatically
externs.

svn path=/trunk/; revision=7555
2003-04-25 05:39:33 +00:00
Guy Harris 8db1b28e8d Fix a comment.
svn path=/trunk/; revision=7554
2003-04-24 23:18:07 +00:00
Guy Harris 8efc6912ef Make the dialog box "transient for" the main window, as we do with other
pop-up dialogs.

If thee's already one such dialog, and the user asks for another one,
reactivate the old one (so it gets un-minimized if necessary), don't
just raise it.

Put the "Create Stat" button in a box, so it doesn't widen to the full
width of the window, and add a "Cancel" button to dismiss the dialog
box.

Arrange that <ESC> dismisses the dialog box, and that typing <Enter> in
the filter dialog box activates the dialog box.

svn path=/trunk/; revision=7553
2003-04-24 23:17:43 +00:00
Guy Harris 090a5aa24b From Matthijs Melchior: add the ASN.1 routines to the table of routines
exported to dissectors.

svn path=/trunk/; revision=7552
2003-04-24 21:15:13 +00:00
Guy Harris 5f13ab0115 From Didier Gautheron: the files being processed by make-tapreg-dotc are
in srcdir, not top_srcdir.

svn path=/trunk/; revision=7551
2003-04-24 18:30:52 +00:00
Ronnie Sahlberg c8e3705196 Update to io-stat for tethereal.
Make it able to calculate COUNT() SUM() MIN() MAX() and AVG() for integers and
relative time fields.

See tethereal manpage for examples.

svn path=/trunk/; revision=7550
2003-04-24 12:25:33 +00:00
Guy Harris eb8c0fb210 Don't ignore SIGCHLD - doing so means that, on many platforms, we don't
get any status information from the child process when it terminates,
and we want that status information (e.g., death due to a signal).

svn path=/trunk/; revision=7549
2003-04-24 09:07:36 +00:00
Guy Harris 78217ecd6a Support for filterable fields in UPDATE messages, based on changes from
Marcio Franco.

Add a bunch of error checking and cleanups in the process of adding the
filterable fields support.

svn path=/trunk/; revision=7548
2003-04-24 09:06:25 +00:00
Guy Harris e875c3330f From Jim McDonough: fix smb transact2 findfirst decoding of info level
2's (including EA sizes, requested by os2 clients).

svn path=/trunk/; revision=7547
2003-04-24 09:04:31 +00:00
Guy Harris bdb8a68599 Support for filterable fields in UPDATE messages, based on changes from
Marcio Franco.

Add a bunch of error checking and cleanups in the process of adding the
filterable fields support.

svn path=/trunk/; revision=7546
2003-04-24 09:00:27 +00:00
Laurent Deniel f8a077d10b Change copyright date to 2003.
svn path=/trunk/; revision=7545
2003-04-23 20:51:57 +00:00
Ronnie Sahlberg a6d39ab5e6 Patch missed by cvs/me due to too different trees
svn path=/trunk/; revision=7544
2003-04-23 10:31:38 +00:00
Ronnie Sahlberg cb5e97d49a Update to TCP to handle hints from dissectors where the next PDU may start.
ONCRPC dissector updated to provide hint to TCP where the next RPCoverTCP
PDU starts as example.
Trivial updates to the other TCP based protocols required to amke them handle
this as well.  See the updates to packet-rpc.c as an example.

This is enabled by activating tcp analysis and provides hints to TCP to know where PDUs starts when not aligned to the start of the segment.

svn path=/trunk/; revision=7543
2003-04-23 10:20:29 +00:00
Guy Harris 1b872b3648 Make "register_tap_listener()" return NULL on success and a "GString *"
referring to a GString containing an error message on failure, and don't
have it print anything on failure.

If it fails, have its Tethereal-tap callers print an error message
before exiting, and have its Ethereal callers pop up a dialog box with
the error (except in cases where the failure is guaranteed not to be the
user's fault, and where we exit, in which case we just print an error
message before we exit).  In all cases, the error message includes the
text of the GString.

Fix a scanf format string in the DCE RPC statistics Ethereal tap, so
that it properly skips the comma before the filter string.

Fix some Ethereal error messages not to say "tethereal".

svn path=/trunk/; revision=7542
2003-04-23 08:20:06 +00:00
Guy Harris 81ebec370d Have "register_tap_menu_item()" create submenus as necessary for a menu
item.

Convert all Ethereal (GUI) taps to use "register_tap_menu_item()" rather
than having hardcoded menu items in "gtk/menu.c".

svn path=/trunk/; revision=7541
2003-04-23 05:37:23 +00:00