Commit Graph

28 Commits

Author SHA1 Message Date
Stephen Fisher a058ef7325 Make IPv4 addresses in AIM TLV data human readable.
svn path=/trunk/; revision=20141
2006-12-17 05:37:18 +00:00
Ronnie Sahlberg 2d1bb39121 change the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdus() to also include a packet_info pointer.
there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size



svn path=/trunk/; revision=19751
2006-10-31 09:29:07 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ronnie Sahlberg f331077a60 waste a couple of bytes per tcp conversation and make the tree for acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global.
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite   tcp analysis might actually work and work well even for tcp over tcp tunnelling. 

this also means that if you include packet-tcp.h   you also need to include emem.h .




svn path=/trunk/; revision=17681
2006-03-20 10:52:53 +00:00
Ronnie Sahlberg ed9d4d16c7 potential dereference of null pointer
coverity cid 39


svn path=/trunk/; revision=17512
2006-03-07 21:18:08 +00:00
Ronnie Sahlberg 213ef19c87 From Jelmer V AIM bugfix
Hi,

The attached patch fixes the name of the version field, which I
previously mistook for an authorization cookie (which is in fact in a
TLV that follows this field).



svn path=/trunk/; revision=16711
2005-12-07 00:27:17 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Jörg Mayer 7b2ff03d8c Fix more "no previous declaration" warnings
svn path=/trunk/; revision=15169
2005-08-02 04:31:42 +00:00
Ronnie Sahlberg 835df3a1d2 convert some uses of tvb_get_string() to ep_tvb_get_string()
there was at least one obvious memleak in one of the uses of tvb_get_string()



svn path=/trunk/; revision=15027
2005-07-24 02:43:41 +00:00
Anders Broman 43c0144b8e From Ilya Konstantinov :
A patch to the AIM dissector to support Client Auto Response messages. I still don't know the meaning of all the fields as they weren't all mapped but this patch decodes all the important ones.

svn path=/trunk/; revision=14911
2005-07-13 05:06:38 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Gerald Combs 131ab36a32 In tvb_get_string(), throw an exception if our length is less than zero.
Add a message block length check to the AIM dissector.

svn path=/trunk/; revision=13955
2005-03-28 15:55:47 +00:00
Guy Harris 3778ca99c1 If a given TLV type isn't found in an aim_tlv table, just use "Unknown"
as the description - some aim_tlv tables have NULL in the end-of-table
entry.

For those that don't, replace "Unknown" with NULL; "Unknown" is now
redundant.

svn path=/trunk/; revision=13084
2005-01-17 08:13:02 +00:00
Guy Harris 51014ac699 Use "tvb_format_text()" to extract and format the buddy name string in
the top-level item for the buddy name, rather than extracting the string
into a mallocated buffer (and not freeing it...).

Put all the code to put stuff into the protocol tree inside "if(tree)".

svn path=/trunk/; revision=12950
2005-01-05 09:41:20 +00:00
Ulf Lamping 5a89cfc00b Again, some warnings removed.
svn path=/trunk/; revision=12834
2004-12-25 18:35:21 +00:00
Gerald Combs f1857c511c Terminate value_strings with "{ 0, NULL }" instead of "{ 0, "Unknown" }".
Otherwise, "tethereal -G values" fails on some platforms.

svn path=/trunk/; revision=12701
2004-12-09 19:52:59 +00:00
Guy Harris 02c9bf57f4 Put the name, as well as the value, of the family and subfamily fields
into the protocol tree item that contains them.

svn path=/trunk/; revision=12379
2004-10-23 08:37:21 +00:00
Guy Harris bbe7f89742 Move prefs.c and prefs.h into the epan subdirectory.
svn path=/trunk/; revision=12115
2004-09-27 22:55:15 +00:00
Guy Harris 285066ac5b From Jelmer Vernooij:
- Dissect ICQ TLV values
- Dissect channel 1 and channel 2 messages correctly in Oscar (required
  for dissecting direct connections)

svn path=/trunk/; revision=12072
2004-09-23 17:40:36 +00:00
Guy Harris 8dedbeed1c From Jelmer Vernooij:
- Dissect the DC (Direct Connection) info structure
 - Dissect the complete buddy icon family (you can now save buddy
   icons as .JPG's/.PNG's directly from the capture using the "Export
   selected bytes..." option!)
 - Add a function that dissects a sequence of TLV's instead of having
   while() loops all over the place.

svn path=/trunk/; revision=12063
2004-09-22 08:04:40 +00:00
Guy Harris 94e550fe69 From Jelmer Vernooij:
Remove some code duplication from the Oscar dissector (reduces
	the number of lines by 500) by providing a custom registration
	function for oscar families (aim_init_family).  This also fixes
	a number of issues with column names.

	Add minor updates such as adding support for the Capability Info
	TLV on users.

svn path=/trunk/; revision=12060
2004-09-21 08:01:29 +00:00
Guy Harris 9a1ec8eb0b From Jelmer Vernooij:
- Support client capabilities list
	- Fix incorrect TLV usage

svn path=/trunk/; revision=12040
2004-09-18 06:42:16 +00:00
Guy Harris 431d187367 From Jelmer Vernooij: get rid of some unused tables.
svn path=/trunk/; revision=12030
2004-09-17 09:37:14 +00:00
Guy Harris 6bc5ac3949 from Thomas Boehne: don't put code before a declaration - that's a
GCCism.

De-@ify Marten Svantesson's e-mail address.

svn path=/trunk/; revision=12028
2004-09-17 09:30:41 +00:00
Guy Harris b3360018b5 From Jelmer Vernooij:
- Support for more generic TLV's
- Support for two more SNAC families: email and sst
- Support for extended status (as used by iChat)
- Use correct TLV in SSI RightsInfo
- Dissect and handle FNAC flags field correctly

svn path=/trunk/; revision=12022
2004-09-17 02:02:04 +00:00
Ulf Lamping d530bd4e14 Prevent the word "desegmentation" at the GUI, but use reassembling at that places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions.
I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences.

Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect.

If you encounter any mistakes I've made here, please let me know...

svn path=/trunk/; revision=11784
2004-08-21 09:02:52 +00:00
Guy Harris c08032765d From Jelmer Vernooij: add support for some more TLVs and another SNAC.
svn path=/trunk/; revision=11577
2004-08-01 22:55:53 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00