Commit Graph

119 Commits

Author SHA1 Message Date
Jeff Morriss b0ab8e5df4 Improve heuristic standard detection:
- Make sccp_called_calling_looks_valid() static.
 - Reject GT-routed Class-2 (it's not used).
 - Handle UDTS.
 - Handle optional pointer on several messages.

svn path=/trunk/; revision=40782
2012-01-31 04:02:08 +00:00
Jeff Morriss a3de46bf3e Heuristic standard tuning:
- Reject all Class-3 messages (it's never used)
 - Group Class-2 and Class-1 messages closer together
 - Some code cleanup (use macros where we have them)

svn path=/trunk/; revision=40780
2012-01-30 23:15:07 +00:00
Anders Broman 80c5205b8e Reformat a section.
svn path=/trunk/; revision=40777
2012-01-30 19:54:39 +00:00
Anders Broman ed5c6cfd71 Try to determine MTP3 Standard heuristically, original code
from Jeff Morris refactored a bit by me.

svn path=/trunk/; revision=40776
2012-01-30 19:47:35 +00:00
Chris Maynard 647c5c0b27 packet_info's in_error_pkt is now a bitfield like in_gre_pkt.
svn path=/trunk/; revision=39764
2011-11-08 18:39:11 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Anders Broman 14fbabcb26 Get rid of check_col() and use ENC.
svn path=/trunk/; revision=39153
2011-09-26 17:50:54 +00:00
Jeff Morriss 5262c3f4b0 Update my email address (the old one still works but I don't use it for Wireshark related stuff).
svn path=/trunk/; revision=38841
2011-09-01 14:30:16 +00:00
Jeff Morriss 8ce306faa0 Inspired by one of the changes from r37406 and bug 2794: detect hf abbreviations
with two or more periods in a row.  Fix one case of that.

svn path=/trunk/; revision=37407
2011-05-26 13:32:04 +00:00
Anders Broman 6a4ed4f4c3 From Michael Mann.
Part of "display filters with redundancies of PROTABBREV in them."
The ones left outs should be fixed differently I think.
Rename som ndps hf variables while at it.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794

svn path=/trunk/; revision=37406
2011-05-26 06:32:51 +00:00
Jeff Morriss db372d0ad2 Add some expert infos for unusual messages:
- routing on SSN but the SSN is not present or is unspecified (zero)
 - message handling has an unexpected value
 - message class is incorrect for the message type

Also clean up some indentation and other white space.

svn path=/trunk/; revision=37400
2011-05-25 21:47:35 +00:00
Guy Harris ff389e5a18 Squelch a narrowing warning.
svn path=/trunk/; revision=37228
2011-05-17 23:39:06 +00:00
Jeff Morriss 747a964aef Always add the parameter length field to the tree; only make it visible
if the preference is set.

Add %d to the "not found" string in val_to_str() calls.

Upgrade the "ITU address format seen in ANSI" expert info from NOTE to WARN.

svn path=/trunk/; revision=37218
2011-05-17 22:21:25 +00:00
Jeff Morriss 82a8d6b153 Add a filterable item for the length of the GT digits in a subtree under the
digits.

Since we now have a subtree from which to hang things, make the generic (called
or calling) digits fields visible under this new subtree (one less hidden item).

Don't use add_string_format() to add the GT digits, let epan format it for us.
Use more descriptive field descriptions for these entries.

svn path=/trunk/; revision=37214
2011-05-17 21:59:58 +00:00
Jeff Morriss 664c69dbaa Use proto_tree_add_item() when it saves us from having to retrieve the value
and without causing us to potentially run into bug 3834.

Add a couple hf entries for things that had been added with add_text().

svn path=/trunk/; revision=36946
2011-04-29 02:16:13 +00:00
Jeff Morriss 6b13963a63 If we're in a message return (UDTS or XUDTS), set pinfo->in_error_pkt to help
make it obvious to the user that this is an error message.

Fix up some indentation.

svn path=/trunk/; revision=36945
2011-04-29 01:45:34 +00:00
Stig Bjørlykke 84bc28bd6a Introduce "Fragment count" filter element for all protocols doing reassembly.
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jeff Morriss 2b77738b11 From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :
The information which is used to determine which sub-dissector to use for the
various Data messages within an SCCP connection is only present within the
initial Connection Request, so even with connection tracking on, unless the
trace contains the Connection Request no sub-dissector is called. It is common
for traces to only contain a single carried protocol anyway - e.g. RANAP.

The supplied patch adds a user preference for a "default payload"
sub-dissector, which is called in preference to the Data dissector if nothing
else has claimed the packet first.

svn path=/trunk/; revision=35098
2010-12-01 23:26:07 +00:00
Jeff Morriss 7967c282c0 From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :
The packet-sccp.c has a bug in the declared valid ranges of the SSN and DPC
values in the user table used to match to a subdissector. The SSN range is 16
bits rather than 8 (not really an issue) but the DPC range is 16 bits rather
than 24 - so many traces cannot be matched by this table.

svn path=/trunk/; revision=35097
2010-12-01 23:12:46 +00:00
Stig Bjørlykke f7c394dfd0 Initialize no_assoc.app_info=0.
svn path=/trunk/; revision=35011
2010-11-22 21:05:49 +00:00
Guy Harris 17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
2010-10-29 21:11:33 +00:00
Jeff Morriss 074e49fd41 hf variables can be copied/passed by value, not by reference.
svn path=/trunk/; revision=34467
2010-10-11 01:52:41 +00:00
Jeff Morriss 3be92af2d9 Add a preference that allows the user to decide if they want the calling and
called GTs (if RI=GT) put in the (pinfo) source and destination (and thus into
the source and destination columns).

This may help (if the PCs change but the GT does not) or hurt (if the GT or RI
change but the PCs do not) TCAP's ability to identify which messages belong to
which TCAP "session."

svn path=/trunk/; revision=33097
2010-06-04 20:52:02 +00:00
Jeff Morriss 99aa11c6ed Reindent a bit
svn path=/trunk/; revision=32794
2010-05-13 20:31:53 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Stig Bjørlykke 2f8830b4d0 From LEGO via bug 3459:
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.

svn path=/trunk/; revision=32112
2010-03-04 12:50:18 +00:00
Stig Bjørlykke 539b558f8c Renamed some reassembled data texts.
Removed some check_col().

svn path=/trunk/; revision=31809
2010-02-06 18:20:21 +00:00
Gerasimos Dimitriadis 214148c7c6 Fix the MNC decoding when Global Title is built
according to E.212

svn path=/trunk/; revision=31802
2010-02-05 20:54:13 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Anders Broman 6343ffb68e Try to fix indentation sligtly.
svn path=/trunk/; revision=31518
2010-01-13 20:26:17 +00:00
Jeff Morriss 6d11b171d6 Add support for LUDT/LUDTS in ANSI (ANSI added them in 2000/2001).
svn path=/trunk/; revision=31268
2009-12-14 20:08:11 +00:00
Gerasimos Dimitriadis b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam b97cfa22fd offset_from_real_beginning() is only called with 0 as second argument, so remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning().
svn path=/trunk/; revision=29844
2009-09-10 16:54:02 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Jeff Morriss b62e6545b9 Add an expert info noting that an ANSI message with the national indicator set to 0 (international) is unusual.
svn path=/trunk/; revision=29464
2009-08-18 13:25:49 +00:00
Gerald Combs 0ff1dd7142 Add a bunch of length checks. Fixes bug 3826.
svn path=/trunk/; revision=29383
2009-08-11 18:37:59 +00:00
Gerald Combs 85f68c7461 Fix compilation warnings in a few dissectors and try moving them to the
"clean" list.

svn path=/trunk/; revision=29313
2009-08-06 20:55:04 +00:00
Guy Harris bd97aecdd3 Clean up indentation somewhat.
svn path=/trunk/; revision=29281
2009-08-03 21:17:30 +00:00
Gerald Combs 8224d4e436 Add a null pointer check. Remove some unused variables.
svn path=/trunk/; revision=29278
2009-08-03 19:50:35 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jeff Morriss 05322d40f1 Decode SCCP cause values in SUA (using value_strings exported from the SCCP
dissector).

svn path=/trunk/; revision=28599
2009-06-02 15:34:17 +00:00
Gerald Combs def3068154 Use se_alloc0 and ep_alloc0.
svn path=/trunk/; revision=28397
2009-05-18 20:30:55 +00:00
Anders Broman 95c51c2e2d Make an epxpert item checking PC length.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3458

svn path=/trunk/; revision=28337
2009-05-12 17:48:48 +00:00
Jaap Keuter 33791dea9f From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28223
2009-05-01 07:18:41 +00:00
Jaap Keuter b751e5367c Constify some more value_strings.
svn path=/trunk/; revision=28101
2009-04-21 05:33:32 +00:00
Bill Meier bee5d93ed9 packet_sccp.c: Init an uninit'd variable which was the cause of intermittent crashes.
Fixes Bug #3409 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3409)

svn path=/trunk/; revision=28058
2009-04-15 20:01:45 +00:00
Anders Broman 7d3b2bfbbd Small indentation fix.
svn path=/trunk/; revision=28016
2009-04-09 05:51:15 +00:00