osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
25485 commits 26 branches 0 tags 795 MiB
Commit graph

138 commits

Author SHA1 Message Date
Jeff Morriss
4a0826ef2f From yami via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2603 : register the SMB dissector by name. 
svn path=/trunk/; revision=25444
 2008-06-12 13:39:55 +00:00
Guy Harris
bdd6b807d7 Note underflow/overflow possibilities (there used to be checks that 
clamped at TIME_T_MIN and TIME_T_MAX, but newer versions of GCC
"helpfully" warn that the usual checks for overflow or underflow "can't
fail").

svn path=/trunk/; revision=25391
 2008-05-29 16:51:49 +00:00
Bill Meier
44af6ef887 Fix some of the Errors/warnings detected by checkapi. 
svn path=/trunk/; revision=25290
 2008-05-14 01:47:41 +00:00
Jörg Mayer
60547db130 gcc 4.3 will not handle an overflow in the expected way but will warn instead. -Werror does the rest 
svn path=/trunk/; revision=25029
 2008-04-14 21:33:56 +00:00
Jeff Morriss
dd11fc1385 Fix another crash from http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1113 : conv_tables_t hold several g_malloc()'d things that need to be freed in smb_init_protocol() but the conv_tables themselves were se_ allocated so they have already been freed by the time we want to try to free them. Fix this by g_malloc()'ing them and freeing them after we've freed their contents. 
svn path=/trunk/; revision=24669
 2008-03-17 17:46:05 +00:00
Stig Bjørlykke
b091b8d26c Rewrote to use g_strlcpy and g_strlcat. 
svn path=/trunk/; revision=24525
 2008-03-01 17:23:39 +00:00
Stig Bjørlykke
28ae535b00 Removed even more "statement not reached" warnings. 
svn path=/trunk/; revision=24286
 2008-02-07 15:44:45 +00:00
Ronnie Sahlberg
7e919ef623 add support for qpi level 516 : posix acl 
svn path=/trunk/; revision=24052
 2008-01-09 23:10:17 +00:00
Ronnie Sahlberg
9a3eeab4ee add some more names for Query/Set path info levels and add empty stubs 
for these blobs


svn path=/trunk/; revision=23831
 2007-12-10 21:16:17 +00:00
Gerald Combs
3697704b62 Fix bug 2019: The SMB dissector was dereferencing a NULL pointer. 
svn path=/trunk/; revision=23593
 2007-11-25 23:08:09 +00:00
Anders Broman
6226035893 Apply yet another set of the optimization patches: 
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().

On the other hand 
	if (tvb_bytes_exist(tvb, 0, 20)
is more readable than
	if (tvb_length(tvb) >= 20

so only do it in heuristic function

svn path=/trunk/; revision=23412
 2007-11-09 06:01:18 +00:00
Anders Broman
4d07f32a41 Apply yet another set of the optimization patches: 
- Move proto_tree_add_xxxx calls inside 'if (tree) {}' block

svn path=/trunk/; revision=23403
 2007-11-08 22:38:06 +00:00
Anders Broman
1950ffc214 Apply the small performance enhancment patches for: 
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
 2007-10-23 05:50:00 +00:00
Ronnie Sahlberg
331d267b50 we need to track the fid in the rwdata structure so that reassembly of 
connectionoriented dcerpc over smb pipes will be able to find the fid 
used for reassembly


svn path=/trunk/; revision=22557
 2007-08-20 08:09:52 +00:00
Ronnie Sahlberg
f74d20b142 track filenames between rename requests and responses to make it easier to 
diagnose why a rename failed


svn path=/trunk/; revision=22122
 2007-06-17 23:58:01 +00:00
Ronnie Sahlberg
0adc338017 remember locking info between requests and repsonses so it is easier to 
diagnose why an operation returned an error


svn path=/trunk/; revision=22121
 2007-06-17 20:57:34 +00:00
Guy Harris
ad07451fd1 For various routines used by dissect_smb_fid() to dissect various FID 
attributes specified at open time, have them take a length value, and
pass 4 if the values are extracted from the current packet and 0 if they
come from values saved when the FID was opened (as they're generated
values not found in the packet) - that fixes bug 1638.

svn path=/trunk/; revision=22053
 2007-06-05 21:23:49 +00:00
Ronnie Sahlberg
49849c691e show the directory name in replies to CreateDir/Checkdir and DeleteDir 
svn path=/trunk/; revision=21899
 2007-05-22 23:12:58 +00:00
Ronnie Sahlberg
bc33880788 show the filename that was to be deleted in the Delete reply 
svn path=/trunk/; revision=21897
 2007-05-22 23:05:25 +00:00
Ronnie Sahlberg
9f69a4eae2 improve FIND_FIRST2 useability in the same way as in the previous 
patches


svn path=/trunk/; revision=21881
 2007-05-22 03:55:54 +00:00
Ronnie Sahlberg
050a0508e1 remember the object name from a QUERY_PATH_INFO and show it as a 
generated item in the response.

also show the infolevel in the response as a generated item


svn path=/trunk/; revision=21880
 2007-05-22 03:33:51 +00:00
Ronnie Sahlberg
dac8664c9e show the QUERY_FS_INFO level as a generated item in the response packet 
svn path=/trunk/; revision=21875
 2007-05-22 02:14:35 +00:00
Ronnie Sahlberg
c5575a6894 add the level of interest to the dissection of QUERY_PATH_INFO/QUERY_FILE_INFO responses 
as a generated item


svn path=/trunk/; revision=21874
 2007-05-22 01:42:56 +00:00
Ronnie Sahlberg
196ed78ce8 add the disposition to the data we store for how a fid is opened 
svn path=/trunk/; revision=21873
 2007-05-22 01:26:32 +00:00
Ronnie Sahlberg
52143e84d0 add tracking of OFFSET/LENGTH to reads/writes so we can easily see in a failed read/write 
what offset/length was requested


svn path=/trunk/; revision=21858
 2007-05-21 07:17:36 +00:00
Ronnie Sahlberg
274ef386b0 since we now have a generic "track fid for transactions" we no longer need to do this 
explicitely in the read/write functions


svn path=/trunk/; revision=21857
 2007-05-21 06:49:18 +00:00
Ronnie Sahlberg
7a68b1be72 track FIDs on a per transaction (request+response) basis and make sure the FID is printed 
in both packets of a transaction.

this makes filters such as "smb.file==foo.txt" work much better since they now show both 
the read/write request and also the response packets.
this is similar to what we already do in nfs for filehandles



svn path=/trunk/; revision=21856
 2007-05-21 03:44:49 +00:00
Ronnie Sahlberg
be579f8bb2 there wre two fields in smb for filenames with the same display filer string. 
rename one of them to a different name so filtering works reliably


svn path=/trunk/; revision=21855
 2007-05-21 03:07:25 +00:00
Ronnie Sahlberg
ff35bf2ca1 make create_options, access_mask and share_access fitlerable 
svn path=/trunk/; revision=21745
 2007-05-11 03:02:38 +00:00
Ronnie Sahlberg
f43afbaf35 add more tracking of FID properties 
track create_flags, access_mask, file_attributes, share_access and 
create options for all FIDs


svn path=/trunk/; revision=21743
 2007-05-10 20:53:35 +00:00
Ronnie Sahlberg
e5e23150ab prettify dissection of FIDs, 
put the filename, if known, on the fid expansion line

also place a "generated" fid in failed ntcreateandx so it is easier to 
quickly see which file the ntcreateandx failed for


svn path=/trunk/; revision=21739
 2007-05-10 02:34:06 +00:00
Ronnie Sahlberg
0eae1cc0bd add dissection of smb1 ioctl data by tying it into the dissectors for 
ioctl data that already exists for smb2


svn path=/trunk/; revision=21713
 2007-05-07 09:07:29 +00:00
Ronnie Sahlberg
34afdc5fc3 change the smb2 ioctl function to take a pointer to a uint32 (ioctl 
function code) instead of a structure

extend the nt trans structure to contain a ioctl function code for smb1


svn path=/trunk/; revision=21712
 2007-05-07 08:11:59 +00:00
Ronnie Sahlberg
bda722d3bf remove the ioctl function and table from the smb dissector and just use 
the one in smb2 instead since the smb2 one is more developed.


svn path=/trunk/; revision=21711
 2007-05-07 07:41:35 +00:00
Guy Harris
65b4512fe3 As with other types of extra info, tag the UID extra info. Don't add 
stuff to the UID tree unless it's UID stuff.

Also, as we appear to allow for null domain and account information in
dissect_smb_uid(), check for null information before trying to add it to
the top-level item.

svn path=/trunk/; revision=21597
 2007-04-26 19:44:18 +00:00
Ronnie Sahlberg
1f80370b85 Add tracking of uid->domain/account mappings for SMB by tapping the ntlmssp tap for the information from the authentication messages 
Improve the tid tracking by putting the host/share information on the tid expansion line so one can see it without opening the expansion


svn path=/trunk/; revision=21547
 2007-04-24 05:09:00 +00:00
Stephen Fisher
763a80f5bb Fix more warnings 
svn path=/trunk/; revision=21286
 2007-03-30 21:20:57 +00:00
Stephen Fisher
8fd3ee0560 Remove almost all of the casts I committed recently and in place of 
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
 2007-03-28 21:55:11 +00:00
Stephen Fisher
85a464c980 Fix a bunch of warnings, add svn:keywords Id and svn:eol-style native 
to packet-iuup.c.
 

svn path=/trunk/; revision=21244
 2007-03-28 07:06:39 +00:00
Ulf Lamping
f1a58d41d4 from Peter Johansson: 
compilation warnings fixed

svn path=/trunk/; revision=21230
 2007-03-27 21:20:19 +00:00
Ronnie Sahlberg
97ee85b682 remove some compiler warnings 
svn path=/trunk/; revision=21071
 2007-03-20 14:58:55 +00:00
Ronnie Sahlberg
bfcb77a3ff show the share mode bits that are SET on the share mode expansion line so one can see easily which share modes are requested without having to open the share mode expansion 
svn path=/trunk/; revision=20808
 2007-02-14 11:49:01 +00:00
Bill Meier
a481698a95 Remove unused variable 
svn path=/trunk/; revision=20038
 2006-12-05 02:53:39 +00:00
Ronnie Sahlberg
7ca2ad980f store FID/TID tracking based on the fid/tid value and not the frame it was opened in. 
svn path=/trunk/; revision=20031
 2006-12-01 23:41:10 +00:00
Ronnie Sahlberg
5c2232dc22 replace a rotating buffer in smb with ep allocated memory 
dont try dcerpc reassembly of fragments if we dont have the entire pdu

only call the heuristical dissectors once from smb/pipe as per guy(?)s comments about idempotence.
when doing reassembly, the dcerpc dissector is indeed not idempotent any more.



svn path=/trunk/; revision=19304
 2006-09-23 13:21:54 +00:00
Jaap Keuter
18664a7803 From: Marco Strack 
The smb dissector displays lock requests in the "Locking AndX Request" as a vector of locks. It opens a tree branch
"Locks" and appends the locks to this branch. Instead of adding "Lock" objects to this branch it added "Unlock"
objects. Everything else is fine.

svn path=/trunk/; revision=19271
 2006-09-21 13:08:50 +00:00
Gerald Combs
7bded1f0ee Fix CID 209 (possible NULL dereference). 
svn path=/trunk/; revision=18950
 2006-08-18 20:18:38 +00:00
Ronnie Sahlberg
58396f47da add tracking of fid type to objects opened by NT CREATE so that we can dissect aces properly also for these fids 
svn path=/trunk/; revision=18929
 2006-08-16 19:38:39 +00:00
Ronnie Sahlberg
b02d08fa76 use the same structure to pass the fid type information from nt transaction parameter to nt transaction data dissector for both ssd and qsd instead of two different ones 
svn path=/trunk/; revision=18927
 2006-08-16 10:35:04 +00:00
Ronnie Sahlberg
d08c190fe0 track fid types between NT TRans QUERY_SECURITY_DESCRIPTOR and dissect the ACEs properly 
svn path=/trunk/; revision=18926
 2006-08-16 09:22:36 +00:00