Commit Graph

1705 Commits

Author SHA1 Message Date
Kovarththanan Rajaratnam a9ed97b344 From Gerasimos Dimitriadis via. bug 4104:
When dissecting a h248 message, col_set_str is called with a string from the ephemeral pool and an assertion fails.

svn path=/trunk/; revision=30398
2009-10-08 13:17:51 +00:00
Stig Bjørlykke b7d8cd1c6a Switch to using tvb_new_subset_remaining() in .cnf files.
svn path=/trunk/; revision=30386
2009-10-07 07:59:11 +00:00
Stig Bjørlykke 843459d075 Made dissect_pres() static.
Added changes from r29446 to .cnf file:
 Switch a bunch of dissectors over to using tvb_new_subset_remaining()

svn path=/trunk/; revision=30385
2009-10-07 07:47:41 +00:00
Anders Broman bc9a809b65 From Didier Gautheron:
ep memory can't be used for tvbs defined as data_source.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4054

svn path=/trunk/; revision=30376
2009-10-06 19:15:58 +00:00
Anders Broman 0f4d4344dd From Gerasimos Dimitriadis:
GSM MAP: an-APDU not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4095

svn path=/trunk/; revision=30375
2009-10-06 19:04:29 +00:00
Stig Bjørlykke 01668de485 Fixed offset_from_real_beginning() -> tvb_offset_from_real_beginning()
svn path=/trunk/; revision=30349
2009-10-05 21:39:47 +00:00
Stig Bjørlykke 902a1013a4 Return from dissect_snmp_VarBind() when detecting invalid oid.
svn path=/trunk/; revision=30348
2009-10-05 21:39:07 +00:00
Kovarththanan Rajaratnam 7a3721dcea Whitespace changes
svn path=/trunk/; revision=30301
2009-10-04 14:59:18 +00:00
Anders Broman 9967ec683f From Vincent Helfre:
Update the LTE RRC dissector to september 29 version.

svn path=/trunk/; revision=30241
2009-10-01 18:22:16 +00:00
Anders Broman 8537091ce8 Update to 3GPP TS 36.413 V9.0.0 (2009-09)
svn path=/trunk/; revision=30232
2009-10-01 14:21:40 +00:00
Anders Broman 5e6b38d75a Update to 3GPP TS 36.413 V8.7.0 (2009-09)
svn path=/trunk/; revision=30231
2009-10-01 13:48:36 +00:00
Stig Bjørlykke e2d6320d75 Only include config.h in C files, to avoid multiple inclusion.
svn path=/trunk/; revision=30182
2009-09-28 17:58:47 +00:00
Stig Bjørlykke 8fce84f9e2 Fix a possible dereference of null pointer when having no tree.
svn path=/trunk/; revision=30174
2009-09-27 21:18:18 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam 830dd8e8f0 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30126
2009-09-24 20:07:41 +00:00
Kovarththanan Rajaratnam 65c53fedb6 Don't guard col_append_str with check_col
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam cf8138e195 Remove check_col() guard
svn path=/trunk/; revision=30124
2009-09-24 19:50:43 +00:00
Anders Broman 1b454d9012 Propagate the changes to the .cnf file so they don't get lost when regenerating the dissector.
Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO

svn path=/trunk/; revision=30092
2009-09-23 15:43:55 +00:00
Kovarththanan Rajaratnam 99624329fa Don't col_clear() followed by col_set_str(). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though)
svn path=/trunk/; revision=30086
2009-09-23 14:30:36 +00:00
Anders Broman f16502fdfb Minor ASN1 update.
svn path=/trunk/; revision=29975
2009-09-17 19:45:00 +00:00
Jeff Morriss 7a91a5b053 Don't call check_col(). Add a space at the end of each COL_INFO entry to make the column more readable when SCTP bundles multiple messages together.
svn path=/trunk/; revision=29922
2009-09-15 15:16:15 +00:00
Kovarththanan Rajaratnam b97cfa22fd offset_from_real_beginning() is only called with 0 as second argument, so remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning().
svn path=/trunk/; revision=29844
2009-09-10 16:54:02 +00:00
Anders Broman 8a23b29c91 From Alex Lindberg:
Add H248V1 suport.
(H248 dissector fails on poorly formed AuditReply packet from Media Gateway)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953

svn path=/trunk/; revision=29835
2009-09-10 05:57:30 +00:00
Anders Broman 0c5dfd7698 Target Identification shall be coded as TLV IE where value is
coded as TargetRNC-ID.
Proposed fix to
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3974
(The enclosed trace dioes not decode properly but may be wrongly encoded).

svn path=/trunk/; revision=29816
2009-09-09 07:29:41 +00:00
Anders Broman 3d2e307ae6 From Alex Lindberg:
Update to h248v3.asn

Applied the change from the Amendment 1 by hand.

svn path=/trunk/; revision=29787
2009-09-08 09:11:21 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam f352fa6d90 s/col_add_fstr/col_add_str
svn path=/trunk/; revision=29727
2009-09-06 05:29:51 +00:00
Kovarththanan Rajaratnam 6fe1060cd1 Don't pass ep_alloc()'ed strings to col_set_str().
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984

svn path=/trunk/; revision=29726
2009-09-06 04:26:50 +00:00
Tomas Kukosa 9e282cf141 export t38_add_address, prefer destination port for T.38 conversation searching
svn path=/trunk/; revision=29564
2009-08-26 15:10:31 +00:00
Tomas Kukosa 60022bc5f2 Expert info for undecoded Q.932 and H.450 operations
svn path=/trunk/; revision=29534
2009-08-24 09:05:15 +00:00
Kovarththanan Rajaratnam 66afe84075 Use <gcrypt.h> instead of 'gcrypt.h'
svn path=/trunk/; revision=29501
2009-08-21 20:40:49 +00:00
Kovarththanan Rajaratnam c19f7978db Sanitize epan includes
svn path=/trunk/; revision=29500
2009-08-21 20:32:50 +00:00
Anders Broman c8ec27c000 Make build bot happy?
svn path=/trunk/; revision=29463
2009-08-18 12:15:36 +00:00
Anders Broman a4109274e2 Typo: parameter_tvb to be used.
svn path=/trunk/; revision=29462
2009-08-18 11:39:55 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible.
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
Kovarththanan Rajaratnam ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Kovarththanan Rajaratnam ced157e4b7 Make sure that we pass on the same set of parameters to asn2wrs.py on Unix/Windows. This fix ensures that the generated copyright headers are identical on both platforms.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3658

svn path=/trunk/; revision=29336
2009-08-08 09:57:07 +00:00
Gerald Combs 7cf4114654 If we have a format error, don't try adding something to the
tree. Fixes bug 3822.

svn path=/trunk/; revision=29331
2009-08-08 00:27:31 +00:00
Gerald Combs 931a750908 Add a couple of pointer checks.
svn path=/trunk/; revision=29301
2009-08-05 00:36:27 +00:00
Bill Meier cb7dac7100 Initialize several ett_... variables to -1
svn path=/trunk/; revision=29295
2009-08-04 18:52:01 +00:00
Gerald Combs 87c095780a Rework an assignment to keep static analyzers from complaining.
svn path=/trunk/; revision=29287
2009-08-03 23:51:13 +00:00
Gerald Combs 9a35ed601d Remove more unused variables.
svn path=/trunk/; revision=29249
2009-07-30 23:47:36 +00:00
Ronnie Sahlberg f8cf2d2c83 When we passed the crytobuffer to krb5_c_decrypt() we never actually
verified that we did have enough data in the buffer/tvb, which could 
lead to a SEGV.
(for example if we enable KRB5 decryption but we do NOT use TCP 
reassembly, and the encrypted data goes beyong the end of the current 
segment)


Change the signature to decrypt_krb5_data() to take a TVB instead of a 
buffer+length.
Actually check that we do have the entire encrypted PDU before calling 
out to the kerberos libraries.



svn path=/trunk/; revision=29213
2009-07-28 13:01:41 +00:00
Ronnie Sahlberg ac1b52a838 From: Matthieu Patou <mat+Informatique.Samba@matws.net>
Date: Mon, 27 Jul 2009 08:55:55 +0000 (+0200)
Subject: patch_ldap_260709

Add a few additional LDAP OIDs
and increase the maximum SASL blob size to be 1M instead of 256kb



svn path=/trunk/; revision=29210
2009-07-28 07:18:05 +00:00
Anders Broman f1e8e405ce From Neil Piercy:
Another missing RRC dissector chaining link.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3769

svn path=/trunk/; revision=29172
2009-07-23 05:32:31 +00:00