Extract the FCS decoding section of the PPP_HDLC dissector to
allow the CHDLC dissector to use the same routine.
The ppp_options used for preferences has been renamed to
fcs_options and exported via packet-ppp.h so CHDLC gets a
separate (but identical) FCS preference.
This means prefs.h has to be included before packet-ppp.h so a
couple of ppp related files (packet-{gtp,null,raw,vj}.c) had
their includes slightly re-arranged.
From me: make the PPP/CHDLC FCS code use "crc32()" to check the 32-bit
FCS.
svn path=/trunk/; revision=8266
use to translate addresses to strings - wire that into
"endpoint_talkers_table.c", don't pass the function as an argument to
"init_ett_table()".
svn path=/trunk/; revision=8263
which fills in a caller-supplied buffer.
Create "_buf()" versions of various "to_str" routines for various
address types, and create a routine to map SNA FIDs to strings, and use
them to finish up "address_to_str_buf()".
Get rid of the declaration of "sna_fid_type_4_addr_to_str()" in
"packet-sna.h", as that routine has been swallowed up in
"sna_fid_to_str()".
svn path=/trunk/; revision=8260
1. Added support for defragmentation of NDS packets
2. The packet signature fixes seemed to never been applied. I
have been using this code to dissect reply packets with packet
signatures for quite some time and have never experienced any
problems with it. Without these changes then reply packets
containing signatures will not be decoded properly. It was
recommended by Guy to not use public variables to track the
signatures but it has been my experience that if signatures are
enabled then it is enabled in the whole environment and would be
valid for all NCP packets within the trace. I could change this
but it would add additional code to build a memory table to
track this. If for some reason it is determined to not add this
part of the code then I will have to go back and add this table.
svn path=/trunk/; revision=8258
1. Added support for defragmentation of NDS packets
2. Moved the run_info_string logic outside of the
pinfo->fd->flags->visited because of the dissection of info
strings is not processed on subsequent decodes then the
find/string/info will not locate info string values. By moving
this outside then when the find logic runs a tvb_dissect_new
then the info string gets processed again and all data is
visible. Otherwise only info column data that is processed by
the NCP dissector is visible not any data from ncp2222.py
processed by the info string function.
svn path=/trunk/; revision=8257
1. Added Secret Store Services group
2. Added a number of NCP return values
3. Added support for NDS defragmentation
4. Fixed type from file to bindery on ncp's 23/20, 23/21, 23/22, 23/24,
23/27, 23/28, 23/29, 23/30, and 23/31
5. Fixed type from comm to nmas on ncp 91
6. Fixed ncp 92 to include 92/01, 92/02, 92/03, 92/04, 92/05, 92/06,
92/07, 92/08, 92/09, and 92/10
7. Added return value for 104/02
8. Fixed reply structures for NCP 123/60 and NCP 123/79
svn path=/trunk/; revision=8256
make the "Help" menu the rightmost menu item, as is done in
recent versions of Windows;
Mac OS X;
recent versions of KDE;
recent versions of GNOME;
rather than making it an item on the far right side.
Make the "Protocol" display in the help mention the number of
entries, and give it has 3 columns, starting with the one that
was used to sort this list.
Make the "Display Filters" display mention the number of fields
for each protocol and at the end the total number of fields.
Give it 4 columns, including the 'blurb'.
List all fields with the correct protocol.
svn path=/trunk/; revision=8253
to make it easier to navigate when having multiple instances of ethereal
and io-stat open
at the same time.
Updates to all endpoint talkers and service response time windows to do this as well.
Bonus, when the user opens a new capture file when having these windows open,
the title bar will be updated to reflect the name of the new capture file.
svn path=/trunk/; revision=8251
The heuristic for RPC detection sometimes mistakenly decodes something as RPC when in reality it is payload.
Since the heuristics is based on the PDU suze as specified in the record marker
make this limit settable from the preferences.
Arbitrary limit of 256kb is choosen as default instead of the original limit of 2mb.
(face it, the largest common oncrpc pdus are those for nfs read/write anyway and these seldom go above 32kb.)
svn path=/trunk/; revision=8250
support for registering fields after all the protocol
registration routines are called (i.e., adding fields to the
named field tree as they're registered);
fix the GTK 2.x version of the field list dialog to show the
correct name.
svn path=/trunk/; revision=8248
windows can also be invoked from the Ethereal command line using the -z
talkers argument" (as pod2man suggests be done).
svn path=/trunk/; revision=8244
Put in some additional "case AT_" statements to
1) squelch compiler warnings;
2) add AT_ARCNET (cheap and easy);
3) add placeholders for some other address types.
svn path=/trunk/; revision=8243
Update the talkers tap for tethereal (iousers) and change the command line to invoke the tethereal version from -z io,users, to -z talkers, to be the same
as for ethereal.
Sorry if it breaks some scripts but io,users was a very nonintuitive name for this option.
talkers is not much better but at least a little bit more descriptive/intuitive. Anyone with a better name for this are welcome to provide a patch.
The tethereal version is now agnostic to wether v4 or v6 are transporting UDP/TCP
svn path=/trunk/; revision=8236
Implement conersion from address to string for IPv4 and IPv6
and update the conversation tables to use the new interface.
svn path=/trunk/; revision=8234
Supported types are Ethernet/TokenRing/IP/UDP and TCP.
Will add FibreChannel soon.
The framework for this feature needs to be enhanced in the future so that by selecting one entry and click the right mousebutton, this will bring up a menu with Prepare/Match options with suboptions for AnyDirection, ForwardOnly or ReverseOnly which updates the display filter accordingly.
Had to update some of the taps as well to change them to use a proper address structure for the address fields.
We should now be able to to these stats correctly even for ip tunneled over ip tunnelled over ip ...
svn path=/trunk/; revision=8222
a not-yet-ready-for-prime-time project of mine (fast random access to
gzipped files, plus an mechanism to allow support for other forms of
compression).
svn path=/trunk/; revision=8221
Guy Harris