Commit Graph

8374 Commits

Author SHA1 Message Date
Gerald Combs a8f9d8211d Fix a buffer overflow in msisdn_to_str(). Clean up string pointer handling
in it, imsi_to_str(), and id_to_str() a bit.

svn path=/trunk/; revision=8468
2003-09-14 21:28:13 +00:00
Jörg Mayer 0c4c9462c8 Fix warning: guint8 is always <= 255
svn path=/trunk/; revision=8467
2003-09-14 20:59:31 +00:00
Guy Harris 44b236a123 According to draft-ietf-manet-aodv-13, the only differences between V4
and V6 AODV messages is the addresses in the message.

According to the now-expired draft-perkins-aodv6-01, some of the
messages differ in the order of the fields as well.

Dissect the draft-ietf-manet-aodv-13 messages correctly.

svn path=/trunk/; revision=8466
2003-09-13 00:57:10 +00:00
Guy Harris 375204a3e2 According to draft-ietf-manet-aodv-13, "the only changes to the protocol
are that the address fields are enlarged", so presumably that supercedes
the now-expired draft-perkins-aodv6-01 which gives different type
numbers for V6.  We support both - the draft-ietf-manet-aodv-13 messages
are dissected based on the address type of the source address, while the
draft-perkins-aodv6-01 messages are dissected as V6.

Handle the Route Reply Acknowledgment message.

svn path=/trunk/; revision=8465
2003-09-12 22:52:22 +00:00
Guy Harris 3cbb7da413 From Kari Tiirikainen:
Updated the COPS dissector to print the names of the Prefix
	PRIDs correctly.  The last fix to PRID OID printout caused this
	minor problem for PPRIDs.

	Rename a few variables to make the code more logical to read.

svn path=/trunk/; revision=8464
2003-09-12 19:40:33 +00:00
Ronnie Sahlberg bec5704f64 Update to netlogon
make it decode DsrGetDCSiteCoverage replies properly

svn path=/trunk/; revision=8463
2003-09-12 11:13:17 +00:00
Ronnie Sahlberg 3afd5dfa7c upadtes to NETLOGON
svn path=/trunk/; revision=8462
2003-09-12 10:32:21 +00:00
Ronnie Sahlberg b48de22d5b Enhancement to the TCP dissector:
Track window scaling and display the window field after it has been scaled to its real value

If we have seen a SYN packet with a WindowScalingOption
then if the option to use RelativeSequence numbers has been enabled,
then ethereal will change the presented window field to be the window after it has been scaled to the real value.

This obviously only works if we have seen the SYN packet and if the SYN packet contained a window scaling option

svn path=/trunk/; revision=8461
2003-09-12 05:52:38 +00:00
Ronnie Sahlberg 1ce1722006 Attempt to prettify frame.time_relative
and some other fields

svn path=/trunk/; revision=8460
2003-09-12 04:52:55 +00:00
Ronnie Sahlberg 007d873671 Added TimeReference frames.
One can now select a packet and mark it as a TimeReference packet using the menu.
A TimeReference packet will be indicated by having all timestamp related column entries replaced by the string *REF*
A TimeReference packet will always be displayed in the packet pane, and overrides any display filters.

When a frame is a TimeReference frame, all later frames will calculate the TimeRelativeToFirstPacket  relative to the timestamp of the TimeReference frame instead of the first frame of the capture.

You can have any number of TimeReference frames you like.

svn path=/trunk/; revision=8459
2003-09-12 02:48:23 +00:00
Ronnie Sahlberg 9f5cabe151 From hans Viens:
T38 dissector

svn path=/trunk/; revision=8458
2003-09-11 13:37:35 +00:00
Ronnie Sahlberg e2311645e4 From Hans Viens :
T38 dissector

svn path=/trunk/; revision=8457
2003-09-11 13:36:04 +00:00
Ronnie Sahlberg a776f2d3d9 From Jean-Baptiste Marchand
update of the type of pointer used for DsrGetSiteName reply packets

svn path=/trunk/; revision=8456
2003-09-11 13:24:19 +00:00
Ronnie Sahlberg 9428cb362e Do not take the pointer to a stack object and pass it to the tap system.
The tap listener will try to parse this pointer at a much later stage where the stack frame where this object lived will have dissapeared and possible got overwritten.

best that can happen is that service response times for dcerpc interfaces is screwed up
more probable is that we get a coredump

svn path=/trunk/; revision=8455
2003-09-11 10:31:01 +00:00
Guy Harris 930e137aff From Anders Broman: add support for BICC dissection.
Change his e-mail address.

svn path=/trunk/; revision=8454
2003-09-11 00:08:14 +00:00
Guy Harris d09530d0cf Don't export MAX_VAR_LEN - nobody uses it.
svn path=/trunk/; revision=8453
2003-09-10 23:55:52 +00:00
Guy Harris 341e84d9ec Document the "Print only marked packets" option in the "Print" dialog,
and document that you can now search for packets with particular text in
the Info column or protocol tree.

svn path=/trunk/; revision=8452
2003-09-10 22:33:31 +00:00
Guy Harris 3e1a532413 When saving packets, we have a "Save only marked packets" option; label
the option to print only marked packets similarly, rather than as
"Suppress unmarked packets" (for consistency, and because the latter
isn't unlike a double negative).

svn path=/trunk/; revision=8451
2003-09-10 22:23:58 +00:00
Gerald Combs 7704cdd149 Make tvb_find_tvb() return -1 if either tvb length is 0. Otherwise, an
assertion happens 'xxxx contains ""'.

svn path=/trunk/; revision=8450
2003-09-10 21:19:47 +00:00
Guy Harris 4e21a36656 Don't use "alloca()", and don't use "match_strval()", just use
"val_to_str()".

svn path=/trunk/; revision=8449
2003-09-10 20:07:10 +00:00
Guy Harris d4954b6700 Use the *correct* value_string for the IE Type field.
svn path=/trunk/; revision=8448
2003-09-10 19:27:14 +00:00
Guy Harris 52ecb8b688 From Albert Chin: fix yet another C++-comment problem.
svn path=/trunk/; revision=8447
2003-09-10 19:23:29 +00:00
Ronnie Sahlberg 700251d16d NETLOGON/DsrDeregisterDNSHostRecords :
The dns_host field is a REF pointer to a unicode string.
NOT a Unique pointer.

Update iethereal so that this packet is dissected properly

svn path=/trunk/; revision=8446
2003-09-10 09:49:31 +00:00
Jörg Mayer e020bc8964 Albert Chin:
- AM_PROC_LIBTOOL is just an alias for AC_PROG_LIBTOOL, which is
	  called earlier.
	- Use AM_CPPFLAGS instead of CFLAGS and CPPFLAGS to add inlude
	  directories

svn path=/trunk/; revision=8445
2003-09-10 07:17:21 +00:00
Guy Harris ce166e6dfb If there's no saved interface name, set the interface name in the
Capture Options dialog box to the first string in the combo box, not to
the first interface name in the list, so we get the description.

svn path=/trunk/; revision=8444
2003-09-10 07:02:25 +00:00
Guy Harris 29ea42f868 If we have no interfaces, don't set the popdown list for interface combo
boxes.

svn path=/trunk/; revision=8443
2003-09-10 06:55:28 +00:00
Guy Harris 0de9c67adf Void functions don't return values.
svn path=/trunk/; revision=8442
2003-09-10 06:48:55 +00:00
Guy Harris b657bea870 Fix a compile error on Windows.
svn path=/trunk/; revision=8441
2003-09-10 06:47:04 +00:00
Guy Harris 27ea7816ee Have "get_interface_list()" return a list of "if_info_t" structures
containing a pointer to an interface name and possibly a pointer to an
interface description (although that pointer might be null if no
description is available), rather than having the Windows version glue
together the name and description into a single string.

Supply for the Linux "any" device the same description that libpcap's
"pcap_findalldevs()" returns.

svn path=/trunk/; revision=8440
2003-09-10 05:35:26 +00:00
Gerald Combs df25d41673 Final(?) changes for the 0.9.15 release.
svn path=/trunk/; revision=8438
2003-09-09 23:17:08 +00:00
Guy Harris 95f648cd9e Use the right value_string table for the filter mode in
CMD_CARD_SET_FILTER_MODE and CMD_CARD_GET_FILTER_MODE.

svn path=/trunk/; revision=8437
2003-09-09 19:22:05 +00:00
Guy Harris 6dbd4842fa Fix the URL for the DOCSIS specifications.
svn path=/trunk/; revision=8436
2003-09-09 19:14:29 +00:00
Guy Harris 935a07c593 From Nathan Jennings: fix a problem with empty descriptions.
svn path=/trunk/; revision=8435
2003-09-09 18:27:49 +00:00
Guy Harris 92fbca527d Add "dissector_get_string_handle()" for string dissector tables, similar
to "dissector_get_port_handle()" for uint dissector tables.

svn path=/trunk/; revision=8434
2003-09-09 18:09:42 +00:00
Ronnie Sahlberg 24bf25d652 For iSCSI
During the Login phase, if the T bit is not set, then the iniator/targets are not ready to transition to the next stage.
Thus the NSG bits are undefined.

Change the dissector to only dissect the NSG bits iff the T bit is set in the Login pdu.

svn path=/trunk/; revision=8433
2003-09-09 09:54:13 +00:00
Ronnie Sahlberg e759fbd9d4 NFSv3 Read Reply and Write Calls are often short pdus.
Change the dissector for these calls to prettify the COL_INFO and the tree item
before dissecting the data block.

Previously the dissector would bail out during the short data block anbd thus not do the COL_INFO/item prettification.

Bug is not fixed

svn path=/trunk/; revision=8432
2003-09-09 09:49:01 +00:00
Guy Harris 5f7d204bd3 If the uppermost bit of the first length octet is set, it means that the
length is in the lower 7 bits of that octet, not that there's another
octet of length.

svn path=/trunk/; revision=8431
2003-09-09 09:20:07 +00:00
Guy Harris 8b5b480bf6 Display the odd/even indicator in an IMSI.
Display the identity as a separate item.

Clean up white space.

svn path=/trunk/; revision=8430
2003-09-09 09:14:55 +00:00
Guy Harris 4605a6b5b3 Don't use "match_strval()" unless you know the value is going to match
or you are prepared to handle a null pointer return value; use
"val_to_str()" if you want an "Unknown (XXX)" string if the value is
unknown.

svn path=/trunk/; revision=8429
2003-09-09 08:53:48 +00:00
Guy Harris f7b8844b7f Process TLVs as such.
svn path=/trunk/; revision=8428
2003-09-09 07:51:37 +00:00
Guy Harris 950e97c6d4 The PDU length is the length field minus the length of the EHDR *minus
the length of the HCS*.

svn path=/trunk/; revision=8427
2003-09-09 07:18:11 +00:00
Guy Harris c7d03ae2da Fix the URL for the DOCSIS 1.1 Baseline Privacy Plus Interface
Specification.

Show the crypto suite attribute symbolically.

Get rid of unused value_string tables.

svn path=/trunk/; revision=8426
2003-09-09 07:17:00 +00:00
Guy Harris 5ac2c46899 Put each TLV in a tree of its own, and put the TLV type and length
fields into that tree.

svn path=/trunk/; revision=8425
2003-09-09 06:59:35 +00:00
Guy Harris 56a85341f0 Update the URL for the DOCSIS 1.1 specifications.
Use Booleans, not uint8's, for single-bit Boolean flags.

svn path=/trunk/; revision=8424
2003-09-09 05:49:15 +00:00
Guy Harris 3fbf8da883 Get rid of "fsf_conn_flag_vals[]" - the connection usage flags are bit
flags, not part of a field where each value means something special.

Put in ID names for some current FCIP drafts.

Note fields that should arguably show their individual bits.

svn path=/trunk/; revision=8423
2003-09-09 05:02:35 +00:00
Guy Harris ba400ac5fe From Nathan Jennings: give the "Edit..." window for the capture options
dialog the right icon, and make ESC cancel it.

svn path=/trunk/; revision=8422
2003-09-09 04:44:57 +00:00
Gerald Combs 97966554f9 More updates for 0.9.15. Target release is tomorrow (Sep 9).
svn path=/trunk/; revision=8421
2003-09-09 03:34:26 +00:00
Gerald Combs 4c19deb206 In the Find dialog add periods or dashes to the list of allowed hex
separator characters.  Update the Ethereal man page accordingly.

svn path=/trunk/; revision=8420
2003-09-09 02:41:00 +00:00
Guy Harris 81fc518ec6 From Nathan Jennings:
support for user-supplied interface descriptions;

	support for hiding interfaces in drop-down list in capture
	dialog.

Clean up comments written to preferences file.

svn path=/trunk/; revision=8419
2003-09-08 21:44:42 +00:00
Ronnie Sahlberg 3185b945fb Update to the culmulative byte column.
Only calculate culmulative bytes on those packets that are actually displayed in the packet pane.

When a display filter is applied, culmulative bytes should only be calculated on thoise packets that are actually displayed.

svn path=/trunk/; revision=8418
2003-09-08 21:08:43 +00:00