Commit Graph

13946 Commits

Author SHA1 Message Date
Gerald Combs 78a09d190b Fix another invalid item length. Fixes bug 98.
svn path=/trunk/; revision=14184
2005-04-25 15:28:32 +00:00
Gerald Combs a9e9262981 Don't try to tell proto_tree_add_item() that FT_UINT32s are something other
than 4 bytes.  It throws a fit when you do that.  Fixes bug 97.

svn path=/trunk/; revision=14183
2005-04-25 15:21:37 +00:00
Gerald Combs 87772809f4 Fix an infinite loop.
svn path=/trunk/; revision=14182
2005-04-25 03:02:50 +00:00
Lars Roland f78d66b0d7 From Martin Mathieson:
a first step of cleaning up the mgcp dissector:

- re-indenting/formatting the file as it was tricky to follow
- some code simplification and commenting (more to do)
- losing some unnecessary includes (not needed under linux at least...)
- show duplicate request and response fields in tree (previously hidden)
- improved duplicate response detection
- fix a couple of problems shown by fuzz testing

svn path=/trunk/; revision=14181
2005-04-25 00:51:11 +00:00
Lars Roland 118ce715a7 From Alejandro Vaquero:
improve dissection of Dynamic payload 
types used in conversations and the
codec list summary in the "Voip Calls Graph".

svn path=/trunk/; revision=14180
2005-04-24 18:43:42 +00:00
Lars Roland ca97aa1849 From Martin Mathieson:
Fix dissection of the SIP Method in the CSeq header.

svn path=/trunk/; revision=14179
2005-04-24 17:59:18 +00:00
Gerald Combs af4696c98d Fix an infinite loop.
svn path=/trunk/; revision=14178
2005-04-24 01:15:53 +00:00
Gerald Combs 103103e21c Fix a quoting bug.
svn path=/trunk/; revision=14177
2005-04-24 00:37:08 +00:00
Gerald Combs 522e204d87 Don't try to free the same memory twice.
svn path=/trunk/; revision=14176
2005-04-24 00:36:11 +00:00
Gerald Combs 640a1fcd53 Force a bunch of protocol items to be the proper length.
svn path=/trunk/; revision=14175
2005-04-23 22:13:00 +00:00
Gerald Combs a6cf86ce37 Add a few tvb_ensure_bytes_exist() calls.
svn path=/trunk/; revision=14174
2005-04-23 21:33:44 +00:00
Gerald Combs 46ebfe16b0 Don't try to free NULL. Don't overflow a buffer.
svn path=/trunk/; revision=14173
2005-04-23 21:31:25 +00:00
Gerald Combs cf23c92003 Make sure we don't exhaust system memory.
svn path=/trunk/; revision=14172
2005-04-23 20:54:59 +00:00
Gerald Combs 50d0f95328 Add more tvb_ensure_bytes_exist() calls.
svn path=/trunk/; revision=14171
2005-04-23 13:24:57 +00:00
Gerald Combs 028075b673 Add a couple of tvb_ensure_bytes_exist() calls to avoid dissector bug
exceptions.

svn path=/trunk/; revision=14170
2005-04-23 04:06:45 +00:00
Gerald Combs 082651c83e Define a maximum OID string length, and use it in a lot of places. Fixes a
buffer overflow found while fuzz testing.

svn path=/trunk/; revision=14169
2005-04-22 21:17:13 +00:00
Gerald Combs e8730eab95 Fix for the previous fix.
svn path=/trunk/; revision=14168
2005-04-22 18:06:39 +00:00
Gerald Combs 3ed50e1ae7 Don't pass a null format string to val_to_str().
svn path=/trunk/; revision=14167
2005-04-22 15:18:56 +00:00
Gerald Combs 42f80d7478 Don't pass a null format string to val_to_str().
svn path=/trunk/; revision=14166
2005-04-22 15:00:45 +00:00
Gerald Combs f2695565b4 Fix an infinite loop in dissect_rsvp_gen_uni(). Fixes bug 90. Fix up a
previous infinite loop fix.

svn path=/trunk/; revision=14165
2005-04-22 14:55:27 +00:00
Ronnie Sahlberg bf70d24df3 prettify portmapper GETPORT requests and responses
svn path=/trunk/; revision=14164
2005-04-22 05:00:02 +00:00
Gerald Combs f0795da8d6 Add some tvb_ensure_bytes_exist() calls.
svn path=/trunk/; revision=14163
2005-04-22 04:26:23 +00:00
Gerald Combs 8d914c66fd Squelch a valgrind warning.
svn path=/trunk/; revision=14162
2005-04-22 04:10:44 +00:00
Gerald Combs 1906593816 Fix a buffer overflow in isis_dissect_nlpid_clv().
svn path=/trunk/; revision=14161
2005-04-22 04:07:56 +00:00
Ronnie Sahlberg b95490206d from Olivier J
bugfix for IMPLICIT NULL in BER sequences
and gsmmap updates



svn path=/trunk/; revision=14160
2005-04-21 21:37:23 +00:00
Gerald Combs dfc96b3d23 In get_string(), throw an exception if the string is too long to
process.  Hopefully this doesn't break anything.  Add a bunch of
tvb_ensure_bytes_exist() calls.  Fixes bugs 48 - 51.

svn path=/trunk/; revision=14159
2005-04-21 18:19:38 +00:00
Gerald Combs f907a1085b Add a tvb_ensure_bytes_exist(). Fixes bug 68 and its many duplicates.
svn path=/trunk/; revision=14158
2005-04-21 15:11:38 +00:00
Guy Harris 09ed220e28 Add a comment asking about the address and mask length fields in
join/prune requests.

svn path=/trunk/; revision=14157
2005-04-20 21:55:14 +00:00
Gerald Combs ec5ec3768e Allow the locations of tethereal, editcap, and capinfos to be changed.
Limit the amount of VM the process can use (default 500 MB).  If we
can't save a capture in libpcap format, try again with the encapsulation
type set to "ether".

svn path=/trunk/; revision=14156
2005-04-20 21:00:03 +00:00
Gilbert Ramirez 5176d29243 Avoid a buffer overflow in the cseq_method field, a fixed-length character array.
svn path=/trunk/; revision=14155
2005-04-20 20:23:07 +00:00
Gerald Combs adcd4554df From Dinesh Dutt: Improve reassembly checking. Replace a match_strval()
with a val_to_str().

svn path=/trunk/; revision=14154
2005-04-20 20:07:17 +00:00
Gerald Combs 190057e036 Fix an infinite loop discovered during fuzz-testing.
svn path=/trunk/; revision=14153
2005-04-20 19:52:23 +00:00
Gerald Combs 5ff26fa19e Remove leftover debugging code.
svn path=/trunk/; revision=14152
2005-04-20 19:50:11 +00:00
Gerald Combs c5f8de0fbd Fix an infinite loop. Fixes bug 80.
svn path=/trunk/; revision=14151
2005-04-20 19:33:03 +00:00
Gerald Combs 94c071b115 Use proto_tree_add_time() for hf_srvloc_authblkv2_timestamp. Fixes bug 81.
svn path=/trunk/; revision=14150
2005-04-20 19:16:02 +00:00
Gerald Combs 1111832d96 In all functions that require smb_info data, throw an exception if we
can't fetch it.  Fix a few more null pointer dereferences.  Fixes bug 79.

svn path=/trunk/; revision=14149
2005-04-20 16:23:22 +00:00
Gerald Combs a0e1ac489c Add a newline to the end of the file.
svn path=/trunk/; revision=14148
2005-04-20 14:37:53 +00:00
Tomas Kukosa 2d40f0464b - fix handling SET/SEQUENCE OF Type if type name contains hyphen
- raise warning if type is not renamed to name with the first letter uppercase
- raise warning if field is not renamed to name with the first letter lowercase

svn path=/trunk/; revision=14147
2005-04-20 12:39:34 +00:00
Ronnie Sahlberg 6658493b2f increase the length of the field field from 30 to 50 characters so that hopefully all long named fields can fit in the textbox for iorapgs/advanced
svn path=/trunk/; revision=14146
2005-04-20 08:58:49 +00:00
Ronnie Sahlberg 20a4d3257e Add a tree parameter to get_ber_length() so that
IF the length seems bogus, like longer than the reported tvb_length
we add a helpful text item to the tree  and generate a [malformed packet]


change all callers of get_ber_length to the new signature.



svn path=/trunk/; revision=14145
2005-04-20 08:35:47 +00:00
Ulf Lamping 5115a265a9 fix some minor bugs with the current interface name:
-always show descriptive string in combo box
-correct the initialization, so cancelling the option dialog won't make trouble

svn path=/trunk/; revision=14144
2005-04-19 22:32:52 +00:00
Gilbert Ramirez 6b90d6085e Allow automake and aclocal to share a common version number suffix, since
they come from the same package.

svn path=/trunk/; revision=14143
2005-04-19 22:27:05 +00:00
Ulf Lamping 9b5d52aab6 ask for unsaved file when using the new start capture feature,
ask for unsaved file when really starting the capture, not already when showing the options dialog,
use the start capture icon in the capture options dialog (instead of simply Ok)

svn path=/trunk/; revision=14142
2005-04-19 21:02:01 +00:00
Gerald Combs 2078bfc8b4 Fix a pile of format string bugs.
svn path=/trunk/; revision=14141
2005-04-19 20:59:41 +00:00
Ulf Lamping d22ba722a4 bugfix: don't crash if we have no interface name
svn path=/trunk/; revision=14140
2005-04-19 20:55:27 +00:00
Gerald Combs a78465a839 From Peter Johansson:
My patch changes the decoding of the Destination address to conform with the
spec found at http://www.cisco.com/univercd/cc/td/doc/product/lan/trsrb/frames.htm#xtocid75
and adds decoding of user field values 4-7 while updating the description of
user field values 0-3 according to IEEE 802.1D-2004, annex G.


svn path=/trunk/; revision=14139
2005-04-19 20:53:42 +00:00
Ulf Lamping 38b423ec6b fix labels of the two toggle toolbar buttons
svn path=/trunk/; revision=14138
2005-04-19 20:53:22 +00:00
Ulf Lamping 40222850f8 add keyboard expand/collapse in the tree view (with Left/Right keys) with GTK2
svn path=/trunk/; revision=14137
2005-04-19 20:46:35 +00:00
Gerald Combs 64cafdda21 From Peter Johansson: Fix a segmentation fault in the reassembly code.
Fix up the formatting a bit.

svn path=/trunk/; revision=14136
2005-04-19 14:17:22 +00:00
Ronnie Sahlberg 4656201984 From Jon R
Update to README.developer for the conversation changes


svn path=/trunk/; revision=14135
2005-04-19 12:05:50 +00:00