Commit Graph

21229 Commits

Author SHA1 Message Date
Luis Ontanon bb7e52fcd8 will this finally get rid of the warnigs?
svn path=/trunk/; revision=21666
2007-05-03 18:32:52 +00:00
Gerald Combs c1688f5612 Check for an infinite loop while processing cipher suites. Fixes bug 1582.
Add release notes for the SSL and display filter macro bugs.

svn path=/trunk/; revision=21665
2007-05-03 16:59:13 +00:00
Gerald Combs 5713fbc9b9 Handle cases where our macro doesn't have any arguments. We should
probably provide feedback to the user, but at least we don't crash now.
Fixes Coverity CID 232.

svn path=/trunk/; revision=21664
2007-05-03 16:11:18 +00:00
Tomas Kukosa 3ecac7ddd1 - REAL type and values are supported
- if a value of some INTEGER type is defined then it is assigned to this type like a named value
i.e.
MyType ::= INTEGER
mv01 MyType ::= 1
is equal to
MyType ::= INTEGER { mv01 (1) }

svn path=/trunk/; revision=21663
2007-05-03 11:42:33 +00:00
Tomas Kukosa a70a1b3eb6 EXTERNAL type is handled in asn2wrs now
private implementations were renamed EXTERNAL -> EXTERNALt

svn path=/trunk/; revision=21662
2007-05-03 11:37:47 +00:00
Tomas Kukosa a2e548266d comment out parameters of parametrized type
svn path=/trunk/; revision=21661
2007-05-03 10:49:49 +00:00
Tomas Kukosa 558221f7b8 uppercase identifiers are not allowed
svn path=/trunk/; revision=21660
2007-05-03 09:59:09 +00:00
Tomas Kukosa e09ee99714 uppercase identifiers are not allowed
svn path=/trunk/; revision=21659
2007-05-03 09:51:49 +00:00
Tomas Kukosa 6e491e8c3b REAL type support
svn path=/trunk/; revision=21658
2007-05-03 09:15:04 +00:00
Gerald Combs 696af3f35e Fix a couple of typos and fixup whitespace.
svn path=/trunk/; revision=21657
2007-05-03 00:21:22 +00:00
Luis Ontanon 51a7fa1404 The forgotten file strikes back.
... It also fixes a lua compile warning/error in wslua_gui.c. ...


svn path=/trunk/; revision=21656
2007-05-02 23:54:01 +00:00
Luis Ontanon 8a293db121 From Tamas Regos (Via Balint Reczey)
The attached patch adds ability of of creating radio button, drop-down
list and range type preference entries to the Lua plugin.
It also fixes a lua compile warning/error in wslua_gui.c.
The patch is written by Tamas Regos, he asked me to send it to the list.

svn path=/trunk/; revision=21655
2007-05-02 23:39:44 +00:00
Gerald Combs bb76982d2c Add a routine to dissect the MCS Set. Add a tree for the MCS Set
Rx Bitmask.  "Steams" -> "Scheme".

svn path=/trunk/; revision=21654
2007-05-02 23:26:33 +00:00
Luis Ontanon 13b1ebe574 fix warnings
svn path=/trunk/; revision=21653
2007-05-02 21:58:52 +00:00
Luis Ontanon 49e49452dd fix warnings in debug code
svn path=/trunk/; revision=21652
2007-05-02 20:37:25 +00:00
Luis Ontanon d4fd968d50 add support for the text export format of textronix k1[25]
svn path=/trunk/; revision=21651
2007-05-02 20:09:42 +00:00
Guy Harris cbea9dd75b Check for read failures, and report them (and don't parse the key list
if we get one).

svn path=/trunk/; revision=21650
2007-05-02 19:46:05 +00:00
Guy Harris 2cbb8e33e2 Immediately quit routines if fwrite() fails - further writes will
probably fail (as you're probably out of disk space or over quota), and,
even if they don't, the file's going to be corrupt in any case.

(Hopefully that's sufficient to avoid warnings that we're ignoring the
result of fwrite().)

For fread(), check for errors or short reads, at least in all cases
where we have a provision for failing if the read fails.

svn path=/trunk/; revision=21649
2007-05-02 19:28:24 +00:00
Jaap Keuter e51904c765 Fix the windows build by changing uint32_t into guint32.
svn path=/trunk/; revision=21648
2007-05-02 18:42:53 +00:00
Jaap Keuter 5834873aa7 From Matt Addison:
Problem:
The existing sll dissector does not handle ppp_hdlc packets (sll.ltype == 0x0007).
Resolution:
Alter packet-sll.c to call the ppp_hdlc dissector when a packet with sll.ltype=0x0007 is received.

svn path=/trunk/; revision=21647
2007-05-02 18:42:02 +00:00
Ronnie Sahlberg 46602a91ae updates to the ctdb dissector to follow the latest protocol
svn path=/trunk/; revision=21646
2007-05-02 13:32:07 +00:00
Tomas Kukosa cd06093bcc fix forgotten calling of dissect_per_External()
svn path=/trunk/; revision=21645
2007-05-02 12:48:22 +00:00
Ronnie Sahlberg 9efe581adc comment out a unused function so that wireshark builds on suse again
svn path=/trunk/; revision=21644
2007-05-02 12:34:28 +00:00
Ronnie Sahlberg 3abb8dd622 fix some compiler warnings leading to compile failure
svn path=/trunk/; revision=21643
2007-05-02 12:26:26 +00:00
Tomas Kukosa 6f80d9228f - better reporting of syntax errors (or unsupported syntax) in ASN.1 source
- support of EXTERNAL type
- support of ObjectDescriptor for PER
- new #.CLASS directive for supporting some class workarounds

svn path=/trunk/; revision=21642
2007-05-02 12:18:27 +00:00
Ronnie Sahlberg 8d27a59817 some more : try to make read/write not break the build if the return value is not used
svn path=/trunk/; revision=21641
2007-05-02 12:17:01 +00:00
Tomas Kukosa b112f7cd40 PER - support of EXTERNAL and ObjectDescriptor types (not tested)
svn path=/trunk/; revision=21640
2007-05-02 12:13:29 +00:00
Ronnie Sahlberg 6c3ca6fb55 do something with the return value from eth_write (which is a define for fwrite)so that -Werror does not cause the build to fail
-This line, and those below, will be ignored--

M    gtk/rtp_analysis.c

svn path=/trunk/; revision=21639
2007-05-02 12:07:46 +00:00
Ronnie Sahlberg 2fadd01c25 fix some more warnings that the result from fread/fwrite is discarded by assigning the return value to a variable
svn path=/trunk/; revision=21638
2007-05-02 11:50:54 +00:00
Ronnie Sahlberg f2d36b3349 store the result of fread in a variable to make -Werror happy
svn path=/trunk/; revision=21637
2007-05-02 08:50:16 +00:00
Jaap Keuter a25bb5b393 From Stefan Puiu:
A DHCP Discover option 90 has no Secret ID nor HMAC MD5 Hash.

svn path=/trunk/; revision=21636
2007-05-02 06:17:19 +00:00
Anders Broman 1cf1f16391 Split out common asn1 stuff to asn1.h and include that where needed.
svn path=/trunk/; revision=21635
2007-05-01 22:05:11 +00:00
Gerald Combs 8a2810c15a From Dustin Johnson: Normalize indentation.
svn path=/trunk/; revision=21634
2007-05-01 16:55:15 +00:00
Martin Mathieson a6b92e3e39 Make these protocols findable by name.
svn path=/trunk/; revision=21633
2007-05-01 09:45:34 +00:00
Gerald Combs 45ae5ef0c7 Fetch IP and TCP length values directly instead of casting the data buffer
to struct pointers (which causes compiler errors on the Solaris builder).

svn path=/trunk/; revision=21632
2007-05-01 04:58:12 +00:00
Guy Harris 0bbac7a3e2 Parenthesize to squelch a compiler warning (a warning that suggests that
the parentheses are needed - not that I can remember which of && and ||
have higher precedence, anyway, which is why I like parenthesizing
expressions such as this...).

svn path=/trunk/; revision=21631
2007-05-01 01:56:58 +00:00
Gerald Combs 78b475fc0c From Dustin Johnson and myself:
- HT Control fixes and updates
  - Add an is_ht flag to the common dissection and capture routines, along
    with a registered dissector (which is used in code that hasn't been
    checked in yet.)
  - Action Fixed Parameter updates
  - Control Wrapper fixes and updates
  - Beacon Interval fixes and updates
  - Capability Info fixes and updates
  - Block Ack / Block Ack Request fixes
  - Lots of miscellaneous fixes and updates

svn path=/trunk/; revision=21630
2007-04-30 23:50:35 +00:00
Guy Harris 5b5a0ced85 Use memcpy() to copy the session ID to the buffer, so we don't get
warnings from the compiler about pointer value alignment.

svn path=/trunk/; revision=21629
2007-04-30 21:22:15 +00:00
Guy Harris 3f6b914175 Update copyright notice.
svn path=/trunk/; revision=21628
2007-04-30 19:25:18 +00:00
Guy Harris 1d73cea470 Add a header that redefines g_array_index() to throw in a "void *" cast
to work around the "data" field of a GArray being a guint8 *, and
defines a g_array_data() macro to extract that field and cast it to void
*.

Use that header where needed.

svn path=/trunk/; revision=21627
2007-04-30 19:24:25 +00:00
Guy Harris db53f99cca Yet another workaround for GArray's bad data type choice.
svn path=/trunk/; revision=21626
2007-04-30 16:54:29 +00:00
Guy Harris 358b838924 Fix up the asn/q932 Makefile as per Tomas Kukosa's suggestion - and make
it a lot more like the Makefile.nmake file.  Also, use $(PROTOCOL_NAME)
in a couple of places in Makefile.nmake where it wasn't being used
before.

(It might be interesting to see whether we can use a template for these
Makefiles, and just tweak some variables at the beginning.)

That lets us get a Q.932 ROS dissector with the right file name and with
"q932.ros" rather than "q932-ros" as the dissector name; do that.

svn path=/trunk/; revision=21625
2007-04-30 08:55:59 +00:00
Tomas Kukosa 8640032603 newline at end of file is required by some compilers
svn path=/trunk/; revision=21624
2007-04-30 08:38:59 +00:00
Guy Harris 3485b6810a Thou shalt not squelch compiler complaints about an assignment
discarding a qualifier by explicitly casting away the qualifier;
constness should persist, so that attempts to, for example, modify
something you got with tvb_get_ptr() get complained about (as we don't,
and won't, guarantee that you will get correct behavior if you do that).
Just make the pointer to which a const pointer is being assigned const
itself.

Yet *AGAIN* work around GArray's brokenness of having its data pointer
be a guint8 * rather than a void *.

svn path=/trunk/; revision=21623
2007-04-30 08:33:44 +00:00
Guy Harris 2f88e4ca81 The Q.932 dissector doesn't need to include <string.h>; the Q.932 ROS
dissector does.

The fix to the Makefile to generate packet-q932-ros.c changed the
protocol name in some cases; change it uniformly.

svn path=/trunk/; revision=21622
2007-04-30 06:41:53 +00:00
Tomas Kukosa 3dd386cc35 move T.30 protocol into its own dissector file
svn path=/trunk/; revision=21621
2007-04-30 06:40:07 +00:00
Guy Harris d77bc4e02e Put the q932-ros dissector into a file with the right name.
svn path=/trunk/; revision=21620
2007-04-30 06:24:27 +00:00
Guy Harris 3a0381579e Don't cast a "guint8 *" to a pointer to a structure; just use the
pointer to the guint8, plus explicitly defined structure offsets (the
structure had better be the same on all platforms, forever, otherwise
binary compatibility breaks, which would be an error, given that the
structure appears in capture files).

svn path=/trunk/; revision=21619
2007-04-30 06:19:35 +00:00
Stephen Fisher c38acbae0e From Sake Blok:
While looking into the http-dissector I improved a few things on
how it dissects a proxy CONNECT session. This is what I have changed:

- added the fields hf_http_proxy_connect_host and -port

- changed proto_tree_add_text to proto_tree_add_string and -uint
  so that it's possible to filter on them

- make these two fields "PROTO_ITEM_SET_GENERATED"

- removed the alteration of the ports within pinfo, now the
  ports in the column info are not changed to the port used to
  connect to the backend server. It is now possible to use
  follow-tcp-stream again on proxied ssl sessions.


svn path=/trunk/; revision=21618
2007-04-28 23:52:12 +00:00
Guy Harris 9772732adc The data in a GArray is guaranteed to be properly aligned; add a cast to
squelch compiler warnings.

svn path=/trunk/; revision=21617
2007-04-28 22:31:04 +00:00