Commit graph

6848 commits

Author SHA1 Message Date
Guy Harris
ff195c6868 For 1-byte and 2-byte FIDs, convert the void * data pointer in the
address to a guint8 *, to get at the bytes.

svn path=/trunk/; revision=21583
2007-04-26 03:08:23 +00:00
Guy Harris
febd662cf3 Get rid of unused variable.
svn path=/trunk/; revision=21582
2007-04-26 02:36:24 +00:00
Guy Harris
abc66d168a Use the right local variable.
svn path=/trunk/; revision=21581
2007-04-26 02:35:36 +00:00
Guy Harris
d78cbd4b00 Get rid of no-longer-needed variable.
svn path=/trunk/; revision=21580
2007-04-26 01:35:26 +00:00
Guy Harris
7537b3afa3 Add missing backslash.
svn path=/trunk/; revision=21579
2007-04-26 01:11:24 +00:00
Guy Harris
bba0b00392 Rename HASH_ADDRESS to ADD_ADDRESS_TO_HASH, to make it clearer what it
does (i.e., it will add the address bytes to the value that's already
there - it will not initialize the value, so you have to clear it before
doing any hashing).

svn path=/trunk/; revision=21578
2007-04-26 01:01:27 +00:00
Guy Harris
1ed26d317c Add a macro for hashing the bytes of an address into a hash value.
Use it in the IAX2 dissector and in the conversation code.

svn path=/trunk/; revision=21577
2007-04-26 00:51:33 +00:00
Guy Harris
41cafa2212 The data pointer of an address structure is a void *; convert it to a
guint8 * in order to look at the raw bytes of the address.

svn path=/trunk/; revision=21576
2007-04-26 00:03:41 +00:00
Guy Harris
2a48544203 Check to make sure the address really *is* an IPv4 address.
If it is, convert the "void *" data pointer to a "guint8 *", so we can
look at the first byte.

svn path=/trunk/; revision=21575
2007-04-26 00:01:29 +00:00
Guy Harris
e077465aa4 The data pointer in an address structure is a void *; if the address is
a MAC address, convert it to a guint8 * in order to look at the bytes of
the address.

svn path=/trunk/; revision=21574
2007-04-25 23:58:43 +00:00
Guy Harris
ef5b370850 Use "address_to_str()" to format an address, rather than assuming it's
an IPv4 address.

svn path=/trunk/; revision=21573
2007-04-25 23:56:46 +00:00
Guy Harris
9439c19e31 The data field of an address structure is a void *, so we can't look at
what it points to.  Stop doing that in the code to check for source
routing.

svn path=/trunk/; revision=21572
2007-04-25 23:54:54 +00:00
Guy Harris
17b1c57ec9 Fix the previous fix.
svn path=/trunk/; revision=21571
2007-04-25 23:31:22 +00:00
Guy Harris
f5bd20cacf Check that the addresses are FC addresses before looking at them.
If the address is an FC address, convert the data pointer to a guint8 *,
as it's a void *.

svn path=/trunk/; revision=21570
2007-04-25 23:11:22 +00:00
Guy Harris
20611f65e4 Fail if the addresses being checked aren't Ethernet addresses.
svn path=/trunk/; revision=21569
2007-04-25 23:09:58 +00:00
Guy Harris
e7fc05410d Use "address_to_str()" to format an address, rather than assuming it's
an IPv4 address.

svn path=/trunk/; revision=21568
2007-04-25 22:33:47 +00:00
Guy Harris
e26198a1f7 The data field of an address structure is now a void *; convert it as
appropriate.

Also, throw in a check for the types of the addresses.

svn path=/trunk/; revision=21567
2007-04-25 22:04:46 +00:00
Guy Harris
2361eb46de The data field of an address structure is now a void *; convert it as
appropriate.

svn path=/trunk/; revision=21566
2007-04-25 21:37:15 +00:00
Guy Harris
7acd23c938 The "data" field of an address structure is a "void *"; when looking at
a MAC address, convert it to a "guint8 *".

svn path=/trunk/; revision=21565
2007-04-25 20:14:41 +00:00
Gerald Combs
99c0698b95 From Dustin Johnson:
- A-MSDU updates
  - Secondary Channel Offset tag updates
  - A-MPDU parameter updates
  - Lots of string fixes updates
  
Fixup whitespace.

svn path=/trunk/; revision=21564
2007-04-25 19:38:47 +00:00
Guy Harris
c3ac6f1e71 Some types of addresses are data structures; make the address data
pointer in an address structure a "void *", to indicate that it can
point to some arbitrary type of object, rather than a "guint8 *", which
indicates that it points to an array of bytes.

For any address type where the address is a structure, this removes some
alignment warnings; the author of the code to handle a particular
address type has the responsibility of making sure you don't set up the
address structure with misaligned data.  (Yes, it matters, at least on
SPARC.)

svn path=/trunk/; revision=21563
2007-04-25 19:28:56 +00:00
Gerald Combs
cde0384abc From Stig Bjørlykke:
Fix break placement for control frames in dissect_ieee80211_common()

svn path=/trunk/; revision=21562
2007-04-25 17:39:38 +00:00
Tomas Kukosa
dfcfaeeaa9 fread() return value can not match file size on Windows due CR/LF conversion - do not check it
svn path=/trunk/; revision=21560
2007-04-25 10:16:33 +00:00
Jörg Mayer
70f0c88ea1 proto_tree_add_bits -> iuup_proto_tree_add_bits as discussed
on wireshark-dev to make it compile again

svn path=/trunk/; revision=21558
2007-04-24 21:26:40 +00:00
Luis Ontanon
55507800aa extraInfo was not propperly tagged causing ber decoding errors.
Fixes Bug 1554


svn path=/trunk/; revision=21557
2007-04-24 19:28:12 +00:00
Anders Broman
fea883ebec Add a new proto function proto_tree_add_bits() which adds bits to the tree
starting at the bit offset given for the number of bits indicated which wll also return
the value of the bits.
Experimental and for review, documentation to be updated.

svn path=/trunk/; revision=21556
2007-04-24 19:24:14 +00:00
Guy Harris
8ff20a50ce Fix definition of tvb_memcpy() to match declaration.
svn path=/trunk/; revision=21555
2007-04-24 17:12:29 +00:00
Guy Harris
6f8cee8acd "memcpy()" takes void *'s as arguments and returns a void *; have
tvb_memcpy() be similar, to avoid unnecessarily alignment warnings.

Do the same with "ep_tvb_memdup()".

svn path=/trunk/; revision=21554
2007-04-24 11:54:18 +00:00
Guy Harris
0be322bad8 Try to squelch an alignment warning (we put "int"s into the array, so we
know the pointer's aligned appropriately for an array of "int"s).

svn path=/trunk/; revision=21552
2007-04-24 06:43:01 +00:00
Ronnie Sahlberg
3a0cdfb42b add a missing change from the previous commit
svn path=/trunk/; revision=21548
2007-04-24 05:09:53 +00:00
Ronnie Sahlberg
1f80370b85 Add tracking of uid->domain/account mappings for SMB by tapping the ntlmssp tap for the information from the authentication messages
Improve the tid tracking by putting the host/share information on the tid expansion line so one can see it without opening the expansion


svn path=/trunk/; revision=21547
2007-04-24 05:09:00 +00:00
Bill Meier
6386eda24c Addt'l fixes so suite-unittests will run under windows
svn path=/trunk/; revision=21546
2007-04-24 03:43:08 +00:00
Guy Harris
1b2cecda53 Need to include <epan/pint.h> to get pletohl() defined.
svn path=/trunk/; revision=21544
2007-04-23 22:34:31 +00:00
Anders Broman
c0dc340d5d From Florent DROUIN:
I have made some changes to the final patch to have the operation code decoded
as ForwardSM. A change for TCAP is included too, to be sure that the
application context is not overwritten by the User Info OID (this was the case,
when a MAP open dialog was included in the request).
Fix bug:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1498

svn path=/trunk/; revision=21543
2007-04-23 21:26:27 +00:00
Guy Harris
d6fc852779 byteReverse assumes its argument is aligned on a 32-bit boundary; make
it a pointer to a guint32.  Also, use pletohl() to fetch a 32-bit
little-endian quantity.

svn path=/trunk/; revision=21542
2007-04-23 21:23:30 +00:00
Guy Harris
5a4771d9cb The "in" array in an MD5 context is expected to be aligned on a 4-byte
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary
casts.

(Missed on the previous checkin.)

svn path=/trunk/; revision=21541
2007-04-23 21:12:04 +00:00
Guy Harris
0acc6bc5b8 The "in" array in an MD5 context is expected to be aligned on a 4-byte
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary
casts.

svn path=/trunk/; revision=21540
2007-04-23 20:47:07 +00:00
Anders Broman
cd66fcfe16 Remove a relic from experimental code.
svn path=/trunk/; revision=21539
2007-04-23 20:30:31 +00:00
Anders Broman
b65e5b390a TCAP: Fix up indentation a bit.
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.

svn path=/trunk/; revision=21538
2007-04-23 20:21:31 +00:00
Anders Broman
d07a92f8bc TCAP: Fix up indentation a bit.
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.

svn path=/trunk/; revision=21537
2007-04-23 20:20:46 +00:00
Guy Harris
8e32c1e739 Get rid of no-longer-needed, and warning-generated, casts.
svn path=/trunk/; revision=21536
2007-04-23 18:30:29 +00:00
Guy Harris
adcccbcdee More const cleanup.
svn path=/trunk/; revision=21535
2007-04-23 18:18:08 +00:00
Guy Harris
cdb59eed63 Make Mk16_le() work on both big-endian and little-endian processors and
on processors that don't support unaligned loads - just use pletohs().

svn path=/trunk/; revision=21534
2007-04-23 18:11:12 +00:00
Guy Harris
6f4a938c64 Dissector table names should be pointed to by const pointers.
svn path=/trunk/; revision=21533
2007-04-23 17:40:33 +00:00
Guy Harris
0e7e1ba0aa Fix type cast to match target of assignment.
svn path=/trunk/; revision=21532
2007-04-23 17:38:56 +00:00
Guy Harris
56fcbf41be The "needles" argument of guint8_pbrk() needs to be const, as that's
what's passed to it.

svn path=/trunk/; revision=21531
2007-04-23 17:37:36 +00:00
Guy Harris
877db595ff Don't assume byte pointers can be safely cast to more aligned pointers;
the compiler now warns of that.

svn path=/trunk/; revision=21530
2007-04-23 17:33:29 +00:00
Guy Harris
f010b46419 decode_as_dt's argument points to a dissector table name, so it should be
a const pointer.

svn path=/trunk/; revision=21529
2007-04-23 16:49:24 +00:00
Guy Harris
552fff182e Don't assume a pointer to UCHAR is necessarily aligned; that now
generates a warning.

svn path=/trunk/; revision=21528
2007-04-23 16:41:31 +00:00
Stephen Fisher
90f8b1a080 From Paolo Abeni:
(from -dev list)
On Sun, 2007-04-22 at 23:06 +0200, Joerg Mayer wrote:
> Can someone please have a look at uand fix the following warning:
>
> cc1: warnings being treated as errors
> packet-ssl.c: In function 'ssl_parse':
> packet-ssl.c:334: warning: ignoring return value of 'fread', declared
> with attribute warn_unused_result

The attached patch fix the issue. It also try to fix a bit the
indentation.

Me: Move size_t nbytes up to top of function and fix typo expeted->expected


svn path=/trunk/; revision=21527
2007-04-23 16:22:34 +00:00
Guy Harris
1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Guy Harris
7dc9df5f26 Just use -1 to go to the end of a tvbuff.
svn path=/trunk/; revision=21525
2007-04-23 10:57:34 +00:00
Jeff Morriss
20a3a52951 Mark all the items for TCAP statistics as generated
svn path=/trunk/; revision=21524
2007-04-23 10:45:00 +00:00
Ronnie Sahlberg
c84eda3a80 add request/response matching for ctdb
svn path=/trunk/; revision=21523
2007-04-23 09:44:13 +00:00
Anders Broman
9344195101 Formating changes and align a bit to spec.
svn path=/trunk/; revision=21521
2007-04-23 06:24:39 +00:00
Guy Harris
c5beaef29e "call_ber_syntax_callback()" isn't used outside packet-ber.c, isn't
declared in any header file, and isn't in epan/libwireshark.def; make it
static, to squelch compiler warnings.

svn path=/trunk/; revision=21518
2007-04-23 00:32:04 +00:00
Jörg Mayer
b16106f89f Only #deinfe __USE_XOPEN if not already defined. On my Suse 10.2 it was
already #defined to 1, so this would create a warning/error.


svn path=/trunk/; revision=21508
2007-04-22 20:04:34 +00:00
Guy Harris
065be642f4 Get rid of some const warnings.
Use the "pnto" macros to fetch 16-bit quantities from a buffer - not
only do they have the right casts to avoid const warnings, they also
work even on platforms (such as SPARC) where you can't dereference
unaligned pointers without a trap.

Similarly, compare a possibly-unaligned (we make no alignment guarantees
in Wireshark) 16-bit quantity against 0 a byte at a time.

svn path=/trunk/; revision=21507
2007-04-22 18:26:45 +00:00
Guy Harris
6327554e6c Check the GLib version number, not the GTK+ version number; it's GLib we
care about, and this code doesn't use GTK+, so it doesn't include any
GTK+ headers and therefore doesn't get the GTK+ version number defined.

svn path=/trunk/; revision=21506
2007-04-22 18:04:52 +00:00
Ronnie Sahlberg
7a97135752 GString.len has changed signednedd between gtk1 and gtk2
this will hopefully again compile under both gtk1 and 2


svn path=/trunk/; revision=21499
2007-04-22 15:22:53 +00:00
Jörg Mayer
7b20d35047 Fix a signedness warning.
svn path=/trunk/; revision=21497
2007-04-22 11:51:36 +00:00
Jaap Keuter
647446dadf Fix for bug 1541. Adjust offset for long longs by 8, not by 4.
svn path=/trunk/; revision=21496
2007-04-22 10:29:47 +00:00
Ronnie Sahlberg
99bc488535 fix the sign of a variable to prevent a singed/unsigned warning during
compiling


svn path=/trunk/; revision=21494
2007-04-22 09:58:12 +00:00
Anders Broman
4960e68578 EXPORT DialoguePDU UniDialoguePDU and make them callable by OID.
svn path=/trunk/; revision=21487
2007-04-21 20:53:35 +00:00
Anders Broman
eab3eb5c68 Put some missing TAG:s in the tree if internal BER fields shown.
svn path=/trunk/; revision=21486
2007-04-21 20:27:05 +00:00
Gerald Combs
02926636da Move some data frame back out of the control frame scope, so Wireshark
will stop crashing.

More .11n additions and updates from Dustin:

  - Power Capability tag
  - Supported Channels tag
  - Block Ack/Block Ack Request

Fixup whitespace.

svn path=/trunk/; revision=21484
2007-04-20 22:29:11 +00:00
Gerald Combs
2c9c0f3651 Fix 64-bit integer handling and whitespace.
svn path=/trunk/; revision=21483
2007-04-20 18:09:31 +00:00
Gerald Combs
24b3b66ba8 More .11n-related updates and additions from Dustin Johnson and myself:
- MIMO Control frame support
  - Control Wrapper frame support
  - Measurement Pilot
  - Action No Ack
  - Block Ack Action
  - PCO Phase Control
  - PSMP Parameter Set
  - Antenna Selection
  - Extended Channel Switch Announcement
  - HT Information
  - HT Action
  - MIMO CSI Matrices Report
  - Fill in and update a bunch of hf strings
  
Fixup(?) whitespace.

svn path=/trunk/; revision=21482
2007-04-20 17:40:13 +00:00
Sebastien Tandel
def734249e Since code generated by lex may trigger gcc warnings, we are now generating two
libraries.  A single library is generated with the lex code without the barrier
"stop on warning". An other library is generated from the remaining source
files with the "stop on warning" barrier.


svn path=/trunk/; revision=21481
2007-04-20 14:30:48 +00:00
Sebastien Tandel
366716e31d get rid of some unused parameters in process_ssl_payload
svn path=/trunk/; revision=21480
2007-04-20 14:19:20 +00:00
Anders Broman
5954b97ac4 Add EXTERNAL to the value string and add comments about UNIVERSAL tags.
svn path=/trunk/; revision=21479
2007-04-20 13:54:56 +00:00
Jörg Mayer
31937c3b30 Add Recognition of ELRP (Extreme Loop Recognition Protocol) Elements.
I don't know how to decode them though.

Fix some typos.

Change some Element descriptions.

svn path=/trunk/; revision=21478
2007-04-20 09:26:59 +00:00
Richard van der Hoff
5c50b6f96f From Hannes Gredler:
attached a small bugfix that uses the correct bits
for determining if the ATM payload is a OAM cell.


svn path=/trunk/; revision=21477
2007-04-19 17:13:49 +00:00
Tomas Kukosa
1bf555aa2f export dissect_ber_tagged_type()
svn path=/trunk/; revision=21474
2007-04-19 12:57:23 +00:00
Tomas Kukosa
840b4e46a9 register the right dissector for SIP over SSL/TLS
svn path=/trunk/; revision=21473
2007-04-19 07:09:59 +00:00
Richard van der Hoff
674306a87d following advice from Gerald, Graham Bloice, and others, let's try copying the unit test executables into the wireshark-gtk2 directory before running them.
svn path=/trunk/; revision=21472
2007-04-18 22:31:47 +00:00
Anders Broman
e7e9a81155 Fix to BUG GSM CAMEL-3 GPRS InvokeInitialDPGPRS.APN decoded incorrectly
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1543

svn path=/trunk/; revision=21471
2007-04-18 21:52:11 +00:00
Martin Mathieson
d01b682f52 Make specifier string match args
(may not be the intended formatting, but it builds...)

svn path=/trunk/; revision=21468
2007-04-18 09:23:27 +00:00
Tomas Kukosa
a6a0a76c45 usage of new #.MAKE_DEFINES asn2wrs directive in RNSAP
svn path=/trunk/; revision=21467
2007-04-18 08:58:48 +00:00
Jeff Morriss
ee73a2aff2 Don't use DISSECTOR_ASSERT to (essentially) verify packet data. Instead
add an expert info entry if the AVP length is 0 and just return after
dissecting that AVP.

svn path=/trunk/; revision=21465
2007-04-18 07:06:56 +00:00
Anders Broman
5e859c36d7 Add a comment.
svn path=/trunk/; revision=21464
2007-04-18 06:32:00 +00:00
Anders Broman
3f3d0d3d44 From Michael Lum:
This patch implements parameter dissection for about 1/2 to 2/3 of the messages in IS-801.

Built and tested against the latest source as of Friday April 13th 2007.

svn path=/trunk/; revision=21463
2007-04-18 06:31:25 +00:00
Anders Broman
cca5f4cfbc Add an IE.
svn path=/trunk/; revision=21462
2007-04-18 06:30:23 +00:00
Jeff Morriss
bc1a33021c Pass NULL (instead of proto_) in the last parameter of tap_queue_packet()
because NULL is just as interesting as the proto_ entry and the latter
generates a compiler warning.

svn path=/trunk/; revision=21460
2007-04-18 04:13:50 +00:00
Luis Ontanon
fdbc713314 register the right dissector for tcp
Fixes Bug 1429

svn path=/trunk/; revision=21457
2007-04-17 15:46:05 +00:00
Jörg Mayer
e8d1c6bff7 Detect ELSM as such - meaning of the elements is still unknown.
svn path=/trunk/; revision=21456
2007-04-17 15:17:06 +00:00
Luis Ontanon
869b908463 Make sure ENDTRY gets evaluated
svn path=/trunk/; revision=21455
2007-04-17 15:13:17 +00:00
Jeff Morriss
ab97c31bb2 Fix warnings of the form "long long unsigned int format, guint64 arg": use
the PRI macros instead of %llu, etc.

svn path=/trunk/; revision=21454
2007-04-17 10:11:41 +00:00
Gerald Combs
5285c91f9a More .11k/n updates from Dustin Johnson:
- Measurement Pilot frame support
  - Various Block Ack fields
  - Various Power fields
  - Measurement Pilot field
  - Country String field
  - Channel Width field
  - QoS Information fields

svn path=/trunk/; revision=21452
2007-04-17 00:34:32 +00:00
Luis Ontanon
b46c4dd535 revert back to 20437
svn path=/trunk/; revision=21451
2007-04-16 23:15:03 +00:00
Gerald Combs
d0a793c353 From Tuomas Maattanen:
the current SVN (rev 21448) 802.11 WMM TSPEC dissector seems to have
some bugs.

TS Info field should be three bytes long, not two.  Suspension Interval
field is missing altogether, shifting all other fields by four bytes.
Maximum Burst Size, Minimum PHY Rate, Peak Data Rate and Delay Bound
are in wrong order.


svn path=/trunk/; revision=21450
2007-04-16 18:35:22 +00:00
Michael Tüxen
2a10f9ea96 Use recent IANA port assignments.
svn path=/trunk/; revision=21449
2007-04-16 17:03:30 +00:00
Jeff Morriss
80c7330166 Replace g_assert() with DISSECTOR_ASSERT()
svn path=/trunk/; revision=21448
2007-04-16 09:03:11 +00:00
Jeff Morriss
aaf6cfb252 From Victor Fajardo: update the PANA dissector to draft-15a
svn path=/trunk/; revision=21447
2007-04-16 08:53:33 +00:00
Jeff Morriss
3f68c1395b Fix a couple warnings
svn path=/trunk/; revision=21446
2007-04-16 08:37:39 +00:00
Tomas Kukosa
111d18c4b3 move string tables from packet-ssl-utils.h to packet-ssl-utils.c and export them
svn path=/trunk/; revision=21445
2007-04-16 06:41:56 +00:00
Jeff Morriss
00cf2ec89c Frame numbers are unsigned, print them as such
svn path=/trunk/; revision=21443
2007-04-16 04:52:51 +00:00
Jeff Morriss
1295039ee9 Wireshark now requires support for 64-bit types so there's no need to #ifdef
around them.  Print 64-bit types using the PRI macros; add inttypes.h to
tap.h (if necessary) to pick up those macros for all the taps.

svn path=/trunk/; revision=21442
2007-04-16 04:34:07 +00:00
Jörg Mayer
f59e6b9e1e Revert commit 21430 and use #if 0/#endif instead
svn path=/trunk/; revision=21440
2007-04-15 00:40:05 +00:00
Stephen Fisher
a3a02dd82e From Sake Blok:
Fix false malformed SSL handshake messages


svn path=/trunk/; revision=21438
2007-04-14 19:04:19 +00:00
Sebastien Tandel
7d89f5bf5f "false" unused variables (they are not use in wiretap repo)
svn path=/trunk/; revision=21437
2007-04-14 18:39:07 +00:00
Sebastien Tandel
06deb19f7d move ipsec to DISSECTOR_SRC
fix some more MacOSX gcc warnings

svn path=/trunk/; revision=21433
2007-04-14 15:57:03 +00:00
Sebastien Tandel
aa17869bf7 remove "treat warnings as errors" barrier for every repo containing code
generated by $(LEX) until a solution is found to compile them separately.


svn path=/trunk/; revision=21432
2007-04-14 14:07:46 +00:00
Sebastien Tandel
68ad2f4b9b fix MacOSX gcc-3.3 warnings about unused tfs/value_string variables
most have been tagged unused (few have been deleted if dissector has not been
modified since a long time)

move packet-ssl-utils.c to DISSECTOR_SRC


svn path=/trunk/; revision=21431
2007-04-14 14:01:53 +00:00
Sebastien Tandel
c3530274e0 get rid of unused variables (tfs, value_string)
svn path=/trunk/; revision=21430
2007-04-14 13:15:52 +00:00
Sebastien Tandel
84e1cfee7f delete Td4 as it is used only in rijndaelDecrypt and rijndaelDecryptRound not
present in the wireshark code

svn path=/trunk/; revision=21429
2007-04-14 11:55:19 +00:00
Sebastien Tandel
454e23c936 typo fix
svn path=/trunk/; revision=21428
2007-04-14 07:55:43 +00:00
Jörg Mayer
8f3934e243 Beginnings of a Cisco ERSPAN dissector - the only thing missing is the code
to actually call this (aka to handle the ambiguities of DLT values).

svn path=/trunk/; revision=21427
2007-04-14 01:07:36 +00:00
Sebastien Tandel
2878fd21d6 don't treat warnings as errors until a solution is found for scanner.c
depending on the lex used, it may generates warning.

svn path=/trunk/; revision=21424
2007-04-13 23:40:50 +00:00
Stephen Fisher
fa57c8fc44 Fix some Solaris buildbot warnings
svn path=/trunk/; revision=21423
2007-04-13 23:32:21 +00:00
Stephen Fisher
63692e83f8 Remove unused variable that is causing a warning
svn path=/trunk/; revision=21420
2007-04-13 22:50:47 +00:00
Sebastien Tandel
e51e1e7560 move to CLEAN_DISSECTOR_SRC
svn path=/trunk/; revision=21418
2007-04-13 22:40:42 +00:00
Sebastien Tandel
be81a9cabb fix gcc warning
svn path=/trunk/; revision=21416
2007-04-13 20:38:19 +00:00
Gerald Combs
1295325704 802.11k/n updates from Dustin Johnson:
- Refactored Frame Control into its own function
  - Refactored the Action field
  - Add Block Ack/Block Ack Request
  - Add a Control Wrapper stub
  - Add the Neigbor Report tag
  - Add the Extended Channel Switch Announcement tag
  - Add the Supported Regulatory Classes tag
  - Add the Secondary Channel Offset tag

svn path=/trunk/; revision=21415
2007-04-13 19:28:03 +00:00
Sebastien Tandel
75d1cac3a9 ultimate declaration of a volatile variable to let gcc-3.4 happy.
svn path=/trunk/; revision=21414
2007-04-13 18:08:27 +00:00
Luis Ontanon
06a52917ad Have the h248term handle evaluated as late as possible.
svn path=/trunk/; revision=21413
2007-04-13 17:46:54 +00:00
Sebastien Tandel
a7615a1afb another attempt to let windows buildbot becoming green
fix rev21398 (gcc warning fix)

svn path=/trunk/; revision=21412
2007-04-13 17:16:24 +00:00
Sebastien Tandel
7be3171467 miss some volatile qualifiers in scsi-osd
svn path=/trunk/; revision=21411
2007-04-13 15:52:04 +00:00
Sebastien Tandel
8dc9e333ea fix some gcc warnings and put dissectors in CLEAN_DISSECTOR_SRC
svn path=/trunk/; revision=21410
2007-04-13 15:25:33 +00:00
Sebastien Tandel
42791e157b use of volatile for every functions and not only the ones using the Exception
mechanisms. (fix rev21398)

Windows buildbot sould be green again as formal parameters are the same as the
ones in the declaration now.

svn path=/trunk/; revision=21409
2007-04-13 15:23:47 +00:00
Sebastien Tandel
a9db1f7a77 fix gcc warning :
use of new_register_dissector instead of register_dissector

svn path=/trunk/; revision=21408
2007-04-13 14:55:55 +00:00
Tomas Kukosa
18808d7525 H.235.7: MIKEY in H.323
svn path=/trunk/; revision=21406
2007-04-13 14:15:12 +00:00
Jeff Morriss
07953c95a6 From Kevin A. Noll via bug 1522:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1522

Support for WLCCP version 0xC1.

Also updated his email address in AUTHORS.


svn path=/trunk/; revision=21404
2007-04-13 06:49:22 +00:00
Jeff Morriss
46e52aa261 Change the prototypes of dissect_spc_inquiry() and dissect_spc_reportluns()
as per the change in rev 21398 to get Windows builds working again.


svn path=/trunk/; revision=21403
2007-04-13 06:24:58 +00:00
Gerald Combs
536dd665a4 Fix a mis-labeled field reported in Ethereal bug 1101. Update all
of the short descriptions and fill in all of the long descriptions.
Fix up whitespace.

svn path=/trunk/; revision=21401
2007-04-13 05:44:57 +00:00
Bill Meier
e6a1e67017 Fix for link commands for exntest.exe, tvbtest.exe and reassemble_test.exe;
(Seems to work using vc6 on Windows XP).

svn path=/trunk/; revision=21400
2007-04-13 01:53:14 +00:00
Stephen Fisher
994846f215 Fix unused variable warning when neither SSL_DECRYPT_DEBUG nor HAVE_LIBGNUTLS is defined.
svn path=/trunk/; revision=21399
2007-04-13 01:03:55 +00:00
Stephen Fisher
f002ac6db5 Fix various warnings
Move packet-cops.c out of clean dissectors due to a #define conflict
in the headers of net-snmp with our config.h


svn path=/trunk/; revision=21398
2007-04-13 00:50:23 +00:00
Luis Ontanon
5f5f656108 From: Balint Reczey
I would like to handle the rare situation of Little Endian encoded
IP addresses, so i added a function which reads the address with
tvb_get_ipv4(), then swaps the bytes before SET_ADDRESS().


svn path=/trunk/; revision=21397
2007-04-12 22:45:22 +00:00
Sebastien Tandel
bbf2ad0977 move dissectors which compiles without any warning from DISSECTOR_SRC to
CLEAN_DISSECTOR_SRC

svn path=/trunk/; revision=21396
2007-04-12 22:43:45 +00:00
Sebastien Tandel
07eec0b469 include packet-ipv6.h for capture_ipv6 function
svn path=/trunk/; revision=21395
2007-04-12 22:42:31 +00:00
Sebastien Tandel
9eb8eca6c4 get rid of unused variable
svn path=/trunk/; revision=21394
2007-04-12 22:39:16 +00:00
Sebastien Tandel
e26748f068 set unused parameters flags to fiw some gcc warnings
svn path=/trunk/; revision=21393
2007-04-12 22:38:36 +00:00
Anders Broman
2d7b1da3bf Workaround for the ber CHOICE crash.
svn path=/trunk/; revision=21392
2007-04-12 20:37:08 +00:00
Gerald Combs
94dbb06046 Additional 802.11k/n support from Dustin Johnson and myself:
- Break out and display A-MSDUs
  - HT Control field (currently disabled)
  - Action No Ack
  - HT Information IE
  - HT Capability IE
  - Block Ack Request
  - Secondary Channel Offset Tag
  - Measurement Request Tag
  - Measurement Report Tag

...along with a bunch of other updates, including displaying the
type/subtype as a hex value (first nibble: type, second nibble: subtype).

svn path=/trunk/; revision=21391
2007-04-12 18:42:19 +00:00
Sebastien Tandel
d99d6ccba5 From Matthijs Mekking :
New dissector support, SHIM6

checked in with the following modifications :
  - use of proto_tree_add_item whenever possible (addition of several hf_items),
  - use distinct subtree idx for each subtree,
  - addition of some subtrees,
  - split shim_opts in several functions,
  - accurate incrementation of offset in locator preferences (in case of option length > 3)
  - add true_false_string for critical options and protocol differentiation (hip, shim6)
  - add ipv6.shim6.checkksum_good, ipv6.shim6.checkksum_bad, cksum expert info

section added to AUTHORS


svn path=/trunk/; revision=21390
2007-04-12 17:34:30 +00:00
Martin Mathieson
4b18fbc8a5 Add Via sigcomp-id param (from draft-ietf-rohc-sigcomp-sip)
svn path=/trunk/; revision=21389
2007-04-12 14:31:49 +00:00
Richard van der Hoff
dae27a8aa6 try linking against user32.lib and wsock32.lib
svn path=/trunk/; revision=21386
2007-04-11 23:20:02 +00:00
Luis Ontanon
5b08821866 have tvbrange:get_ipv4() not modifying the byte order of the extraced data.
have Proto.new() registering the protocol by name.


svn path=/trunk/; revision=21385
2007-04-11 19:24:19 +00:00
Gerald Combs
19ac60d3a7 From Stig Bjørlykke:
This patch adds an option to IEEE 802.11 to ignore the wep bit with IV,
as mentioned in
http://www.wireshark.org/lists/wireshark-dev/200704/msg00021.html

I also fixed a bug where the packet is dissected different in the Packet
List with and without "Colorize Packet List" (actually when dissecting
with and without "tree").  Try toggling "Colorize Packet List" with my
previous posted ieee80211-wep.pcap without this patch to see the bug.

The patch is tested on OSX.

svn path=/trunk/; revision=21384
2007-04-11 15:15:28 +00:00
Martin Mathieson
c958b0b8fc Dissect IPPRIM conn_id field.
svn path=/trunk/; revision=21383
2007-04-11 14:34:56 +00:00
Richard van der Hoff
0d6e4649f5 fix typos
svn path=/trunk/; revision=21382
2007-04-11 12:26:02 +00:00
Tomas Kukosa
fa4e3ac28b make packet-ssl-utils.c compileable without GnuTLS
svn path=/trunk/; revision=21381
2007-04-11 05:54:15 +00:00
Richard van der Hoff
d1f795d28e right; this is going badly.
Let's take a different tack: include only the bare minimum, and set up stubs for everything else.

svn path=/trunk/; revision=21379
2007-04-11 00:22:58 +00:00
Anders Broman
8d756c3049 Add a reference.
svn path=/trunk/; revision=21377
2007-04-10 21:02:50 +00:00
Anders Broman
6898074943 Dissect a bit more of the h263 data.
svn path=/trunk/; revision=21376
2007-04-10 21:01:54 +00:00
Luis Ontanon
31a68c4802 fix another warning
svn path=/trunk/; revision=21374
2007-04-10 18:50:57 +00:00
Richard van der Hoff
5a7c666d1e From Sake Blok:
- changed dissect_ssl2_hnd_client_hello to use hf_ssl_handshake_version instead
of hf_ssl_record_version. SSLv2 client hello's did not display when the filter
ssl.handshake.version == 0x0002 was used, only SSLv2 server hello's were
displayed. Now they are both displayed

- Added generated hf_ssl_record_version to SSLv2 handshake. Since the SSLv2
does not include a record layer version field (unlike SSLv3), this field is
generated so that all packets with a SSLv2 record layer can be filtered out.
[this is actually what bug 1503 was all about]


svn path=/trunk/; revision=21373
2007-04-10 18:40:05 +00:00
Richard van der Hoff
794b272985 From Sake Blok:
wireshark SHOULD be able to filter on multiple hf's with the
same field-name, BUT there is a little bug in the code. I have pinpointed it to
the following in epan/dfilter/dfvm.c:
...
It actually loops through all the hf's with the same name, but only checks
against the original (first) hf.


svn path=/trunk/; revision=21372
2007-04-10 18:31:36 +00:00
Richard van der Hoff
3608bc694a fix a number of warnings, and type of ssl_decrypt_record when HAVE_LIBGNUTLS is not defined.
svn path=/trunk/; revision=21371
2007-04-10 18:09:51 +00:00
Richard van der Hoff
5851b8aa40 remove dependency on zlib.h
svn path=/trunk/; revision=21370
2007-04-10 17:57:47 +00:00
Richard van der Hoff
901b6d1c55 fix typo in eth_stdio_fopen defn
svn path=/trunk/; revision=21369
2007-04-10 17:34:32 +00:00
Tomas Kukosa
9f2ccb7fc0 - SSL desegmentation support
- SSL DEFLATE compression method support (RFC3749)
- fix for Bugzilla Bug 1515: SSL bug with mutual authentication

svn path=/trunk/; revision=21368
2007-04-10 15:12:48 +00:00
Jeff Morriss
4d21c49929 Get rid of some more g_assert*()'s in the dissectors. There are a few
remaining that I'm not sure exactly what to do with at the moment:
the one in packet-frame probably should be there, the others probably
shouldn't but they also should never fail unless there's a compile or build
problem (AFAICS).


svn path=/trunk/; revision=21367
2007-04-10 14:48:06 +00:00
Jeff Morriss
7e2cb04ebf Fix bug 1511:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1511

by replacing g_assert() with DISSECTOR_ASSERT().


svn path=/trunk/; revision=21366
2007-04-10 14:31:09 +00:00
Richard van der Hoff
e83c397ce3 user32.lib and wsock32.lib shouldn't be make dependencies
svn path=/trunk/; revision=21365
2007-04-10 13:46:33 +00:00
Tomas Kukosa
36fe262fa8 new SE_COPY_ADDRESS macro
svn path=/trunk/; revision=21364
2007-04-10 13:35:39 +00:00
Richard van der Hoff
d72a70d653 more libs, more stubs... i'll get there one day
svn path=/trunk/; revision=21363
2007-04-10 11:51:16 +00:00
Jeff Morriss
38b1e3f285 From David Kennedy via bug 1464:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1464

Support for Symantec SGS v3 files.

svn path=/trunk/; revision=21362
2007-04-10 07:01:59 +00:00
Richard van der Hoff
ecbeb10d7f hrm, we even need dissectors.lib
svn path=/trunk/; revision=21353
2007-04-08 13:33:30 +00:00
Richard van der Hoff
bac617e731 another go at making reassemble_test build: give it lots more libraries
svn path=/trunk/; revision=21352
2007-04-08 11:48:59 +00:00
Richard van der Hoff
52727b58b7 link reassemble_test against the right library
svn path=/trunk/; revision=21351
2007-04-07 11:16:46 +00:00
Gerald Combs
a0afc5d832 Add a registration symbol cache to make-dissector-reg.py. When you
update a dissector and recompile, make-dissector-reg.py can now pull
its list of registration routines from a cache instead of having to
scan through every dissector.  The time to create register.c has gone
from 20 to 30 seconds down to 2 on my desktop machine.

The cache file is a Python pickle data stream.  It should be portable
across architectures, so we may be able to add it to the distribution
at some point.

svn path=/trunk/; revision=21348
2007-04-06 16:15:36 +00:00
Graham Bloice
85c33a07cb Remove build detritus
svn path=/trunk/; revision=21347
2007-04-06 15:51:36 +00:00
Tomas Kukosa
155b04eda3 export some desegmentation functions from TCP dissector to reuse them in SSL/TLS desegmentation
svn path=/trunk/; revision=21346
2007-04-06 07:01:01 +00:00
Ronnie Sahlberg
5f469a9e5a update of dissector to reflect wire format changes
svn path=/trunk/; revision=21345
2007-04-06 05:02:41 +00:00
Ronnie Sahlberg
d7d047acb2 initial CTDB dissector
svn path=/trunk/; revision=21344
2007-04-06 04:27:59 +00:00
Jaap Keuter
a7271dd2c0 Fix for bug 1523. Offset handling was off in DialedNumberMessage presentation.
svn path=/trunk/; revision=21343
2007-04-05 23:42:44 +00:00
Gerald Combs
f5b1443173 Fix a typo.
svn path=/trunk/; revision=21341
2007-04-05 22:44:18 +00:00
Luis Ontanon
a031a39a31 Implement proposed fix for Bug 1125
svn path=/trunk/; revision=21339
2007-04-05 22:16:12 +00:00
Gerald Combs
fdbcca2123 In epan/dissectors/Makefile.nmake, fix a typo.
In make-dissector-reg.py, throw an error if we don't have enough files
to process, or if we don't generate enough registrations.  "Enough"
is arbitrarily set to 100.

This should de-purple the buildbot.  (I'm sure there's a "smoke on the
water" joke in there somewhere.)

svn path=/trunk/; revision=21338
2007-04-05 21:38:39 +00:00
Luis Ontanon
a1120493e2 Megaco improvements:
- Verify that we have a ber sequence before handing over to H.248
- Make the dissector more case insensitive (Fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1517)


svn path=/trunk/; revision=21337
2007-04-04 21:23:55 +00:00
Stephen Fisher
269edd8e7a Fix a warning
svn path=/trunk/; revision=21336
2007-04-04 19:35:46 +00:00
Graham Bloice
7710d21893 Fix build failures due to windows.h being included before winsock2.h via other includes
svn path=/trunk/; revision=21335
2007-04-04 12:18:10 +00:00
Anders Broman
a17051ebbb Add wtap_nstime_to_sec.
svn path=/trunk/; revision=21333
2007-04-04 06:56:04 +00:00
Luis Ontanon
96384817ec Make sure that when a windows exception is thrown ENDTRY gets evaluated.
fix for one of the various issues that cause bug 1334

svn path=/trunk/; revision=21332
2007-04-03 22:06:31 +00:00
Sebastien Tandel
7e8012faa5 From metatech :
Dissector for the DRDA protocol. This is the protocol used by among
  others the DB2 database.

  modify his entry in AUTHORS

svn path=/trunk/; revision=21331
2007-04-03 21:48:40 +00:00
Stephen Fisher
6625e7503f Fix warnings on Linux/gcc 4.1.1
svn path=/trunk/; revision=21330
2007-04-03 21:17:13 +00:00
Luis Ontanon
d51726941d xFi a Ytpo
svn path=/trunk/; revision=21328
2007-04-03 20:52:37 +00:00
Sebastien Tandel
edfd071881 Creation of ALL_DISSECTORS_SRC including all dissectors sources
- used in Makefile.nmake instead of DISSECTOR_SRC
 - used for the target register.c

svn path=/trunk/; revision=21327
2007-04-03 20:22:32 +00:00
Sebastien Tandel
2e26bbeda3 delete packet-drda.c
svn path=/trunk/; revision=21326
2007-04-03 20:12:05 +00:00
Richard van der Hoff
af6809a33d fix an 'unused parameter' warning
svn path=/trunk/; revision=21325
2007-04-03 19:53:05 +00:00
Sebastien Tandel
0854c90e87 epan/dissectors/Makefile is now building four libraries :
- asn dissectors : libasndissectors.la
  - pidl dissectors : libpidldissectors.la
  - normal dissectors : libdissectors.la *and* libcleandissectors.la. I
  separated it in two libraries temporarily. The source files used to build
  libcleandissectors.la do not generate warning anymore and the -Werror is used
  to compile them. If we patch a dissector and it doesn't generate warning
  anymore, we have to move the filename dissector from DISSECTOR_SRC to
  CLEAN_DISSECTOR_SRC in epan/dissectors/Makefile.common.

If you want to define specific cflags for one library type, let's say pidl, you
may define libpidldissectors_la_CFLAGS.

svn path=/trunk/; revision=21324
2007-04-03 19:50:04 +00:00
Sebastien Tandel
1c7d843166 minor changes in constants names
svn path=/trunk/; revision=21322
2007-04-03 19:13:06 +00:00
Luis Ontanon
9709011a9b Implement a proposal from Elefterios Gabriel for SCCP:
Add a table of DPCs and SSNs that allow to override the protocol that would be choosen
so that the same SSN can use two different protocols in two different DPCs.

I did not believe it someone could have done it, then I saw the captures...


svn path=/trunk/; revision=21321
2007-04-03 19:08:00 +00:00
Richard van der Hoff
8177d0f4a9 disable generation of unput to avoid a compiler warning.
svn path=/trunk/; revision=21320
2007-04-03 18:41:24 +00:00
Richard van der Hoff
38142e0e1d Set $(LINK). I swear I'll get there in a minute with this.
svn path=/trunk/; revision=21319
2007-04-03 17:30:02 +00:00
Richard van der Hoff
97bf03e456 hmm, apparently $^ doesn't work for nmake
svn path=/trunk/; revision=21318
2007-04-03 15:48:59 +00:00
Richard van der Hoff
c55799267b mpa_* stubs to make this link properly
svn path=/trunk/; revision=21317
2007-04-03 13:56:19 +00:00
Richard van der Hoff
0d949be362 rules for making the unit tests
svn path=/trunk/; revision=21316
2007-04-03 13:24:20 +00:00
Richard van der Hoff
12ae982bfc hopefully, fix reassemble_test by linking against libgcrypt
svn path=/trunk/; revision=21313
2007-04-03 11:12:27 +00:00
Jeff Morriss
755698ebcf Fix bug 1508:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1508

Dissect ISUP CIC as 14 bits in ANSI (instead of 12 bits like in ITU)


svn path=/trunk/; revision=21310
2007-04-03 06:27:18 +00:00
Richard van der Hoff
d522b25216 From me: make tvbtest return an exitcode appropriate to its success
svn path=/trunk/; revision=21308
2007-04-03 01:53:52 +00:00
Richard van der Hoff
96058b34bc From me:
disable failing composite tvb tests

svn path=/trunk/; revision=21307
2007-04-03 01:49:14 +00:00
Richard van der Hoff
606a756714 From me:
fix compiler warnings in tvbtest.c

svn path=/trunk/; revision=21306
2007-04-03 01:45:59 +00:00
Richard van der Hoff
2c14858aef From Mike Duigou:
The enclosed patch corrects a problem where jxta elements were being added to the protocol tree for segments that did not contain complete jxta frames. This patch ensures that the jxta proto elements are only added those the segments that end a complete, assembled jxta frame.

The patch has been fuzz tested with a broad selection of jxta captures and ran successfully overnight for over 4000 iterations.


svn path=/trunk/; revision=21305
2007-04-03 01:31:22 +00:00
Stephen Fisher
4d185950d7 From Donald White:
A partial RFC 2508 dissector for packet-ppp.c


svn path=/trunk/; revision=21304
2007-04-02 23:45:38 +00:00
Luis Ontanon
b68f7da564 Add decoding of TFO Codec and Codec List
svn path=/trunk/; revision=21302
2007-04-02 21:47:54 +00:00
Jörg Mayer
92dcf79a78 - Use proto_tree_add_item instead of proto_tree_add_(u)int
in many places.
- Seperate decoding of magic and version.
- Explicitely display the padding bytes.

svn path=/trunk/; revision=21301
2007-04-02 16:39:54 +00:00
Jeff Morriss
a5f4e7b85a Make RX a new style dissector: return 0 if there isn't at least 28 bytes of message or if it receives an unknown Type. Add a check of tvb length to README.developer's cut-n-paste dissector code.
svn path=/trunk/; revision=21300
2007-04-02 08:25:43 +00:00