Commit Graph

14 Commits

Author SHA1 Message Date
Guy Harris c21a5d83f7 Give the "iscsi_desegment" and "iscsi_port" the right types, matching
the declarations of the functions to which a pointer to them is passed;
this also fixes it so it compiles with MSVC++, as there's no "uint" type
declared by MSVC++ by default.

svn path=/trunk/; revision=4054
2001-10-21 19:04:20 +00:00
Guy Harris e4dbc04bf0 Updates from Mark Burton:
The enclosed code contains the following improvements:

	1 - Compatible with 08 version of the protocol

	2 - Handles both header and data digests

	3 - Supports desegmentation

	4 - Dissects multiple PDUs per packet

	5 - Stronger heuristics to avoid dissecting non-iSCSI packets

	6 - General rationalisation and de-crufting!

	The old code that attempted to automatically detect the presence
	of a header digest has been removed.  You now have to specify in
	the iSCSI preferences whether digests are enabled and if they
	are, whether they are CRC32 or not.  If not CRC32, you also need
	to specify the size of the digests (in bytes).

	Another new option specifies the iSCSI port number.  This is
	used in the heuristics to filter out packets with silly port
	numbers, set to 0 to disable the port filter.

	One problem that I haven't been able to track down is that if
	desegmentation is enabled and you turn digests on or off
	ethereal throws a SEGV.

svn path=/trunk/; revision=4051
2001-10-21 17:20:10 +00:00
Guy Harris 24c930c708 FT_UINTn values must always have a base, even if they're bitfields - the
width of the item containing the bitfield is "n", so you don't have to
specify it explicitly, as you have to do with FT_BOOLEAN bitfields.

svn path=/trunk/; revision=4047
2001-10-20 18:30:50 +00:00
Guy Harris 7204834327 From Mark Burton: update to the -08 draft.
svn path=/trunk/; revision=4043
2001-10-19 20:53:14 +00:00
Guy Harris 946ec3a865 Update from Mark Burton.
svn path=/trunk/; revision=3771
2001-07-22 20:02:23 +00:00
Guy Harris f338bd3ffc Get the length of a null-terminated string with "tvb_strnlen()", not by
getting a pointer to the first byte of the string with "tvb_get_ptr()"
and then assuming you can safely do a "strlen()" with that pointer
(it's not guaranteed that you can, as the terminating null byte might
not be in the tvbuff).

Add the resulting string with "proto_tree_add_item()".

svn path=/trunk/; revision=3728
2001-07-16 06:06:06 +00:00
Guy Harris 3c91e2e203 Convert a bunch of "proto_tree_add_bytes(tree, hf, tvb, offset, length,
tvb_get_ptr(tvb, offset, length))" calls to "proto_tree_add_item()"
calls.

Do the same, in "packet-iscsi.c" and "packet-mrdisc.c", for
"proto_tree_add_uint()" and "proto_tree_add_boolean()" calls.

svn path=/trunk/; revision=3726
2001-07-16 05:16:58 +00:00
Guy Harris 0ffd5686d1 Updates from Mark Burton.
svn path=/trunk/; revision=3618
2001-06-28 08:05:26 +00:00
Guy Harris 8412393197 From Joerg Mayer: explicitly fill in all members of a
"header_field_info" structure, including the ones that are later set by
the routines to register fields.

svn path=/trunk/; revision=3561
2001-06-18 02:18:27 +00:00
Guy Harris 8ee0584e8d Updates from Mark Burton.
svn path=/trunk/; revision=3508
2001-06-04 05:32:52 +00:00
Guy Harris 3831d06992 On Windows, "min" apparently gets defined or declared in such a fashion
that declaring our own static function "min()" doesn't work; rename it
"iscsi_min()" to get rid of the problem.

svn path=/trunk/; revision=3504
2001-06-02 08:13:04 +00:00
Guy Harris c3db6052cb Updates from Mark Burton.
svn path=/trunk/; revision=3492
2001-05-31 19:20:41 +00:00
Guy Harris ffb3b28de6 Don'tcramallthewordsinapreference'snametogether;
underscores_are_permitted_in_those_names.

svn path=/trunk/; revision=3491
2001-05-31 08:54:17 +00:00
Guy Harris 714c10a91c iSCSI support, from Mark Burton.
svn path=/trunk/; revision=3482
2001-05-30 18:52:38 +00:00