Commit Graph

17138 Commits

Author SHA1 Message Date
Jeff Morriss a3fc8f5f45 Register a frame-end routine to reset mtp3_standard back to the preference
value even if an exception was thrown.

svn path=/trunk/; revision=40827
2012-02-03 18:16:21 +00:00
Sake Blok 9888a0a8a5 From Martin Kaiser.. FIX subdissector selection
#BACKPORT:YES

svn path=/trunk/; revision=40825
2012-02-03 17:30:55 +00:00
Jeff Morriss f2539534a3 Finish the heuristic standard detection logic by adding support (untested)
for LUDT and LUDTS messages.

svn path=/trunk/; revision=40824
2012-02-03 16:55:27 +00:00
Martin Mathieson 7c0b8e6097 Dissect and check reserved bits at start of signalling format.
svn path=/trunk/; revision=40823
2012-02-03 16:44:56 +00:00
Martin Mathieson 1b42caf3b3 Add a link back to previous frame for UM sequence number analysis.
Change a couple of filter names to use "-" rather than "_".  Update
stats window to use changed filter name.

svn path=/trunk/; revision=40822
2012-02-03 10:42:01 +00:00
Jeff Morriss 73ce69dcd4 Improve heuristic standard detection:
- Fix various bugs.
 - Add some optional debug.
 - Enable checking of the Calling address.
 - Check that the Called/Calling address has at least a minimum number of
   octets.
 - Handle XUDTS.
 - Reject messages whose mandatory variable pointers are 0 (meaning not
   present).
 - Reject Class-2 messages whose Class-spare bits are non-zero.
 - For (Class-2) messages that have no variable parameters but an optional
   pointer, only accept messages whose optional pointer is 0 (no optional
   parameters) or 1 (optional parameter immediately follows the pointer).
 - (For some of those Class-2 messages) if there are no optional parameters,
   reject messages if we didn't reach the end of the message.

svn path=/trunk/; revision=40819
2012-02-03 04:09:10 +00:00
Anders Broman e150c57992 From guettler:
Apply part  of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5622 to see OSI over IP.

svn path=/trunk/; revision=40818
2012-02-02 21:39:33 +00:00
Jeff Morriss eba7aaecc0 dissect_gtpv2_mbms_session_duration(): 'tree' is unused but 'item' is. Mark them as such.
svn path=/trunk/; revision=40817
2012-02-02 21:35:51 +00:00
Anders Broman 29bde33be2 From keysandwood:
osi-options dissector : dissect_option_route wrong parsing of NET

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5583

svn path=/trunk/; revision=40816
2012-02-02 21:34:23 +00:00
Anders Broman 1ac893fe4e From keysandwood:
register by name protocol isis (to be callable from LUA).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5612

svn path=/trunk/; revision=40813
2012-02-02 21:10:13 +00:00
Anders Broman d35177e0d2 From David Wei:
Start update with the latest signals and IE's

svn path=/trunk/; revision=40812
2012-02-02 20:56:20 +00:00
Jeff Morriss 4193e9c318 Rather than rename the remaining HI2Operations source files in asn1/ (to fix building of the dissector and make distcheck), revert 40803 and 40801.
svn path=/trunk/; revision=40811
2012-02-02 20:35:48 +00:00
Jörg Mayer 2d7a4646e2 Include config.h in preparation of moving the definition
of _U_ from the compiler command line into config.h

svn path=/trunk/; revision=40806
2012-02-02 11:54:33 +00:00
Jörg Mayer 2d72f9baa7 packet-HI2Operations.c was sorted into the file list as if it were
spelled packet-hi2operations.c. Rename the file to represent this.


svn path=/trunk/; revision=40801
2012-02-02 01:08:02 +00:00
Jeff Morriss e15175f2be Move m3ap from clean-asn1-dissector list to dirty-asn1-dissector list.
svn path=/trunk/; revision=40798
2012-02-01 22:43:27 +00:00
Jeff Morriss ba65ed5dd5 Move m3ap from clean-asn1-dissector list to dirty-asn1-dissector list.
svn path=/trunk/; revision=40796
2012-02-01 21:42:07 +00:00
Anders Broman c1813b0701 Collect and use some SRTP information.
svn path=/trunk/; revision=40794
2012-02-01 20:33:33 +00:00
Anders Broman b2114c1c40 See if this makes it build cleanly.
svn path=/trunk/; revision=40793
2012-02-01 20:20:03 +00:00
Anders Broman 3ec9eda058 Add M3AP to the build.
svn path=/trunk/; revision=40791
2012-02-01 19:36:16 +00:00
Anders Broman c739706ffd From David Wei:
Add a dissector for 3GPP TS 36.444 V11.0.0 (2011-12) M3AP

svn path=/trunk/; revision=40790
2012-02-01 19:27:08 +00:00
Jörg Mayer 0d827a2cce Fix warning: pci set but not used warning
svn path=/trunk/; revision=40789
2012-02-01 10:02:01 +00:00
Chris Maynard fc18d1f4f7 Fix some typos.
svn path=/trunk/; revision=40788
2012-02-01 02:23:51 +00:00
Chris Maynard 3db18f185e Fix some typos.
svn path=/trunk/; revision=40787
2012-02-01 02:05:19 +00:00
Chris Maynard f88e871171 Fix some typos.
svn path=/trunk/; revision=40786
2012-02-01 01:41:11 +00:00
Guy Harris afdf8061a1 Let's make all offsets within the packet guints. (In most of the API,
they're signed, but that's only to handle "offset from the end" - we
should probably get rid of that and make them unsigned.)

svn path=/trunk/; revision=40785
2012-01-31 23:36:52 +00:00
Jeff Morriss 0db7fc9dfc Heuristic standard tuning:
- Handle ERR and IT messages.
 - When checking variable parameter lengths, check that we have enough data
   remaining (by adding the current offset to the retrieved length).
 - Check the lengths of several more messages.
 - When checking the length, add up the values of the parameter length macros
   to make it obvious how we came to use that value.

svn path=/trunk/; revision=40784
2012-01-31 23:06:27 +00:00
Jeff Morriss 9e9553003d Use PINFO_FD_NUM and PINFO_FD_VISITED
svn path=/trunk/; revision=40783
2012-01-31 20:40:29 +00:00
Jeff Morriss b0ab8e5df4 Improve heuristic standard detection:
- Make sccp_called_calling_looks_valid() static.
 - Reject GT-routed Class-2 (it's not used).
 - Handle UDTS.
 - Handle optional pointer on several messages.

svn path=/trunk/; revision=40782
2012-01-31 04:02:08 +00:00
Jeff Morriss a3de46bf3e Heuristic standard tuning:
- Reject all Class-3 messages (it's never used)
 - Group Class-2 and Class-1 messages closer together
 - Some code cleanup (use macros where we have them)

svn path=/trunk/; revision=40780
2012-01-30 23:15:07 +00:00
Anders Broman d29d5bf966 Remove an unused parameter.
svn path=/trunk/; revision=40778
2012-01-30 20:03:29 +00:00
Anders Broman 80c5205b8e Reformat a section.
svn path=/trunk/; revision=40777
2012-01-30 19:54:39 +00:00
Anders Broman ed5c6cfd71 Try to determine MTP3 Standard heuristically, original code
from Jeff Morris refactored a bit by me.

svn path=/trunk/; revision=40776
2012-01-30 19:47:35 +00:00
Anders Broman 0ee76da516 Minor updates to debug output.
svn path=/trunk/; revision=40775
2012-01-30 19:42:21 +00:00
Anders Broman 9f6bfbacdb From Andreas Heise:
Remove a debug line.

svn path=/trunk/; revision=40774
2012-01-30 19:41:29 +00:00
Jeff Morriss 509c2203eb Revert 40772: the abort() needs to be pushed higher (into packet.c?) so
checkapi remains happy; thus far my attempts at that aren't working.

svn path=/trunk/; revision=40773
2012-01-30 19:23:25 +00:00
Jeff Morriss 0a8b301218 If WIRESHARK_ABORT_ON_DISSECTOR_BUG is set, abort() out if we happened to
catch a DissectorError exception.

(I found this useful when debugging a "More than 1000000 items in the tree"
DissectorError.)

svn path=/trunk/; revision=40772
2012-01-30 17:51:22 +00:00
Jeff Morriss f091005d3e Fix infinite loop reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6778 :
SDP_CRYPTO: Give up (and display an expert info) if we don't find the colon
separating the key-method and the key-info.

Reindent this area of code a bit.

Remove tabs in some places for consistency.

svn path=/trunk/; revision=40771
2012-01-30 17:39:15 +00:00
Anders Broman 84370fffcb Add *.sbr files to the clean target.
svn path=/trunk/; revision=40762
2012-01-29 20:21:30 +00:00
Gerald Combs e564a427df [Automatic manuf, services and enterprise-numbers update for 2012-01-29]
svn path=/trunk/; revision=40757
2012-01-29 15:03:23 +00:00
Michael Tüxen f011eca8c1 Don't register ett_ssl_keyex_params twice.
This bug was introduced in
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40748

svn path=/trunk/; revision=40756
2012-01-28 22:22:01 +00:00
Anders Broman c05cf29916 From Tyson Key:
Update the CCID dissector's filter/handler names.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6752

svn path=/trunk/; revision=40755
2012-01-28 17:19:25 +00:00
Anders Broman 20881c49bb From Claudio:
linear white space (LWS) not ignored after HTTP header field content.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6591

svn path=/trunk/; revision=40753
2012-01-28 17:04:48 +00:00
Anders Broman 855289862a From Andreas Heise:
option ssl_ignore_mac_failed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6748

svn path=/trunk/; revision=40752
2012-01-28 16:48:06 +00:00
Anders Broman 638ae058f4 From Tobias Witek:
Add support for a new dissector (MTP2) to the 'meta' dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6717

svn path=/trunk/; revision=40751
2012-01-28 16:37:50 +00:00
Anders Broman 6dbeabfc6f From Tobias Witek:
Allow dissectors to indicate that an ATM AAL5 frame contains SSCOP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6717

svn path=/trunk/; revision=40750
2012-01-28 16:34:22 +00:00
Anders Broman 95c9d2c52f From Michal Labedzki:
Fix:Wrong bluetooth PSM detected when parse the L2CAP packet.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6619

svn path=/trunk/; revision=40749
2012-01-28 16:24:12 +00:00
Anders Broman cde63b2001 From Michael:
Enhance SSL Key Exchange dissection.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6716

svn path=/trunk/; revision=40748
2012-01-28 15:50:59 +00:00
Guy Harris 25125ae369 Well, we *did* go to a widget that invokes callback to get the text for
the columns, so we *can* clean up the exporting of col_set_fmt_time() by
not exporting it any more.

svn path=/trunk/; revision=40743
2012-01-28 02:21:03 +00:00
Jeff Morriss 98d51466e5 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6712 :
Since SMPP knows the time zone of its (absolute) times and since we don't
have access to a mktime() routine that doesn't take into account the local
time zone (and since I don't think repeatedly setting the TZ environment
variable is a healthy choice):

1) subtract the 'timezone' (or '_timezone' on Windows) back out after calling
   mktime()
2) then adjust the time to take into the protocol-specified time zone
3) and (finally) display the time in UTC (since we don't have the
   infrastructure to display it in the protocol-specified time zone).

(I *think* (1) is portable: POSIX says that variable should exist...)

svn path=/trunk/; revision=40742
2012-01-27 22:59:25 +00:00
Anders Broman 48f70baa03 From Mike Morrin:
The gsmtap patch related to
Add dissectors for GSM and UMTS Cell Broadcast protocols.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770

svn path=/trunk/; revision=40738
2012-01-26 23:13:31 +00:00