osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
41347 commits 26 branches 0 tags 795 MiB
Commit graph

50 commits

Author SHA1 Message Date
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
pascal
736627bb97 Attempt to fix clang warnings (dead assignment and dereference of null pointer) 
svn path=/trunk/; revision=42389
 2012-05-02 20:40:49 +00:00
Jakub Zawadzki
68ec58d385 Fix some: 'cast discards qualifiers from pointer target type' warnings 
- Add const qualifier
- Remove some strange casts

svn path=/trunk/; revision=42131
 2012-04-18 12:35:36 +00:00
Martin Mathieson
2b13fcbb2c Set the extent of IR, IR-DYN and feedback packet types. 
Make some fields display and HEX and DEC.

svn path=/trunk/; revision=41881
 2012-04-01 14:55:40 +00:00
Bill Meier
01154ebca4 proto_reg_handoff...() doesn't need 'if(!Initialized)'; 
Also: Do some whitespace cleanup.

svn path=/trunk/; revision=41088
 2012-02-20 22:00:50 +00:00
Michael Tüxen
7b368e3895 Remove redundant (). 
svn path=/trunk/; revision=40719
 2012-01-25 16:43:04 +00:00
Anders Broman
4caa84610d Restructure the code abit. 
svn path=/trunk/; revision=40700
 2012-01-24 19:16:32 +00:00
Jeff Morriss
dc0ad2aac7 Revert 40675 and set 'protocol' appropriately when IPv6 is used. 
Initialize it to something other than UDP if we can't determine the protocol.

Reindent parts of the subject function.
Replace tabs with spaces (for consistency).
Remove trailing white space.

svn path=/trunk/; revision=40677
 2012-01-23 22:37:53 +00:00
Jeff Morriss
4e7f5c2e8f Initialize 'protocol' to something, at least until it can be properly assigned in the IPv6 and default cases. 
svn path=/trunk/; revision=40675
 2012-01-23 22:20:15 +00:00
Anders Broman
4e30aece3a Only continue dissection if protocol is UDP. 
svn path=/trunk/; revision=40673
 2012-01-23 21:13:10 +00:00
Anders Broman
088723a512 From Pascal Quantin: 
Use the private data if available, call the data dissector for data.

svn path=/trunk/; revision=40663
 2012-01-23 19:10:50 +00:00
Chris Maynard
0733183dc2 Fix Coverity CID 1370: UNREACHABLE by deleting erroneous break; 
svn path=/trunk/; revision=40608
 2012-01-20 18:35:56 +00:00
Jörg Mayer
64ddaef37b Fix: 
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-rohc.c: In function ‘dissect_rohc_ir_rtp_profile_dynamic’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-rohc.c:775:21: error: variable ‘cc’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors



svn path=/trunk/; revision=40593
 2012-01-19 22:18:06 +00:00
Anders Broman
61b3c117a1 Update comments and dissection of comptessed lists 
svn path=/trunk/; revision=40589
 2012-01-19 19:43:02 +00:00
Anders Broman
0299bdbc62 Add more to dissect_compressed_list() 
svn path=/trunk/; revision=40560
 2012-01-17 21:27:48 +00:00
Jörg Mayer
2428b75969 Fix warning about a variable that is written to only. 
svn path=/trunk/; revision=40559
 2012-01-17 18:27:01 +00:00
Martin Mathieson
914f06e618 Mark a couple of unused parameters as such. 
svn path=/trunk/; revision=40558
 2012-01-17 18:23:11 +00:00
Anders Broman
32c759745a Enhance dissection of compressed lists. 
svn path=/trunk/; revision=40557
 2012-01-17 17:57:52 +00:00
Martin Mathieson
30d4a0dc7e Simplify key for cid->context hash table. Copy more details between contexts when updating. 
svn path=/trunk/; revision=40403
 2012-01-07 02:50:37 +00:00
Jörg Mayer
b7356ab3cd Fix: packet-rohc.c:439:20: error: variable ‘PS’ set but not used [-Werror=unused-but-set-variable] 
svn path=/trunk/; revision=40394
 2012-01-06 10:11:30 +00:00
Chris Maynard
95ff0e0999 Fix Coverity CID's 1348-1349: UNUSED_VALUE and CID 1344: CONSTANT_EXPRESSION_RESULT. 
svn path=/trunk/; revision=40391
 2012-01-05 19:14:54 +00:00
Martin Mathieson
21a7e5cc13 - Add the beginning of compressed list handling. 
- Will at least skip the single byte if there is nothing in the list.
    - Checks that the intended encoding type (ET) is found
    - Need to call from lots of places
- Pass correct subtree for feedback items (was passing NULL so items weren't there)
- show SNs as decimal
- remove a few stray tabs
- fix a typo

Still need to port some parts from packet-pdcp-lte.c that aren't handled (e.g. UO_0).  And the context lookup seems broken (at least for IxCatapult logs).

svn path=/trunk/; revision=40388
 2012-01-05 17:40:41 +00:00
Anders Broman
1b98cbfe97 Use a hash table to gather information from IR packets and store it in per-packet-data. 
svn path=/trunk/; revision=40362
 2012-01-03 22:08:13 +00:00
Chris Maynard
ec24a7f89b Fix Coverity CID's 1339 and 1340: UNUSED_VALUE. 
svn path=/trunk/; revision=40241
 2011-12-18 16:38:31 +00:00
Anders Broman
a106a9047a Call the rohc dissector directly, the code will be cleaned up 
in the next weeks or so.

svn path=/trunk/; revision=40213
 2011-12-15 20:22:54 +00:00
Anders Broman
b2678b43d1 From Per Liedberg: 
RoHC dissection improvment.

svn path=/trunk/; revision=40210
 2011-12-15 17:28:43 +00:00
Bill Meier
63c71a7090 Use consistent indentation. 
svn path=/trunk/; revision=40191
 2011-12-13 23:47:47 +00:00
Martin Mathieson
70e2a50ad1 Initialise 'sub_tree' to NULL, to avoid warnings about possibly using 
uninitialised.  The warnings are bogus, but could have been avoided, as the test
to see if we're using a compression profile is redundant/will always be TRUE
in those functions...

Also removed some unnecessary braces from switch cases (no local variables were defined).

svn path=/trunk/; revision=40181
 2011-12-13 19:46:24 +00:00
Anders Broman
d47335b133 From Per Liedberg: 
RoHC dissection improvment.

svn path=/trunk/; revision=40177
 2011-12-13 17:13:50 +00:00
Anders Broman
9d0fa5cfcb - Change the tree layout to mimic packet-pdcp-lte.c 
- Add IPv6 static chain dissectoin
- Part of IPv6 dynamic chain dissectoin

svn path=/trunk/; revision=40156
 2011-12-12 06:58:37 +00:00
Anders Broman
86117b6a9f 607: warning: unused variable 'd' 
svn path=/trunk/; revision=40148
 2011-12-10 13:09:17 +00:00
Anders Broman
8f480def7c Dissect the whole IR dyn packet in packet-rohc.c 
svn path=/trunk/; revision=40147
 2011-12-10 12:50:05 +00:00
Guy Harris
f70480894c Get rid of unused variable. 
Fix a comparison.

svn path=/trunk/; revision=40137
 2011-12-09 20:28:12 +00:00
Anders Broman
08ca01b2a4 Dissect the whole IR packet in packet-rohc.c 
svn path=/trunk/; revision=40135
 2011-12-09 18:58:26 +00:00
Anders Broman
1372c03cf3 Use correct offset. 
svn path=/trunk/; revision=40125
 2011-12-09 06:16:07 +00:00
Guy Harris
3f199f793a Move the definition of enum rohc_mode into packet-rohc.h. 
Have packet-pdcp-lte.h include packet-rohc.h to pick up that definition.

Get rid of now-no-longer-necessary includes.

svn path=/trunk/; revision=40123
 2011-12-09 02:34:53 +00:00
Guy Harris
9242ce10c3 packet-pdcp-lte.h defines "enum rohc_mode", and packet-rohc.h uses it, 
so include packet-pdcp-lte.h first.

Get rid of extra definition of "enum rohc_mode".

svn path=/trunk/; revision=40122
 2011-12-09 00:59:47 +00:00
Anders Broman
f6dbd0863e Start using functions from packet-rohc.c 
svn path=/trunk/; revision=40120
 2011-12-08 21:45:35 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier
4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
 2011-10-06 03:35:44 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Jeff Morriss
339136d1d0 Based on patch from Denis Ovsienko via 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 :

Fix typo: s/unkown/unknown/

svn path=/trunk/; revision=38561
 2011-08-16 13:16:33 +00:00
Bill Meier
2bf572bc41 Remove unneeded #includes: proto.h,tvbuff.h,value_string.h,stdlib.h,... 
svn path=/trunk/; revision=38413
 2011-08-08 17:59:32 +00:00
Chris Maynard
24644ea58a Fix two cases of comparisons begin made against incorrect values following a 
mask operation.  Also, initialize g_rohc_info if pinfo->packet_data is !NULL.
Fixes Coverity ID's 1187, 1188 and 1190.

svn path=/trunk/; revision=37042
 2011-05-10 15:37:06 +00:00
Stig Bjørlykke
9739656c71 Make it build. 
svn path=/trunk/; revision=36697
 2011-04-18 15:27:27 +00:00
Anders Broman
9f2e70aad5 Start merging from packet-pdcp-lte.c 
svn path=/trunk/; revision=36696
 2011-04-18 14:38:18 +00:00
Anders Broman
c63471823d Try to make the OSX buildbot happy. 
svn path=/trunk/; revision=36669
 2011-04-16 17:32:30 +00:00
Stig Bjørlykke
1bc2077b3e Initialize feedback_data_len to avoid a compiler warning. 
svn path=/trunk/; revision=36666
 2011-04-16 16:37:53 +00:00
Anders Broman
6a0cbfbce8 Fix: 
packet-rohc.c: In function 'dissect_rohc_ir_rtp_profile_dynamic':
packet-rohc.c:285: warning: 'val_len' may be used uninitialized in this function
packet-rohc.c:186: warning: 'num_bits' may be used uninitialized in this function
packet-rohc.c:186: note: 'num_bits' was declared here

svn path=/trunk/; revision=36663
 2011-04-16 12:28:03 +00:00
Anders Broman
0a1437bfac Add a basic ROCH dissector. 
Limitations:
- Small CID
- RTP profile
- IPv4

svn path=/trunk/; revision=36659
 2011-04-16 11:44:05 +00:00