Commit Graph

257 Commits

Author SHA1 Message Date
Bill Meier 160bee8c16 The Styleguide section has been moved to the Wireshark Developer's Guide.
svn path=/trunk/; revision=35214
2010-12-17 20:55:45 +00:00
Bill Meier 2798debd90 Update the "Following Conversations" section to use se_alloc() instead of GMemChunks.
Also: add information about the conversation_set_dissector() function.

svn path=/trunk/; revision=35185
2010-12-14 14:23:27 +00:00
Bill Meier 2041f87240 Add some info about extended value string to section 1.7.1
svn path=/trunk/; revision=34621
2010-10-22 15:00:37 +00:00
Bill Meier 15851701e8 Rework "extended value strings":
- Allow direct access when a range of values begins with a value other than 0;
- Provide value_string_ext_new() for creating extended value strings at runtime;
- Do access to value_string_ext members via a macro (all but value_string.c);
- Update documentation.

svn path=/trunk/; revision=34514
2010-10-14 17:50:35 +00:00
Jeff Morriss 2a0128c258 Document what prefs_register_string_preference() does with your value pointer.
svn path=/trunk/; revision=33873
2010-08-21 03:54:55 +00:00
Bill Meier 432cfde19c Remove an incorrect line of code from the proto_reg_hanoff prototype.
svn path=/trunk/; revision=33790
2010-08-12 20:05:41 +00:00
Guy Harris f0bb5f4c9a Fix grammaro, indent example code.
svn path=/trunk/; revision=33641
2010-07-27 01:19:06 +00:00
Guy Harris 9f4c3409b2 Tell people to be careful about loops like
for (guint8 = 0; guint8 < guint; guint8++)

(one of which recently caused an infinite loop with a fuzzed packet in
the buildbot).

svn path=/trunk/; revision=33639
2010-07-27 01:06:10 +00:00
Stig Bjørlykke c7ed9aa2b8 Update to reflect changes in defines: REP_* > ENC_*
svn path=/trunk/; revision=33286
2010-06-22 11:54:45 +00:00
Guy Harris 7da29cfe69 Put in a warning about the <stdarg.h> problem that I just found and
fixed in one place (and am now fixing in some other places).

svn path=/trunk/; revision=32962
2010-05-26 02:21:23 +00:00
Bill Meier 9bafe20643 Minor rewording; Also: add note to not use "" for a hf[] array blurb.
svn path=/trunk/; revision=32940
2010-05-25 00:00:58 +00:00
Guy Harris 1b444c55fd Refer to the endianness arguments as "encoding" rather than
"representation" - we already use "representation" to refer to the text
representation of fields.

Change some routines with an endianness argument to make it a
representation argument instead; 

svn path=/trunk/; revision=32929
2010-05-24 06:06:17 +00:00
Guy Harris 5e8cbc60d4 Use the new REP_ values for proto_tree_add_item().
svn path=/trunk/; revision=32925
2010-05-24 03:05:19 +00:00
Anders Broman be717625ff Describe values_string_ext.
svn path=/trunk/; revision=32916
2010-05-23 10:00:50 +00:00
Jeff Morriss 37abd28d34 Document find_or_create_conversation()
svn path=/trunk/; revision=32792
2010-05-13 18:57:41 +00:00
Stephen Fisher 63a9ceeb6c Change copyright date in sample dissector code to 201x from 200x for the
new decade.


svn path=/trunk/; revision=32553
2010-04-25 08:23:12 +00:00
Jeff Morriss 6c5201f39a 64-bit integers take the same FIELDDISPLAY as shorter integers
svn path=/trunk/; revision=32551
2010-04-24 14:53:30 +00:00
Bill Meier e635180aeb (Trivial changes)
svn path=/trunk/; revision=32497
2010-04-16 17:28:03 +00:00
Bill Meier e740706aeb Updates:
1. Include stdio.h, stdlib.h and string.h only if needed;
2. Add dissector source filename to epan/CMakeLists.txt as well as 
   epan/Makefile.common.

svn path=/trunk/; revision=32495
2010-04-16 16:37:31 +00:00
Guy Harris fd29d27282 Rename FIELDBASE to FIELDDISPLAY, as it's a "how to display this"
indication, not necessarily a base (the base is "how to display" some
numeric fields, but it's not how to display some other fields).

Note that FIELDDISPLAY is the number of bits in the field containing an
FT_BOOLEAN bitfield.

svn path=/trunk/; revision=32480
2010-04-15 20:54:27 +00:00
Bill Meier b92603b395 Fix a typo
svn path=/trunk/; revision=32475
2010-04-15 19:33:33 +00:00
Guy Harris 500eb99cd9 Add a third date format, ABSOLUTE_TIME_DOY_UTC, to show UTC with the
date as YYYY/DDD, where DDD is a 1-origin day of year.  Move the formats
to a "time_fmt.h" file, included by the headers that use it.  Have
abs_time_to_str() and abs_time_secs_to_str() take the date format value,
rather than a Boolean "show this as UTC" flag, as an argument.  Document
the ABSOLUTE_TIME_ formats a bit better.  Use that format in the CCSDS
and VCDU dissectors, rather than having those dissectors do the
formatting themselves.

svn path=/trunk/; revision=32034
2010-02-27 19:01:27 +00:00
Bill Meier f7440d43e4 Add note about not using C99 features.
svn path=/trunk/; revision=31933
2010-02-20 17:36:18 +00:00
Guy Harris 94b8c6433b Rewrite the bit about null vs. non-null "tree" dissector arguments a
bit, so as not to imply that there's some form of global "mode"
Wireshark is in when it passes a null or non-null pointer (there isn't),
and to explicitly note that there is *no* guarantee about the value of
"tree" on the first call to the dissector.  (I.e., please do not build a
mental model of how Wireshark works in that regard, and write your
dissector based on that mental model - you *will* be wrong.)

svn path=/trunk/; revision=31560
2010-01-18 23:21:13 +00:00
Guy Harris 8e236e55de For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.

svn path=/trunk/; revision=31319
2009-12-19 03:17:44 +00:00
Guy Harris ed9f7440e3 Clarify that BASE_RANGE_STRING is a flag set in the display field, not
itself a valid value for that field - it should be ORed with a value.

Indicate that it will never be possible to record in a header_field_info
a byte order for all fields, as some protocols do not specify the
endianness of fields (for example, DCE RPC uses "receiver makes it
right", with the sender sending data in its byte order, with an
indication in the packet of what that byte order is).

svn path=/trunk/; revision=31248
2009-12-12 02:33:16 +00:00
Jaap Keuter 6af0e4e002 From Richard Pecl:
Adding prefs_register_protocol_subtree to libwireshark.def

svn path=/trunk/; revision=31246
2009-12-11 17:35:10 +00:00
Guy Harris 0551d2edf8 From Nemeth Marton: in an example of a valid (at least at the C language
level) way to handle passing the result of strlen() to a routine
expecting a int-sized value, mark it as "OK", not "Compiler warning".

svn path=/trunk/; revision=30747
2009-10-28 18:19:54 +00:00
Bill Meier 7b58b17af7 Update: Remove references to the use of check_col() since no longer required.
svn path=/trunk/; revision=29897
2009-09-14 15:28:09 +00:00
Kovarththanan Rajaratnam 49930eff58 We don't use PRId64, PRIu64, PRIx64, PRIX64, and PRIo64 internally in Wireshark, so don't encourage people to use them. Use G_GINT64_FORMAT + friends instead.
svn path=/trunk/; revision=29636
2009-08-31 18:28:10 +00:00
Bill Meier cfde59d509 From dragonlinux AT gmail.com: Fix incorrect location of a right brace;
svn path=/trunk/; revision=29565
2009-08-26 16:39:34 +00:00
Bill Meier 89a44fcd36 Fix a typo
svn path=/trunk/; revision=29241
2009-07-29 23:18:34 +00:00
Stig Bjørlykke 884ef57f1e From Kovarththanan Rajaratnam:
Update to include the new constraints.

svn path=/trunk/; revision=29015
2009-07-08 08:04:30 +00:00
Guy Harris d5289354ab Recommend the expert mechanism, rather than DISSECTOR_ASSERT(), for
checks that really check whether the packet is valid; DISSECTOR_ASSERT()
should only be used for cases where the dissector is making an
assumption about its internal state.

svn path=/trunk/; revision=29006
2009-07-08 00:57:01 +00:00
Anders Broman 568054f777 From Kovarththanan Rajaratnam:
More "Cleanup header_field_info definitions"

svn path=/trunk/; revision=28961
2009-07-06 18:35:05 +00:00
Stig Bjørlykke 9dd57bd754 Use NULL for empty blurb.
svn path=/trunk/; revision=28846
2009-06-26 03:24:08 +00:00
Guy Harris ec5dbeca71 Note that non-ASCII characters in source files cause problems.
svn path=/trunk/; revision=28742
2009-06-15 16:54:07 +00:00
Guy Harris 5dadbecd97 Fix tpyo.
svn path=/trunk/; revision=28708
2009-06-11 17:25:57 +00:00
Stig Bjørlykke 76dfdd6d6f Update the GPL statement used in dissectors.
svn path=/trunk/; revision=28695
2009-06-11 10:29:34 +00:00
Jaap Keuter 8e6cd9ba37 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark documentation.

svn path=/trunk/; revision=28242
2009-05-02 06:43:24 +00:00
Gerald Combs 31a7e6f676 Add a note about LLP64 portability.
svn path=/trunk/; revision=28080
2009-04-17 20:58:18 +00:00
Gerald Combs 446d43351c Add initial support for string buffers - ep_allocated, growable strings
similar to GLib's GStrings. Use them to create the list of TCP flags.

svn path=/trunk/; revision=27872
2009-03-27 23:05:37 +00:00
Stephen Fisher 1a71ec7c45 Introduce two new functions:
tvb_get_seasonal_string();
  tvb_get_seasonal_stringz();

.. which work the same as the ephemeral versions of the functions, but use
se_alloc() instead of ep_alloc().


svn path=/trunk/; revision=27868
2009-03-27 19:40:23 +00:00
Bill Meier 58f69d7383 Trivial spacing change
svn path=/trunk/; revision=27376
2009-02-05 15:49:52 +00:00
Bill Meier c7450a6a89 Update the description & skeleton code for the use of proto_reg_handoff.
svn path=/trunk/; revision=27239
2009-01-15 16:52:15 +00:00
Stephen Fisher 45ef29a0a8 Wrap "USA." in the address of the FSF onto a new line with a * in front of it.
svn path=/trunk/; revision=26801
2008-11-18 05:15:10 +00:00
Jaap Keuter f1db2a5e83 Update tabsize, re-group bitfield proto_tree functions, extend fieldinfo macro descriptions.
svn path=/trunk/; revision=26667
2008-11-01 14:31:43 +00:00
Bill Meier 6bfb1a0cde Add tvb_bytes_to_str() & tvb_bytes_to_str_punct(); fix a few typos.
svn path=/trunk/; revision=26519
2008-10-23 00:19:58 +00:00
Jaap Keuter 00f08adddb Polish up the proto_tree_add_bitmask() description example.
svn path=/trunk/; revision=26249
2008-09-22 22:15:26 +00:00
Jaap Keuter cc692da997 Fix for bug 2889:
Add description of FT_UINT_BYTES.

svn path=/trunk/; revision=26248
2008-09-22 21:53:44 +00:00