"mysql_handle" doesn't need to be static.
"is_response" is really a Boolean; make it a gboolean.
Get rid of some unused variables.
svn path=/trunk/; revision=6944
Source-Active TLV should be based on the length of the Source-Active
TLV, not on the length of the data remaining in the tvbuff.
The length of an (S,G) block is 12 bytes, not 24 bytes.
svn path=/trunk/; revision=6943
error packets, the copy of the packet that got the error, rather than
doing it in the CLNP dissector and the ICMP dissector and the ICMPv6
dissector and the PPP dissector for various control protocols; have it
do that work iff "pinfo->in_error_pkt" is set.
svn path=/trunk/; revision=6942
state of the columns and the current protocol, and restore them when
done. Also, cache BoundsError and, if we get a BoundsError, restore
them and then re-throw the BoundsError, so we see a "Short Frame"
indication if the frame was cut off by the snapshot length.
svn path=/trunk/; revision=6941
fix a padding issue and a problem where the spec appears to give
the size of the AFP session token length incorrectly (changed to
match what's captured, not what the spec says);
provide more verbose messages in the Info column and decode more
parameters for login packets.
svn path=/trunk/; revision=6938
seconds as well as for UNIX-style date/time stamps.
FT_ABSOLUTE_TIME fields don't have a base, so use BASE_NONE.
Make hf_afs_fs_callback_expires an FT_RELATIVE_TIME, as it's a relative
time not an absolute UNIX time.
svn path=/trunk/; revision=6937
Undo change to dissect_doserror() and dissect_ntstatus() made in
revision 1.42 as it breaks the display of rpc errors in COL_INFO.
svn path=/trunk/; revision=6934
versa, into "filter_dialog_new()", rather than replicating it in a
couple of routines.
The return value of "display_filter_construct_cb()" isn't used for
anything, it's ignored by most callers and stored but subsequently
ignored by io_stat.c; get rid of the return value, and don't bother
storing it in io_stat.c.
Before destroying a filter dialog box associated with a button being
destroyed, break the association.
Get rid of an unused variable in io_stat.c.
svn path=/trunk/; revision=6931
"destroy" signal handler for any button that pops up a filter; if the
button has a filter dialog box associated with it, it destroys that
dialog box.
Have the routines that create filter dialog boxes asociate the dialog
box with the button that created it, so that if the button is destroyed
the filter dialog box can be destroyed as well, and associate the button
with the dialog box.
This means that if a dialog box has a button to create a filter, we no
longer have to have the destroy handler for the dialog box destroy any
filters - that'll happen when the button in the dialog box is destroyed
as part of the process of destroying the dialog box.
Don't make the "Filter" buttons in the io_stat dialog box insensitive if
there's already a filter dialog box open - we can have more than one
open per dialog box.
svn path=/trunk/; revision=6930
Move SCTP payload protocol IDs to a header file, and get the PPIDs from
that header file rather than defining them in dissectors running atop
SCTP. Use both the old(?) and official PPID for ASAP.
svn path=/trunk/; revision=6926
indicates the subtype of an "Internetwork analyzer" capture; we've seen
only one such capture, and it was a frame relay capture, so we just wire
it to frame relay for now.
svn path=/trunk/; revision=6923
header, if present.
Don't explicitly base the length of the subset we hand to the PPP
dissector on the length in the header, as it might not be present;
instead, just use -1 for the lengths, as we set the length of our tvbuff
if there's a length in the L2TP header.
Set the length of the L2TP top-level protocol item for data packets, so
it covers the L2TP header but not the packet data.
Don't put a padding item into the tree if there's no padding.
svn path=/trunk/; revision=6922
as you dissect it, so we can dissect packets that are cut short before
the end of an IP header.
Check for an IP total length less than the header length.
svn path=/trunk/; revision=6921
- Decoders for the few remaining FC protocols not included in my first
patch. Included in this list are decoders for FC-CT (common transport),
Name Server (dNS), Fabric Configuration Server (FCS) and Zone Server
(FZS).
- Decoder for MDS Debug Port Adapter. MDS Debug Port Adapter (internal
name was Boardwalk and this is the file name) is a piece of hardware
that can be purchased with Cisco's MDS Fibre Channel switches that
converts FC frames into Ethernet frames. One end is connected to a
port on a FC switch and the other end is connected to a FE/GE Ethernet
port. The decoder included here decodes the encapsulation header that
carries information such as SOF/EOF of FC frames.
svn path=/trunk/; revision=6919
* Break up dissection into separate functions
* Added families not already present (based on GAIM source code)
* Added entries from the "generic" family not already present
* Started to break families and subtypes into constants instead of
having hardcoded values (signon and generic are done, others in
progress)
svn path=/trunk/; revision=6917
just Ethernet type values. Move the type value for ISO network-layer
protocols there, and put the type value for IEEE spanning tree there as
well, use that value in the BPDU dissector, and add an item to the CHDLC
dissector for it.
svn path=/trunk/; revision=6915
tree item, not with hf_nt_str. Get rid of hf_nt_str, as it's no longer
used.
Put ASCII strings into the protocol tree only once.
svn path=/trunk/; revision=6910
string; set it to the result of the "fake_unicode()" call, not to the
raw Unicode string. (Yes, we should have support for strings that don't
have 8-bit characters - and somehow handle strings in packets in
multiple character sets, e.g. ISO 8859/x and other EUC codes, the
Macintosh extended character set, various DOS/Windows code pages, and
Unicode - but we don't have it now.)
svn path=/trunk/; revision=6909
Deleted all the old crufy ndr pointer dissection. Hooray!
Next on the hit list is some refactoring of the ndr string
routines...
svn path=/trunk/; revision=6899
