Commit graph

8392 commits

Author SHA1 Message Date
Jaap Keuter
9af351f536 From Peter Kjellerstedt
The base64 decoder in epan_base64_decode() returns an incorrect length (one
byte too many) for three out of four base64 coded strings. Please apply the
attached patch to correct this.

svn path=/trunk/; revision=24654
2008-03-16 09:54:00 +00:00
Jaap Keuter
e2ee2bcab6 From Steve Karg:
Here is a modified patch that fixes the BACnet Schedule object Weekly_Schedule
decoding when an array index is used.  It also fixes the Priority_Array property 
when an array index is used.

svn path=/trunk/; revision=24653
2008-03-16 08:44:42 +00:00
Guy Harris
cd2d7e0a6d Map "dcp.*" preferences to "dccp.*".
svn path=/trunk/; revision=24652
2008-03-16 08:26:16 +00:00
Jeff Morriss
c84dbb230a From Chaskiel Grundman via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1556: patch to track afs requests by rx connection id
svn path=/trunk/; revision=24651
2008-03-16 01:38:11 +00:00
Jeff Morriss
d951728e6b Have started_with_special_privs() assert out if get_credential_info() was not
previously called.  This prevents the function from always returning TRUE in
programs that hadn't called get_credential_info().

Call get_credential_info() in the programs that should have been.

svn path=/trunk/; revision=24648
2008-03-16 00:32:12 +00:00
Guy Harris
6367e7c054 Oops, missed one name change.
svn path=/trunk/; revision=24647
2008-03-16 00:17:24 +00:00
Guy Harris
d589b0523b OK, now use DCCP rather than DCP for the Datagram Congestion Control
Protocol.  (Better late than never....)

svn path=/trunk/; revision=24646
2008-03-16 00:03:13 +00:00
Guy Harris
bcd666a74f Rename Distributed Checksum Clearinghouse protocol from "DCCP" to just
"DCC".  Googling for

	DCCP "Distributed Checksum Clearinghouse Protocol"

finds only hits related to Ethereal/Wireshark, either on the Ethereal or
Wireshark Web site, or on discussions where Datagram Congestion Control
Protocol developers were griping that Ethereal/Wireshark already used
DCCP for the Distributed Checksum Clearinghouse protocol.

Next step: fix the Datagram Congestion Control Protocol dissector.

svn path=/trunk/; revision=24645
2008-03-15 23:49:26 +00:00
Guy Harris
3cf6162f72 Get rid of a flag that's not used and that has no effect.
svn path=/trunk/; revision=24644
2008-03-15 23:01:12 +00:00
Jeff Morriss
689e8bd855 From http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1539 :
Hexadecimal and octal are unsigned.  Don't let dissectors register signed
fields (FT_INT*) to be displayed in hexadecimal (including HEX_DEC and DEC_HEX)
or octal.  Fix dissectors that do that mostly by changing the fields to
unsigned though in PANA it appears the fields are meant to be signed so
change those fields to be displayed in decimal.

This fixes an assertion crash in hfinfo_numeric_format() if/when someone tries
to create a filter using one of these mixed signed/unsigned fields (because
that routine does not know how to present the user with a signed value in
hex).

Also add FT_*INT64 to the "make sure it's not BASE_NONE" check.

svn path=/trunk/; revision=24643
2008-03-15 22:41:57 +00:00
Guy Harris
320c1117f6 Add a comment.
svn path=/trunk/; revision=24642
2008-03-15 20:14:29 +00:00
Gerald Combs
46bcad885a Check in the OS X packaging patch from bug 2341, since I've had
confirmation that the OS X package works on at least one system
other than my laptop.

svn path=/trunk/; revision=24640
2008-03-15 18:31:52 +00:00
Bill Meier
dca49accfa Fix trivial spelling error
svn path=/trunk/; revision=24639
2008-03-15 18:17:52 +00:00
Anders Broman
2fbd6fcf1f Add register_ber_oid_dissector to the exported functions.
svn path=/trunk/; revision=24638
2008-03-15 11:40:49 +00:00
Gerald Combs
7519d12f8f Make sure the Infiniband plugin is properly built and packaged.
svn path=/trunk/; revision=24634
2008-03-14 21:53:16 +00:00
Jaap Keuter
74178fafda From Dustin D. Trammell:
The FIX protocol dissector uses the 6 byte string "8=FIX." at the beginning of
the data to match the beginning of a FIX version string of the format
"8=FIX.x.x" in order to determine if the data is the FIX protocol or not.
With FIX 5.x and beyond, the beginning of the data will have a version string 
of the format "8=FIXT.x.x" to indicate the FIX Transport (FIXT) version.

A simple solution is to update the current FIX dissector to only match the
first 5 bytes of the version string (see attached patch).  This will cause a
match for FIX version 4.x and prior (8=FIX.x.x) as well as 5.x and beyond
(8=FIXT.x.x).

svn path=/trunk/; revision=24633
2008-03-14 21:36:01 +00:00
Stig Bjørlykke
ccf85f3195 Added check for length in heuristic check so we don't dissect unknown
TCP packets with less than 5 bytes data as a malformed XCSL packet.

svn path=/trunk/; revision=24630
2008-03-14 19:03:56 +00:00
Gerald Combs
68d23708bc From Stephen Donnelly via bug 2235:
This plugin implements a dissector for Infiniband. It is released 
under the GPL v2.

Rather than using say libpcap to capture raw (unframed) IP packets 
from near the top of an IPoIB stack, this plugin dissects link level
Infiniband frames.

Infiniband trace files can be read from Endace ERF format trace 
files, or from libpcap DLT_ERF files containing ERF TYPE_INFINIBAND 
records. There is currently no native DLT_INFINIBAND in libpcap.

Each record contains a hardware timestamp, capture metadata such as 
port Id, and a complete link level Infiniband frame starting from
the Local Route Header.

svn path=/trunk/; revision=24628
2008-03-14 17:47:53 +00:00
Jaap Keuter
14e0b8f792 From Dan Messinger:
The OSD APPEND command does not use the sort order field. Wireshark is decoding it.

svn path=/trunk/; revision=24627
2008-03-14 07:45:30 +00:00
Guy Harris
ef81118b2c Update documentation information.
svn path=/trunk/; revision=24624
2008-03-14 03:28:12 +00:00
Guy Harris
7cc6cfb7ad Update documentation links.
svn path=/trunk/; revision=24623
2008-03-14 03:23:36 +00:00
Gerald Combs
106968d7e8 From Hariharan Ananthakrishnan:
I have added two new display filters to support filtering based on LSP-ID and
hostname for ISIS protocol. 

svn path=/trunk/; revision=24621
2008-03-13 23:45:48 +00:00
Gerald Combs
f8e75ecd32 Make the SMI preference a little more verbose. In the COPS and SNMP
preferences, tell the user where they can change the SMI settings. In
the 802.11 preferences, fix a tooltip.

svn path=/trunk/; revision=24620
2008-03-13 22:17:11 +00:00
Jaap Keuter
7ef65a5df6 Partial fix for bug 2153
AMF object ID is in the lower 6 bits of the octet

svn path=/trunk/; revision=24619
2008-03-13 18:32:10 +00:00
Gerald Combs
fea0442105 Remove leftover debug code.
svn path=/trunk/; revision=24618
2008-03-13 14:45:52 +00:00
Martin Mathieson
6328b4471a Make SABP work over registered ports.
svn path=/trunk/; revision=24617
2008-03-13 11:54:06 +00:00
Gerald Combs
bf75c9eac6 sscanf() apparently handles negative input values, even when your
target is an unsigned int.  Adjust our bogus value check to match
the recent int -> guint change. Fixes bug 2355.

svn path=/trunk/; revision=24615
2008-03-13 05:24:21 +00:00
Stephen Fisher
7d8df3dee4 Save about 1MB of RAM that was wasted for the entire Wireshark session.
This is done by using dynamically allocated memory for tpncp field names
instead of relying on a static array of 256 bytes.  This makes a noticeable
difference because there are so many entries in tpncp/tpncp.dat.
 

svn path=/trunk/; revision=24614
2008-03-13 04:49:37 +00:00
Stig Bjørlykke
477b2c061a Fixed uint -> guint.
svn path=/trunk/; revision=24613
2008-03-12 21:43:37 +00:00
Jaap Keuter
4d3922952f Fix for bug 2344:
AMF number if a double, not a uint16.

svn path=/trunk/; revision=24612
2008-03-12 21:25:42 +00:00
Jörg Mayer
80140a78f5 + DHCP overload option parsing changes (triggered by bug 2194):
- The overloaded options are displayed at the same level as other options
  - The bootp file and server name options are displayed as overloaded if
    appropriate. To achieve this the bootp header parsing code needed to be
    moved to a later point.
+ Some signedness warning fixes.
+ Make a global variable (novell_string) static


svn path=/trunk/; revision=24611
2008-03-12 21:00:00 +00:00
Gerald Combs
b0f634c396 If we haven't found a handshake packet, say so.
svn path=/trunk/; revision=24605
2008-03-11 18:32:20 +00:00
Jaap Keuter
04e6c9f1dc From Dick Gooris:
The protocol is called Xcsl a TCP based and ASCII based protocol that is used
to control call generators. The Xcsl dissector decodes the Call Specification
Language.

svn path=/trunk/; revision=24601
2008-03-10 19:28:03 +00:00
Jaap Keuter
1987d5e3af Update comments.
svn path=/trunk/; revision=24600
2008-03-10 17:33:53 +00:00
Gerald Combs
9d2533aa25 Change the BSD-licensed written by CACE to BSD+GPL.
svn path=/trunk/; revision=24599
2008-03-10 17:20:15 +00:00
Martin Mathieson
8605cec511 Fix for bug 2328.
I can see this function is used in limited places.
I'm not sure if BASE_RANGE_STRING needs to masked out
of hfinfo->display in various other functions in proto.c.

svn path=/trunk/; revision=24598
2008-03-10 15:36:44 +00:00
Jaap Keuter
e1f488293a From Sami Farin:
Reads EMEM_CANARY_DATA_SIZE (15) bytes, compares return value to EMEM_CANARY_SIZE (8).
Also, I also added setbuf call in patch so it reads 15 bytes instead of 4096 or 8192.

svn path=/trunk/; revision=24596
2008-03-10 07:53:46 +00:00
Jeff Morriss
5ca9e9cbe8 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2009 : if the dissector told us how to format the representation of an item then indicate if we truncated it (we were already doing this if we formatted the representation). Do the same for FT_BYTES.
svn path=/trunk/; revision=24593
2008-03-09 14:50:14 +00:00
Stig Bjørlykke
aa9b4bf541 Add a const.
svn path=/trunk/; revision=24592
2008-03-09 14:20:28 +00:00
Stig Bjørlykke
9f412a5a8a Show VarBind OIDs and trap enterprise OID in info column.
Initialize pdu_type in dissect_snmp_PDUs() and param_tvb in
dissect_snmp_SnmpEngineID() to avoid potential crashes.

svn path=/trunk/; revision=24591
2008-03-09 13:58:58 +00:00
Jaap Keuter
dcc26d20dc Update almost year out of date file, with over 150 changes and over 1800 additions.
svn path=/trunk/; revision=24590
2008-03-09 12:33:43 +00:00
Stig Bjørlykke
3c6ecbf54b Corrected a typo: octestring -> octetstring.
svn path=/trunk/; revision=24589
2008-03-09 11:24:37 +00:00
Stig Bjørlykke
293e337c2b Display agent-addr as IPv4 address.
svn path=/trunk/; revision=24588
2008-03-09 10:54:55 +00:00
Jeff Morriss
0bb7de356a Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=383 : show multiple (pipelined) HTTP packets in the Info column.
svn path=/trunk/; revision=24586
2008-03-08 21:17:43 +00:00
Jeff Morriss
9c28399930 Add Id tag
svn path=/trunk/; revision=24584
2008-03-07 23:12:05 +00:00
Martin Mathieson
524f4c1611 Adjust the RTP heuristic dissector:
- loosen by accpepting dynamic payload type range
- tighten by only accepting even-numbered ports

svn path=/trunk/; revision=24583
2008-03-07 18:15:46 +00:00
Stig Bjørlykke
c714042d2f Updated to Version 2.0 Draft 6.
Removed unofficial port numbers.

svn path=/trunk/; revision=24582
2008-03-07 12:22:20 +00:00
Stig Bjørlykke
fdc980e79d Added an option to uat_new() to set if configuration shall be saved in the
selected profile.

Don't save SMI Paths and SMI Modules in the profiles because reloading
currently doesn't work (bug 2309).

svn path=/trunk/; revision=24580
2008-03-06 22:13:24 +00:00
Jeff Morriss
bde6848d5a From Florian Lohoff via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2320 : A new (heuristic) dissector for the RedBack Lawful Intercept Packet header.
svn path=/trunk/; revision=24579
2008-03-06 20:09:34 +00:00
Jeff Morriss
4bb245bf3d Make this dissector (which runs on a non-IANA-assigned port) a new-style dissector. Change some fprintf's to expert infos. Also reindent.
svn path=/trunk/; revision=24578
2008-03-06 19:39:26 +00:00