osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
34873 commits 26 branches 0 tags 795 MiB
Commit graph

1511 commits

Author SHA1 Message Date
Jeff Morriss
987e35df39 From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5406 : 
I attached a patch which fixes some problems in the array handling of OPC UA 
data when the array length is zero or -1 which is a Null-Array.

svn path=/trunk/; revision=34880
 2010-11-15 18:52:41 +00:00
Stig Bjørlykke
1f2f2e918e Simply use %c for printing char. 
svn path=/trunk/; revision=34789
 2010-11-05 09:59:40 +00:00
Stig Bjørlykke
75c2052a01 Fixed a printf modifier to remove a warning from clang. 
svn path=/trunk/; revision=34784
 2010-11-05 08:04:24 +00:00
Stig Bjørlykke
4b1be2be63 Remove some unused hf entries. 
svn path=/trunk/; revision=34549
 2010-10-17 20:57:11 +00:00
Stig Bjørlykke
333ef8b5b7 Removed unused hf_pn_dcp and hf_pn_ptcp. 
svn path=/trunk/; revision=34544
 2010-10-17 16:49:10 +00:00
Stig Bjørlykke
763e03b407 Removed unused hf_ecat_mailbox. 
svn path=/trunk/; revision=34543
 2010-10-17 16:43:07 +00:00
Jeff Morriss
7502bd4a8f From ToddS via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5300 : 
In the profinet plugin, the decoding of the MRP LinkUp and MRP LinkDown
messages is missing the MRP_SA field which garbles the decode of the rest of
the packet.

This fix adds the decoding of the MRP_SA field to the MRP LinkUp and MRP
LinkDown dissectors.

svn path=/trunk/; revision=34524
 2010-10-15 17:17:04 +00:00
Jeff Morriss
2d9d0900c5 From ToddS via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5299 : 
In profinet plugin, there is a dissection based on whether the read data
returned is expected to contain a single or multiple blocks. Currently, the
I&M0FilterData case assumes only a single block is returned. Profinet specifies
two optional additional blocks.

This change moves I&M0FilterData to expect multiple blocks to correct decode
the optional information.

svn path=/trunk/; revision=34523
 2010-10-15 17:10:29 +00:00
Anders Broman
5984fb4888 From Yu Zhang: 
MRP packet is not correctly parsed in PROFINET multiple write record request.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5267

svn path=/trunk/; revision=34358
 2010-10-04 06:16:45 +00:00
Guy Harris
ac3ac6c476 Plugins are not shared libraries, so: 
1) don't set thei SOVERSION - run-time-loaded modules don't have
	   an SOVERSION;

	2) build them with link mode MODULE, not SHARED, on all
	   platforms.

(Fixing 1) also fixes the problem with building them as MODULE on OS X.)

svn path=/trunk/; revision=34243
 2010-09-24 20:41:34 +00:00
Jaap Keuter
5025165845 Track offset even when tree==NULL. 
svn path=/trunk/; revision=34239
 2010-09-24 18:46:28 +00:00
Jeff Morriss
9ce0915786 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34231
 2010-09-24 02:55:52 +00:00
Jeff Morriss
0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34227
 2010-09-23 21:46:31 +00:00
Jörg Mayer
de68ad3066 H. Sivank <hsivank@gmail.com> 
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.


svn path=/trunk/; revision=34201
 2010-09-23 07:02:33 +00:00
Uwe Girlich
9a1c175692 interlink type is decimal 
some keyword substitution added

svn path=/trunk/; revision=34178
 2010-09-22 07:18:49 +00:00
Jeff Morriss
381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : 
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
 2010-09-21 03:14:49 +00:00
Bill Meier
7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[]; 
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
 2010-09-17 04:51:21 +00:00
Jeff Morriss
d2b84da490 prefs_register_string_preference() overwrites the given value pointer with a copy of the string. Since the string this dissector passes in is mallocated, keep a pointer to it and then free it after the pointer has been overwritten. 
svn path=/trunk/; revision=33872
 2010-08-21 03:44:36 +00:00
Bill Meier
e600394937 (Trivial) Use consistent indentation; Whitespace cleanup. 
svn path=/trunk/; revision=33788
 2010-08-12 16:27:16 +00:00
Bill Meier
32ea9657c8 Add new expansion.h file left out of the previous commit. 
svn path=/trunk/; revision=33787
 2010-08-12 15:58:01 +00:00
Bill Meier
ead0425688 From Don Newton: Added dissection of Expansion Module (KEM,GEM) messages to Unistim plugin. 
From me: Add expansion.h to list of .h files in Makefile.common;
         #include <stdio.h> not required.

svn path=/trunk/; revision=33786
 2010-08-12 15:47:31 +00:00
Jaap Keuter
ccf61ec3b2 From Don Newton: 
Fails to decrement msg_len on 3 different message types which causes the
dissector to attempt to decode an addition or misplaced unistim cmd.

svn path=/trunk/; revision=33643
 2010-07-27 06:46:00 +00:00
Guy Harris
75ffa6bb71 The only reason to escape "%" in a string is if you are, incorrectly, 
passing a string directly to a routine that expects a format string. 
The correct way to handle that is to pass "%s" as the string.

As long as you're escaping non-printable characters, just let
tvb_format_string() handle that.

For null-terminated strings, get the length of the string with
tvb_strsize(), and then just put the string into the protocol tree as a
regular item.

svn path=/trunk/; revision=33482
 2010-07-09 21:27:08 +00:00
Gerald Combs
bc9f8d0cd7 Add Visual C++ project files to the distribution. 
svn path=/trunk/; revision=33386
 2010-06-30 23:20:03 +00:00
Gerald Combs
423669df7d Back out r33088 for now. 
svn path=/trunk/; revision=33102
 2010-06-05 00:29:31 +00:00
Gerald Combs
d123b9e737 Add a checkapis target. 
svn path=/trunk/; revision=33092
 2010-06-04 19:49:12 +00:00
Gerald Combs
f6b2458924 From Matt Poduska via bug 1957 (with minor changes): 
New dissector (plugin) to support decode of the EPCglobal Low-Level Reader
protocol (see llrp.org for more information). This dissector has passed fuzz
testing.

svn path=/trunk/; revision=33088
 2010-06-04 18:45:02 +00:00
Guy Harris
1b444c55fd Refer to the endianness arguments as "encoding" rather than 
"representation" - we already use "representation" to refer to the text
representation of fields.

Change some routines with an endianness argument to make it a
representation argument instead; 

svn path=/trunk/; revision=32929
 2010-05-24 06:06:17 +00:00
Stig Bjørlykke
aa6dc5e692 Fixed warning "Field width should have type 'int'". 
svn path=/trunk/; revision=32909
 2010-05-20 14:53:29 +00:00
Jaap Keuter
eb6efdc4a4 Synchronize Makefiles even more. 
svn path=/trunk/; revision=32808
 2010-05-14 16:48:17 +00:00
Jeff Morriss
54082c6ed0 Add Cmake stuff to the source distribution so more people can try it out. 
svn path=/trunk/; revision=32807
 2010-05-14 16:27:03 +00:00
Guy Harris
998677339e Create a new REP_NA value for fields where there are no representations 
from which to choose; use that for protocol fields in some protocols
(modify the CORBA generator to use it, and manually update the generated
CORBA dissectors accordingly).

svn path=/trunk/; revision=32777
 2010-05-13 00:20:40 +00:00
Jeff Morriss
d85cc79af1 Add some information about how/why this dissector is (partially) machine-generated and what that means to Wireshark maintainers. 
svn path=/trunk/; revision=32577
 2010-04-27 13:50:43 +00:00
Jeff Morriss
85885007ef Make the OpcUa plugin's fields filterable (by giving them abbreviations). 
(Thank you, sed, for doing the 90% of the work for me.)

Note that two of these files says "do not modify" implying that they are
machine generated but AFAIK we don't have the means to rebuild them.

svn path=/trunk/; revision=32561
 2010-04-26 00:15:30 +00:00
Bill Meier
17b57d46d3 Simplify Makefile.nmake so that adding a new plugin to Makefile.nmake 
requires only adding the plugin (directory) name to a list of plugins.

svn path=/trunk/; revision=32516
 2010-04-19 14:38:20 +00:00
Jeff Morriss
b09f79f414 Be sure we initialize the p_id in hf's. This fixes 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3010 .

Also finish the implementation of ShowTimes for GOGs so that the variable gets
initialized (preventing another uninitialized variable warning from Valgrind).

svn path=/trunk/; revision=32465
 2010-04-14 18:39:00 +00:00
Jeff Morriss
ef2548d093 Fix up MATE's hf display values so MATE will actually run. 
svn path=/trunk/; revision=32464
 2010-04-14 14:20:16 +00:00
Anders Broman
e611923124 Get rid of check_col(). 
svn path=/trunk/; revision=32428
 2010-04-08 15:51:44 +00:00
Anders Broman
a10b76a99b Get rid of check_col(). 
svn path=/trunk/; revision=32426
 2010-04-08 15:21:07 +00:00
Bill Meier
5ccee6196a Remove some uneeded #includes 
svn path=/trunk/; revision=32419
 2010-04-07 18:24:18 +00:00
Anders Broman
846eed1d9e Get rid of check_col 
svn path=/trunk/; revision=32401
 2010-04-06 16:13:09 +00:00
Jeff Morriss
a2241bf7b8 Don't use %s as the format string in val_to_str(). 
svn path=/trunk/; revision=32400
 2010-04-06 15:45:11 +00:00
Jeff Morriss
8f21d5c167 Don't use %s as the format string in val_to_str(). This fixes the fuzz failure in bug 4646. 
svn path=/trunk/; revision=32398
 2010-04-06 13:40:06 +00:00
Guy Harris
252178ed7e The third argument to val_to_str() is a format string that gets passed 
the value that couldn't be mapped to a string - it's an integer and
needs to be printed with an integer format.  Fixes bug 4644.

svn path=/trunk/; revision=32396
 2010-04-06 02:49:18 +00:00
Anders Broman
7cfa27b04b Get rid of a bunch of check_col(). 
svn path=/trunk/; revision=32388
 2010-04-05 20:04:52 +00:00
Jaap Keuter
9c05bc3bc5 Make the test compile. 
svn path=/trunk/; revision=32359
 2010-04-02 06:03:44 +00:00
Anders Broman
dc5e066cae From sangaran: 
8-bit Bit Flag decoder method needed in wimaxasncp plugin dissecto.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4608

svn path=/trunk/; revision=32356
 2010-04-01 20:49:07 +00:00
Bill Meier
beb8d29ad6 From Richard Kümmel: Added the bitmasks for port 10 and port 11. 
From me: As per Richard: Fix definitions of the bitfield for hf_esl_crcerror and
hf_esl_alignerror.

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3677#c10


svn path=/trunk/; revision=32324
 2010-03-29 16:52:47 +00:00
Jörg Mayer
96779de920 cmake changes: 
- Add checking for linker flags
- Install plugins with the name including the Wireshark version.
  This will make it easier to find matching plugin versions if
  files get just copied over.


svn path=/trunk/; revision=32231
 2010-03-18 10:27:17 +00:00
Kovarththanan Rajaratnam
2dc49da00d Some if (tree) cleanup 
svn path=/trunk/; revision=32207
 2010-03-16 07:53:48 +00:00
Kovarththanan Rajaratnam
4d2163dd3b Avoid some dead assignments 
svn path=/trunk/; revision=32206
 2010-03-16 07:49:13 +00:00
Kovarththanan Rajaratnam
737d0b5549 Whitespace cleanup 
svn path=/trunk/; revision=32205
 2010-03-16 07:45:12 +00:00
Kovarththanan Rajaratnam
4296471220 Indicate width of parent bitfield 
svn path=/trunk/; revision=32204
 2010-03-16 07:43:17 +00:00
Kovarththanan Rajaratnam
850aba71ac Inline truth/false table 
svn path=/trunk/; revision=32203
 2010-03-16 07:36:00 +00:00
Uwe Girlich
c4d29dfd99 This adds a new dissector plugin: INTERLINK. This protocol is used in 
(real and simulated) BMW cars for all kinds of gadget communication.
My plugin only dissects the high level infrastructure and not any particular
messages. It uses a heuristic dissector to detect INTERLINK packets.

svn path=/trunk/; revision=32202
 2010-03-16 06:58:25 +00:00
Guy Harris
5535f4a598 Fix some compiler warnings, clean up indentation a bit. 
svn path=/trunk/; revision=32201
 2010-03-16 03:31:44 +00:00
Jörg Mayer
67072286bf - Remove the lib prefix for plugin names. 
- Remove a (resolved) comment.
- Add a commented out line how to add version infos to the
  plugin's file name.

svn path=/trunk/; revision=31995
 2010-02-24 22:32:10 +00:00
Stig Bjørlykke
25dcd066b6 From Hannes Diethelm via bug 4525: 
Corrected values for IdentInfo (which was obviously wrong)

svn path=/trunk/; revision=31978
 2010-02-24 08:22:33 +00:00
Bill Meier
c033a08313 Fix some gcc -Wshadow warnings. 
svn path=/trunk/; revision=31724
 2010-01-28 23:53:27 +00:00
Bill Meier
bb79476b22 Fix gcc -Wshadow warning; 
Move proto_register... and proto_reg_handoff... to the end of the file.

svn path=/trunk/; revision=31723
 2010-01-28 23:11:54 +00:00
Bill Meier
1341fcd87e Fix some gcc -Wshadow warnings. 
svn path=/trunk/; revision=31722
 2010-01-28 21:49:30 +00:00
Bill Meier
2ea1e1962f Fix gcc -Wshadow warning. 
svn path=/trunk/; revision=31721
 2010-01-28 19:58:48 +00:00
Anders Broman
440c3f9261 From Didier Gautheron: 
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
 2010-01-13 20:32:01 +00:00
Anders Broman
c4dd31cd87 From Didier Gautheron: 
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
 2010-01-13 20:25:10 +00:00
Bill Meier
de767f7dea Do some cleanup: 
- Separate .h file not req'd since not used elsewhere;
- Use bitmasks instead of using non-portable bitfields;
- Note possible incorrect display of crcError and alignError flags;
- Clean up spacing.

svn path=/trunk/; revision=31412
 2010-01-02 22:00:30 +00:00
Guy Harris
8e236e55de For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of 
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.

svn path=/trunk/; revision=31319
 2009-12-19 03:17:44 +00:00
Bill Meier
9587938020 From Martin Lutz: Patch tvb_memeql return check; 
... tvb_memeql returns 0 for truth.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3986#c7

svn path=/trunk/; revision=31294
 2009-12-17 16:22:50 +00:00
Jaap Keuter
0bd900a72b Fix header field names containing dots. 
Move excessive long texts to header field blurb.

svn path=/trunk/; revision=31207
 2009-12-08 22:05:55 +00:00
Gerasimos Dimitriadis
c840cdd5a0 Remove the address operator from value_string arrays fed to VALS() 
svn path=/trunk/; revision=30995
 2009-11-17 18:35:27 +00:00
Jörg Mayer
d2cc318f4f Beginnings of enabling static builds. Still to do: 
* Add -static
* Registration may need different handling
* Add plugins
* Build error in wslua

svn path=/trunk/; revision=30987
 2009-11-17 11:58:36 +00:00
Jörg Mayer
9ee31d1d0e cmake will now honor -Werror if configured (default: on) 
svn path=/trunk/; revision=30852
 2009-11-07 10:07:00 +00:00
Ulf Lamping
06e6441c9e add "reserved for profiles" comments 
svn path=/trunk/; revision=30811
 2009-11-04 00:07:54 +00:00
Anders Broman
03c3b66945 From Benjamin Meyer: 
UserData in Profinet ProcessAlarm declared as UserStructIdentifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4195

svn path=/trunk/; revision=30808
 2009-11-03 20:11:19 +00:00
Anders Broman
ecbe3c28f3 From Matthias FRANK: 
PROFIDrive parameter requests not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4193

svn path=/trunk/; revision=30804
 2009-11-03 12:30:59 +00:00
Anders Broman
d0a15b4473 From Matthias FRANK: 
PROFISafe F-Parameter record not decoded in PROFINET dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4192
From me remove check_col();

svn path=/trunk/; revision=30801
 2009-11-02 18:09:46 +00:00
Stig Bjørlykke
9e4549de12 The stats_tree plugin deserves a version number other than "0.0". 
svn path=/trunk/; revision=30706
 2009-10-26 09:29:46 +00:00
Jeff Morriss
762af05327 Don't call PROTO_ITEM_SET_GENERATED(proto_tree_add[...]): that will end up adding the item to the tree multiple times. 
svn path=/trunk/; revision=30635
 2009-10-20 14:03:00 +00:00
Stig Bjørlykke
a52bf035b7 Removed redundant redeclaration of delete_avpl(). 
svn path=/trunk/; revision=30618
 2009-10-19 14:42:10 +00:00
Stig Bjørlykke
8248955d7d Renamed tvb_new -> new_tvb to avoid name collision. 
svn path=/trunk/; revision=30617
 2009-10-19 14:36:26 +00:00
Stig Bjørlykke
ce502fc59b Added cast to (void *) for pointers used in printf format %p. 
svn path=/trunk/; revision=30614
 2009-10-19 13:24:54 +00:00
Stig Bjørlykke
d7ca2a6444 Initialize variables which may be used uninitialized. 
svn path=/trunk/; revision=30535
 2009-10-12 14:13:01 +00:00
Bill Meier
09393ee57d Replace GMemChunk usage with se_alloc(); 
Fixes memory leak for GLib > 2.8.

svn path=/trunk/; revision=30526
 2009-10-12 01:13:20 +00:00
Kovarththanan Rajaratnam
8b8399b711 Use register_dissector_files in the plugins dissectors 
svn path=/trunk/; revision=30435
 2009-10-09 16:39:34 +00:00
Kovarththanan Rajaratnam
6d93ca7c96 Use register_dissector_files in asn1 plugin 
svn path=/trunk/; revision=30434
 2009-10-09 16:33:16 +00:00
Anders Broman
4d2e653901 From Didier Gautheron: 
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107

svn path=/trunk/; revision=30415
 2009-10-09 07:24:33 +00:00
Stig Bjørlykke
c8605cc746 Don't include config.h in header files. 
svn path=/trunk/; revision=30382
 2009-10-07 06:28:36 +00:00
Stig Bjørlykke
cf85342eec Build plugins with cmake on OSX. 
svn path=/trunk/; revision=30373
 2009-10-06 18:58:09 +00:00
Anders Broman
b95ab896f7 From Benjamin Meyer: 
Profinet PDIRFrameData field FrameDetails not decoded
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4091

svn path=/trunk/; revision=30321
 2009-10-04 19:34:48 +00:00
Anders Broman
7bff8c664b From Benjamin Meyer: 
PROFINET DCP ResetFactorySettings not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4090

svn path=/trunk/; revision=30320
 2009-10-04 19:31:02 +00:00
Kovarththanan Rajaratnam
0721ade9ed Remove check_col() 
svn path=/trunk/; revision=30317
 2009-10-04 18:40:44 +00:00
Kovarththanan Rajaratnam
80f0d3116a Use G_N_ELEMENTS instead of hard coding size of array 
svn path=/trunk/; revision=30315
 2009-10-04 18:29:51 +00:00
Kovarththanan Rajaratnam
09932ce535 Constify wimax_mac_calc_crc8() 
svn path=/trunk/; revision=30314
 2009-10-04 18:26:01 +00:00
Kovarththanan Rajaratnam
0c860d2cd5 Constify wimax_mac_calc_crc16() 
svn path=/trunk/; revision=30313
 2009-10-04 18:22:36 +00:00
Kovarththanan Rajaratnam
70d977764c Constify wimax_mac_calc_crc32() 
svn path=/trunk/; revision=30309
 2009-10-04 17:21:45 +00:00
Kovarththanan Rajaratnam
c33111a841 Remove forward references 
svn path=/trunk/; revision=30308
 2009-10-04 17:12:42 +00:00
Kovarththanan Rajaratnam
86ca4a24b6 Move prototype to wimax_utils.h 
svn path=/trunk/; revision=30307
 2009-10-04 17:03:57 +00:00
Kovarththanan Rajaratnam
0bc65a23d0 Include wimax_utils.h 
svn path=/trunk/; revision=30306
 2009-10-04 16:57:04 +00:00
Guy Harris
0b17f67061 Until we either supply "yapp" or put "yapp" into the list of tools you 
need to install, don't include in Wireshark anything that requires "yapp".

svn path=/trunk/; revision=30154
 2009-09-25 20:05:16 +00:00
Jörg Mayer
cbc3d3f772 Try to add tpg, but it seems it doesn't build with autofoo either. 
svn path=/trunk/; revision=30151
 2009-09-25 18:09:42 +00:00
Jörg Mayer
72ea6d56d2 Forgot to commit the unistim cmakefile 
svn path=/trunk/; revision=30145
 2009-09-25 15:29:15 +00:00