Commit Graph

31 Commits

Author SHA1 Message Date
Martin Mathieson 1b8fccbc9d Don't create & leak a hash table during unsuccessful open()
svn path=/trunk/; revision=22150
2007-06-21 17:30:13 +00:00
Martin Mathieson 2d6388599a Work with isdn_l2.
svn path=/trunk/; revision=21986
2007-05-29 14:38:40 +00:00
Guy Harris 267a2cbf02 Print a gint64 the right way.
svn path=/trunk/; revision=21976
2007-05-29 06:16:24 +00:00
Sebastien Tandel 76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00
Jörg Mayer b7755fb4e4 Fix some (incorrect but unforseeable)
"might be used uninitialized" warnings.

svn path=/trunk/; revision=21862
2007-05-21 16:16:18 +00:00
Martin Mathieson 47a9c22ad4 mipv6 -> ip
svn path=/trunk/; revision=21741
2007-05-10 15:29:38 +00:00
Stephen Fisher bede68648b Fix some warnings on the Solaris buildbot
svn path=/trunk/; revision=21147
2007-03-23 05:50:31 +00:00
Martin Mathieson 997e5415f9 Add separate union entries to fvalue.value for signed and unsigned
32-bit numbers.  Separate signed and unsigned accessors have been
added and used where appropriate.

Definitely not for 0.99.5.

svn path=/trunk/; revision=20472
2007-01-18 11:02:26 +00:00
Martin Mathieson b9f69234ad Check in trivial changes before generating a big diff...
svn path=/trunk/; revision=20304
2007-01-04 13:25:25 +00:00
Ulf Lamping a339636b85 both recent fixes of warnings don't compile on Win32, inttypes.h is not available and PRId64 is not defined in the config.h.win32.
As discussed in a seperate thread the PRId64 should not be required.

svn path=/trunk/; revision=19925
2006-11-18 03:37:34 +00:00
Martin Mathieson 7712c21de5 Try to squash 2 more warnings seen on buildot
svn path=/trunk/; revision=19921
2006-11-17 16:33:43 +00:00
Martin Mathieson 2d58914f77 Fix possible build error + warnings seen on buildbot
svn path=/trunk/; revision=19892
2006-11-14 13:45:35 +00:00
Martin Mathieson 8e9a8430d8 - Use 64-bit indexes into file for packet locations (was previously casting index to and from void*) - this should allow very large files to be used
- The characters between the timestamp and start of data are almost always " l ", optimise memory usage in this case
- Rename hash table for clarity

svn path=/trunk/; revision=19891
2006-11-14 12:06:11 +00:00
Ulf Lamping 59d6c8ea33 change all file offsets from long to gint64 so we can - theoretically - handle files > 2GB correct.
Please distclean Win32 builds!

svn path=/trunk/; revision=19814
2006-11-05 22:46:44 +00:00
Martin Mathieson d55c609c55 - Fix problems with parsing sctpprim headers
- Add dissection of nbap (as encap or inside sctp primitive)

svn path=/trunk/; revision=19664
2006-10-23 17:22:20 +00:00
Martin Mathieson 3474ea868c - Add special case for reading strange encoding of ATM CID field
- Indicate direction of DCH Data in info column
- Assume EDCH payload CRC if 2 bytes are left over (previous test was broken)

svn path=/trunk/; revision=19405
2006-10-03 14:21:07 +00:00
Martin Mathieson 2e1177c328 For DCT2000, show better transport info:
- for FP over AAL2, add CID to AAL tree
- for IPPRIM protocols, show IPV4 addresses in src & dst columns

svn path=/trunk/; revision=19156
2006-09-05 16:05:23 +00:00
Martin Mathieson 76192b1c6c Partial implementation of UMTS FP. Currently only works with Catapult DCT2000 format files, as need extra information about packet when decoding. There are a few TODOs (notably E-DCH channels), but the current version gives OK coverage.
svn path=/trunk/; revision=19130
2006-09-04 11:04:14 +00:00
Martin Mathieson 4842aeab96 Wasn't allocating big enough frame buffer!
svn path=/trunk/; revision=18848
2006-08-07 17:08:11 +00:00
Martin Mathieson 229e2dfbde - Removes last traces of 'board ports only' preference (other than marking it as an obselete preference)
- Add a preference to try to find messages within sctp primitive messages (tries renaming of known mismatches)
- Add outhdr to stub protocol (getting ready for IuB FP)

svn path=/trunk/; revision=18818
2006-08-02 09:30:28 +00:00
Anders Broman 974fd085dc From Martin Mathieson:
Skips variant string bytes of dct2000 header when finding real packet 
data to dump.

svn path=/trunk/; revision=18458
2006-06-14 05:39:52 +00:00
Anders Broman 81bda938ff From Martin Mathieson:
This patch:
- treats the variant field as a variable-length string field.  This is 
needed for some of the more complicated protocols where the variant 
number of the embedded protocol is also represented

- the patch to Makefile.am was not applied from 
http://www.wireshark.org/lists/wireshark-dev/200606/msg00009.html

svn path=/trunk/; revision=18427
2006-06-11 08:26:55 +00:00
Anders Broman 1814821adc From Martin Mathieson:
- Many DCT2000 protocols can be embedded within an IP primitive 
message.  Add a heuristic to see if we can find the protocol payload 
within in IP primitive message, and look for an ethereal dissector 
matching the DCT2000 protocol name (this is useful for simple protocol 
testing where no physical links are involved)
- Make some more of these protocols (diameter, http, mgcp) findable by name
- Adds protocol 'variant' number to stub and dissector
- Break the duplicated writing of the stub header out into a separate 
function

svn path=/trunk/; revision=18212
2006-05-23 05:48:00 +00:00
Guy Harris 031773273c Squelch some compiler warnings (a time_t might be an int or a long).
svn path=/trunk/; revision=18188
2006-05-19 08:18:22 +00:00
Anders Broman de3b8195c5 From Martin Mathieson:
This patch should hopefully remove any possible buffer overflows in 
parse_line() as reported by the current Coverity scan.  I'm not sure 
that the error it currently reports is valid (I think its confused by 
supposing that a condition that is being tested can be true, whereas it 
can't...), but this patch fixes a number of potential problems remaining 
in the function.

svn path=/trunk/; revision=17979
2006-04-24 19:08:52 +00:00
Anders Broman 8dd0e70722 Fix CID: 150
svn path=/trunk/; revision=17968
2006-04-23 18:05:23 +00:00
Anders Broman b99bf25795 From Martin Mathieson:
Fix coverity bugs.

svn path=/trunk/; revision=17909
2006-04-19 18:57:25 +00:00
Anders Broman 375ba77274 From Martin Mathieson:
These patches:
- fix the bounds errors reported by coverity in bug 879
- fix a couple of other potential bounds errors (length checking 1st & 2nd lines in file)
- reorder catapult_dct2000_phdr so that normal protocol pseudo-header info is at the start.  This means that the stub dissector can avoid the nasty
(overlapped) memcpy
- a little whitespace fixing

svn path=/trunk/; revision=17886
2006-04-17 18:46:14 +00:00
Anders Broman 518732d903 From Martin Mathieson:
Please find a patch to catapult_dct2000.c:
- doesn't use g_hash_table_new_full(), which is missing from earlier versions of glib
- fixed a couple of memory leaks
- hopefully cast away a few warnings I saw on the fedora and solaris buildbot logs


svn path=/trunk/; revision=17867
2006-04-15 15:16:26 +00:00
Anders Broman 69ea88e3f7 SVN properties...
svn path=/trunk/; revision=17863
2006-04-14 13:08:41 +00:00
Anders Broman af554c2f75 From Martin Mathieson:
patch and new files provide support for Catapult DCT2000 
.out files to wiretap and ethereal.

This wiretap support (catapult_dct2000.c+h) appends a short header to 
each packet giving some context, and a corresponding ethereal dissector 
(packet-catapult-dct2000.c) parses this before passing the real payload 
onto an existing ethereal dissector (for ethernet, ip, lapd, ppp, 
frame-relay,...).

For now, there is only support for saving dct2000 files in their own 
format, although I may add support for converting between dct2000 and 
libpcap later.

updated version of these files and patch, now with support 
for MTP2.  Olivier's trace used the ANSI variant - the MTP2 and MTP3 
decode fine with the right preferences set (although the ISUP dissector 
reports a reserved/retired message type).

Witha a change to NOT to declare gboolean catapult_dct2000_board_ports_only;
as extern as MSVC choked on it.

svn path=/trunk/; revision=17862
2006-04-14 12:41:06 +00:00