Commit graph

16164 commits

Author SHA1 Message Date
Guy Harris
13a24cc310 There's no guarantee that BYTE_ORDER is defined as anything useful, and
the BYTE_ORDER == BIG_ENDIAN values for FMIP_HI_FLAG_ASSIGNED and
FMIP_HI_FLAG_BUFFER are bogus for the way they're used anyway (they're
used to check bits in a one-byte value), so throw away those values, and
get rid of the leading 00 in the BYTE_ORDER == LITTLE_ENDIAN values.

svn path=/trunk/; revision=16455
2005-11-10 03:16:25 +00:00
Guy Harris
177dc6902c Skip some toolbar #includes if we're not using GTK+ 2.x.
svn path=/trunk/; revision=16454
2005-11-10 03:00:43 +00:00
Guy Harris
17456c2e09 Include <unistd.h> if available, to get "close()" declared.
Update the big comment to reflect current reality.

svn path=/trunk/; revision=16453
2005-11-10 02:49:54 +00:00
Anders Broman
f86d2d458c From Andrei Emeltchenko
I have added new RTCP POC fields as OMA standard says. With some additions. 

svn path=/trunk/; revision=16452
2005-11-09 21:50:39 +00:00
Ronnie Sahlberg
4acbd6bcc9 add initial decode for SMB2_FS_INFO_01
svn path=/trunk/; revision=16451
2005-11-09 21:06:06 +00:00
Ronnie Sahlberg
d0a574078d add decode of SMB2_FS_INFO_05
svn path=/trunk/; revision=16450
2005-11-09 20:57:56 +00:00
Ronnie Sahlberg
005fbb5304 add decoding of the create request
svn path=/trunk/; revision=16449
2005-11-09 20:37:49 +00:00
Gerald Combs
f9d4caf148 From Stig Bjørlykke:
I just learned how easy it is to reassemble multiple UDP packets, so  I
had to implement this for the P_Mul protocol :)

This patch fixes:
* Reassemble multiple data packets
* Add packet length check
* Fix for PDU type in tree entry

svn path=/trunk/; revision=16448
2005-11-09 16:01:35 +00:00
Ronnie Sahlberg
8ba0aaf3a9 some more of the never ending stream of smb2 updates
svn path=/trunk/; revision=16447
2005-11-09 13:19:57 +00:00
Ronnie Sahlberg
2c0b087fde add decode of Write commands
svn path=/trunk/; revision=16446
2005-11-09 10:18:31 +00:00
Ronnie Sahlberg
d94d156a7a add support for Close and the new guess that the FID is present in the Find request.
Ohoy sailor,    we have spotted the concept of current working directory.

does this mean we also get rid of the silly 200-256 byte path length limitation?




svn path=/trunk/; revision=16445
2005-11-09 09:29:41 +00:00
Ronnie Sahlberg
a204fdaea7 dissect more of the SMB2/Close function
svn path=/trunk/; revision=16444
2005-11-09 09:14:11 +00:00
Guy Harris
03ac44a500 Remove comment that no longer applies.
If we get a getopt() error in the pre-scanning, quit - don't do all the
GUI stuff and re-scan the arguments (and print the error message twice).

svn path=/trunk/; revision=16443
2005-11-09 08:46:24 +00:00
Ulf Lamping
5fa59abfe4 Updated feature: When cancelling a file load operation...
svn path=/trunk/; revision=16442
2005-11-09 00:39:20 +00:00
Ulf Lamping
a10a0d2636 from Jaap Keuter:
Anyone having objections to idea of stopping the load of a capture file
i.s.o. cancelling it? I'm refering to WishList Data I/O item #6.
It seems a very reasonable idea and easy to implement.

I've done some extensions:
-Improve the corresponding comment on the implications why this is useful
-added a new simple_dialog text to explain what's really going on (simply using the WTAP truncated packet message was a bit misleading)

svn path=/trunk/; revision=16441
2005-11-08 22:24:53 +00:00
Anders Broman
2044d02bcb Move def of subid_t to format-oid.h don't include asn1.h in cops any more.
svn path=/trunk/; revision=16440
2005-11-08 22:18:06 +00:00
Ronnie Sahlberg
53ab6ed970 start dissecting SMB2_FILE_INFO_12
svn path=/trunk/; revision=16439
2005-11-08 21:16:36 +00:00
Gerald Combs
781f8051e5 From Peter Kovar: Fix the typo referenced in bug 577.
svn path=/trunk/; revision=16438
2005-11-08 15:28:15 +00:00
Gerald Combs
ba26efe7f1 Fix a cut-and-pasteo.
svn path=/trunk/; revision=16437
2005-11-08 15:23:20 +00:00
Gerald Combs
f2d2a624d8 You don't tug on Superman's cape. You don't spit into the wind.
You don't pull the mask off the old Lone Ranger, and you don't
overflow a guint8.  Fixes the infinite loop in bug 576.

Fix up whitespace.  Add an entry to the release notes.  Apologies
to Jim Croce.

svn path=/trunk/; revision=16436
2005-11-08 15:22:38 +00:00
Ronnie Sahlberg
6f2482bc9f dissect some of GetInfo requests and Replies
svn path=/trunk/; revision=16435
2005-11-08 09:20:04 +00:00
Ronnie Sahlberg
f8b4f34276 add a comment to keep the dissector in sync with the wiki
rename functions 0x10 and 0x11 to follow the names in the wiki



svn path=/trunk/; revision=16434
2005-11-08 08:53:55 +00:00
Ronnie Sahlberg
b46a5611ed add a pointer to the wiki for documentation of this protocol
svn path=/trunk/; revision=16433
2005-11-08 08:41:42 +00:00
Ronnie Sahlberg
40b13e337f add dissection of the known parts of negotiate protocol
svn path=/trunk/; revision=16432
2005-11-08 08:40:32 +00:00
Guy Harris
31a44d4bfc When using GCC, compile with -Wpointer-arith, to catch code that some
other C compilers can't handle.

svn path=/trunk/; revision=16431
2005-11-08 04:03:50 +00:00
Guy Harris
af00219b1b Use "proto_tree_add_item()", not "proto_tree_add_bytes()", if you're
just supplying the result of "tvb_get_ptr()" with the same tvbuff,
offset, and length as the byte array.

Get rid of an unused variable.

Set svn:keywords and svn:eol-style appropriately.

svn path=/trunk/; revision=16430
2005-11-07 22:50:34 +00:00
Gerald Combs
b1b1c50f1e Fix an ftsanity.py error.
svn path=/trunk/; revision=16429
2005-11-07 21:58:27 +00:00
Gerald Combs
062621786f Fix bug 575, from Menno Andriesse:
In two functions that call proto_tree_add_bytes I forgot the
  'tvb_get_ptr' function, the argument was 'FALSE' instead.  This gave
  a predictable 'NULL' pointer bug...

Fix an ftsanity.py error.  Fixup whitespace.


svn path=/trunk/; revision=16428
2005-11-07 21:54:08 +00:00
Ronnie Sahlberg
66d99c3eed begin dissecting the Find response packet
svn path=/trunk/; revision=16427
2005-11-07 21:19:59 +00:00
Guy Harris
6c521f90f5 The return value of tvb_get_ptr() is a const ptr; assign it to a const
ptr.

The answer to the question
"??????????????????????????????????????????????????????????????????" is
"No - the return value of tvb_get_ptr() is a reference, not an allocated
copy, and it cannot be freed and doesn't need to be freed."

svn path=/trunk/; revision=16426
2005-11-07 21:10:52 +00:00
Ronnie Sahlberg
39ecd87667 dissect the treeconnect request packet
svn path=/trunk/; revision=16425
2005-11-07 21:00:09 +00:00
Ronnie Sahlberg
8012fd3cd9 add request response matching so we can start passing info levels around from request to response and start dissecting some of the commands
svn path=/trunk/; revision=16424
2005-11-07 20:32:27 +00:00
Guy Harris
262a414f41 The problem wasn't that <sys/stat.h> wasn't being included, the problem
was that file_util.h wasn't in the distribution tarball, so it couldn't
be included - it handles including <sys/stat.h>.

svn path=/trunk/; revision=16423
2005-11-07 20:14:40 +00:00
Ulf Lamping
91e66afb84 add file_util.h so distcheck might work
svn path=/trunk/; revision=16422
2005-11-07 19:51:16 +00:00
Anders Broman
708d793e63 Display MSW and LSW as NTP timestamp as well.
svn path=/trunk/; revision=16421
2005-11-07 19:40:55 +00:00
Anders Broman
a9a63056df Dissect NSAP
svn path=/trunk/; revision=16420
2005-11-07 19:39:38 +00:00
Anders Broman
b2ec8c9ca4 Bug fix to dissection of NSAP E164 Country codes
svn path=/trunk/; revision=16419
2005-11-07 19:39:02 +00:00
Anders Broman
199214844b Martin Hill has examined packet-dec-dnart.c and found some errors and made some improvements.
svn path=/trunk/; revision=16418
2005-11-07 19:37:10 +00:00
Anders Broman
8586ce47d2 From Stig Bjørlykke
A new dissector for P_Mul (ACP142) http://www.jcs.mil/j6/cceb/acps/Acp142.pdf

svn path=/trunk/; revision=16417
2005-11-07 19:35:48 +00:00
Guy Harris
60c4c050d0 You need <sys/stat.h>, if present, to use fstat().
svn path=/trunk/; revision=16416
2005-11-07 17:18:52 +00:00
Guy Harris
688a256884 The standard <dirent.h> routines to rewind and close a directory are
rewinddir() and closedir().

Clean up indentation.

svn path=/trunk/; revision=16415
2005-11-07 17:12:43 +00:00
Ronnie Sahlberg
575907f024 put the error code in col info
svn path=/trunk/; revision=16414
2005-11-07 08:57:04 +00:00
Ronnie Sahlberg
0b01ed88cb smb2 updates, most of the header is now decoded properly
svn path=/trunk/; revision=16413
2005-11-07 08:39:23 +00:00
Guy Harris
ca781ff145 Use eth_dir_open(), not g_dir_open(); g_dir_open() isn't available in
GLib 1.2[.x].

svn path=/trunk/; revision=16412
2005-11-07 08:36:25 +00:00
Guy Harris
8e5823e0fe This is UN*X-only, so it doesn't need to use the eth_close() wrapper;
close() will be available.

svn path=/trunk/; revision=16411
2005-11-07 08:35:28 +00:00
Guy Harris
db9fba20b4 Use <wiretap/file_util.h> to include "file_util.h"; otherwise, the
include fails as we don't do -Iwiretap.

If we have it, include <sys/stat.h> in epan/filesystem.c - we need it
for stat() and the macros and structures it uses.

svn path=/trunk/; revision=16410
2005-11-07 02:47:09 +00:00
Guy Harris
7474bc0f13 If we're using libz, make file_open() construct the open() flag
argument, rather than requiring the caller to get the open() flag and
the fopen() flag in sync.  That also means that if we're *not* using
libz, it can just be a wrapper around eth_fopen().

We need to include <fcntl.h>, at least on UN*X, to get open() declared
and the O_ flags defined.

svn path=/trunk/; revision=16409
2005-11-07 02:45:19 +00:00
Guy Harris
b7407b5a2a Fix a typo.
svn path=/trunk/; revision=16408
2005-11-07 02:38:34 +00:00
Guy Harris
15cd2aed30 Include <wiretap/file_util.h> to declare the eth_ routines.
svn path=/trunk/; revision=16407
2005-11-07 02:35:02 +00:00
Ulf Lamping
937a50243c as mkstemp makes trouble and is only used once in util.c, move definition from file_util.h to util.c for now
this hopefully fixes the mkstemp problem

svn path=/trunk/; revision=16406
2005-11-07 00:20:20 +00:00