Commit Graph

35 Commits

Author SHA1 Message Date
Bill Meier a2b58f051d Add #include <stdlib.h> to files which reference fcns declared in stdlib.h;
(In many cases I previously incorrectly removed the #include <stdlib.h>).

svn path=/trunk/; revision=37334
2011-05-20 19:00:09 +00:00
Jakub Zawadzki 38c2f2a151 Cleanup: replace sizeof(arr)/sizeof(arr[0]) with shorter array_length(arr)
svn path=/trunk/; revision=36986
2011-05-04 19:32:35 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jörg Mayer 2556852f9e Make the telnet data lines filterable elements.
svn path=/trunk/; revision=34527
2010-10-15 21:02:30 +00:00
Jeff Morriss a229509b85 From Robert Hogan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3922 :
Add support for the IBM TN5250 data stream protocol.

http://wiki.wireshark.org/TN5250

From me:

Move most of the contents of the header file to the .c file.

Replace blurbs that match the hf name with NULL.
Replace empty-string blurbs with NULL.
Fix some abbreviations (hf_tn5220_xxx -> tn5220.xxx).
Make some functions static.
Cast some offset increments to unsigned to make sure we don't go backwards
(which could create a loop).  This includes making most of the subdissection
functions return an unsigned number.

Use find_or_create_conversation().

svn path=/trunk/; revision=32838
2010-05-17 02:55:51 +00:00
Jeff Morriss acc410ae87 From Robert Hogan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4257 :
Correctly decode and display the buffer address in SBA orders.


Note: This includes a macro with a new license which is added to COPYING.

svn path=/trunk/; revision=32785
2010-05-13 15:19:40 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Kovarththanan Rajaratnam 0b5f235491 Call subdissector even when tree is NULL
svn path=/trunk/; revision=30108
2009-09-24 04:52:35 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Jaap Keuter f9177273d8 From Robert Hogan:
I'm working on a tn3270 dissector. 
See: http://roberthogan.net/stuff/tn3270-dissector/

svn path=/trunk/; revision=29129
2009-07-17 06:49:58 +00:00
Balint Reczey ab57f8da5d Unescape telnet suboption data if needed.
This fixes bug 191.

svn path=/trunk/; revision=28582
2009-06-02 00:04:55 +00:00
Balint Reczey 8b7993180b Revert 28580.
svn path=/trunk/; revision=28581
2009-06-01 22:41:48 +00:00
Balint Reczey 4d55fdb51c Fix dissection of telnet window size suboption.
This fixes bug 191.

svn path=/trunk/; revision=28580
2009-06-01 22:27:00 +00:00
Anders Broman c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Stig Bjørlykke b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Stig Bjørlykke 677eb18d20 Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24249
2008-02-02 17:25:40 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Anders Broman 4c692a62b6 Start introducing actx to ber functions.
svn path=/trunk/; revision=21705
2007-05-06 22:34:05 +00:00
Ronnie Sahlberg d5d5159b6d From Sebastien Tandel
fixes for various compiler warnings

svn path=/trunk/; revision=21210
2007-03-26 11:06:26 +00:00
Jeff Morriss 0787b688cc Squelch a few unused parameter warnings.
svn path=/trunk/; revision=20863
2007-02-19 15:30:06 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jaap Keuter f08e4931e1 From Ted Percival:
I have updated the TELNET dissector to dissect encryption negotiation
commands as specified by RFC 2946. 

svn path=/trunk/; revision=18187
2006-05-18 17:08:41 +00:00
Luis Ontanon 0cfdbc3676 - contsify a variable in packet-alcap.c to see if a fake bug reported by coverty goes away.
- fix an off by one error in packet-telnet.c reported by coverty


svn path=/trunk/; revision=17487
2006-03-07 04:33:46 +00:00
Ronnie Sahlberg 8409491a8a get rid of one strcpy()
svn path=/trunk/; revision=16198
2005-10-12 02:30:10 +00:00
Gerald Combs 5a7164249e When we create a new tvb, make sure the memory is freed at some point.
svn path=/trunk/; revision=15361
2005-08-15 20:28:04 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Jörg Mayer 2b2506f0f6 More char -> const char warning fixes
svn path=/trunk/; revision=15222
2005-08-05 13:10:58 +00:00
Ronnie Sahlberg 0d7a2abbc7 some more memification of tvb_get_string() no obvious memleaks fixed this time :-(
svn path=/trunk/; revision=15131
2005-07-28 09:47:28 +00:00
Jörg Mayer f4e36cdc6c Partial fix for bug 191: Sanity check is ok now
svn path=/trunk/; revision=14692
2005-06-18 15:41:26 +00:00
Gerald Combs fe89e3d640 Don't try to check the suboption length type if we don't have a suboption.
Found by Steve Grubb.  Fixes part of bug 217.

svn path=/trunk/; revision=14499
2005-05-30 21:04:58 +00:00
Guy Harris d5c1aec8b5 Get rid of extra semicolon - it might be giving MSVC++ heartburn.
svn path=/trunk/; revision=13740
2005-03-13 07:53:19 +00:00
Gerald Combs 9d5ee3cfea Fix a check for the number of suboptions.
svn path=/trunk/; revision=13739
2005-03-13 05:48:43 +00:00
Guy Harris 46e1e52757 If there's no data in the authentication option, don't unescape and
tvbuffify it.

svn path=/trunk/; revision=11482
2004-07-23 08:36:07 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00