Commit Graph

60 Commits

Author SHA1 Message Date
Stig Bjørlykke 5359494b1f Second try to move crc routines to libwsutil.
This time keep the tvb routines in epan.

Now we can use common crc routines outside epan.

svn path=/trunk/; revision=38810
2011-08-31 09:00:54 +00:00
Stig Bjørlykke 71f903b956 Revert r38800, as the crc routines contains some tvb functions.
svn path=/trunk/; revision=38803
2011-08-30 14:17:40 +00:00
Stig Bjørlykke 4132d40e50 Move all crc routines to libwsutil.
This way we can use the crc routines in wiretap.

svn path=/trunk/; revision=38800
2011-08-30 13:46:42 +00:00
Stig Bjørlykke ba2aae0f8e Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.
svn path=/trunk/; revision=38122
2011-07-19 18:48:31 +00:00
Stig Bjørlykke f282154ab0 Use correct encoding for proto_tree_add_item().
svn path=/trunk/; revision=38107
2011-07-19 10:51:12 +00:00
Stig Bjørlykke e96930f38b Yet another cast to uint.
svn path=/trunk/; revision=37508
2011-06-01 13:58:19 +00:00
Stig Bjørlykke 9334eee893 Corrected usage of uint/pointer conversion.
svn path=/trunk/; revision=37507
2011-06-01 13:57:13 +00:00
Stig Bjørlykke d368f9325b Added support for DMP version 2 and some national variants.
svn path=/trunk/; revision=37506
2011-06-01 13:31:48 +00:00
Stig Bjørlykke ff40ab2174 Added a sanity check to remove a coverity warning.
Coverity 537.

svn path=/trunk/; revision=36353
2011-03-26 15:59:57 +00:00
Stig Bjørlykke 5868c7d026 Renamed x411 to p1, x420 to p22 and s4406 to p772 to be consistent
on the naming policy for X.400 protocols.

svn path=/trunk/; revision=36013
2011-02-20 17:03:29 +00:00
Jeff Morriss 867bf1477e Use nstime_set_zero() to initialize nstime_t's.
svn path=/trunk/; revision=35622
2011-01-22 15:35:34 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jeff Morriss cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Stig Bjørlykke ab215a67d5 Code cleanup:
- Use ep_strdup_printf instead of ep_alloc + g_snprintf
- Untabify

svn path=/trunk/; revision=33414
2010-07-02 13:15:44 +00:00
Guy Harris 927b7da346 Have abs_time_to_str() and abs_time_to_str_secs() take an additional
argument indicating whether to include the time zone in the string.  If
we're constructing a display filter, don't include the time zone,
otherwise do.  Fixes bug 4756.

svn path=/trunk/; revision=32913
2010-05-21 06:33:25 +00:00
Guy Harris 500eb99cd9 Add a third date format, ABSOLUTE_TIME_DOY_UTC, to show UTC with the
date as YYYY/DDD, where DDD is a 1-origin day of year.  Move the formats
to a "time_fmt.h" file, included by the headers that use it.  Have
abs_time_to_str() and abs_time_secs_to_str() take the date format value,
rather than a Boolean "show this as UTC" flag, as an argument.  Document
the ABSOLUTE_TIME_ formats a bit better.  Use that format in the CCSDS
and VCDU dissectors, rather than having those dissectors do the
formatting themselves.

svn path=/trunk/; revision=32034
2010-02-27 19:01:27 +00:00
Stig Bjørlykke 637274ebbc Change back from tvb_child_uncompress() to tvb_uncompress() when
parent is NULL, because this will lead to a DISSECTOR_ASSERT in 
tvb_set_child_real_data_tvbuff().

This bug was introduced in revision 31499.

svn path=/trunk/; revision=31659
2010-01-25 13:58:07 +00:00
Anders Broman 324af9e6fa Fix part of Bug 3917 "tvb_new_real_data is prone to memory leak"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

svn path=/trunk/; revision=31499
2010-01-11 16:14:26 +00:00
Guy Harris 4fde145bd2 Add an argument to abs_time_to_str() and abs_time_secs_to_str()
indicating whether the time should be shown as local time or UTC.  For
now, always pass FALSE, meaning "show as local time".

Clean up some stuff in the SNMP dissector, use abs_time_secs_to_str()
for times with one-second resolution, and update a comment in various
macros in the WSP dissector, while we're at it.

svn path=/trunk/; revision=31227
2009-12-10 22:19:29 +00:00
Stig Bjørlykke 7885ac7b92 Added defines for protocol identifier.
Added hf_addr_ext_form_orig for Originator.
Rewrote strings for addr_form.
Indicate national protocol.
Added expert info for unknown compression.
Some code cleanup.

svn path=/trunk/; revision=31203
2009-12-08 10:14:22 +00:00
Anders Broman 88bb44a51e From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=30691
2009-10-25 11:43:30 +00:00
Stig Bjørlykke 999ab12945 Use IANA assigned port number as default UDP port.
svn path=/trunk/; revision=30352
2009-10-06 06:54:18 +00:00
Stig Bjørlykke 332502e77a Removed unused variable.
svn path=/trunk/; revision=30223
2009-09-30 19:48:52 +00:00
Stig Bjørlykke 801cd0249b Do not use tfs true_string and false_string directly.
svn path=/trunk/; revision=28991
2009-07-07 15:21:36 +00:00
Stig Bjørlykke d00c2baf5c Remove some check_col() calls.
svn path=/trunk/; revision=28974
2009-07-07 10:07:42 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke 26d30411b6 Adjusted my name to use only ASCII characters.
svn path=/trunk/; revision=27733
2009-03-15 21:13:27 +00:00
Stig Bjørlykke db57a3b6fb Use some default true_false_string's.
Fixed a typo.

svn path=/trunk/; revision=27618
2009-03-05 22:29:15 +00:00
Bill Meier 5ac2ba6354 Minor changes related to proto_reg_handoff & pref ranges
svn path=/trunk/; revision=26254
2008-09-23 15:03:39 +00:00
Bill Meier a3e6eb8071 Minor cleanup mostly related to proto_reg_handoff
svn path=/trunk/; revision=26236
2008-09-19 17:39:44 +00:00
Bill Meier 802f4452b4 Minor cleanup related to proto_reg_handoff ....
svn path=/trunk/; revision=26176
2008-09-11 14:07:02 +00:00
Bill Meier afd857957a Fix a few Emacs "file variables" to have "safe" values.
That is: indent-tabs-mode: tabs --> indent-tabs-mode: t
Also: fix a typo: set-tabs-mode --> indent-tabs-mode

svn path=/trunk/; revision=26113
2008-09-02 11:17:03 +00:00
Bill Meier f8e3822738 Fix some warnings reported by gcc -Wshadow ...
Fix some spacing in packet-dcom.c

svn path=/trunk/; revision=25618
2008-06-27 16:15:30 +00:00
Bill Meier 931cc922a1 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25305
2008-05-15 01:44:53 +00:00
Stig Bjørlykke 729cbe42a8 Register dissector by name.
svn path=/trunk/; revision=25179
2008-04-25 19:25:22 +00:00
Stig Bjørlykke 3590fc0713 Changed to checksum_good and checksum_bad to align with other dissectors.
svn path=/trunk/; revision=24115
2008-01-16 19:16:30 +00:00
Stig Bjørlykke c6ac2fd721 Fixed a small issue reporting corresponding package num for retransmitted
reports and notifications.

svn path=/trunk/; revision=24107
2008-01-15 22:32:34 +00:00
Stig Bjørlykke b0c8583de7 Fixed a guint64 compile issue with a Sun C 5.8 compiler.
Fixed a tree placement.

svn path=/trunk/; revision=24086
2008-01-14 09:51:22 +00:00
Stig Bjørlykke 1dbf329466 Added Precedence and Importance to COL_INFO.
svn path=/trunk/; revision=23929
2007-12-20 14:18:38 +00:00
Stig Bjørlykke 88216b4940 Added total retransmission time analysis field.
svn path=/trunk/; revision=23920
2007-12-19 09:38:03 +00:00
Stig Bjørlykke d450d9fe4e Added option to turn off SEQ/ACK analysis.
Moved some resend expert infos to correct entry.
Small fix in seq/ack analysis for report/notificacion.

svn path=/trunk/; revision=23825
2007-12-10 11:17:48 +00:00
Stig Bjørlykke 0f0c02bbae Duplicate packet # -> Retransmission #
svn path=/trunk/; revision=23751
2007-12-04 14:04:37 +00:00
Stig Bjørlykke 111cedfc75 - Added SEQ/ACK analysis for reports and notifications.
- Identify ack type in COL_INFO.
- No analysis when in error packets.
- Some cleanup in hf_ names.

svn path=/trunk/; revision=23630
2007-11-27 22:54:15 +00:00
Stig Bjørlykke a2b5cf9528 Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23589
2007-11-25 21:30:33 +00:00
Stig Bjørlykke cf5aa9d616 Added port range.
Added a dissector assert on inconsistent data.
Do not align retransmission or duplicate acknowledgement data in COL_INFO.
Removed several _U_ for used variables.
Re-indented some if-blocks.

svn path=/trunk/; revision=23492
2007-11-19 07:31:56 +00:00
Stig Bjørlykke 2e98c04584 Create a subset tvb for dissect_x411_ORName so it doesn't eat too much data.
Removed some unnecessary int casts.

svn path=/trunk/; revision=23392
2007-11-07 20:03:29 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Gerald Combs 17f1b4cf46 Add a cast to allow compilation on Vista.
svn path=/trunk/; revision=22874
2007-09-14 15:36:13 +00:00
Stig Bjørlykke 9ad9f9edb7 Corrected some types, instead of adding a cast (from r21142).
Reindented file.

svn path=/trunk/; revision=22816
2007-09-06 22:29:04 +00:00