Commit Graph

36807 Commits

Author SHA1 Message Date
Martin Mathieson aad47c8438 RLC-NR: When have NACK Range, clearly show which SNs were lost 2022-05-20 16:17:04 +01:00
Brian Sipos e47ab95e46 BPv7 and TCPCL: Update references to published RFCs 2022-05-19 20:15:59 -04:00
lindnerp 7079d881fa Update bpv7 and bpsec dissectors to resolve ticket 17727 2022-05-18 12:48:41 -04:00
easonweii 148f5905af SDP: Minor Refactoring by Extract Method
Extract Method for multiple message of SDP Media Attribute to simplify things and Make processes clearer.
dissect_sdp_media_attribute_rtpmap
dissect_sdp_media_attribute_fmtp
dissect_sdp_media_attribute_path
dissect_sdp_media_attribute_h248_item
dissect_sdp_media_attribute_crypto
The original function remain unchanged.
2022-05-18 08:29:37 +00:00
Jason Cohen 44433d3c9c f5ethtrailer: Decode TLS 1.3 trailer info on some versions 2022-05-18 08:28:57 +00:00
Nardi Ivan fc89ddcdcf ISUP: avoid parameter summary text duplication
Parameter name should be appended only once to the tree, when handling
national extensions.

Close #18094
2022-05-17 07:57:27 +00:00
Gerald Combs d5f99ef126 [Automatic update for 2022-05-15]
Update manuf, services enterprise numbers, translations, and other items.
2022-05-15 16:59:34 +00:00
Gerald Combs 8020aea27a epan: Fix our conversation flags
Make sure we pass NO_ADDR2 and NO_PORT2 to conversation_new and
NO_ADDR_B and NO_PORT_B to find_conversation.
2022-05-15 16:36:43 +00:00
Gerald Combs 909280ce82 MySQL: Initialize a variable.
Fix

*** CID 1504408:  Uninitialized variables  (UNINIT)
/builds/wireshark/wireshark/epan/dissectors/packet-mysql.c: 2683 in mysql_dissect_ok_packet()
2677     				}
2678     			}
2679     		}
2680     	} else {
2681     		/* optional: message string */
2682     		if (tvb_reported_length_remaining(tvb, offset) > 0) {
>>>     CID 1504408:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "lenstr".
2683     			if(lenstr > (guint64)tvb_reported_length_remaining(tvb, offset))
2684     				lenstr = tvb_reported_length_remaining(tvb, offset);
2685     			proto_tree_add_item(tree, hf_mysql_message, tvb, offset, (gint)lenstr, ENC_ASCII);
2686     			offset += (int)lenstr;
2687     		}
2688     	}
2022-05-12 17:05:56 +00:00
Jaap Keuter 8c9480214b Remove execute flag on source files 2022-05-12 13:41:47 +02:00
Jérôme HAMM aa8b2b9f1c ssh: fixing warnings. 2022-05-12 09:43:57 +00:00
Jérôme HAMM 3e81d98499 ssh: fixing MAC IV derivation. 2022-05-12 09:43:57 +00:00
Jérôme HAMM a036c4dd09 ssh: switching consistently from g_debug to ws_debug 2022-05-12 09:43:57 +00:00
Jérôme HAMM 797486fa18 ssh: Diffie-Hellman
diffie-hellman-group1-sha1
diffie-hellman-group14-sha1
diffie-hellman-group14-sha256
diffie-hellman-group16-sha512
diffie-hellman-group18-sha512
2022-05-12 09:43:57 +00:00
Jérôme HAMM 967107fb8e ssh: Diffie-Hellman group exchange. 2022-05-12 09:43:57 +00:00
Jérôme HAMM 51087141c8 ssh: aes-ctr 2022-05-12 09:43:57 +00:00
Jérôme HAMM e1ca35c7a6 ssh: aes-cbc 2022-05-12 09:43:57 +00:00
Jérôme HAMM f3c61d7638 ssh: aes-gcm 2022-05-12 09:43:57 +00:00
Min Wang 4e41383aad MySQL: fix bug for mysql response message length. 2022-05-12 15:55:43 +08:00
Min Wang f265c5869b MySQL: fix bug for mysql response message length. 2022-05-12 15:29:38 +08:00
Min Wang dab59caf38 MySQL: fix bug for mysql response message length. 2022-05-12 14:06:09 +08:00
easonweii eedf82cd97 SIP: Refactoring too many if-else branches by table-driven method
When there are a lot of if-else branch judgments, the table-driven method can be used to optimize to facilitate subsequent maintenance.
The original function remain unchanged.
2022-05-11 16:42:40 +00:00
John Thacker c4f6914aa6 DVB-S2: Only add the rolloff value once
DVB-S2X has two possible meanings of the rolloff factor, with
different value strings. Only add the correct one as part of the bitmask,
instead of always adding it twice, once with the low value string and once
with the appropriate value string.
2022-05-10 22:11:06 -04:00
Piotr Winiarczyk d5a0d390e8 btmesh: More information displayed
In some cases the available information on packets were not displayed.
This change displays this information. Some code formatting and
variable renaming was also done.
2022-05-09 18:44:23 +00:00
Alexander Clouter fdf55aaa51 eap: support tunneled TLS decoding
Using a similar strategy to ce087027ef we
group conversation and pdata use by the layer depth we are decoding.

This now decodes EAP-TLS within TEAP (and should work for TTLS and PEAP)
2022-05-09 18:28:27 +00:00
Yu Gao 6739d0397b Fix the pfm-sd default case 2022-05-08 18:02:38 -04:00
Alexander Clouter 6b4b9f614b EAP: fix stride when decoding TEAP TLVs and tree alignment 2022-05-08 18:58:07 +00:00
Gerald Combs c69045c04f [Automatic update for 2022-05-08]
Update manuf, services enterprise numbers, translations, and other items.
2022-05-08 16:40:00 +00:00
Guy Harris 8f1cf0176c USBLL: create the top-level item using the regitered protocol. 2022-05-07 18:50:44 -07:00
Odysseus Yang 8f4d38b776 MBIM: Fix the offset to RSRP and SNR buffer of MBIM_SIGNAL_STATE_INFO_V2 2022-05-06 17:53:24 +00:00
Pascal Quantin d9ec48a759 NAS 5GS: add a UDP framing format
Similar to what was done for NAS EPS in 51165cf
2022-05-06 16:05:22 +02:00
Dr. Lars Völker 0f5025eae4 SOME/IP: Adding string fields for easier filtering 2022-05-05 05:48:35 +00:00
Martin Mathieson 000e4ec75e PDCP-LTE: Allow updated keys to be found by frame number 2022-05-03 22:02:23 +00:00
Dylan Ulis 7261eb0f09 CIP Safety: Fix SERCOS III attributes 2022-05-03 20:30:55 +00:00
Dylan Ulis a14e35a440 CIP Safety: Detect Cancel Propose/Apply TUNID 2022-05-03 20:13:55 +00:00
Karsten Graul 0ab1cbdb40 SMC: show translated MTU and buffer size
Additionally append the translated/uncompressed MTU and
buffer size.

Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
2022-05-03 19:12:18 +00:00
Karsten Graul 341e625249 SMC: support for SMC-Rv2 LLC messages
Add the support for SMC-Rv2 Link Level Control (LLC) messages which
flow over Infiniband.

Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
2022-05-03 19:12:18 +00:00
Karsten Graul 7c70af016f SMC: improve SMC-Rv2 CLC message support
More fine tuning of the SMC-Rv2 support, and add the support to show
the GID list in a CLC proposal message.

Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
2022-05-03 19:12:18 +00:00
Guvenc Gulce b66b07a786 SMC: Add support for SMCRv2
Add SMCRv2 clc proposal/accept/confirm and decline support.
Proposal and decline parsing routines are used by SMC-R(v2) and SMC-D(v2).

Enhance the existing SMC protocol dissector in such
a generic way that it supports both SMC-R(v2) and SMC-D(v2)
protocols. These two protocols are similar to each other.
SMC-D and SMC-R has a version 1 and version 2.

Signed-off-by: Guvenc Gulce <guvenc@linux.ibm.com>
2022-05-03 19:12:18 +00:00
Dylan Ulis edfef021e7 CIP Safety: Increase error detection diagnostics to PI_ERROR 2022-05-03 15:06:50 +00:00
Alexander Clouter e75f6800ca EAP: fix packet leak caused by ce087027ef
Caught and flagged in https://gitlab.com/wireshark/wireshark/-/merge_requests/6838#note_932484809
2022-05-02 17:12:24 +01:00
Gerald Combs 2f31c09045 [Automatic update for 2022-05-01]
Update manuf, services enterprise numbers, translations, and other items.
2022-05-01 17:26:48 +00:00
Martin Mathieson 7fbfea9d68 IEEE80211: Fix a couple of filters 2022-04-30 21:56:21 +00:00
Alexander Clouter ce087027ef EAP: massage pinfo for EAPOL so the TLS decoder does not get lost 2022-04-30 13:30:20 +00:00
Alexander Clouter 6843ca2463 EAP: decode TEAP Outer-TLVs 2022-04-30 13:30:20 +00:00
Alexander Clouter 914d8bc756 EAP: add PEAP decoder
The existing PEAP support does not decode the inner attributes, this
commit adds that support by introducing packet-peap.c which recreates
a 'pseudo' EAP header before looping the TVB back into the EAP dissector.
2022-04-30 13:30:20 +00:00
Alexander Clouter 49c730cc23 EAP: use enum for pdata instead of magic numbers
Later for packet-peap.c, need to use pdata to pick into the parent
dissector so here we set up packet-eap.c to use enum.
2022-04-30 13:30:20 +00:00
Alexander Clouter b9681002c5 EAP: add MSAUTH-TLV decoder 2022-04-30 13:30:20 +00:00
Alexander Clouter f694e70771 EAP: improve EAP-TLS flag decoding
Decode TEAP's O-flag.

We also update the diagram and references as PEAPv0 has a different view
of how the flags are used compared to the RFCs and drafts.
2022-04-30 13:30:20 +00:00
Joakim Karlsson b244db8f3c pfcp: Update to 3GPP TS 29.244 V17.4.0 2022-04-29 11:29:19 +00:00