Commit Graph

76 Commits

Author SHA1 Message Date
Jeff Morriss 8d32d2066a There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or
tvb_get_const_stringz().

Use tvb_memeql() & tvb_memcmp().

svn path=/trunk/; revision=35558
2011-01-16 20:51:21 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman 3c998dadc2 value_string_ext fixes.
svn path=/trunk/; revision=34932
2010-11-17 16:56:51 +00:00
Bill Meier 9675740701 Use value_string_ext fcns to access certain value_string arrays;
Sort several value_string arrays to be in ascending order.
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34766
2010-11-03 22:08:49 +00:00
Bill Meier 055dd62063 #include <string.h> not needed.
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis dfde72f247 Fix for Bug 4588:
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Gerasimos Dimitriadis b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Bill Meier fa3443bbc1 Change default range from 1401,1401 to 1401 so that the port isn't double-registered.
svn path=/trunk/; revision=29266
2009-08-02 19:17:09 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Anders Broman 9eb5ed0d9b Update UMA towards the most recent 3GPP spec, and export InterRATHandoverInfo
from the RRC dissector.

svn path=/trunk/; revision=27584
2009-03-03 18:24:10 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Bill Meier e3a601cf20 Fix compile error; Revise reg_handoff code slightly
svn path=/trunk/; revision=26992
2008-12-13 22:56:00 +00:00
Anders Broman e2e9dc4197 From Vincent Helfre:
Make the dissector callable by name.

svn path=/trunk/; revision=26989
2008-12-13 21:59:33 +00:00
Bill Meier 8d4c57177b Comment out variable not cuurently used ...
svn path=/trunk/; revision=26777
2008-11-14 15:52:34 +00:00
Bill Meier 0f2456b2ff Various proto_register & proto_reg_handoff changes:
Change tcp ports preference name in prefs file to tcp.ports
   (register old 'udp.ports" as obsolete);
  Do various find_dissector & etc once-only in proto_reg_handoff;
  Move find_dissector_table from proto_register to proto_reg_handoff;
  Localize saved ports pref range;
  Do dissector_add_handle("udp.port",...) rather than registering 
   to udp port 0;
Also:
 Clean up some spacing;
 Declare some global variables as static;
 Remove some unnecessary =NULL initializers;

svn path=/trunk/; revision=26776
2008-11-14 15:29:36 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Bill Meier af00f796a0 Another temporary fix to prevent a build error
svn path=/trunk/; revision=25925
2008-08-04 23:50:11 +00:00
Anders Broman 96aa45646d First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy)
rename the "old" one to gsm_a_common.

svn path=/trunk/; revision=25915
2008-08-04 16:11:17 +00:00
Stig Bjørlykke c6af1bfdd4 Removed some "statement not reached" warnings.
svn path=/trunk/; revision=24282
2008-02-07 12:14:40 +00:00
Anders Broman a1347fde05 Set up RTP conversation when PORT is known.
svn path=/trunk/; revision=23377
2007-11-06 18:11:20 +00:00
Gerald Combs abfa8887ad Remove a couple of unused variables.
svn path=/trunk/; revision=23266
2007-10-24 16:32:51 +00:00
Anders Broman 3ddd51de7f Add port ranges.
svn path=/trunk/; revision=23265
2007-10-24 15:04:01 +00:00
Anders Broman 0b4529008d Implement some of the minor possible speed improvment patches.
svn path=/trunk/; revision=23150
2007-10-11 21:23:14 +00:00
Anders Broman c01f382974 Second step in introducing asn context to BER dissectors just like in PER.
svn path=/trunk/; revision=21753
2007-05-13 20:58:29 +00:00
Sebastien Tandel 68ad2f4b9b fix MacOSX gcc-3.3 warnings about unused tfs/value_string variables
most have been tagged unused (few have been deleted if dissector has not been
modified since a long time)

move packet-ssl-utils.c to DISSECTOR_SRC


svn path=/trunk/; revision=21431
2007-04-14 14:01:53 +00:00
Ronnie Sahlberg d5d5159b6d From Sebastien Tandel
fixes for various compiler warnings

svn path=/trunk/; revision=21210
2007-03-26 11:06:26 +00:00
Stephen Fisher 64cc1b407c From Sebastien Tandel:
(Fixing warnings)

stripped away some unused variables/parameters
+ in prefs.c
    suggestion of parentheses makes gcc happy


svn path=/trunk/; revision=21156
2007-03-23 18:45:21 +00:00
Anders Broman 79a551e513 Display 2 octet length field correctly.
svn path=/trunk/; revision=20801
2007-02-12 22:04:58 +00:00
Anders Broman 6becee230b Fix a typo.
svn path=/trunk/; revision=20055
2006-12-06 22:05:55 +00:00
Ronnie Sahlberg 2d1bb39121 change the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdus() to also include a packet_info pointer.
there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size



svn path=/trunk/; revision=19751
2006-10-31 09:29:07 +00:00
Anders Broman 71628796c4 Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1107
"The decoder has some bugs:
 * RTP redundancy field is decoded incorrectly.
 * Timer TU3920 is displayed as being in seconds, but it is really in units of
100 ms."

svn path=/trunk/; revision=19247
2006-09-17 19:43:13 +00:00
Anders Broman f377855e9f Dissect RTP Redundancy Support correctly.
svn path=/trunk/; revision=18225
2006-05-27 18:24:29 +00:00
Anders Broman b727e4e355 From Markus Meier:
The UMA-message Handover From UMAN Command includes the complete L3-message (and header) and not only the handover-IE's.

svn path=/trunk/; revision=18215
2006-05-23 19:02:05 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 2002225c79 Fix BUGs:
955 UMA: Handover Command message not decoded.
956 UMA: multirate-configuration not decoded correctly .
957 UMA: Received Signal Level List not decoded.

svn path=/trunk/; revision=18179
2006-05-17 18:09:14 +00:00
Anders Broman a23a5b603a Fix bug 951 UMA: message URR_RELEASE not decoded corretly
and 952 UMA: IE length-field of UMA-message can always be 2 bytes 

svn path=/trunk/; revision=18167
2006-05-15 20:23:37 +00:00
Guy Harris e5d0659195 A dissector called from tcp_dissect_pdus() has to return void. (If you
want to have a dissector capable of rejecting packets, you need to
reject the packet before you call tcp_dissect_pdus() - once you're doing
reassembly, etc., it's too late to reject the packet.)

svn path=/trunk/; revision=18029
2006-04-29 09:30:09 +00:00
Anders Broman 039e39d8b4 Fix bug 896 by using tcp_dissect_pdus() .
svn path=/trunk/; revision=18027
2006-04-28 21:41:13 +00:00
Anders Broman c850e7a683 Use dissect_e212_mcc_mnc().
svn path=/trunk/; revision=17127
2006-01-30 05:55:46 +00:00
Lars Roland de4522f70d Fix an infinite loop in gsm_a dissector and a wrong offset in uma dissector.
This fixes bug 716.

svn path=/trunk/; revision=17119
2006-01-29 15:54:10 +00:00
Anders Broman 0fd0ebef0e Dissct Ptotocol Id 0
svn path=/trunk/; revision=16627
2005-11-30 20:11:45 +00:00
Anders Broman 20381722de Use the right offset when calling packet-gsm_a.c functions.
svn path=/trunk/; revision=16276
2005-10-20 15:49:03 +00:00
Anders Broman 855e39b91c Update to the latest version of the standard.
svn path=/trunk/; revision=16056
2005-09-29 20:24:02 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00