Commit Graph

91 Commits

Author SHA1 Message Date
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 1c01cbfa60 Remove two duplicate values from rtp_payload_type_short_vals value_string array.
svn path=/trunk/; revision=34812
2010-11-08 21:35:14 +00:00
Bill Meier 2de3781872 Remove two duplicate entries from rtp_payload_type_vals array.
svn path=/trunk/; revision=34811
2010-11-08 21:24:10 +00:00
Anders Broman cab0cef11d Use value_string_ext for RTP payload types.
svn path=/trunk/; revision=34804
2010-11-08 14:43:59 +00:00
Anders Broman 6117e317c6 Remove deprecated check_col().
svn path=/trunk/; revision=34107
2010-09-12 19:29:05 +00:00
Jeff Morriss ac262a6043 Fix fuzz failure in bug 4671: don't assume the conversation data exists (check for a NULL pointer). Also correct a typo (assignment to wrong variable).
svn path=/trunk/; revision=32477
2010-04-15 20:09:46 +00:00
Anders Broman 83ce037aa9 Use the sample rate from SDP info in RTP stream analysis.
svn path=/trunk/; revision=32466
2010-04-14 20:48:37 +00:00
Bill Meier 055dd62063 #include <string.h> not needed.
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Stig Bjørlykke 47e732e29e Changed "reassembled_length" -> "reassembled.length".
svn path=/trunk/; revision=31776
2010-02-03 08:47:15 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Bill Meier 92c387a992 fid_table never used: remove it (Fixes very minor memory leak).
svn path=/trunk/; revision=30583
2009-10-16 22:05:49 +00:00
Jeff Morriss 1daf990897 From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2815
but (since the patch no longer applied cleanly) essentially manually
re-implemented by me:

Rename "stun" to "classic stun" and "stun2" to "stun", to follow the usage
defined in draft-ietf-behave-rfc3489bis-18 section 2.

svn path=/trunk/; revision=29884
2009-09-13 23:03:38 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Bill Meier 8fda47d5b2 Replace "repeated blurb" by NULL in two cases;
Reformat a long line.

svn path=/trunk/; revision=29606
2009-08-29 02:25:04 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke 4d8dd01e8e Changed flags_set_truth -> tfs_set_notset
svn path=/trunk/; revision=28989
2009-07-07 14:54:15 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jaap Keuter bd563faabb From Michael Lum:
Some of the hard-coded 96 and 127 values representing dynamic payloads 
were changed to use #defines from rtp_pt.h but not all.

svn path=/trunk/; revision=28466
2009-05-25 06:46:33 +00:00
Gerald Combs f3080aff14 From Alex Lindberg via bug 3094:
Added descriptions for dynamic RTP Payload types.

svn path=/trunk/; revision=28433
2009-05-20 23:46:48 +00:00
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Guy Harris e99e0bc9bb Section 11 of RFC 3550, "RTP over Network and Transport Protocols",
speaks only of destination ports; in the heuristic dissectors, don't
check whether the source port is even or odd.

The total length of an RTCP packet is in tvb_reported_length(), not
tvb_length() - the latter includes only the actual captured data, which
might be cut short by a snapshot length.

svn path=/trunk/; revision=28041
2009-04-13 22:37:35 +00:00
Anders Broman b666a7942e More size_t casts.
svn path=/trunk/; revision=27887
2009-03-29 18:26:06 +00:00
Bill Meier 4993cb95cd (Minor) Change a g_snprint to a g_strlcpy;
Also: Fix an off-by-1  inadvertantly introduced a while back.

svn path=/trunk/; revision=27820
2009-03-22 16:25:01 +00:00
Bill Meier 262f40505a Adjust some indentation; reformat a line or two.
svn path=/trunk/; revision=27628
2009-03-06 22:55:02 +00:00
Bill Meier 5817e6002b dissect_rtp_heur: prevent a 'false positive' when trying stun dissection.
Specifically: when dissect_rtp_heur calls the stun dissector:
- Don't do a 'data' dissection if stun dissection fails;
  (ie: use call_dissector_only instead of call_dissector).
- return the stun dissector success/fail status to the caller of dissect_rtp_heur;
  (Done by registering and calling the heuristic version of the stun dissector).
Also: use call_dissector_only for each of the dissectors called by dissect_rtp_heur
 (altho it really makes no difference at this point except for the call to the
  stun dissector).

svn path=/trunk/; revision=27443
2009-02-12 17:30:15 +00:00
Gerald Combs 6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Anders Broman 51de8ebdb8 Back out the expert info - it's wrong.
svn path=/trunk/; revision=26441
2008-10-13 19:32:06 +00:00
Anders Broman d5677f851a Add an expert item if src port = dst port.
svn path=/trunk/; revision=26410
2008-10-11 10:41:58 +00:00
Jaap Keuter e45be35abb From Sagar Pai:
This is a dissector for ZRTP, the Zfone projects secure media protocol, developed by Phil Zimmermann.
It is updated to the latest IETF draft draft-zimmermann-avt-zrtp-08.

svn path=/trunk/; revision=26274
2008-09-25 22:06:58 +00:00
Bill Meier 03187c631d Fix so pkt_ccc port pref works; proto_reg_handoff's: gen'l cleanup.
svn path=/trunk/; revision=26205
2008-09-15 19:33:38 +00:00
Anders Broman 47aca4c30f From stéphane bryant:
STUN, STUN2 and TURN dissection enhancements.

svn path=/trunk/; revision=25895
2008-08-01 15:11:06 +00:00
Jeff Morriss 28426d27ff prefs_register_uint_preference() takes as its argument a pointer to a uint, not a pointer to a gboolean. Similarly prefs_register_enum_preference takes a pointer to a gint, not a guint.
svn path=/trunk/; revision=25710
2008-07-11 19:56:43 +00:00
Jeff Morriss 83ae90ae83 In a call to proto_tree_add_bytes_format(): actually pass a pointer to the start of the bytes
svn path=/trunk/; revision=25709
2008-07-11 19:48:30 +00:00
Jaap Keuter ea13bae738 From Alon Tal:
RTP header extensions that are longer than 4 bytes (rtp.ext.len > 1)
get dissected incorrectly. The first 4 bytes of the header extension are
repeated rtp.ext.len times, and the remaining bytes are ignored.

svn path=/trunk/; revision=25184
2008-04-27 11:10:57 +00:00
Jaap Keuter 36471e1f8c From Peter Fuller:
If a UDP packet is submitted to the RTP heuristic dissector with either odd src
or dst ports, the heuristic will correctly return FALSE.  However, that
interferes with the next few lines of code that can potentially treat version 0
RTP packets as either STUN or T38 depending on preference settings.

svn path=/trunk/; revision=25150
2008-04-23 06:51:15 +00:00
Martin Mathieson 524f4c1611 Adjust the RTP heuristic dissector:
- loosen by accpepting dynamic payload type range
- tighten by only accepting even-numbered ports

svn path=/trunk/; revision=24583
2008-03-07 18:15:46 +00:00
Stig Bjørlykke b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Jaap Keuter 81aaf4a8b1 Avoid misreporting of cryto state of RTP payload.
svn path=/trunk/; revision=24461
2008-02-25 19:08:13 +00:00
Martin Mathieson d786333ab2 #ifdef DEBUG around left-over printfs. Should these just be deleted?
svn path=/trunk/; revision=24045
2008-01-09 16:21:03 +00:00
Tomas Kukosa 27a531e06a more sophisticated H245 OLC handling focusing on more reliable T.38 establishment
svn path=/trunk/; revision=24043
2008-01-09 13:30:31 +00:00
Jaap Keuter d3b3178186 Fix for bug 2026:
Clean up RTP header extension code. Remove duplicate raw presentation.

svn path=/trunk/; revision=24016
2008-01-06 11:49:32 +00:00
Jaap Keuter 93ef681227 From Andreas St:
In our communication systems, we make use of the RTP header extension to encode
signalling information in the form of a bit mask. To improve our debugging, we
extended the default RTP dissector to call back any subdissector registering
for a particular RTP payload type string. This allows to render the value of
the header extension in a different, more flexible way compared to the default
numeric representation, such as in form of a subtree.

svn path=/trunk/; revision=23943
2007-12-23 20:10:57 +00:00
Tomas Kukosa a76ff82d70 - register RFC 2198 as RTP dynamic payload type "red"
- display dynamic payload type names inside RFC 2198

svn path=/trunk/; revision=23846
2007-12-12 10:51:09 +00:00
Tomas Kukosa 9b3c5f9f03 display SRTP isntead of RTP if stream is established like a SRTP
svn path=/trunk/; revision=23337
2007-11-02 07:43:49 +00:00
Jaap Keuter b2d63bac5f Allow for full size setup method name.
svn path=/trunk/; revision=22863
2007-09-13 18:47:54 +00:00
Jaap Keuter 7b593acb18 From Neil Piercy:
This patch set provides a an API for out of band signalling protocols to
register flows as SRTP/SRTCP using extended versions of the existing
rt(c)p_add_address functions. At present the encrypted portions of the payloads
are simply skipped, and the auth tags etc added as fields.

svn path=/trunk/; revision=22562
2007-08-21 07:23:34 +00:00
Martin Mathieson 59c8ec0670 Make contributing items and hdr extensions proper fields.
svn path=/trunk/; revision=22382
2007-07-23 14:39:17 +00:00
Stephen Fisher 2745f06d96 From Lars Ruoff:
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.


svn path=/trunk/; revision=22017
2007-05-31 18:41:25 +00:00