Commit Graph

60 Commits

Author SHA1 Message Date
Jeff Morriss 8d32d2066a There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or
tvb_get_const_stringz().

Use tvb_memeql() & tvb_memcmp().

svn path=/trunk/; revision=35558
2011-01-16 20:51:21 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman 7870de6f95 Fill value_strings.
svn path=/trunk/; revision=34875
2010-11-15 16:46:07 +00:00
Bill Meier b78ec52693 Use value_string_ext fcns to access certain value_string arrays;
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.

svn path=/trunk/; revision=34794
2010-11-05 22:44:03 +00:00
Jaap Keuter c1b8394ebc From Alexis La Goutte:
Fix false positive from checkhf.

svn path=/trunk/; revision=34772
2010-11-04 06:44:57 +00:00
Jaap Keuter b7920c07c5 From Alexis La Goutte:
Replace all *_min()/*_max() by MIN() and MAX().

svn path=/trunk/; revision=34767
2010-11-04 06:36:33 +00:00
Tomas Kukosa b32d39b755 ignore unreassembled fragments if the first segment of the next message comes
svn path=/trunk/; revision=32643
2010-05-03 08:07:53 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Tomas Kukosa 6fe3d98de8 Do not reassemble messages if segment is not complete (packet size limited during capture)
svn path=/trunk/; revision=32326
2010-03-30 12:23:52 +00:00
Tomas Kukosa 02a8a77f03 add some Q.931 messages from older specifications
svn path=/trunk/; revision=32244
2010-03-19 13:03:14 +00:00
Tomas Kukosa cd719af33a Add heuristic table for Q.931 User-specific protocol
svn path=/trunk/; revision=32218
2010-03-17 15:25:20 +00:00
Stig Bjørlykke 47e732e29e Changed "reassembled_length" -> "reassembled.length".
svn path=/trunk/; revision=31776
2010-02-03 08:47:15 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Bill Meier 1a4283ccf8 Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Anders Broman 3faf5345ab From Gerasimos Dimitriadis:
DTAP: Progress description depends on coding standard.
Changed to export value strings trough .h file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146

svn path=/trunk/; revision=30661
2009-10-22 05:28:53 +00:00
Anders Broman f5f2bf6ecd From Gerasimos Dimitriadis:
DTAP: Call state depends on coding standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145

svn path=/trunk/; revision=30655
2009-10-21 09:38:51 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Jaap Keuter 2c9c96744d From Gerasimos Dimitriadis:
Added decoding support for the High Layer Compatibility IE in DTAP and updated
the relevant part in Q.931. Also some minor enhancements in Q.931.

svn path=/trunk/; revision=29280
2009-08-03 21:12:41 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier 5aa5576a55 The convention is to use TFS(...) when specifying a true_false_string with an FT_BOOLEAN field;
Also: use the global true_false_string tfs_yes_no  in place of a static local string.

svn path=/trunk/; revision=28320
2009-05-08 22:18:14 +00:00
Richard van der Hoff 02dbe1edba fix unused parameter warning
svn path=/trunk/; revision=27779
2009-03-18 20:30:35 +00:00
Guy Harris d160db2cfb Check the length in dissect_q931_change_status_ie().
Don't print a string value returned by a function by using it as the
format string - use "%s" as the format.

svn path=/trunk/; revision=27320
2009-01-28 18:16:22 +00:00
Tomas Kukosa 3116c7d051 new SERVICE/SERVICE ACKNOWLEGE messages defined in various US standards (AT&T TR41459, Nortel NIS A211-1, Telcordia SR-4994)
svn path=/trunk/; revision=27317
2009-01-28 13:32:13 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Tomas Kukosa fd2e95371f H.323 over SCTP support
svn path=/trunk/; revision=26903
2008-12-02 13:09:21 +00:00
Anders Broman 33ad445703 Packet-isup.c &packet-q931.[ch]:
In case of cause pointing out ie "faults" use the correct "ie value_string".
in packet-isup.c use packet-e164.c for country code translation.

svn path=/trunk/; revision=26264
2008-09-24 21:59:50 +00:00
Jaap Keuter a83a87e9ca Fix for bug 2870:
Wrap dissect_q931_cause_ie() in a save version which clears the have_valid_q931_pi semaphore. This may remain set if a malformed q931 message causes an exception.

svn path=/trunk/; revision=26190
2008-09-14 13:09:14 +00:00
Jaap Keuter 7a942da919 Add codeset 5 ETSI party catagory IE.
svn path=/trunk/; revision=24690
2008-03-18 19:57:35 +00:00
Jaap Keuter a6c664155a Add consistent Bearer Capability layer identifications.
svn path=/trunk/; revision=24689
2008-03-18 19:53:07 +00:00
Guy Harris f260d1cd81 memmove() is needed only if the source and destination might overlap.
svn path=/trunk/; revision=21591
2007-04-26 05:43:43 +00:00
Jaap Keuter 14cafb271f From Alfred Alinazar:
The patch is to dissect unknown information element when an Avaya PBX
use codeset = 6 to send display.

svn path=/trunk/; revision=20189
2006-12-21 22:24:33 +00:00
Anders Broman 612c85a7af From Richard Braun:
The Q931 dissector applies a wrong mask when testing the odd/even indicator bit.

svn path=/trunk/; revision=20010
2006-11-28 06:31:07 +00:00
Anders Broman c8f1354c14 Fix for bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1106
packet-lapd.c change on 2006-03-02 (17452) by etxrab swaps SRC/DST for the default case
And added a comment to Q.931

svn path=/trunk/; revision=19275
2006-09-21 19:39:42 +00:00
Tomas Kukosa 539102ca60 - new function ssl_dissector_delete()
- register H.225.0 over TLS (configurable port 1300)
- register SIP over TLS (fixed port 5061)
- new function proto_tree_get_root()

svn path=/trunk/; revision=19059
2006-08-28 07:05:02 +00:00
Anders Broman c19f6b2d97 gsm_a: Dissect LLC
Q.931: Add Bit 8 first in Bearer Cap IE

svn path=/trunk/; revision=18477
2006-06-15 21:14:26 +00:00
Anders Broman b590de7ce0 From Richard van der Hoff:
Q.931:I
mprovesthe dissection of Q.931 Channel 
Identification information elements, by using proper (filterable) header 
fields rather than text tree items.

H253:
make the h.263 dissector dissect the group-of-block 
number which comes after a GOB start code.

svn path=/trunk/; revision=18323
2006-06-02 20:29:05 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jaap Keuter a10dd1b04e Completed Channel Identification IE with Channel number/Slot map field
svn path=/trunk/; revision=17712
2006-03-23 23:04:43 +00:00
Tomas Kukosa a3ed89556a protocol discriminator byte has to be taken into info_element_len
svn path=/trunk/; revision=16698
2005-12-06 10:50:21 +00:00
Anders Broman 20f04faf96 From Jaap Keuter:
Q.931 fails to pass long message to H.225

svn path=/trunk/; revision=16631
2005-12-01 06:20:17 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Jörg Mayer 69dcb66cd9 More char -> const char warning fixes
svn path=/trunk/; revision=15218
2005-08-05 00:23:22 +00:00
Ronnie Sahlberg 9ef6568c56 some more dissectors converted to ep_tvb_get_string
again   at least one obvious memleak was found in the old code



svn path=/trunk/; revision=15031
2005-07-24 03:01:41 +00:00
Anders Broman e37467eb29 From Alejandro Vaquero
new dissector for the AudioCodes trunk trace protocol. 
This protocol is used to debug the trunk protocol in AudioCodes 
gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, 
etc...) trunk protocols. It also add these protocols in the "Voip Calls 
Graph..."

svn path=/trunk/; revision=14790
2005-06-27 06:21:51 +00:00
Ulf Lamping 56a9fe6d2a add a generated toplevel line between the connectionless DCE/RPC protocol and the defragmented DCE/RPC content, to better understand what's going on if defragmentation is done.
svn path=/trunk/; revision=14531
2005-06-02 20:55:58 +00:00
Gerald Combs 46ebfe16b0 Don't try to free NULL. Don't overflow a buffer.
svn path=/trunk/; revision=14173
2005-04-23 21:31:25 +00:00
Gerald Combs 3ed50e1ae7 Don't pass a null format string to val_to_str().
svn path=/trunk/; revision=14167
2005-04-22 15:18:56 +00:00