Commit Graph

86 Commits

Author SHA1 Message Date
Jeff Morriss d553df218e Use tvb_memeql().
Use tvb_ip_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

svn path=/trunk/; revision=35547
2011-01-16 03:46:16 +00:00
Anders Broman bdc3fa5463 From Alexis La Goutte:
- Update RFC Draft (draft-vida-mld-v2-08.txt) to Final RFC
(RFC 3810)
- Make MLD field filterable 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5552

svn path=/trunk/; revision=35413
2011-01-07 00:19:28 +00:00
Anders Broman 52264efdfe Fix build.
svn path=/trunk/; revision=35358
2011-01-04 08:45:03 +00:00
Jaap Keuter b9f7ef1bb2 From Alexis La Goutte:
A Patch to enchance the ICMPv6 Router Renumbering for IPv6 (RFC 2894) Dissector
- Make RR field filterable 
- Add RR Result Message
- ...

svn path=/trunk/; revision=35355
2011-01-04 07:44:39 +00:00
Jaap Keuter bf301e6d86 Fix the HAI value display filter string.
svn path=/trunk/; revision=35294
2010-12-29 07:39:52 +00:00
Chris Maynard 40106e2f5b From Alexis La Goutte via bug 5528:
Fix wrong Field Type for HAI-Value and MN-Value (RFC 5271)

svn path=/trunk/; revision=35289
2010-12-28 18:26:16 +00:00
Jaap Keuter 64d02a0ae1 From Alexis La Goutte:
A patch to enchance the ICMPv6 dissector
- Update RFC Draft (draft-ietf-ipngwg-icmp-name-lookups-07/08) to Final RFC (RFC 4620)
- Make NI field filterable 
- ....

svn path=/trunk/; revision=35283
2010-12-28 10:34:19 +00:00
Anders Broman 2f80045a5c From Alexis La Goutte:
ICMPv6 Enhancements : make ICMP option filterable (Part 2)

*Merge (and update) FMIPv6 Option with ND Option
*Make ICMP option filterable (use proto_tree_add_item..)
*Reorder ND Option
*Add dissector for RA Flags Extension (RFC5075)
*Add dissector for Handover Key Request/Reply (RFC5269)
*Add dissector for Handover Assist Info / Mobile Node ID (RFC5271)
*Add dissector for DNS Search List (RFC6106

From me removed a c++ style comment and changed 
to tvb_memcpy(tvb, (guint8 *)&prefix.bytes in a couple of places.

svn path=/trunk/; revision=35272
2010-12-27 10:57:42 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman 879821bc35 Try to fix Buildbot crash output: fuzz-2010-11-28-11164.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5448

svn path=/trunk/; revision=35060
2010-11-29 13:02:31 +00:00
Stig Bjørlykke 3bfd25c34e Removed unused route_preference.
svn path=/trunk/; revision=34990
2010-11-21 11:28:42 +00:00
Anders Broman ebac83d6a3 From Alexis La Goutte:
ICMPv6 Enhancements : make ICMP option filterable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5424

svn path=/trunk/; revision=34988
2010-11-21 10:30:35 +00:00
Anders Broman 5d6d0f6fea Update from IANA records.
svn path=/trunk/; revision=34846
2010-11-11 21:18:46 +00:00
Jeff Morriss df0692a8e6 Use while loops instead of goto's.
svn path=/trunk/; revision=34580
2010-10-20 01:37:03 +00:00
Jeff Morriss 8a7125f063 From Colin O'Flynn and Owen Kirby via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5266 :
The attached patch begins to add support for RPL to the ICMPv6 file. All
locations that RPL code have been added are marked with a comment allowing this
patch to be reverted at a future time if it is decided to e.g. move all the RPL
code to it's own dissector.

A few values await IANA assignment and are also clearly marked (in
packet-ipv6.h). 

Only the 'metric' option is left unsupported, as it is primarily defined in
another I-D.

svn path=/trunk/; revision=34579
2010-10-20 01:23:32 +00:00
Gerald Combs fff19c8383 Improve the ND flag display.
svn path=/trunk/; revision=34388
2010-10-05 22:16:29 +00:00
Gerald Combs a0b284c5db Add more information to the Info column for some ICMPv6 messages. Add a
small comment to addr_resolv.c.

svn path=/trunk/; revision=34384
2010-10-05 17:57:23 +00:00
Jaap Keuter add282a338 From Colin O'Flynn
Add 6lowpan-nd-13 Support.
This brings the 6lowpan dissector up to the latest revision, nd-13.

svn path=/trunk/; revision=34294
2010-09-30 19:43:33 +00:00
Stig Bjørlykke 35073fe5a7 Added some values from IANA's icmpv6-parameters.
Note: option 29 and 30 still not dissected according to RFC 5271.

svn path=/trunk/; revision=33563
2010-07-18 12:09:14 +00:00
Stig Bjørlykke becb46a421 Added some updates from RFC 4443.
svn path=/trunk/; revision=33562
2010-07-18 11:47:43 +00:00
Stig Bjørlykke 039c0ccac0 Show the reserved values in type 135, 137 and 143 in the packet tree.
This fixes the issues in bug 5018.

svn path=/trunk/; revision=33561
2010-07-18 11:07:04 +00:00
Anders Broman 970dbcb464 Clean up a bit, fix indent.
svn path=/trunk/; revision=33045
2010-06-02 10:50:39 +00:00
Jörg Mayer af443c79c8 Add three more ICMPv6 type that only have a code of 0
svn path=/trunk/; revision=32120
2010-03-04 23:51:30 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Anders Broman 4d2e653901 From Didier Gautheron:
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107

svn path=/trunk/; revision=30415
2009-10-09 07:24:33 +00:00
Kovarththanan Rajaratnam cf8138e195 Remove check_col() guard
svn path=/trunk/; revision=30124
2009-09-24 19:50:43 +00:00
Kovarththanan Rajaratnam 90a5e748c2 Don't col_clear(COL_PROTOCOL) followed by col_set_str(COL_PROTOCOL). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though)
svn path=/trunk/; revision=30090
2009-09-23 14:59:22 +00:00
Kovarththanan Rajaratnam 124faf721c Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO
svn path=/trunk/; revision=30089
2009-09-23 14:52:01 +00:00
Bill Meier 75e727697f Remove unneeded #includes; Clean up indentation; Comment a few "closing braces".
svn path=/trunk/; revision=29538
2009-08-24 15:17:58 +00:00
Stig Bjørlykke ca5995f532 From Ivan Sy via bug 3931:
Added ND Proxy Flag for IPv6 RA flag.

svn path=/trunk/; revision=29533
2009-08-24 08:00:39 +00:00
Bill Meier c66f265dda Rework code slightly to prevent a GCC 'strict-aliasing' warning.
svn path=/trunk/; revision=29532
2009-08-23 23:52:40 +00:00
Jaap Keuter 1711f5899b From Ivan Sy:
Per RFC 3810 - Multicast Listener Discovery Version 2 (MLDv2) for IPv6,
Add Number of Sources. Also to show Record Type's numeric value and not 
just its equivalent.

Cleaned up presentation and included record number as well.

svn path=/trunk/; revision=29528
2009-08-23 17:18:29 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Balint Reczey 181f4c8364 Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test
svn path=/trunk/; revision=29393
2009-08-12 12:55:27 +00:00
Balint Reczey 80fbe4959a From Ivan Sy (with minor modifications):
Show Teredo Connectivity tests.
Fix offset of ICMPv6 sequence number.

svn path=/trunk/; revision=29387
2009-08-11 23:20:03 +00:00
Stig Bjørlykke 2002748969 Cleanup handling of ICMPv6 type and code (not complete):
- Use value_string to convert strings
- Added more types and codes from IANA

Removed use of check_col()
Some white space cleanup

svn path=/trunk/; revision=29054
2009-07-10 12:48:48 +00:00
Jaap Keuter 9ba3058f05 From Shinsuke SUZUKI:
Due to an incorrect offset setting in packet-icmpv6.c Wireshark cannot parse RA router-lifetime and RA flags properly.

svn path=/trunk/; revision=28818
2009-06-23 06:45:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier 871c9c7152 ep_strbuf usage: ep_strbuf_new_label("") --> ep_strbuf_new_label(NULL);
ep_strbuf_append() --> ep_strbuf_append_c() in a few cases.

svn path=/trunk/; revision=28052
2009-04-14 18:31:02 +00:00
Gerald Combs 7265c99e0c Get rid of a bunch of size_t's.
svn path=/trunk/; revision=27967
2009-04-05 23:42:26 +00:00
Guy Harris ee8ddd5123 Use an emem_strbuf_t in bitrange().
svn path=/trunk/; revision=27965
2009-04-05 18:20:20 +00:00
Stig Bjørlykke c11055cda9 Fixed some data types to remove some warnings in the solaris build.
svn path=/trunk/; revision=27825
2009-03-23 12:41:56 +00:00
Jaap Keuter b4278f490c From Evan Black:
SeND:
rfc 3971:
1) Certification Path Solicitation was not being dissected.
2) CGA Parameter was not dissected.

rfc 4581:
Adding support.

svn path=/trunk/; revision=26699
2008-11-05 10:59:20 +00:00
Stig Bjørlykke bd08ae7ee6 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26647
2008-10-31 15:11:57 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Stig Bjørlykke cb51efd25d From Roy Marples (bug 2781 and bug 2796):
Display FQDN binary encoded name as text
Ensure that get_dns_name does not cross packet sub boundry

From me:
Preserve the usage of bootp.fqdn.name as a display filter

svn path=/trunk/; revision=25981
2008-08-11 12:00:27 +00:00
Bill Meier 33af75a599 Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25628
2008-06-28 21:09:57 +00:00
Guy Harris 83fc9d5e09 Constify a bunch of stuff, to squelch -Wwrite-strings warnings.
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.

Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).

Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().

Clean up some indentation.

svn path=/trunk/; revision=25601
2008-06-25 09:12:35 +00:00
Bill Meier 44af6ef887 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25290
2008-05-14 01:47:41 +00:00
Anders Broman 02353b11ce From bboissin:
fix RFC4191 handling
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2498

svn path=/trunk/; revision=25156
2008-04-23 20:42:02 +00:00