Commit Graph

119 Commits

Author SHA1 Message Date
Martin Mathieson d9520dc09c Getting ready for R9 versions of some LTE protocols.
svn path=/trunk/; revision=35518
2011-01-13 15:16:45 +00:00
Jeff Morriss 0c4e881911 Introduce, and start using, tvb_get_const_stringz(). This function returns a
pointer to a NULL-terminated string in the TVB.  It is no safer than dissectors
which call tvb_get_strsize() and then tvb_get_ptr() but it makes it clear that
this usage of tvb_get_ptr() is safe.

This function is slightly more efficient than tvb_get_ephemeral_stringz()--but
only as long as we're not using composite TVBs.

svn path=/trunk/; revision=35493
2011-01-12 02:25:08 +00:00
Jeff Morriss 18f751d877 (After discussion on -dev) revert 35393: the old code is faster (and it is safe).
svn path=/trunk/; revision=35400
2011-01-06 16:08:56 +00:00
Jeff Morriss fb7450a8df Use tvb_get_ephemeral_stringz() instead of tvb_get_strsize() plus (sometimes multiple) calls to tvb_get_ptr().
svn path=/trunk/; revision=35393
2011-01-06 02:18:36 +00:00
Martin Mathieson d8506bbfed Remove a stray debug printf().
svn path=/trunk/; revision=35374
2011-01-05 14:45:31 +00:00
Martin Mathieson 5e49db3304 Properly read UL grant subframe number.
svn path=/trunk/; revision=35251
2010-12-23 12:16:37 +00:00
Martin Mathieson c08d3b76d9 Skip an outheader field.
svn path=/trunk/; revision=35250
2010-12-23 11:09:52 +00:00
Martin Mathieson 1386eb8fa3 Be more consistent about how offset is updated while dissecting lte_rrc fields.
Show cell-id in info column (if don't manage to call RRC).

svn path=/trunk/; revision=35237
2010-12-21 17:46:25 +00:00
Martin Mathieson c7c4850c38 From Papan Kumar Singh (bug 5504 & 5505):
Add missing break so that PDCP-LTE direction is set properly.

svn path=/trunk/; revision=35228
2010-12-20 11:26:50 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Martin Mathieson dc24655c06 Add support for FP E-DCH T2 frames.
svn path=/trunk/; revision=35188
2010-12-15 01:45:43 +00:00
Martin Mathieson 7cd3ff263b Add more PHY attributes to MAC frames.
svn path=/trunk/; revision=35125
2010-12-05 23:34:11 +00:00
Martin Mathieson a6368260cc Fix calling of LTE RRC dissector for "rrc_lte_r8" frames.
svn path=/trunk/; revision=35050
2010-11-28 15:37:40 +00:00
Martin Mathieson 76bc0e537b Pass ueid + channel-info into PDCP dissector.
This will allow me soon to track per-channel sequence numbers...

svn path=/trunk/; revision=34793
2010-11-05 18:00:35 +00:00
Martin Mathieson 829ee8752b Add 'ndi' and 'harq-id' as new MAC-PHY DL attributes.
svn path=/trunk/; revision=34753
2010-11-02 15:20:38 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Martin Mathieson c53d8b200b Let DCT2000 tree extend to end of ipprim or sctpprim bytes.
svn path=/trunk/; revision=33919
2010-08-25 13:27:27 +00:00
Martin Mathieson b7158c4e2d Fix ipprim IPv6 port number offsets.
svn path=/trunk/; revision=33840
2010-08-18 10:47:21 +00:00
Martin Mathieson 75af18e3a8 Show IPv6 addresses in ipprim summary line.
svn path=/trunk/; revision=33839
2010-08-18 10:33:54 +00:00
Martin Mathieson dbb4538ec8 Improve the way the encoded FP variant is interpreted.
svn path=/trunk/; revision=33785
2010-08-12 15:30:56 +00:00
Martin Mathieson b10fb789ef Don't use sprintf().
svn path=/trunk/; revision=33668
2010-07-29 09:39:52 +00:00
Martin Mathieson 4a4f1965e9 Improve display of tty lines.
svn path=/trunk/; revision=33667
2010-07-29 09:30:09 +00:00
Martin Mathieson b2a872cd9f Show grant-subframe from context info.
svn path=/trunk/; revision=33437
2010-07-05 16:45:36 +00:00
Martin Mathieson 735ec2d6d2 For DL HARQ retx, support knowing result or not.
svn path=/trunk/; revision=33431
2010-07-05 10:35:17 +00:00
Martin Mathieson 892d3112ed Add a filter for DCT2000 error strings, and allow it be included in generated filters from RLC status window.
svn path=/trunk/; revision=32946
2010-05-25 14:02:17 +00:00
Martin Mathieson 5ed2e2f914 Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting
svn path=/trunk/; revision=32611
2010-04-30 17:15:59 +00:00
Martin Mathieson b3a29fcb32 Add some extra (optional) physical layer attributes to logged MAC frames.
svn path=/trunk/; revision=32190
2010-03-14 17:56:37 +00:00
Guy Harris ce3c4b2370 Get rid of unnecessary casting away of const.
svn path=/trunk/; revision=32024
2010-02-27 01:12:24 +00:00
Martin Mathieson 7b2a3c26e6 Recognise update string for SR failure, and show ueid in MAC if set.
svn path=/trunk/; revision=31916
2010-02-18 21:24:47 +00:00
Stig Bjørlykke c198fc6546 From Didier Gautheron via bug 4419:
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00
Martin Mathieson 88447bd5cb Add needed offset to 'radio-type' attached to MAC frame.
svn path=/trunk/; revision=31469
2010-01-08 16:08:22 +00:00
Martin Mathieson 9781efbc67 Getting ready to dissect CPRI C&M commands.
svn path=/trunk/; revision=31391
2009-12-29 22:57:10 +00:00
Martin Mathieson 2e3dc7f0f4 Flag errors with expert info.
svn path=/trunk/; revision=30748
2009-10-28 19:00:41 +00:00
Martin Mathieson b712bb0f19 Add a preference to control whether or not comment strings are scanned for oob LTE MAC messages. Scanning them is probably quite slow.
svn path=/trunk/; revision=30713
2009-10-26 16:40:57 +00:00
Martin Mathieson afffcffff9 Add support for displaying/filtering some LTE MAC out-of-band events.
svn path=/trunk/; revision=30711
2009-10-26 15:39:00 +00:00
Martin Mathieson 6dfb4d1f71 Add support for showing/filtering/resaving logged LTE strings.
svn path=/trunk/; revision=30700
2009-10-26 00:04:27 +00:00
Martin Mathieson 261a938bac Show UEId in info column for CCCH frames.
svn path=/trunk/; revision=29892
2009-09-14 10:26:53 +00:00
Kovarththanan Rajaratnam 6fe1060cd1 Don't pass ep_alloc()'ed strings to col_set_str().
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984

svn path=/trunk/; revision=29726
2009-09-06 04:26:50 +00:00
Bill Meier 94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd.
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Martin Mathieson 5560cb61c0 Show CRC errors for RARs.
svn path=/trunk/; revision=29548
2009-08-25 11:01:51 +00:00
Martin Mathieson 8760a6b49d Allow s1ap not to be dissected (to avoid seeing errors, possibly due to proprietary variants).
svn path=/trunk/; revision=29420
2009-08-15 01:29:29 +00:00
Martin Mathieson 19d117fb97 Remove calls to check_col(), and stop giving '{' a line of its own.
svn path=/trunk/; revision=29078
2009-07-13 10:55:53 +00:00
Martin Mathieson 47552ea3a4 Add preference for turning off LTE RRC.
svn path=/trunk/; revision=28988
2009-07-07 14:38:14 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier 548e468959 Misc dissector cleanup:
- Make some fcns & vars static
- hf[] blurbs: "" and repeated text --> NULL
- Move proto_register & proto_reg_handoff to end of source
- packet-catapult-dct2000: simplify proto_reg_handoff
- Use consistent indentation

svn path=/trunk/; revision=28488
2009-05-26 16:01:12 +00:00
Martin Mathieson 4dda12f0be - add direction filter to PDCP
- fix PDCP fields ("pdcp.*" -> "pdcp-lte.*")
- improve PDCP info column output (to be more like RLC)

svn path=/trunk/; revision=28342
2009-05-13 09:36:42 +00:00
Martin Mathieson ea18cc4095 Enable preference to call LTE RRC for data inside PDCP frames.
svn path=/trunk/; revision=28329
2009-05-11 15:19:51 +00:00
Martin Mathieson 18f0722913 Try to cast away win64 buildbot problem.
svn path=/trunk/; revision=28191
2009-04-28 10:05:56 +00:00
Martin Mathieson 231928b308 Avoid calling strlen() lots of unnecessary times when parsing outhdr values.
svn path=/trunk/; revision=28190
2009-04-28 09:22:35 +00:00