freeing our data structures, we can go through all those structures and
free up the hash tables associated with them, rather than just leaking
them.
svn path=/trunk/; revision=13891
"gtk_style_copy()" has a reference count of 1; release the reference
when we're finished setting other widgets' styles to it.
svn path=/trunk/; revision=13890
whether the suboption data offset plus the suboption data length is >,
not >=, the end of the option data - the end of the option data is the
first byte *after* the option data.
For CableLabs string suboptions, use the right offset when fetching the
data.
svn path=/trunk/; revision=13884
structures allocated by a dissection. Currently, it's the same as
"init_dissection()", but they should be split with "init_dissection()"
allocating the initial data structures and "cleanup_dissection()"
freeing them and *not* reallocating the initial data structures.
Use "cleanup_dissection()" in "cf_close()" to make it easier to find leaks.
svn path=/trunk/; revision=13881
enough, and fix them - and handle the already-fixed case similarly (note
that the length is bogus, and break out of the loop).
Put object header items into the protocol tree in the order in which
they appear in the packet.
For unknown subobjects, make the "Data (N bytes)" item cover only the
data, not the header (which is already covered).
Fix the offset in some calls.
svn path=/trunk/; revision=13879
But what's the right way to do instead? Just inserted a return, this should do no harm.
Could someone with more knowledge of this dissector review this change?
svn path=/trunk/; revision=13878
so don't check whether they've done so with "DISSECTOR_ASSERT()".
("proto_item_set_string()" and friends already do so.)
Fix indentation.
svn path=/trunk/; revision=13876
filter after installing the filter.
Set HAVE_PCAP_LIB_VERSION if we're building with WinPcap 3.1; it's not
present in earlier versions, but is present in current 3.1 betas.
Check HAVE_PCAP_LIB_VERSION when building capture-wpcap.c.
svn path=/trunk/; revision=13872
TO THE DISSECTOR DEVELOPERS, PLEASE FIX THIS: I could easily found several places where a g_assert is called, depending on the input packet data. NEVER DO THIS, as this crashes Ethereal simply by invalid packet data input!!!
svn path=/trunk/; revision=13868
update for q933
(and changes to move variable declarations to the start of a block since normal c compilers can not handle declarations in the middle of a block)
svn path=/trunk/; revision=13854
tables that are searched rather than dense tables that are indexed, so
there's no reason to tread payload types 130 and 131 specially.
svn path=/trunk/; revision=13844
when formatting numerical values for CSV lists, save the locale
before formatting, set the locale to the "C" locale, and then
restore the locale, so that numbers are always formatted with
"." as the decimal point;
add to the RTP streams window a Copy button that copies all data
from the CList to the clipboard as CSV.
svn path=/trunk/; revision=13842
Guy Harris