Commit Graph

6062 Commits

Author SHA1 Message Date
Jörg Mayer 6a1666b35d Add sequence number wrap to tcp window checking.
svn path=/trunk/; revision=5945
2002-08-03 23:20:06 +00:00
Jörg Mayer 98754219e2 The url to the IEEE data changed for non-interactive use.
Bring manuf up to date.

svn path=/trunk/; revision=5944
2002-08-03 23:09:24 +00:00
Guy Harris 6ed12f6993 Create the TCP protocol tree, and put the source and destination ports
into it, as soon as we've extracted the source and destination ports
from the packet, so that if we throw an exception fetching something
else from the packet, we still have the protocol tree and ports.

svn path=/trunk/; revision=5943
2002-08-03 22:28:16 +00:00
Guy Harris a7b0159be4 We don't use anything from <sys/socket.h> (we need to know the AF_INET6
values of the various BSDs that support DLT_NULL, but those aren't
necessarily the AF_ values on the machine on which you're building
Ethereal), so we don't need to include it.

svn path=/trunk/; revision=5942
2002-08-03 20:06:46 +00:00
Guy Harris faa7402f6e We don't use anything from <arpa/inet.h>, so we don't need to include
it.

svn path=/trunk/; revision=5941
2002-08-03 20:01:13 +00:00
Guy Harris 968a88bfdc We don't use anything from <sys/socket.h>, so we don't need to include
it.

svn path=/trunk/; revision=5940
2002-08-03 19:50:44 +00:00
Guy Harris b0cdf7988d We don't use anything from <sys/socket.h> (we need to know the AF_
values of the various BSDs that support DLT_NULL, but those aren't
necessarily the AF_ values on the machine on which you're building
Ethereal), so we don't need to include it.

svn path=/trunk/; revision=5939
2002-08-03 19:49:30 +00:00
Guy Harris f7cf55cccd We don't use anything from <arpa/inet.h>, so we don't need to include
it.

svn path=/trunk/; revision=5938
2002-08-03 19:47:50 +00:00
Guy Harris c62e5fd81a <netinet/in.h> is needed for <arpa/inet.h>, at least on some platforms,
and <sys/types.h> is needed for <netinet/in.h>.

On systems with "inet_pton()", the API is defined using "u_char", and
we're including <sys/types.h> on platforms that have it (which should be
most if not all UNIX platforms) and including <winsock2.h> on platforms
that have it (Windows), so we might as well use "u_char" and "u_int", as
the BSD version of "inet_pton.c" does.  (Besides, we weren't including
any GLib include files, so "guchar" and "guint" weren't getting defined
in any case.)

svn path=/trunk/; revision=5937
2002-08-03 19:37:48 +00:00
Guy Harris 38d08c8883 <netinet/in.h> is needed for <arpa/inet.h>, at least on some platforms,
and <sys/types.h> is needed for <netinet/in.h>.

svn path=/trunk/; revision=5936
2002-08-03 19:35:16 +00:00
Ronnie Sahlberg 052b8d6a05 Updated LogonControl2 and ServerAuthenticate2 functions
svn path=/trunk/; revision=5935
2002-08-03 10:48:46 +00:00
Jörg Mayer 49a2f32336 I still have to see a case when a MAC address starting with 0:0:0
actually means Xerox, but 0:0:0:0:0:0 can be found quite often.

svn path=/trunk/; revision=5934
2002-08-03 00:50:22 +00:00
Jörg Mayer 81125f51c0 Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents in the READMEs and examples in the doc/ directory.

svn path=/trunk/; revision=5933
2002-08-02 23:46:26 +00:00
Jörg Mayer 173fe5aef4 Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.

svn path=/trunk/; revision=5932
2002-08-02 23:36:07 +00:00
Ronnie Sahlberg ff72b97ee0 Two new options added to TCP.
1, Analyze TCP sequence numbers.
   This option will keep track of sequence numbers for all tcp sessions
   and flag the following:
   a, If a new segment is seen which is beyong the right edge this is
      an indication that the previous segment was lost and this will be
      flagged as previous segment lost.
   b, If a segment is seen which lies left of the right edge this is flagged
      as retransmission.
   c, if a keep-alive is seen (empty segment, seq==expected seq-1)
      this is flagged as a retransmission.
   d, if an ACK is seen which is beyond the right edge this is an indication
      that a segment has been lost and it will be flagged as segment lost.

   All ACKs which advance the left edge get the RTT displayed between the ACKed
   segment and the ACK itself. The ACK also gets an indication of WHICH segment
   it is an ACK for.

2, Relative sequence numbers. This option needs the first option to be selected
as well. This option will as best as it can try to get ethereal to use
relative sequence numbers instead of absolute ones.

The patch does not handle sequence number wrapping and unexpected results
can probably happen for such.

svn path=/trunk/; revision=5931
2002-08-02 22:41:56 +00:00
Jörg Mayer 96ab70e209 Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the gtk/ directory.

svn path=/trunk/; revision=5930
2002-08-02 22:34:54 +00:00
Jörg Mayer 7e4e31f94c Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the plugins/ directory.

svn path=/trunk/; revision=5929
2002-08-02 22:04:22 +00:00
Jörg Mayer 3105ee542f Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the epan/ directory but leave winsock2.h in inet_pton.c
and inet_ntop.c for now (can't estimate the consequences).

svn path=/trunk/; revision=5928
2002-08-02 21:29:45 +00:00
Jörg Mayer 9630bf353e Fix a few more memleaks found by valgrind (all deriving
from the get_persconffile_path mess).

svn path=/trunk/; revision=5927
2002-08-01 03:15:29 +00:00
Jörg Mayer db0d014224 Use <zlib.h> instead of "zlib.h"
svn path=/trunk/; revision=5926
2002-07-31 22:52:38 +00:00
Jörg Mayer bc82e18843 Add conditional include of winsock2.h again, so compilation with MSVC++
will work again without complaints.

svn path=/trunk/; revision=5925
2002-07-31 22:41:34 +00:00
Guy Harris 7f881fdcd4 From Jim McDonough: support for LsaQueryInformationPolicy2 in the LSA
dissector.

svn path=/trunk/; revision=5924
2002-07-31 21:22:39 +00:00
Guy Harris baf7543595 From Mike Frisch: fix a problem with decoding the AUTHORIZE call.
Update his e-mail address in the AUTHORS file while we're at it.

svn path=/trunk/; revision=5923
2002-07-31 19:58:28 +00:00
Guy Harris 5d929e0e8f From Motonori Shindo: support for reading CoSine L2 debug output.
svn path=/trunk/; revision=5922
2002-07-31 19:27:57 +00:00
Guy Harris 6b10bf4a37 Check whether the first byte of a putative TPKT header is 3 (the TPKT
version number from RFC 1006) and, if not, assume it's *not* a TPKT
header, and don't try getting the packet length and doing TPKT
dissection and reassembly.

svn path=/trunk/; revision=5921
2002-07-31 18:45:50 +00:00
Ronnie Sahlberg c56dc7ea38 Fix small typo
svn path=/trunk/; revision=5920
2002-07-31 11:16:19 +00:00
Guy Harris 39927e5db7 Don't loop forever in "find_rsvp_session_tempfilt()" or
"dissect_rsvp_msg_tree()" if there's a zero-length object.

In "find_rsvp_session_tempfilt()", check to make sure the data exists
before fetching it, so that it doesn't throw an exception - the
information it returns is only used to put items into the protocol tree,
so there's no reason to quit dissecting the packet just because it can't
find that information because, for example, not enough of the packet
data was captured.

svn path=/trunk/; revision=5919
2002-07-31 10:10:44 +00:00
Guy Harris 8751a85ac2 From Chris Waters: check 802.11 FCS if present.
svn path=/trunk/; revision=5918
2002-07-31 09:00:02 +00:00
Ronnie Sahlberg e930dd4a31 Adding a new macro CMP_ADDRESS similar to ADDRESS_EQUAL but this one will return
-1,0,1 as the xxxcmp() functions will instead of just true/false.
Useful if you not only want to check for equality but also if you want to have a way to order the elements.

svn path=/trunk/; revision=5917
2002-07-31 06:15:26 +00:00
Guy Harris e04fc7ebfd From Graeme Hewson:
Ethereal sometimes creates a progress dialog bar and then, if
	the processing is fast, quickly destroys it.  The resulting
	"flash" can be disconcerting.  This set of patches ensures a
	progress bar is either not created or is displayed for a minimum
	time.

svn path=/trunk/; revision=5916
2002-07-30 10:13:16 +00:00
Guy Harris 9c900f33ea Call "proto_item_add_subtree()" to create a subtree for POST data, don't
just use the return value of a "proto_tree_add" routine as if it could
be used as a protocol tree.

svn path=/trunk/; revision=5915
2002-07-30 07:36:22 +00:00
Guy Harris 4348b2e845 From Michael Tuexen: AF_INET6 support for DLT_NULL captures from
Darwin/MacOS X.  (As if FreeBSD and {Net,Open}BSD having different
AF_INET6 values wasn't enough, we have The Other BSD having its own
value....)

svn path=/trunk/; revision=5914
2002-07-30 07:25:29 +00:00
Guy Harris b0de25272d #ifdef out some variables not used on Windows.
If printing a single packet to a file, don't use the "print to a
printer" code for Windows.

Only free "print_args.dest" *after* the last usage.

svn path=/trunk/; revision=5913
2002-07-30 07:04:08 +00:00
Uwe Girlich 5fa90a663e Code from Jan Berkel <jan.berkel@gmx.de> to
* fully decode client->server packets (mouse movement, button press etc.)
* start of decoding server->client packets (names of first command as text)

svn path=/trunk/; revision=5912
2002-07-29 09:28:28 +00:00
Guy Harris ff0df5d8a4 From Didier Gautheron: add FPGetUserInfo.
svn path=/trunk/; revision=5911
2002-07-29 06:35:12 +00:00
Guy Harris 3365355534 From Joerg Mayer:
gtk/colors.c: Fix a memleak found by valgrind
   (Note that there are similar bugs in other functions that
   use the same construct with path!)

svn path=/trunk/; revision=5910
2002-07-29 06:30:01 +00:00
Guy Harris 6e21561be8 From Joerg Mayer:
All files:
  - Replace types from sys/types.h by those from glib.h
  - Replace ntoh family of macros from netinet/in.h and winsock2.h
    by g_ntoh family from glib.h
  - Remove now unneeded includes of sys/types.h, netinet/in.h and
    winsock2.h
wtap.h
  Move includes to the top

svn path=/trunk/; revision=5909
2002-07-29 06:09:59 +00:00
Richard Sharpe 4298a1f07d Committing Kerberos NetBIOS address type stuff from Jim McDonough.
svn path=/trunk/; revision=5908
2002-07-29 02:03:54 +00:00
Ronnie Sahlberg af6da1a420 Changed the SMB dissector to put ALL command PDUs in one SMB in the summary
line, separated by ;

It only prints "Request"/"Response" for the first command to save space

svn path=/trunk/; revision=5907
2002-07-27 05:03:53 +00:00
Ronnie Sahlberg 0fa3c02231 If conversations have already been created in lower layers, say TCP before
SMB sees the PDU, then SMB would forget to create the proper state variables and crash.

SMB is changed to split the operation into
1, only create a conversation if it needs to. (as before)
2, detect if it needs to create the si.ct state variables independant of
whether smb also created a conversation or not.

Without this patch and with changes to say TCP to create conversations ethereal would crash at the first packet the SMB dissector would see.

svn path=/trunk/; revision=5906
2002-07-27 03:18:29 +00:00
Guy Harris 6d68a964e5 From Stefan Wenk: remove an unnecessary +1 from some offset
computations.

svn path=/trunk/; revision=5905
2002-07-25 21:43:53 +00:00
Guy Harris e9310b2f14 For connection-oriented DCE RPC, show the stub data if we can't actually
do anything else with a request or reply (e.g., because we haven't seen
the bind request).

svn path=/trunk/; revision=5904
2002-07-25 21:30:58 +00:00
Tim Potter 617a6d883e Remove trailing space characters between a netbios name and the name type.
This makes the display look much nicer!

svn path=/trunk/; revision=5903
2002-07-22 20:52:21 +00:00
Guy Harris 976323d49a Update from Anand V. Narwani:
fix a minor problem in which the Info colum was incorrectly
	defaulted to "Fragmentation Frame";

	add 4 missing fields for the Extended header in Fragmentation
	frames.

svn path=/trunk/; revision=5902
2002-07-22 20:18:23 +00:00
Guy Harris 6c289aebb9 Fix up some comments.
Fix up a call to use the right byte-ordering routine (both routines have
the same effect, but we want to use the right one to make it clearer
what we're doing).

svn path=/trunk/; revision=5901
2002-07-21 20:31:21 +00:00
Guy Harris 1dd6c308ce Mention the "-h" flag.
Fix up the list of arguments to "-S" in the synopsis.

svn path=/trunk/; revision=5900
2002-07-21 20:28:35 +00:00
Guy Harris 73a4f43644 "yyin" is from lex/flex, so it should be "extern", not "static" - we
have to modify lex/flex's input stream, not some private "FILE *".

Fix up the usage message to:

	mention the "-h" flag;

	not mention the non-existent "-w" flag;

	fit within 80 columns.

Add "-h" to the list of options in the "getopt()" call, as there's code
to support it, and remove "-r" and "-w", as there wasn't any code to
support them.

svn path=/trunk/; revision=5899
2002-07-21 20:27:30 +00:00
Richard Sharpe b5fa2524e6 Fix the problems WRT overwriting a capture file. From Joerg Mayer.
svn path=/trunk/; revision=5898
2002-07-21 16:54:22 +00:00
Guy Harris 52896da39e Offsets in packets should be "int", not "guint8", unless there is an
*inviolable guarantee* that the offset will *never* be bigger than 255.
(The same applies for "guint16" and 65535.) Otherwise, you run the risk
of an infinite loop (packets are not guaranteed to be valid, nor are the
contents of capture files - and there's no guarantee that you're reading
a DOCSIS file if you've turned on the "force interpretation as DOCSIS"
flag.)

svn path=/trunk/; revision=5897
2002-07-21 00:22:17 +00:00
Guy Harris 206b6edb1b From Anand V. Narwani: fix to the Info column for Request frames.
svn path=/trunk/; revision=5896
2002-07-20 23:19:20 +00:00