1f4f0d535a
Remove expert_add_undecoded_item in favor of proto_tree_add_expert.
...
svn path=/trunk/; revision=51632
2013-09-01 16:41:29 +00:00
81f3faf1e8
Completely remove support for proto_item_set_expert_flags.
...
svn path=/trunk/; revision=51144
2013-08-05 02:25:45 +00:00
5a744f4afa
Remove unused data structures from new expert code. Cleans up another ~17KB
...
of leaks, and I suspect they won't be necessary (we can always add them back
using wmem if they do turn out to be needed).
svn path=/trunk/; revision=50409
2013-07-06 16:11:36 +00:00
0bc2afcd06
Allocate expert protocol structs with wmem, cleans up a few KB of leaks in
...
epan_cleanup().
svn path=/trunk/; revision=50406
2013-07-06 12:54:13 +00:00
34cd52a8e5
Fix the use of va_args in the new expert code. Passing a va_list to a ... is
...
valid, but doesn't do what you actually want most of the time.
svn path=/trunk/; revision=50392
2013-07-05 23:53:25 +00:00
7ae263b9e4
Differentiate "Disabled" from "Unknown" and provide macros for the enumerated values.
...
svn path=/trunk/; revision=50323
2013-07-02 20:08:49 +00:00
e16933f496
Add proto_tree_add_expert and proto_tree_add_expert_format. This was added to expert.h instead of proto.h because the underlying code to process expert info is static (and should probably remain so). Also, proto_tree_add_expert and proto_tree_add_expert_format follow "expert info" rules in that they should be called regardless of tree status (even though they take a tree as an argument), unlike the functions in proto.h
...
Also added an enumeration for checksum validation status, as verifying checksums is considered "expert" functionality.
svn path=/trunk/; revision=50322
2013-07-02 19:53:28 +00:00
ecc4e4789e
Cache the malformed filter instead of looking it up each time a malformed packet comes in. This drastically speeds up the load time of captures with lots of malformed packets (ie fuzztesting).
...
svn path=/trunk/; revision=50313
2013-07-02 16:02:31 +00:00
369658c499
inform expert info layer about the current number of packet comments
...
when the last comment is removed and we have no other expert info,
the maximum severity is changed from comment to none
svn path=/trunk/; revision=50091
2013-06-20 22:25:33 +00:00
586df977d1
Ensure most severe is displayed in expert column. Bug 7733 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7733 )
...
#BACKPORT
svn path=/trunk/; revision=49565
2013-05-24 19:23:36 +00:00
71bc722866
expert_add_info(): we can't use va_start()/va_end() so don't try to use a va_list (which isn't used by the called function) either.
...
svn path=/trunk/; revision=49564
2013-05-24 19:14:09 +00:00
44b437c331
expert_add_info() doesn't take a variable number of args; don't use va_start()/va_end().
...
svn path=/trunk/; revision=49563
2013-05-24 18:15:09 +00:00
0d1a4b2920
Add expert info configuration framework. Bug 2412 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2412 ).
...
Expert info "fields" can now be registered/addressed by name. Right now, the basic framework allows expert info fields to become "display filters". However more could be done, like user preferences overriding default severity level, speeding up expert info dialog load time by not needing to redissect a file, etc.
Long term goal is to have all expert_info filterable and have the functionality of expert_add_info_format() include the "registered index". expert_add_info_format_text() is the workaround until all current calls to expert_add_info_format() have been updated with either expert_add_info() or expert_add_info_format_text(). Then the remaining expert_add_info_format_text() will be renamed to expert_add_info_format().
svn path=/trunk/; revision=49559
2013-05-24 17:59:36 +00:00
0df5a9390d
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397
svn path=/trunk/; revision=48438
2013-03-20 01:18:10 +00:00
1b1716638a
Move expert_group_vals expert_severity_vals constant definitions to expert.h
...
svn path=/trunk/; revision=47995
2013-03-02 01:00:20 +00:00
3729335973
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45016
2012-09-20 01:48:30 +00:00
e6ffe7b59b
Add a missing NULL check pointed out by Jakub.
...
svn path=/trunk/; revision=44437
2012-08-10 22:52:04 +00:00
cd3cca7edc
Make the corresponding packet_info available to each tree item. This
...
lets us pass a NULL pinfo to expert_add_info_format() and
expert_add_undecoded_item(), which makes it possible to use those
routines deep in the bowels of many dissectors. As a proof of concept
remove the recent pinfo additions to packet-afp.c. This should also make
it easier to fix bug 3884.
svn path=/trunk/; revision=44435
2012-08-10 20:33:01 +00:00
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
9c9d57321f
Fix compiler warning: "format not a string literal and no format arguments"
...
svn path=/trunk/; revision=43509
2012-06-27 14:44:00 +00:00
e42127ce00
Don't show (essentially meaningless) numeric values of the expert codes.
...
svn path=/trunk/; revision=43508
2012-06-27 14:15:46 +00:00
f2e85a5a96
Display expert codes in hexadecimal (less painful for my eyes :))
...
svn path=/trunk/; revision=43497
2012-06-26 19:36:08 +00:00
3fa645481f
Followup to r43176, r43177, r43178, and r43179: prohibit FT_*INT*
...
with BASE_NONE (or other future display values).
Don't use BASE_NONE with FT_UINT32s in the expert info fields.
svn path=/trunk/; revision=43412
2012-06-20 17:25:53 +00:00
ff47bdf96c
Use the expert system to show packet comments.
...
The packet comment widget should be replaced by a ListView with two columns, packet no and Comment.
svn path=/trunk/; revision=41322
2012-03-02 13:31:16 +00:00
0a1072b083
Treat expert info as a <field> instead of a <proto> when exporting to pdml.
...
svn path=/trunk/; revision=40204
2011-12-14 21:13:06 +00:00
4e20e37aa6
Use ENC_NA for FT_PROTOCOL.
...
svn path=/trunk/; revision=38125
2011-07-19 19:37:58 +00:00
0d128b2c87
Revert r37702 in favour of r37705 for bug 6035.
...
svn path=/trunk/; revision=37706
2011-06-19 10:15:58 +00:00
5faf9008af
Use BASE_DEC for expert.group and expert.severity.
...
This fixes bug 6035.
svn path=/trunk/; revision=37702
2011-06-18 22:52:00 +00:00
07cd05fa52
Use PI_UNDECODED instead.
...
svn path=/trunk/; revision=37392
2011-05-25 13:17:51 +00:00
ccecf5b98b
Add a convinience function to add expert warnings for not dissected items.
...
svn path=/trunk/; revision=37391
2011-05-25 11:05:23 +00:00
e88b2f1fc9
Make frames containing Malformed expert items match with "malformed" display filter.
...
svn path=/trunk/; revision=33551
2010-07-16 11:17:32 +00:00
9417ceec42
Clean up implementation.
...
svn path=/trunk/; revision=32039
2010-02-27 22:12:43 +00:00
2efa26e0e1
Fix a double-free bug which was causing a crash. Our decryption buffer
...
length doesn't change, so allocate it just once. Add an expert item for
a successful decryption.
svn path=/trunk/; revision=31571
2010-01-19 19:28:30 +00:00
29a4a0789a
Added expert info group PI_PROTOCOL.
...
svn path=/trunk/; revision=31308
2009-12-18 15:13:44 +00:00
53b061495d
Whitespace changes
...
svn path=/trunk/; revision=30210
2009-09-30 13:04:06 +00:00
3a13c1a2a4
Modified extarct from Didier Gautheron:
...
optimizations patch http://wiki.wireshark.org/Development/Optimization
'patch.29854.diff.gz"
- ei->protocol is a constant.
- Don't setup expert tap data if there's no tap.
svn path=/trunk/; revision=29873
2009-09-13 13:39:09 +00:00
0e5cef61be
Split a bunch of init routines into init() and cleanup(). This allows us to free memory properly on shutdown.
...
This is an initial step. There's still some work to do.
svn path=/trunk/; revision=29754
2009-09-06 18:25:23 +00:00
083729e02c
Add PTREE_FINFO and use PITEM_FINFO when possible.
...
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
3653b21838
Added missing PI_DEBUG to expert_group_vals[].
...
svn path=/trunk/; revision=28636
2009-06-04 14:22:16 +00:00
4f34bb9b15
From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
...
- As suggested actually use sizeof(...) rather than a numeric constant.
- g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.
svn path=/trunk/; revision=27772
2009-03-18 15:03:46 +00:00
d52fd5e311
From Jakub Zawadzki and me (bug 3283):
...
Added display filter for packets with expert info.
svn path=/trunk/; revision=27668
2009-03-09 00:26:25 +00:00
3b509e89ae
- add a column for the expert info severity level
...
- fix a column related bug introduced in SVN 20118
svn path=/trunk/; revision=22387
2007-07-23 20:11:05 +00:00
2896811274
Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
...
Comment out -Werror in plugins/asn1/ until warnings can be fixed.
svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
d4499eb9a7
move value_strings from expert_dialogs into expert.c to remove duplicates
...
keep the highest severity level of the current file (experimental)
svn path=/trunk/; revision=19104
2006-08-31 22:56:38 +00:00
89f022b12b
name change
...
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
20707c71ec
Assure that pinfo is a valid pointer. Related to Coverity CID 112
...
svn path=/trunk/; revision=17601
2006-03-12 16:42:10 +00:00
8e121c003c
Don't se_leak expert_info records.
...
se_alloc them where and if needed, not every time expert_set_info_vformat is called.
svn path=/trunk/; revision=17293
2006-02-13 23:20:38 +00:00
5d66658184
from Greg Morris:
...
Composite Expert statistics, see:
http://www.ethereal.com/lists/ethereal-dev/200511/msg00002.html
and the following discussions
svn path=/trunk/; revision=16593
2005-11-25 23:42:52 +00:00
d8873511a7
Frame numbers are unsigned, and they start at 1; 0 is what's used for
...
"unknown" for frame numbers. Note that in epan/frame_data.h, and make
the frame number in experts unsigned, and use 0 for "unknown", and
display it as an unsigned number - and, if it's 0, don't display it at
all.
Fix the signature of "expert_dlg_draw()" to match what a tap's draw
routine's signature is expected to be.
svn path=/trunk/; revision=15760
2005-09-11 22:25:33 +00:00
642467ad5c
I'm adding the "Expert Info" prototype now, as it seems to be in a state where others might have a look and probably already find it useful :-). Anyway, we can easily disable it at one or two places in the code if it get's in our way of a new release.
...
Please see: http://wiki.ethereal.com/Development/ExpertInfo for a complete overview of the intended feature and it's current state of implementation.
While I'm working on this, I've also added some more status result codes to the DCE/RPC and DCOM dissectors.
svn path=/trunk/; revision=15754
2005-09-11 16:55:34 +00:00
Michael Mann