Commit Graph

86725 Commits

Author SHA1 Message Date
Gerald Combs 877498ad0b [Automatic update for 2023-02-12]
Update manuf, services enterprise numbers, translations, and other items.
2023-02-12 16:46:06 +00:00
João Valverde 6d401f2eba CMake: Add a comment about dissector headers 2023-02-12 14:50:00 +00:00
João Valverde bb426c7a85 CMake: Remove unnecessary wmem object library
The cmake wmem sub-library code is superfluous and adds complexity
if trying to build parallel different configurations of wsutil.
2023-02-12 13:25:44 +00:00
Martin Mathieson 643fd70229 RTPS: Make a function static 2023-02-11 23:23:28 +00:00
Gerald Combs 53b2994b43 Docbook: Reorganize our guide directories
Move the top-level user-guide.adoc and developer-guide.adoc to their
respective source directores. This is in preparation for a future
toolchain revamp.

Move the wsug_graphics directory to wsug_src/images and wsdg_graphics
directory to wsdg_src/images. Copy common_graphics/* to the each images
directory and remove common_graphics. We only have five admonition
graphics; duplicating them lets us remove some build config overhead.

Rename wsluarm.adoc to wsdg_src/wsdg_lua_support.adoc.

Remove a dummy file.

Tested visually and by enabling `--failure-level=WARN`.
2023-02-11 21:09:46 +00:00
ismaelrti dedad3403a RTPS: Show topic name in info column of ACKNACK, GAP and other submessages
Added the topic name if known to columns of packets that contains
ACKNACK (and fragments), GAP, HEARTBEAT...
2023-02-11 19:57:27 +00:00
John Thacker 994669e5b3 UAT: Have a combobox for Dissectors
Add a drop-down combobox for UATs, including User DLTs, that
have a choice of dissectors. Make the combobox editable, which
will provide suggestions, and pass things through to the existing
UAT validation for dissectors. (It's a very long list, especially
with 1717 entries, including 530 just from various BT GATT UUIDs,
so being able to still type it in seems useful.)

Dissectors are not protocols. Rename the UAT field from PROTO to
DISSECTOR where used. Update the column names and long descriptions
to use dissector instead of protocol in dissectors that used this.
There may at some point be UATs that want protocols instead of
dissectors, but that's not what the current behavior does and
none of the current dissectors that use the existing types want.

Update the documentation to use "dissector" instead of "protocol."
Put the names of the actual current three Ethernet dissectors.
Clarify that the "ip" dissector actually tries IPv4 and IPv6,
instead of just IPv4.

UAT entries are backwards and forwards compatible with versions
without this change.

Fix #18836.
2023-02-11 16:40:13 +00:00
John Thacker 0c79fecac3 wscbor: Ensure skip if errors advances the offset
wscbor_skip_next_item should not return to the beginning offset
if there are errors, because this makes wscbor_skip_if_errors
do the opposite of what it claims. In the case where the errors
involve having far too many items in a list, this can cause
memory exhaustion or infinite loops.

Fix #18782. Fix #18840.
2023-02-11 13:08:48 +00:00
Tomasz Moń 2031c3278b
USB MSC BOT: Workaround USBLL reassembly limitations
Mass Storage Bulk Only Transport prohibits ending data transfers with
zero length packet. This is generally not problematic when capturing at
OS URB level, but it does raise issues when capturing at USB Link Layer.

USBLL dissector has no idea where the transfer ends. It will concatenate
SCSI Data IN with CSW and SCSI Data OUT with next CBW whenever SCSI Data
length is multiple of bulk endpoint max packet size (virtually all Read
and Write commands because most common sector sizes are 512 and 4096).

CBW and CSW always end transfer reassembly because they must start at
packet boundary and their size is not equal to bulk max packet size.

Merging Data IN with CSW poses no problems at all. The only end user
visible difference is that Data IN and CSW appear in single packet (the
packet where reassembly ends).

Merging Data OUT with next CBW is ok for practical purposes, because
host periodically issues TEST UNIT READY (which does not have data
transfer and thus is not subject to the issue). While the CSW (and thus
SCSI status) will appear before Data OUT (and next CBW), the packets
will be correctly linked.

Workaround USBLL reassembly limitation by anticipating that SCSI Data
can be concatenated with Bulk Only Transport wrappers. Proper solution
would involve implementing a framework to allow USB class dissectors to
signal expected transfer length on Bulk IN or Bulk OUT endpoint whenever
CBW is encountered.
2023-02-10 22:04:46 +01:00
Tomasz Moń cd14ebf2df
USB MSC BOT: Move CBW and CSW dissection to functions
Move CBW and CSW dissection to separate functions to make it possible to
reuse the CBW/CSW dissecting code later. No functional changes.
2023-02-10 22:04:42 +01:00
João Valverde 9fca1acb40 CMake: Remove dumpcap dependency on ui 2023-02-10 20:59:22 +00:00
João Valverde 7fd4e2e542 Move ui/filter_files.[ch] to wsutil 2023-02-10 20:59:22 +00:00
João Valverde cf8107eb2a Move ui/clopts_common.[ch] to wsutil 2023-02-10 20:59:22 +00:00
João Valverde 0cea64a632 Move ui/cmdarg_err.[ch] to wsutil 2023-02-10 20:59:22 +00:00
Daniël van Eeden d117e47673 MySQL: decode cloning packets
Some info about this can be found on https://dev.mysql.com/doc/refman/8.0/en/clone-plugin.html
however I didn't find much protocol documentation.
2023-02-10 20:33:01 +00:00
Gtker 6deec49b4c woww: Fix missing BASE_VAL64_STRING for 64 bit type 2023-02-10 19:45:14 +00:00
Gtker e5a35c2125 woww: Fix `index` variable shadowing global C function 2023-02-10 19:45:14 +00:00
Gtker 285534ed37 woww: Fix not using VALS64 for item_class_and_sub_class 2023-02-10 19:45:14 +00:00
Gtker 40b64f133f woww: Remove unused variables 2023-02-10 19:45:14 +00:00
Gtker be9e4d86a7 woww: Add faction and item enums 2023-02-10 19:45:14 +00:00
Gtker fb2b33a523 woww: Remove SMSG_COMPRESSED_MOVES 2023-02-10 19:45:14 +00:00
Gtker f1019b211d woww: Update SMSG_MONSTER_MOVE 2023-02-10 19:45:14 +00:00
Gtker 33dfc4e75a woww: Rename unknown fields on SMSG_ADDON_INFO 2023-02-10 19:45:14 +00:00
Gtker 73c45d7aae woww: Add spell trigger type 2023-02-10 19:45:14 +00:00
Gtker 701bca2813 woww: Replace hf_woww_damage_type with spell_school 2023-02-10 19:45:14 +00:00
Gtker 10eb24f4df woww: Add stat type enum and remove item_stat_value 2023-02-10 19:45:14 +00:00
Gtker 19dde277ad woww: Add item class and subclass enum 2023-02-10 19:45:14 +00:00
Gtker ba50fc09bb woww: Add bonding enum 2023-02-10 19:45:14 +00:00
Gtker fb2f78c6aa woww: Refactor enums and remove allowed_classes hf 2023-02-10 19:45:14 +00:00
Gtker b08b20f5d2 woww: Add NONE to area enum 2023-02-10 19:45:14 +00:00
Gtker a27110e0fe woww: Suffix MAP_MONASTERY with _UNUSED 2023-02-10 19:45:14 +00:00
Gtker be1a87894b woww: Fix typos in MAP enums 2023-02-10 19:45:14 +00:00
Gtker a9cef8a187 woww: Add previously missing movement messages 2023-02-10 19:45:14 +00:00
Gtker 65dc7dff9f woww: Add MSG_CHANNEL_START 2023-02-10 19:45:14 +00:00
Gtker b0370bf17a woww: Make *MSG_WARDEN_DATA take encrypted data arrays 2023-02-10 19:45:14 +00:00
Gtker 1bc82c5b4c woww: Fix booleans large than 1 byte having ENC_NA and add CMSG_DBLOOKUP 2023-02-10 19:45:14 +00:00
Gtker 534a6d4e8a woww: Update maximum length for null terminated strings
This is required for quest texts and descriptions which are often very
long.
2023-02-10 19:45:14 +00:00
Gtker 206cd1084f woww: Remove _guid suffix from most variables
This reduces the amount of duplicated entries and cleans up the naming.
2023-02-10 19:45:14 +00:00
Gtker 08c98e9a8a woww: Change field name in SMSG_SPELLLOGEXECUTE 2023-02-10 19:45:14 +00:00
Gtker c8d7405724 woww: Updating naming of variables for consistency 2023-02-10 19:45:14 +00:00
Gtker 7690a50180 woww: Add unknown field in SMSG_BATTLEFIELD_STATUS 2023-02-10 19:45:14 +00:00
Gtker a9093e9015 woww: Add layout for SMSG_PLAYER_SKINNED 2023-02-10 19:45:14 +00:00
Gtker c1c72d5a06 woww: Add unknown SMSG_SPELLORDAMAGE_IMMUNE field 2023-02-10 19:45:14 +00:00
Gtker 195ce91351 woww: Update SMSG_SPELLLOGEXECUTE layout 2023-02-10 19:45:14 +00:00
Gtker 52526602f1 woww: Fix mirror timer names and various layouts 2023-02-10 19:45:14 +00:00
Gtker cba256048f woww: Add creature_family enum 2023-02-10 19:45:14 +00:00
Gtker e178357c23 woww: Fix SMSG_PET_SPELLS optional fields 2023-02-10 19:45:14 +00:00
Gtker f5fcd860da woww: Add more of SMSG_LOOT_RESPONSE layout 2023-02-10 19:45:14 +00:00
Gtker 61a54a9d3b woww: Fix SMSG_RESURRECT_REQUEST layout 2023-02-10 19:45:14 +00:00
Gtker 2b663dc4a3 woww: Correct layouts related to spells 2023-02-10 19:45:14 +00:00