Commit Graph

41681 Commits

Author SHA1 Message Date
Bill Meier 85e9ca3940 Create/use extended value strings as appropriate;
Remove unneeded initializers;
Do whitespace changes.

svn path=/trunk/; revision=44003
2012-07-25 17:38:05 +00:00
Martin Mathieson e1258c6e15 Remove handlers for a couple of events we're not interested in.
svn path=/trunk/; revision=44002
2012-07-25 17:18:36 +00:00
Martin Mathieson 4b4eb03153 Only call cairo_stroke() when the colour changes, and at the end of the
long list of elements.  Now the graph is like greased lightening!

I will look later to see if I can apply the same change to the TCP
graphs.

svn path=/trunk/; revision=44001
2012-07-25 15:34:31 +00:00
Bill Meier ced3a6c006 Minor cleanup:
- Use col_...() fcns in the proper manner and order;
- proto_reg_handoff...() not needed (does nothing useful);
- remove some unneeded initializers;
- reformat hf[] entries.

svn path=/trunk/; revision=44000
2012-07-25 15:32:29 +00:00
Anders Broman ae021363c8 Unify the AktionEntries for apply/prepare filter we should probably
do the same type thing for the ui_desciptions.

 eg put a "place holder" in the UI descriptions and
make a call from main_menubar.c i.e add_filter_menu()
and do the UI stuff there.

svn path=/trunk/; revision=43999
2012-07-25 15:15:16 +00:00
Martin Mathieson 8fcbfe6022 When drawing the line elements, only call gdk_cairo_set_source_color()
when the element colour changes.

svn path=/trunk/; revision=43998
2012-07-25 15:11:14 +00:00
Bill Meier 19000cbaf5 Minor cleanup:
- Remove some unneeded initializers & casts;
- whitespace.

svn path=/trunk/; revision=43997
2012-07-25 15:04:19 +00:00
Bill Meier 7dd0cf41ce Minor cleanup:
- col_clear() not required;
 - use #if 0/#endif to comment out code (iso /* ... */)
 - whitespace.

svn path=/trunk/; revision=43996
2012-07-25 14:39:32 +00:00
Bill Meier 0800534e66 #include <stdio.h> not needed.
svn path=/trunk/; revision=43995
2012-07-25 13:59:41 +00:00
Bill Meier 572b4dae32 Minor cleanup:
- col_clear() not required;
- ...

svn path=/trunk/; revision=43994
2012-07-25 13:57:22 +00:00
Michael Mann 32ef0a1a18 Converted scsi dissectors display filter format from scsi.<protocol> to scsi_<protocol> (matching their registered filter name)
svn path=/trunk/; revision=43993
2012-07-25 13:56:15 +00:00
Bill Meier 2516627cd5 Minor cleanup:
col_clear() not required;
  unneeded initializers;
  whitespace.

svn path=/trunk/; revision=43992
2012-07-25 13:38:31 +00:00
Jakub Zawadzki 7d900f7450 Fix bug #7347: "Resize All Columns" fails in Time Column
If column is based on frame data packet_list_get_widest_column_string() 
was constructing his own frame_data with biggest *value* for given column
(which might be not the longest string) and later fill column for it.

Which generally should work (time precision is fixed),
but in r41185 to lot col_*() function was added check if fd->flags.has_ts is set.
packet_list_get_widest_column_string() was passing frame_data with flags.has_ts unset.

To make maintaince easier, instead of fixing the problem with flags.has_ts,
generate column buffer for each frame, and find the one which has longest string.


svn path=/trunk/; revision=43991
2012-07-25 12:52:47 +00:00
Michael Mann 6d06ea6062 Converted ZigBee dissectors display filter format from zbee.<protocol> to zbee_<protocol>
Also corrected zbee_afp filters as they were incorrectly using zbee.app

svn path=/trunk/; revision=43990
2012-07-25 12:19:21 +00:00
Alexis La Goutte f4f8e88ae9 lupdate QtShark.pro (with the last change in translation and help menu)
Updating 'qtshark_de.ts'...
   Found 69 source text(s) (23 new and 46 already existing)
Updating 'qtshark_fr.ts'...
   Found 69 source text(s) (25 new and 44 already existing)    Kept 1 obsolete entries

There is new string to translate....

svn path=/trunk/; revision=43989
2012-07-25 12:00:38 +00:00
Alexis La Goutte e9c6f329c0 Add some link (URL) to Help Menu in QtShark
* Use QtAutoconnect feature
* no (yet ?) use help_dlg.* function (topic_action, topic_online_url...)


svn path=/trunk/; revision=43988
2012-07-25 11:57:05 +00:00
Alexis La Goutte dece67951b Add some link (URL) to Help Menu in QtShark
* Use QtAutoconnect feature
* no (yet ?) use help_dlg.* function (topic_action, topic_online_url...)


svn path=/trunk/; revision=43987
2012-07-25 11:53:44 +00:00
Alexis La Goutte d31651c42c Add Help Menu to QtShark
* with new "item" Ask A&Q (not yet available in GTK Gui)
* No yet link (next step)
* No icon...


svn path=/trunk/; revision=43986
2012-07-25 11:49:03 +00:00
Michael Mann cdee738998 Fix NULL deference (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7486).
I don't understand the relationship between the "frame data" and the "conversation" (to me they seem independent, but the code seems to put them together), but at least this fixes the crash 

svn path=/trunk/; revision=43985
2012-07-25 11:27:01 +00:00
Anders Broman 91763a17be From Johan Wåhl:
Make DNS ports configurable.

svn path=/trunk/; revision=43984
2012-07-25 09:40:18 +00:00
Anders Broman e5d974ec6a From Jacob Nordgren and Rishie Sharma:
- FP: added payload CRC validation, RLC: some more error reporting 
- RLC: fixed an exotic LI bug, some cosmetic fixes.

svn path=/trunk/; revision=43983
2012-07-25 09:09:32 +00:00
Anders Broman 967a3c9ce4 From Rishie Sharma:
Add a new CRC16 routine.

svn path=/trunk/; revision=43982
2012-07-25 08:57:33 +00:00
Michael Tüxen 11c86ec476 Update recv/drop counters also when no threads are used.
This should fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7523

svn path=/trunk/; revision=43981
2012-07-25 07:08:20 +00:00
Martin Mathieson d14fa0eb0f When zooming in, never subdivide whole numbers on the Y axis (they are
sequence numbers).

svn path=/trunk/; revision=43980
2012-07-25 02:56:51 +00:00
Gerald Combs b10b774bc6 Make sure xcopy can figure things out on its own.
svn path=/trunk/; revision=43979
2012-07-25 00:47:11 +00:00
Gerald Combs 6d0149175a Make sure wireshark.exe and tshark.exe don't depend on pseudotargets.
svn path=/trunk/; revision=43978
2012-07-25 00:37:29 +00:00
Martin Mathieson 2286e329b2 Don't increase refnum unless graph is created. Also, don't allocate
graph until know that we were able to choose a TCP session.
This could fail if e.g. a MAC LTE frame had > 1 bearers carrying TCP
segments.

svn path=/trunk/; revision=43977
2012-07-25 00:07:47 +00:00
Gerald Combs f25ae3613a Fix the dependencies for wireshark.exe and tshark.exe and use "xcopy
/d" instead of "copy" in Makefile.nmake. Fix the uninstall.exe path in
packaging\nsis\Makefile.nmake. This keeps us from clobbering existing
files in wireshark-gt2 unnecessarily.

svn path=/trunk/; revision=43976
2012-07-24 23:59:42 +00:00
Bill Meier b63bb802ab (Trivial) Cleanup
svn path=/trunk/; revision=43975
2012-07-24 23:25:57 +00:00
Bill Meier 25336651ac (Minor) Create handle in proto_reg_handoff...() (where it's used);
Localize static variable to proto_reg_handoff...()

svn path=/trunk/; revision=43974
2012-07-24 22:57:25 +00:00
Bill Meier 3ef558ba7c (Minor) Localize a static variable;
svn path=/trunk/; revision=43973
2012-07-24 22:51:15 +00:00
Martin Mathieson b342ac680d Don't leak the graph (or skip a graph refnum) if single RLC channel not
found in selected frame in the packet list.

svn path=/trunk/; revision=43972
2012-07-24 22:43:10 +00:00
Bill Meier 08c1114822 Move proto_register..() and proto_reg_handoff...() to the end of the file;
Do other minor cleanup.

svn path=/trunk/; revision=43971
2012-07-24 22:38:13 +00:00
Bill Meier 2be8004129 General cleanup, including:
- prevent potential array overflow: do some bounds checking;
- use emem_strbuf instead of buffers on the stack;
- check_col() not required;
- simplify code in several places;
- remove some boilerplate comments;
- ...

svn path=/trunk/; revision=43970
2012-07-24 21:30:25 +00:00
Martin Kaiser 295b919f5d MPEG PAT: set the tree item's length == number of bytes dissected
don't simply assume the PAT continues until the end of the input tvb

this is similar to packet_dvb_ait.c
I'll change this for other tables shortly

svn path=/trunk/; revision=43969
2012-07-24 21:24:33 +00:00
Jakub Zawadzki fcb17c5558 Make proto_tree_draw wrapper function to proto_tree_draw_resolve.
svn path=/trunk/; revision=43966
2012-07-24 19:49:47 +00:00
Gerald Combs 8d050c2828 Remove uninstall_installer.exe when we're done with it so that we don't
have an extraneous executable in the staging directory.

svn path=/trunk/; revision=43965
2012-07-24 16:30:03 +00:00
Bill Meier 05935f075a (Trivial) remove unneeded #include.
svn path=/trunk/; revision=43962
2012-07-24 15:11:18 +00:00
Anders Broman 88f8b100a2 Analyze->Apply as Filter and Analyze->Prepare a Filter cause crashes
user_data is NULL in the callbacks from the menu_bar, and when preparing filters we need to find the filter widget with g_object_get_data(G_OBJECT(data), E_DFILTER_TE_KEY).
The object is saved in the global variable popup_menu_object.
Use that in the filter callbacks from the menu bar.
- remove unused widget from a couple of callbacks.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7506

svn path=/trunk/; revision=43961
2012-07-24 15:03:59 +00:00
Bill Meier 0c8e6e8f90 Remove unneeded #include;
Create/use extended value strings for several value-string arrays;
Minor whitespace cleanup.

svn path=/trunk/; revision=43960
2012-07-24 14:47:19 +00:00
Bill Meier ca154aad10 (Trivial) whitespace cleanup
svn path=/trunk/; revision=43959
2012-07-24 14:05:20 +00:00
Anders Broman eceff8e0d4 H.248 cannot interpret value of Package 0x0022, Parameter 1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7519

svn path=/trunk/; revision=43958
2012-07-24 13:05:25 +00:00
Anders Broman e83a8e4eee Use the correct symbols
COL_UTC_TIME and COL_UTC_DATE_TIME
insted of TS_UTC and TS_UTC_WITH_DATE.

svn path=/trunk/; revision=43957
2012-07-24 12:20:18 +00:00
Anders Broman 7f345354fe From Karsten Keil:
ISDN LAPD X.31 packet traffic can not be decoded

X.31 is X.25 over ISDN. It use SAPI 16 LAPD service.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7514

svn path=/trunk/; revision=43956
2012-07-24 11:47:23 +00:00
Anders Broman 6572a8e55c From Peng Di:
GIOP request_id used for sub dissectors is not assigned when decoding GIOP 1.2 Request message.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7516

svn path=/trunk/; revision=43955
2012-07-24 10:25:13 +00:00
Anders Broman 3743a01714 From Jacob Nordgren and Rishie Sharma:
- Added support for EDCH type 2 MAC-is reassembly and slightly improved RLC error reporting 

- RLC: fixed bug where complete sequences in the end of a trace where not reassembled

svn path=/trunk/; revision=43954
2012-07-24 07:31:46 +00:00
Anders Broman 2e74809c33 Reinsert conversation colorization shortcuts
svn path=/trunk/; revision=43953
2012-07-24 05:51:42 +00:00
Ronnie Sahlberg 3b0eb70b23 SCSI: Add support for mode subpages
Add support for modepages that contain subpages and add
a simple subpage for the Control page.


svn path=/trunk/; revision=43952
2012-07-24 02:00:50 +00:00
Jakub Zawadzki 045b5b03ce Fix bug #7520: Byteview related Glib-GObject-Critical msgs during GTK2 Wireshark startup
Put generated, with *proper* types version of marshaler (VOID:OBJECT,OBJECT) inside bytes_view.c
It was also only blocker of #undef GTK_DISABLE_DEPRECATED, so remove it.

XXX generated version of marshaler looks portable, but it'd be best to generate it using
glib-genmarshal during compilation.

svn path=/trunk/; revision=43947
2012-07-23 20:24:36 +00:00
Anders Broman 713dbd01c9 Remove #define USE_GOPTION = 1, the code is incomplete
svn path=/trunk/; revision=43945
2012-07-23 19:18:00 +00:00