Commit Graph

51392 Commits

Author SHA1 Message Date
Alexis La Goutte 85ab202c08 Fix -Wsometimes-uninitialized found by Clang
packet-pdcp-lte.c:1397:9: error: variable 'decrypted_data' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:50: note: uninitialized use occurs here
    decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1353:27: note: initialize the variable 'decrypted_data' to silence this warning

packet-pdcp-lte.c:1397:9: error: variable 'payload_length' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:66: note: uninitialized use occurs here
    decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1354:24: note: initialize the variable 'payload_length' to silence this warning

svn path=/trunk/; revision=54791
2014-01-14 17:44:21 +00:00
Alexis La Goutte 6b6d709afc Fix unused const variable found by Clang 3.4
svn path=/trunk/; revision=54790
2014-01-14 17:44:07 +00:00
Pascal Quantin a48b6f4aac Upgrade LTE RRC dissector to v11.6.0
svn path=/trunk/; revision=54789
2014-01-14 16:51:10 +00:00
Pascal Quantin 330654baf8 SNOW3G is not available on default Wireshark
svn path=/trunk/; revision=54788
2014-01-14 16:48:43 +00:00
Pascal Quantin eabf15f80a Fix dissection of 3GPP2 SMS encoded in UCS2
svn path=/trunk/; revision=54787
2014-01-14 16:23:38 +00:00
Martin Mathieson 293f8ca247 Make sure we allocate bytes for snow3g at least rounded up to next 4 byte boundary
svn path=/trunk/; revision=54786
2014-01-14 16:22:44 +00:00
Martin Mathieson b948c75dfe Update a comment
svn path=/trunk/; revision=54785
2014-01-14 15:11:35 +00:00
Martin Mathieson 58e8800136 Add snow3g integrity (not quite working for me), but rework how integrity and ciphering functions and conditional compilation is done
svn path=/trunk/; revision=54784
2014-01-14 15:07:20 +00:00
Pascal Quantin b0d4e7a34b UCS2 encoded SMS is directly read from data -> remove PROTO_ITEM_SET_GENERATED()
svn path=/trunk/; revision=54783
2014-01-14 14:01:03 +00:00
Martin Mathieson b01a99c385 Provide hook for calling EEA1 implementation (Snow3G). Implementation not supplied due to licensing conditions. TODO: EIA1.
svn path=/trunk/; revision=54782
2014-01-14 11:09:47 +00:00
Guy Harris e2b668efe7 Whoever in GLibland was responsible for defining the signature of
g_snprintf() owes the world a huge apology.  They *could* have just used
size_t, or they *could* at least have, if they insisted on having GLib
types to mirror regular types, made gsize an alias for size_t and,
whatever they did with gsize, they *could* have used it as the argument
for the size of the buffer for g_snprintf(), but no, they had to use
gulong.

svn path=/trunk/; revision=54781
2014-01-14 10:50:26 +00:00
Guy Harris ecdc864656 Don't cast away constness.
svn path=/trunk/; revision=54780
2014-01-14 08:32:50 +00:00
Guy Harris e1b57afbc9 Don't cast away constness.
svn path=/trunk/; revision=54779
2014-01-14 08:30:45 +00:00
Guy Harris 9232db14c7 But *do* cast const void * to the appropriate type.
svn path=/trunk/; revision=54778
2014-01-14 08:30:24 +00:00
Guy Harris 1ec9417a43 Don't cast away constness.
svn path=/trunk/; revision=54777
2014-01-14 08:26:24 +00:00
Guy Harris 6aa49e37e0 Don't assign away constness.
svn path=/trunk/; revision=54776
2014-01-14 08:22:38 +00:00
Guy Harris bd165ab19a Don't cast away constness.
svn path=/trunk/; revision=54775
2014-01-14 08:14:28 +00:00
Guy Harris 4a82c3b60b Don't cast away constness.
svn path=/trunk/; revision=54774
2014-01-14 08:12:45 +00:00
Guy Harris dc71034565 Don't cast away constness.
svn path=/trunk/; revision=54773
2014-01-14 08:09:33 +00:00
Guy Harris 382e2c895c gsize, not gusize. Whatever.
svn path=/trunk/; revision=54772
2014-01-14 07:59:58 +00:00
Guy Harris 8b2aced72c Glib, gotta love it. No, gusize isn't the same as size_t, it's long,
which is Too Damn Short on Windows.  (Microsoft, gotta love 'em.  I
guess even more Windows programmers than UN*X programmers thought long
was 32 bits, now and forever, world without end, amen.)

svn path=/trunk/; revision=54771
2014-01-14 07:58:18 +00:00
Guy Harris aaeb6a467b Don't cast away constness.
svn path=/trunk/; revision=54770
2014-01-14 07:56:43 +00:00
Guy Harris dd152d81af Don't cast away constness.
svn path=/trunk/; revision=54769
2014-01-14 05:49:04 +00:00
Guy Harris 4a7636a6f8 Don't cast away constness.
svn path=/trunk/; revision=54768
2014-01-14 05:47:50 +00:00
Guy Harris c6c1887a0b Have ip6_to_str() and tvb_ip6_to_str() return const pointers, as the
ip_to_str equivalents do.

Don't cast away constness, and don't make it necessary to do so.

svn path=/trunk/; revision=54767
2014-01-14 05:39:57 +00:00
Guy Harris e1f6ad8387 Don't cast away constness.
svn path=/trunk/; revision=54766
2014-01-14 05:29:02 +00:00
Guy Harris 0f40fd837c Don't cast away constness.
svn path=/trunk/; revision=54765
2014-01-14 05:25:51 +00:00
Guy Harris 720cfe49c8 Don't cast away constness. In one place, this requires that we use one
pointer while we're filling in a string and then assigning it to a const
pointer when we're done.

Don't use guint16 as a size value; it does no good (it doesn't magically
protect you againt too-long strings), it runs the potential risk of
overflow, it doesn't save time for arithmetic (32-bit or 64-bit
arithmetic may well be faster, and will at least be as fast), and it
doesn't save space (if it fits in a register, you save nothing, and if
it's on the stack, there will probably be padding.

svn path=/trunk/; revision=54764
2014-01-14 05:23:48 +00:00
Guy Harris 547efd4dc9 Cast away constness.
svn path=/trunk/; revision=54763
2014-01-14 05:17:06 +00:00
Guy Harris 1980bb74d9 Constification.
svn path=/trunk/; revision=54762
2014-01-14 04:09:21 +00:00
Guy Harris 1b0cfd415c Don't cast away constness.
svn path=/trunk/; revision=54761
2014-01-14 04:05:23 +00:00
Guy Harris 6a4bd7a91e Don't cast away constness.
svn path=/trunk/; revision=54760
2014-01-14 04:01:59 +00:00
Guy Harris 6a9b99cf98 And more constification.
svn path=/trunk/; revision=54759
2014-01-14 04:01:34 +00:00
Guy Harris ccbebb0ee3 More constification.
svn path=/trunk/; revision=54758
2014-01-14 03:56:36 +00:00
Guy Harris c1b602584d Don't make promises of constness that we can't honor.
svn path=/trunk/; revision=54757
2014-01-14 03:24:37 +00:00
Guy Harris 60f06e558a Don't cast away constness when you don't have to.
svn path=/trunk/; revision=54756
2014-01-14 03:16:27 +00:00
Guy Harris 3decdd5d98 Squelch some casting-away-constness warnings.
svn path=/trunk/; revision=54755
2014-01-14 03:06:40 +00:00
Guy Harris f7b0675bc6 Clean up references to an address and squelch some warnings.
svn path=/trunk/; revision=54754
2014-01-14 02:30:05 +00:00
Guy Harris 7b32b5c14a Don't cast away constness.
svn path=/trunk/; revision=54753
2014-01-14 02:25:20 +00:00
Guy Harris 88e3e47bfd More prototype cleanup.
svn path=/trunk/; revision=54752
2014-01-14 02:17:16 +00:00
Guy Harris 6b8e8d3fea Make a routine not used outside the SNMP dissector static.
svn path=/trunk/; revision=54751
2014-01-14 02:06:42 +00:00
Guy Harris 97137766e7 In a source file that defines external functions, the header file that
declares the functions must be included, in order to make sure the
declarations match the function signature.  Make it so.

Said header declares pipe_input_cb_t, so we don't have to do it
ourselves.

svn path=/trunk/; revision=54750
2014-01-14 01:44:36 +00:00
Guy Harris d399b7ac90 In a source file that defines external functions, the header file that
declares the functions must be included, in order to make sure the
declarations match the function signature.  Make it so.

svn path=/trunk/; revision=54749
2014-01-14 01:41:38 +00:00
Guy Harris afef2cd8f4 Detangle the #ifdefs a bit.
svn path=/trunk/; revision=54748
2014-01-14 01:40:09 +00:00
Guy Harris 2e5c54935b In a source file that defines external functions, the header file that
declares the functions must be included, in order to make sure the
declarations match the function signature.  Make it so.

Don't cast away constness when passing something to a routine that takes
a const pointer argument.

svn path=/trunk/; revision=54747
2014-01-14 01:35:13 +00:00
Guy Harris 6a37db92d1 Make a routine not used outside this file static.
svn path=/trunk/; revision=54746
2014-01-14 01:31:49 +00:00
Guy Harris 205162061e In a source file that defines external functions, the header file that
declares the functions must be included, in order to make sure the
declarations match the function signature.  Make it so.

svn path=/trunk/; revision=54745
2014-01-14 01:29:16 +00:00
Guy Harris 91ad2eadb8 Include ui/progress_dlg.h to get the declaration of
delayed_create_progress_dlg().

svn path=/trunk/; revision=54744
2014-01-14 01:26:51 +00:00
Guy Harris d041ec61af #if 0 out an unused routine.
svn path=/trunk/; revision=54743
2014-01-14 01:23:49 +00:00
Guy Harris 5a43b704c8 In a source file that defines external functions, the header file that
declares the functions must be included, in order to make sure the
declarations match the function signature.  Make it so.

svn path=/trunk/; revision=54742
2014-01-14 01:16:55 +00:00