Commit Graph

85911 Commits

Author SHA1 Message Date
João Valverde 84e75be5c6 dfilter: Add optimization flag
When we are just testing code to see if it compiles performing
optimizations is wasteful. Add an option to disable them.
2022-11-30 17:36:17 +00:00
Joakim Karlsson 4b0bf62791 asn2wrs: disable template line directive by default
Same as with !8955, To debug with line directive build with
-DENABLE_DEBUG_A2W=ON flag
2022-11-30 17:31:46 +00:00
João Valverde 729ea56b46 wmem: Remove wmem_strbuf_new_label()
Only dissectors are using this function and there is no use case,
as far as I know, that requires its use. Any limitation of length
is imposed transparently by the UI backend.

This function is problematic because it is not Unicode aware and
will truncate a string on an arbitrary byte boundary for multibyte
strings.

Replace its use with a normal strbuf without a length limite and
remove the function because it is not useful and the ITEM_LABEL_LENGTH
parameter does not belong in wmem anyway.
2022-11-30 15:55:54 +00:00
João Valverde 93814ef740 dfilter: Always set error pointer in case of failure 2022-11-30 15:00:34 +00:00
John Thacker 8a67ca77e6 http: Check CitrixAGBasic Auth encoding
CitrixAGBasic Authentication has Base64 encoded values. The result of
Base64 decoding is not guaranteed to be valid UTF-8 (or ASCII), so
verify it.

Also add the username and password to the credentials tap.

Fix #18677.
2022-11-30 07:54:01 -05:00
John Thacker 10c84b6450 HTTP2: Load dynamic hf entries when UAT is changed
The dynamic hf entries for HTTP2 read from the UAT should be
changed when the UAT is changed or reset, not on each file
load and file close. If a field is added as a column, coloring
rule, or filter, and the capture file is changed, deregistering
the field and reregistering it can cause a crash.

Use the same approach as with HTTP and SIP, slightly modified
because in HTTP2 the header fields hash contains the static
headers as well, to prevent adding duplicate entries via the UAT.

Fix #14768
2022-11-30 11:04:05 +00:00
Joakim Karlsson 5b8cb733fa asn2wrs: disable line directive by default
To debug with line directive build with -DENABLE_DEBUG_A2W=ON flag
2022-11-30 11:03:09 +00:00
Martin Mathieson 6eb734995a Change the re for matching an item's label 2022-11-30 09:25:13 +00:00
Martin Mathieson c69d0114ea tools/check_static.py - fix remaining errors 2022-11-30 08:49:38 +00:00
João Valverde 7336190bbc wslog: Check fileno() for errors
fileno() can fail and GLib will assert on negative fd.

Fixes #18684.
2022-11-29 15:41:20 +00:00
Martin Gallo 129ed6d4c4 SAPSNC: Added SAP SNC as main dissector 2022-11-29 13:34:38 +00:00
John Thacker 9a19d48736 CIMD: Implement User Data encoding
When CIMD indicates that a message was sent in the 7 bit GSM alphabet,
each character has been converted to ASCII or ISO-8559-1 with the
use of combining escape sequences for characters not present in
the destination encoding. Properly convert back to GSM 7 bit encoding
and then to UTF-8 for display.

Fix #18676.
2022-11-29 07:02:26 -05:00
João Valverde f6e850af47 AJP13: Remove odd use of ITEM_LABEL_LENGTH 2022-11-29 10:22:44 +00:00
Gerald Combs 0af3174508 CMake: Updates for CMake 3.25 and later on Windows.
https://cmake.org/cmake/help/latest/release/3.25.html says:

"On Windows, when targeting the MSVC ABI, the find_library() command now
accepts .a file names after first considering .lib. This is symmetric
with existing behavior when targeting the GNU ABI, in which the command
accepts .lib file names after first considering .a."

If "MSVC" is defined, only search for libsmi-2. This keeps us from finding
libsmi.a. Set NO_SYSTEM_ENVIRONMENT_PATH when we're searching for zlib. This
keeps us from finding Strawberry Perl's version.

Some SpanDSP builds link with LibTIFF, but our Windows version doesn't.
2022-11-28 19:15:48 +00:00
João Valverde a0d77e9329 dfilter: Return an error object instead of string
Return an struct containing error information. This simplifies
the interface to more easily provide richer diagnostics in the future.

Add an error code besides a human-readable error string to allow
checking programmatically for errors in a robust manner. Currently
there is only a generic error code, it is expected to increase
in the future.

Move error location information to the struct. Change callers and
implementation to use the new interface.
2022-11-28 15:46:44 +00:00
Bernhard Dick b4196ab772 DECT-AAMIDE: Remove duplicate relnote entry 2022-11-28 15:04:15 +00:00
Bernhard Dick 7fc7830b13 DECT-MITEL-ETH: gint -> int for hf 2022-11-28 15:04:15 +00:00
Bernhard Dick 7cde243a66 DECT-MITEL-RFP: gint -> int for hf 2022-11-28 15:04:15 +00:00
Bernhard Dick 76ff611966 DECT-MITEL-RFP: Dissection of SYNC messages
Adds dissection of the SYNC message type with the following payloads:
* FREQ_CTRL_MODE_IND
* FREQ_CTRL_MODE_CFM
* SET_FREQUENCY
* START_MAC_SLAVE_MODE_IND
* SYSTEM_SEARCH_IND
* SYSTEM_SEARCH_CFM
* PHASE_OFS_WITH_RSSI_IND
2022-11-28 15:04:15 +00:00
Bernhard Dick 03dd33f740 DECT-MITEL-RFP: Improve display
Add unit display for some header fields
2022-11-28 15:04:15 +00:00
Bernhard Dick d67d08cf9b DECT-MITEL-RFP: Improve includes
More of a cosmetic change but ensure all includes refer to their
directory (i.e. epan/)
2022-11-28 15:04:15 +00:00
Bernhard Dick 7afe726007 DECT-MITEL-RFP: Reorder message dissection 2022-11-28 15:04:15 +00:00
Bernhard Dick 992c1fa616 DECT-MITEL-RFP: Add more messages
Add dissection of the following messages:
* SYS-HEARTBEAT-INTERVAL
* SYS-SYSLOG
* SYS-MAX-CHANNELS
* SYS-HTTP-SET
* SYS-PASSWD
* SYS-RPING
* SYS-CORE-DUMP
* SYS-VSNTP-TIME
* SYS-LICENSE-TIMER
2022-11-28 15:04:15 +00:00
Bernhard Dick 6f8a847b63 DECT-MITEL-RFP: Fix MEDIA-OPEN dissection 2022-11-28 15:04:15 +00:00
Bernhard Dick abea8b8b4a DECT-MITEL-RFP: Set proto length in DECToE case 2022-11-28 15:04:15 +00:00
Bernhard Dick a6c6afedef DECT-MITEL-ETH: Improve subtree len handling
Read the length for the subtree length for RFPc items at the same moment
the length field is added and update the subtree's length afterwards.
2022-11-28 15:04:15 +00:00
Bernhard Dick 443b0a4623 DECT-MITEL-RFP: Simpler TCP port registration
When using dissector_add_uint_with_preference no explicit definition of
the Port configuration option is needed. Thus remove unnecessary code.
2022-11-28 15:04:15 +00:00
Bernhard Dick 397d802618 DECT-MITEL-RFP: Fix spelling 2022-11-28 15:04:15 +00:00
Bernhard Dick 9a2cc2f8e2 DECT-MITEL-ETH: Fix spelling 2022-11-28 15:04:15 +00:00
Bernhard Dick 42927f3953 DECT-MITEL-RFP: Add MEDIA message dissection
Add dissection for the following messages:
* MEDIA-OPEN
* MEDIA-CONF
* MEDIA-START
* MEDIA-STOP
* MEDIA-STATISTICS
* MEDIA-REDIRECT-START
* MEDIA-REDIRECT-STOP
* MEDIA-RESTART
* MEDIA-DTMF
* MEDIA-TONE
2022-11-28 15:04:15 +00:00
Bernhard Dick c42800fa4d DECT-MITEL-ETH: Fix filter name 2022-11-28 15:04:15 +00:00
Bernhard Dick 7e5d5c2ddf DECT-MITEL-ETH: Improve MCEI dissection
Transfer dissection of MCEI field into own function and dissect MCEI in
messages where it was missing.
2022-11-28 15:04:15 +00:00
Bernhard Dick 6f216b9dbb DECT-MITEL-RFP: Remove unused assignments 2022-11-28 15:04:15 +00:00
Bernhard Dick 792fdf05ca DECT-MITEL-ETH: Remove unused assignment 2022-11-28 15:04:15 +00:00
Bernhard Dick 863f7d902d DECT-MITEL-ETH: Fix function naming 2022-11-28 15:04:15 +00:00
Bernhard Dick 7fcf2f8d36 DECT-MITEL-RFP: Improve protocol tree structure 2022-11-28 15:04:15 +00:00
Bernhard Dick 6fd2c267b4 DECT-MITEL_RFP: Honour work from zivillian
The dissection of the DECT-MITEL-RFP protocol is based upon findings
that resulted in rfpproxy, so I think it is a good idea to also name the
author in the source file
2022-11-28 15:04:15 +00:00
Bernhard Dick 8a05fc6a2a DECT-MITEL-RFP: Add SYS-IP-OPTIONS dissection 2022-11-28 15:04:15 +00:00
Bernhard Dick ca540b120a DECT-MITEL-ETH: Improve protocol tree
Put DECT-MITEL-ETH content beneath a tree item in the protocol tree and
use own indices for all different subtree types
2022-11-28 15:04:15 +00:00
Bernhard Dick de7594f58d DECT-MITEL-ETH: Add more RFPc item dissections
Add dissection for the following RFPc message item types:
* Revision
* RFPI
* Higher layer capabilities
* MAC capabilities
* Statistics data
* RFP_PLI
* Extended capabilities
2022-11-28 15:04:15 +00:00
Bernhard Dick 4c9da8039f DECT-MITEL-ETH: Begin dissection of RFPc
Add basic function to dissect RFPc messages and dissection of the RFPc
Extended capabilities message
2022-11-28 15:04:15 +00:00
Bernhard Dick 3bc96a57e4 DECT-MITEL-ETH: Move MAC_PAGE_REQ to function 2022-11-28 15:04:15 +00:00
Bernhard Dick b757b7fed2 DECT-MITEL-ETH: Improve MAC_INFO_IND
Move MAC_INFO_IND to own function call and also dissect PMID field
2022-11-28 15:04:15 +00:00
Bernhard Dick 73fe413b46 DECT-MITEL-ETH: dissect more fields
Add dissection for
* MAC_HO_IN_PROGRESS_IND
* MAC_HO_IN_PROGRESS_RES
2022-11-28 15:04:15 +00:00
Bernhard Dick c4daae6a1e DECT-MITEL-ETH: Improve MAC_DIS_IND dissection 2022-11-28 15:04:15 +00:00
Bernhard Dick 5e1c929697 DECT-MITEL-ETH: Add MAC_CLEAR_DEF_CKEY_REQ 2022-11-28 15:04:15 +00:00
Bernhard Dick 5d6cffc2d0 DECT-MITEL-ETH: Improve MAC_CON_IND
Update PMID field length (20bits instead of 2 bytes), move
MAC_CON_IND dissection into own function call and add flags field
2022-11-28 15:04:15 +00:00
Bernhard Dick cac1709e8d DECT-MITEL-ETH: Add more field dissection
Add dissection for
* MAC_ENC_KEY_REQ
* MAC_ENC_EKS_IND
* MAC_HO_FAILED_IND
2022-11-28 15:04:15 +00:00
Bernhard Dick 15edf3b3ce DECT-MITEL-ETH: Add Layer field and Mt 2022-11-28 15:04:15 +00:00
Bernhard Dick 534e594a34 DECT-MITEL-RFP: Begin of OMM/RFP protocol
This is the begin of a basic dissection of the proprietary protocol used
by the Mitel OMM/RFP communicatino over TCP. Currently no decryption is
supported so there is the need of external decryption.
2022-11-28 15:04:15 +00:00