Commit Graph

14177 Commits

Author SHA1 Message Date
Guy Harris 84c61920d9 OK, I found a URL that will get you to the CPAN page for Yapp without
embedding a version number.  Use it.

"This will build and install the binaries and the manpage (pidl.1)."
refers to the process of installing Pidl; put it immediately after the
steps for installing Pidl.

svn path=/trunk/; revision=35305
2010-12-30 03:13:37 +00:00
Guy Harris e32a3b8a97 The rids argument to samr_GetGroupsForUser() is *not* a single RID, it's
an array of samr_RidWithAttributeArray structures.  Don't equate it to
hf_samr_rid; that causes hf_samr_rid to be added as an item with a
length of -1, but, as hf_samr_rid is an FT_UINT32 field, that causes a
dissector bug error.

The version of Yapp I was using, at least, didn't like C++-style
comments in the IDL file; replace them with C-style comments.

svn path=/trunk/; revision=35304
2010-12-30 02:56:51 +00:00
Guy Harris 4132fab674 Add some white space.
Give more information about getting Yapp; not everybody using it is
necessarily using SUSE (and, yes, that's how it appears to be spelled
now, even though the "u" was for "und" and not originally capitalized).

svn path=/trunk/; revision=35303
2010-12-30 02:10:49 +00:00
Chris Maynard 0832037854 Add GEOIP_COUNTRY_EDITION_V6 to geoip_type_name_vals[].
svn path=/trunk/; revision=35302
2010-12-29 21:06:05 +00:00
Chris Maynard bb6a0a0604 Update list of relevant protocol specs. Some drafts are now RFC's.
svn path=/trunk/; revision=35301
2010-12-29 20:58:14 +00:00
Gerald Combs cf6df46095 Fix a buffer overflow in the engineId preferences. Fixes bug 5530.
svn path=/trunk/; revision=35298
2010-12-29 20:09:27 +00:00
Guy Harris 06a370929b Fix incomplete conversion from an on-the-stack buffer to an ep_allocated
buffer - the size of the latter can't be found with sizeof, as all you
have is a pointer to the buffer.  sizeof (pointer) happened, by chance,
to give the right answer on ILP32 platforms, but gave a too-big answer
on LP64 and LLP64 platforms, which meant we overflowed the buffer when
clearing it.

svn path=/trunk/; revision=35297
2010-12-29 19:40:36 +00:00
Jaap Keuter bf301e6d86 Fix the HAI value display filter string.
svn path=/trunk/; revision=35294
2010-12-29 07:39:52 +00:00
Gerald Combs 73f5cb2503 From non-customers via bug 5530: Fix a buffer overflow in the MAC LTE
dissector.  From me: Add a define, ep_allocate the buffer.

svn path=/trunk/; revision=35292
2010-12-28 20:47:48 +00:00
Chris Maynard d100b2d0e0 From non-customers [AT] operamail [DOT] com, submitted via bug 5529:
Values[9] is fetched twice but Values[8] not at all, despite printing it
    later on.

svn path=/trunk/; revision=35290
2010-12-28 20:19:41 +00:00
Chris Maynard 40106e2f5b From Alexis La Goutte via bug 5528:
Fix wrong Field Type for HAI-Value and MN-Value (RFC 5271)

svn path=/trunk/; revision=35289
2010-12-28 18:26:16 +00:00
Chris Maynard f18068e9ef Improve sanity checking of reception claim count. Fixes bug 5521.
svn path=/trunk/; revision=35287
2010-12-28 18:02:24 +00:00
Anders Broman 735709bee6 Add tvb_bcd_dig_to_ep_str()
/*
 * Given a tvbuff, an offset into the tvbuff, and a length that starts
 * at that offset (which may be -1 for "all the way to the end of the
 * tvbuff"), fetch BCD encoded digits from a tvbuff starting from either 
 * the low or high half byte, formating the digits according to an input digit set, 
 * if NUll a default digit set of 0-9 returning "?" for overdecadic digits will be used.
 * A pointer to the EP allocated string will be returned.
 * Note a tvbuff content of 0xf is considered a 'filler' and will end the conversion.
 */

svn path=/trunk/; revision=35286
2010-12-28 12:36:26 +00:00
Anders Broman 23b188ca06 Add dissection of NAS message container.
svn path=/trunk/; revision=35285
2010-12-28 11:24:46 +00:00
Jaap Keuter 64d02a0ae1 From Alexis La Goutte:
A patch to enchance the ICMPv6 dissector
- Update RFC Draft (draft-ietf-ipngwg-icmp-name-lookups-07/08) to Final RFC (RFC 4620)
- Make NI field filterable 
- ....

svn path=/trunk/; revision=35283
2010-12-28 10:34:19 +00:00
Jaap Keuter b964ee34dd From Masashi Honma:
EAP WPS RF band may be '2.4 GHz and 5 GHz'.

svn path=/trunk/; revision=35282
2010-12-28 09:30:24 +00:00
Guy Harris 7d3051c949 Get rid of trailing white space.
svn path=/trunk/; revision=35277
2010-12-27 21:40:48 +00:00
Anders Broman 2c7b85a624 Add dissection of Radio Priority LCS.
svn path=/trunk/; revision=35276
2010-12-27 20:23:26 +00:00
Anders Broman 14e2d5c04a Remove de_sgsap_tmsi as it's not needed.
svn path=/trunk/; revision=35275
2010-12-27 20:19:55 +00:00
Stephen Fisher 4c0447c8cc Fix build by #if 0 out unused de_sgsap_tmsi() function.
svn path=/trunk/; revision=35274
2010-12-27 16:38:03 +00:00
Anders Broman a95df8ac8c Add more IE dissection.
svn path=/trunk/; revision=35273
2010-12-27 15:15:55 +00:00
Anders Broman 2f80045a5c From Alexis La Goutte:
ICMPv6 Enhancements : make ICMP option filterable (Part 2)

*Merge (and update) FMIPv6 Option with ND Option
*Make ICMP option filterable (use proto_tree_add_item..)
*Reorder ND Option
*Add dissector for RA Flags Extension (RFC5075)
*Add dissector for Handover Key Request/Reply (RFC5269)
*Add dissector for Handover Assist Info / Mobile Node ID (RFC5271)
*Add dissector for DNS Search List (RFC6106

From me removed a c++ style comment and changed 
to tvb_memcpy(tvb, (guint8 *)&prefix.bytes in a couple of places.

svn path=/trunk/; revision=35272
2010-12-27 10:57:42 +00:00
Anders Broman d20be4e050 Fix the Message numbering.
svn path=/trunk/; revision=35271
2010-12-27 09:33:39 +00:00
Anders Broman 259061a26b Try to apiece the Ubuntu buildbot.
svn path=/trunk/; revision=35270
2010-12-27 08:23:55 +00:00
Anders Broman 790ba15666 move the enum to packet-gsm_a_common to
make it possible to use element dissecton from this dissector
in other dissectors.
It is left in packet-nas_EPS.c as a comment for easier reference.

svn path=/trunk/; revision=35269
2010-12-27 05:33:58 +00:00
Martin Mathieson ee714ffac4 Only a new transmission grant should end a Scheduling Request.
svn path=/trunk/; revision=35268
2010-12-26 23:40:22 +00:00
Anders Broman df66b02972 Correct:
RESET IP RESOURCE
RESET IP RESOURCE ACKNOWLEDGE
Tags

svn path=/trunk/; revision=35267
2010-12-26 21:23:06 +00:00
Anders Broman 356aced5bf Start of a SGSAP (TS 29.118) dissector for LTE.
svn path=/trunk/; revision=35266
2010-12-26 21:06:08 +00:00
Gerald Combs c7f11d2926 [Automatic manuf, services and enterprise-numbers update for 2010-12-26]
svn path=/trunk/; revision=35263
2010-12-26 16:03:29 +00:00
Chris Maynard e867b10b98 Properly define and dissect BGP_EXT_COM_LINKBAND. Fixes bug 4409 reported by
Max Ivanov.

svn path=/trunk/; revision=35260
2010-12-24 13:53:26 +00:00
Jaap Keuter 302d4c14df From Julien Kerihuel:
I've just finished to write a ncacn_http dissector for Wireshark which
provides the ability to dissect Outlook anywhere packets properly (as
specified by [MS-RPCH].pdf documentation.

svn path=/trunk/; revision=35259
2010-12-23 23:50:14 +00:00
Guy Harris 158e9a3dae Clean up indentation.
svn path=/trunk/; revision=35257
2010-12-23 21:22:55 +00:00
Stephen Fisher e9f3d27b4a Add a couple more comments to new unicode function to remind us when a
variable is counting UTF-16 characters vs. normal bytes.


svn path=/trunk/; revision=35256
2010-12-23 18:26:25 +00:00
Stephen Fisher f0029fd060 Remove comment to myself that I forgot to remove before commiting r35253
and change comments to fit within 80 column display.


svn path=/trunk/; revision=35255
2010-12-23 18:24:39 +00:00
Stephen Fisher 3bd641004b Proof of concept for using new tvb_get_ephemeral_unicode_stringz(), which was
just introduced in SVN revision 35253.  This new function has many more uses
in the SMB (and other) dissectors. 


svn path=/trunk/; revision=35254
2010-12-23 18:01:28 +00:00
Stephen Fisher 4f5ccc00f8 Introduce new function called tvb_get_ephemeral_unicode_stringz(), which
is a unicode (UTF-16) version of tvb_get_ephemeral_stringz().  It scans
a tvbuff for a UTF-16 string and converts it to UTF-8 upon return.


svn path=/trunk/; revision=35253
2010-12-23 17:59:34 +00:00
Jaap Keuter 48784e79a4 Fix for bug 5517:
MEG ID, ICC-based format is text, not binary.

svn path=/trunk/; revision=35252
2010-12-23 17:45:02 +00:00
Martin Mathieson 5e49db3304 Properly read UL grant subframe number.
svn path=/trunk/; revision=35251
2010-12-23 12:16:37 +00:00
Martin Mathieson c08d3b76d9 Skip an outheader field.
svn path=/trunk/; revision=35250
2010-12-23 11:09:52 +00:00
Jaap Keuter 226a722600 From Jiří Engelthaler:
Fixes computing of milliseconds in CP56time2a and add "bitstring of 32 bits" 
and "step position" support (ASDU types 5,7,32,33,47,51,60 and 64).

svn path=/trunk/; revision=35249
2010-12-22 23:28:23 +00:00
Stephen Fisher df6e1f362b Add #define and value_string entries for the remaining SSH message type
numbers as defined in RFC 4250.


svn path=/trunk/; revision=35246
2010-12-22 19:46:57 +00:00
Stephen Fisher 6a76081482 Change prefixes in #define:
SSH -> SSH1
  SSH2 -> SSH

This will make it easier to compare the code to the SSH RFCs, which only
cover SSH version 2.


svn path=/trunk/; revision=35245
2010-12-22 18:53:21 +00:00
Stig Bjørlykke f4c6355281 From Alexis La Goutte via bug 5514:
Fix a Git issue.

svn path=/trunk/; revision=35243
2010-12-22 13:19:38 +00:00
Jaap Keuter fc4d25fcc4 Allow for NULL preference descriptions.
svn path=/trunk/; revision=35242
2010-12-22 06:25:33 +00:00
Jaap Keuter d1787cafa4 From daulis0@gmail.com:
There are 2 parts to the CIGI protocol. 1) Host to IG messages and 2) IG to
Host messages. Currently, Host to IG messages are parsed correctly, but IG to
Host messages show Malformed Packet (or may not even detect as CIGI at all)

Some of the protocol format is different between versions. The "Minor Version"
is used by the dissector to separate the differences, but this field is in a
different location in the IG Control Packet (Host to IG message) vs the Start
of Frame Packet (IG to Host message).

Attached patch to correct this.

svn path=/trunk/; revision=35241
2010-12-21 21:29:47 +00:00
Bill Meier 2276b10ddf Add a comment about not needing to g_free() the value returned from g_locale_to_utf8().
svn path=/trunk/; revision=35240
2010-12-21 21:01:01 +00:00
Stephen Fisher 0b8494fc2c Fix indentation: change from a mixture of 2 and 4 spaces to tabs (which
is what packet-smb.c uses) and add extra line breaks.  Both changes are
for improved readbility of the frequent complex and cryptic loops.


svn path=/trunk/; revision=35238
2010-12-21 17:51:35 +00:00
Martin Mathieson 1386eb8fa3 Be more consistent about how offset is updated while dissecting lte_rrc fields.
Show cell-id in info column (if don't manage to call RRC).

svn path=/trunk/; revision=35237
2010-12-21 17:46:25 +00:00
Chris Maynard f64b27c979 Fix warnings with format.
svn path=/trunk/; revision=35232
2010-12-20 18:16:12 +00:00
Chris Maynard b9dd529e9c Some PIM enhancements, mostly to allow more fields to be filterable.
svn path=/trunk/; revision=35231
2010-12-20 17:48:26 +00:00