Commit Graph

17 Commits

Author SHA1 Message Date
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Gerald Combs 9a35ed601d Remove more unused variables.
svn path=/trunk/; revision=29249
2009-07-30 23:47:36 +00:00
Stig Bjørlykke 9391dce6b2 From Kovarththanan Rajaratnam via bug 3548:
More header_field_info cleanup.

svn path=/trunk/; revision=28772
2009-06-19 02:09:52 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stephen Fisher c4680240d9 Change my e-mail address
svn path=/trunk/; revision=28537
2009-05-31 05:55:15 +00:00
Jörg Mayer 1922d3ceee Jochen Bartl <jochen.bartl@gmail.com>
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2824

I have added the SCM header to the wlccp dissector. This header is present in
packets of base message type 0x01. You can find the specification in the
following document, when you search for "The table below shows the fields for
an SCM Advertisement Reply Message.":

http://www.freepatentsonline.com/y2005/0220054.html

It seems like the header structure in the document is wrong regarding the "SCM
Node ID" (MAC address) field. From looking at the hexdumps I found out that the
node id shows up in the header before the "Instance Age" field. There is also a
2 byte field between the node id and the instance age, which is always zero. I
have named this field  wlccp.scm_unknown_short, because I don't know what it is
for.

Me:

Fix two bugs that came up during testing but were present before the patch,
both involving wrong length handling triggering dissector assert and malformed
packet messages.



svn path=/trunk/; revision=28376
2009-05-16 16:31:54 +00:00
Gerald Combs 603dca37ee Make sure we always increment our offset. Fixes an infinite loop.
svn path=/trunk/; revision=26734
2008-11-08 00:07:43 +00:00
Bill Meier c3ea1560bd Minor cleanup related to proto_register and proto_reg_handoff
svn path=/trunk/; revision=26281
2008-09-26 22:07:45 +00:00
Bill Meier 77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Jörg Mayer 0c797861ba Warning fixes: function declaration isn’t a prototype
svn path=/trunk/; revision=23862
2007-12-14 15:14:40 +00:00
Stephen Fisher a1f317de36 From Kevin A. Noll via private bug #1683:
This is a major re-write of the WLCCP version 0xc1 dissector. It now is
able to dissect many more WLCCP message types and the TLVs that may be
included in a message. Placeholders are left for message types and
TLV types that we do not currently have enough data to engineer a
dissector.


svn path=/trunk/; revision=22330
2007-07-17 06:21:15 +00:00
Jeff Morriss 07953c95a6 From Kevin A. Noll via bug 1522:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1522

Support for WLCCP version 0xC1.

Also updated his email address in AUTHORS.


svn path=/trunk/; revision=21404
2007-04-13 06:49:22 +00:00
Stephen Fisher 5a3ec27194 Change a match_strval() to val_to_str() in a col_add_fstr() call to prevent
problems if there isn't a match (corrupted packet). 


svn path=/trunk/; revision=20077
2006-12-09 02:25:23 +00:00
Jaap Keuter 6e3dd0c722 From Stephen Fisher:
Here is a patch to make a few small fixes to packet-wlccp.c:

svn path=/trunk/; revision=19661
2006-10-23 05:30:37 +00:00
Ulf Lamping 195144a85e llc_add_oui() wants a pointer, not a pointer pointer
svn path=/trunk/; revision=19585
2006-10-18 00:22:23 +00:00
Jörg Mayer ccca31102b Stephen Fisher:
Please apply the attached patch to improve the WLCCP dissector.  I have
also finished merging in packet-cisco-wireless.c, so it can be deleted.


svn path=/trunk/; revision=19572
2006-10-17 08:59:01 +00:00
Jörg Mayer 7cf6ac9327 Stephen Fisher:
packet-cisco-wireless.c is actually trying to dissect WLCCP:

I have attached a dissector I wrote from scratch for the
frames that I'm seeing.  It has #defines for the field offsets and
lengths so it should be easier to merge.  I also attached a sample
capture with one of the frames that I'm seeing.  There are more fields
in the frame I haven't yet figured out, hopefully your dissector has
those that I'm missing.

Me: - Commented in wlccp over udp as well, it works most of the time.
    - Leave the file packet-cisco-wireless.c in for the time being to
      copy over knowledge until no usable info is left in the file.

svn path=/trunk/; revision=19447
2006-10-07 14:48:04 +00:00