Commit Graph

44300 Commits

Author SHA1 Message Date
Guy Harris 80e599e411 Don't assume developer tools are under /Developer - look for
/Applications/Xcode.app/Developer first (for Xcode 4 and later) and, if
we don't find that, look for /Developer.

Don't assume packagemaker is under $developer_path/usr/bin - with Xcode
4, you need to install Auxiliary Tools for Xcode to get PackageMaker,
and even that doesn't directly install the packagemaker command, so we
currently advise people to copy the PackageMaker binary to
/usr/bin/packagemaker.

svn path=/trunk/; revision=46957
2013-01-05 23:31:08 +00:00
Evan Huus 33981700b5 From Guus Gerrits via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8148
Add some additional formatting to the mmhdr subtree (e.g. selecting 5
mmheaderbytes with mmver!=0, Added a subtree for the Fragmentation Info)

svn path=/trunk/; revision=46956
2013-01-05 23:14:50 +00:00
Guy Harris 2b3849b3d8 Default to LIBPREFIX being /usr/local, as that's where macosx-setup.sh
puts them.  If you choose to use MacPorts versions of the library, edit
the script or run it with -l.

Update the usage message and fix a typo.

svn path=/trunk/; revision=46955
2013-01-05 23:11:38 +00:00
Guy Harris a70b2c5208 Don't assume that, in the output of the file command, the architecture
appears at the end - if the user's installed an up-to-date version of
file to, for example, get pcap-ng files identified (Apple hasn't updated
file in *ages* - they're still in file 5.04!), it will report, for
example, "Mach-O 64-bit x86_64 executable" rather than "Mach-O 64-bit
executable x86_64" for an x86-64 binary.

svn path=/trunk/; revision=46954
2013-01-05 23:07:05 +00:00
Guy Harris d8dfa8597f Give information on command-line tools with Xcode 4.
svn path=/trunk/; revision=46953
2013-01-05 19:42:04 +00:00
Jeff Morriss e04d9b994f Set SVN properties
svn path=/trunk/; revision=46952
2013-01-05 19:41:47 +00:00
Bill Meier 93c28b7da1 Rename ws_gtk_grid_attach() to ws_gtk_grid_attach_defaults();
Also: fix a typo in a comment in 'gui_utils.h'

svn path=/trunk/; revision=46951
2013-01-05 15:25:30 +00:00
Evan Huus 5c57af2df2 When fuzz-testing with valgrind, run both with and without tree (like when
fuzz-testing without valgrind).

svn path=/trunk/; revision=46950
2013-01-05 14:27:37 +00:00
Evan Huus d131bc1077 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8089
Dissector for the SEL (Schweitzer Engineering Labs) Fast Message protocol.

From me:
- use wmem instead of glib to not leak memory
- simplify port preference
- remove unneeded initializers
- modelines
- Id tag

svn path=/trunk/; revision=46949
2013-01-05 14:19:15 +00:00
Pascal Quantin b1143f60b3 Regenerate ANSI MAP dissector
svn path=/trunk/; revision=46948
2013-01-05 13:53:27 +00:00
Alexis La Goutte 5d6a6b4652 Fix regression from upgrade FIX 5.0 (Revision 46944)
../../../epan/dissectors/packet-fix.h:1450:10: error: multi-character character constant [-Werror=multichar]
../../../epan/dissectors/packet-fix.h:1451:10: error: multi-character character constant [-Werror=multichar]
[...]

When FIX field type is MULTIPLESTRINGVALUE use string_string (not value_string)

And regenerated packet-fix.h

svn path=/trunk/; revision=46947
2013-01-05 10:12:44 +00:00
Guy Harris 3fdc413fd6 In the post-install script, get rid of plugins that got converted to
built-in dissectors in 1.8.  Hopefully, this will smash bug 7401.

svn path=/trunk/; revision=46945
2013-01-05 10:06:05 +00:00
Michael Mann bf8fce3a00 Upgrade to FIX 5.0 fields
Bug 7853 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7853)

FIX.xml is now based on FIX50SP2.xml with some fill in from 4x xml files (as determined by diff between "old" and "new" packet-fix.h)

Included all FIX 5.0 field files from http://sourceforge.net/projects/quickfix/files/ 

svn path=/trunk/; revision=46944
2013-01-05 04:06:31 +00:00
Gerald Combs b99199fcf8 Constify a couple of variables and export a couple of functions.
svn path=/trunk/; revision=46943
2013-01-05 03:42:28 +00:00
Gerald Combs 4a3342e4ba Break out preference type names, type descriptions, string
representations, and default status out of write_prefs and into their
own routines. Split the corresponding custom preference write callbacks.
Fix an apparent memory leak in the hidden column callback.

Add an initial preferences dialog to the Qt port. Use the new preference
routines to implement an "Adavanced" page similar to the "about:config"
page available in many web browsers. Standard pages will hopefully follow
soon.

Remove some QDebug includes and make sure our QTreeWidgets have uniform
row heights set.

svn path=/trunk/; revision=46942
2013-01-05 02:30:58 +00:00
Evan Huus bab105d094 Add convenience macros wmem_new and wmem_new0
svn path=/trunk/; revision=46941
2013-01-04 22:11:13 +00:00
Anders Broman c16ab7b57e Use gdk_cairo_set_source_rgba
svn path=/trunk/; revision=46940
2013-01-04 21:10:00 +00:00
Bill Meier 20ee953a8b Fix a minor difference in window handling between Gtk2 & Gtk3:
Use gtk_box_pack_start() instead of gtk_container_add()
   in several places.


svn path=/trunk/; revision=46938
2013-01-04 20:27:29 +00:00
Bill Meier 5a68029ae3 Use ws_gtk_grid...() instead of gtk_table...();
Fix minor differences in window handling between Gtk2 & Gtk3:
   Use gtk_box_pack_start() instead of gtk_container_add() in
   various places.

Also; Do some whitespace and formatting style cleanup.


svn path=/trunk/; revision=46937
2013-01-04 19:27:09 +00:00
Anders Broman 7d1fbc96dc Use gdk_cairo_set_source_rgba
svn path=/trunk/; revision=46935
2013-01-04 17:45:35 +00:00
Anders Broman ad7f545a50 Fix a cut-and-paste error
svn path=/trunk/; revision=46934
2013-01-04 17:44:38 +00:00
Pascal Quantin 7d8ab07431 Fix some errors found by fix-encoding-args.pl script
svn path=/trunk/; revision=46933
2013-01-04 17:35:46 +00:00
Anders Broman d9d58c34f2 Add a wrapper for gdk_cairo_set_source_rgba() in GTK2 and use it in io_stat.c
svn path=/trunk/; revision=46932
2013-01-04 17:07:26 +00:00
Bill Meier 886ac9a613 Fix minor differences in window handling between Gtk2 & Gtk3:
Use gtk_box_pack_start() instead of gtk_container_add() in several places.

Also; Do some whitespace and formatting style cleanup.


svn path=/trunk/; revision=46931
2013-01-04 15:57:44 +00:00
Pascal Quantin deb4f08cb2 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8105 :
Allow use of huges values for localtime / ctime / gmtime with MSVC 2008 or later

svn path=/trunk/; revision=46930
2013-01-04 14:56:27 +00:00
Anders Broman 38fdbeeb7e Apply 46903 to iax_analysis
svn path=/trunk/; revision=46929
2013-01-04 09:13:05 +00:00
Michael Mann 86d690880f replace "unsigned" datatype with "guint". Some mpeg files needed "unsigned int" instead.
bugs 7825-7827 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7825)

svn path=/trunk/; revision=46928
2013-01-04 05:22:43 +00:00
Jeff Morriss d36b4c8525 Fix a (false) could-be-used-uninitialized warning.
Fix up indentation (looks like "4 space tabs").

svn path=/trunk/; revision=46927
2013-01-04 02:28:46 +00:00
Jeff Morriss 3be49bedd1 In AC_WIRESHARK_GCC_CFLAGS_CHECK() don't check if $3 (the program to be run)
exists by doing:

	if test "x$3" != "x" ; then

because if the program contains quotes it breaks the shell's parsing.
Instead test for the existence of $4 (which is mandatory if $3 is given).


Fix up the test program for -Wlogical-op so that it actually compiles
warning-free (at least on my system) when the compiler doesn't have the bug
we're checking for.

svn path=/trunk/; revision=46926
2013-01-04 02:12:51 +00:00
Anders Broman 6ea36c51c3 Add casts to make it build on win64
svn path=/trunk/; revision=46925
2013-01-03 23:24:47 +00:00
Guy Harris fe350d7cbd On the Ubuntu buildbot, this says -Wlogical-op doesn't work, but it
worked OK before.  In the test program, try declaring foo() before
defining it, in case the problem is that --enable-extra-gcc-checks
enables checking for functions that weren't declared before they were
defined, so the lack of that declaration may have caused a separate
warning.

svn path=/trunk/; revision=46924
2013-01-03 22:16:53 +00:00
Pascal Quantin 70d2438851 Add packet-mrcpv2.c to CMakeLists.txt
svn path=/trunk/; revision=46923
2013-01-03 22:03:47 +00:00
Jaap Keuter 6fd81d4994 From Zeljko Ancimer:
New dissector for Media Resource Control Protocol Version 2 (MRCPv2).

svn path=/trunk/; revision=46922
2013-01-03 21:42:59 +00:00
Bill Meier 0db3dd6be3 Use ws_gtk_grid...() in place of gtk_table...();
Add an XXX comment as to an apparent limit on the
 number of characters in a tooltip (at least in one case).

Do some minor whitespace and long-lines cleanup.

svn path=/trunk/; revision=46921
2013-01-03 19:54:02 +00:00
Bill Meier 4f01a9c89e Use ws_gtk_grid...() instead of gtk_table...();
Fix a minor difference in window handling between Gtk2 & Gtk3:
   Use gtk_box_pack_start() instead of gtk_container_add() in one case.

Also; Do some whitespace and formatting style cleanup.

svn path=/trunk/; revision=46920
2013-01-03 18:49:58 +00:00
Michael Mann 46935dbab4 USBHUB: Add useful details to INFO column, bug 8161 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8161)
From Steve Magnani

svn path=/trunk/; revision=46919
2013-01-03 18:08:50 +00:00
Bill Meier 4ae567e978 Use ws_gtk_grid...() instead of gtk_table...();
Set the default window size to show the complete window;
Fix a minor difference in window handling between Gtk2 & Gtk3:
   Use gtk_box_pack_start() instead of gtk_container_add() in one case.

Also; misc minor cleanup.

svn path=/trunk/; revision=46918
2013-01-03 17:53:40 +00:00
Bill Meier 5e8c774ce7 Replace use of gtk_table...() by ws_gtk_grid...().
svn path=/trunk/; revision=46917
2013-01-03 17:01:49 +00:00
Jeff Morriss 69d42810f6 Don't use -Wlogical-op if it causes gcc to generate warnings about logical
operations always evaluating to the same value in (the expansion of)
strchr().

See: https://www.wireshark.org/lists/wireshark-dev/201212/msg00136.html

svn path=/trunk/; revision=46916
2013-01-03 16:50:54 +00:00
Bill Meier 936626b160 Use ws_gtk_grid...() in place of gtk_table...();
Also: Fix a minor difference in window handling between Gtk2 & Gtk3:
  Use gtk_box_pack_start() instead of gtk_container_add(0 in one case.


svn path=/trunk/; revision=46915
2013-01-03 16:26:20 +00:00
Bill Meier add135b901 Replace use of gtk_table...() by ws_gtk_grid...().
Untested (since I don't know Lua) (but should be Ok).

svn path=/trunk/; revision=46914
2013-01-03 15:50:10 +00:00
Alexis La Goutte 69b38c579f From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8157 USBHUB: Add dissection of GetPortStatus responses
Most USBHUB responses are not dissected. Add support for GetPortStatus.

svn path=/trunk/; revision=46913
2013-01-03 11:37:05 +00:00
Anders Broman df50a668b1 From Chris Maynard Wireshark crashes when attempting to obtain help from various dialogs
svn path=/trunk/; revision=46912
2013-01-03 10:49:32 +00:00
Michael Tüxen 674567df8a Cleanup error handling when processing preamble.
svn path=/trunk/; revision=46911
2013-01-03 09:51:51 +00:00
Michael Tüxen 441b5b1bb5 Don't try to process timestamp without the format being
specified.

svn path=/trunk/; revision=46910
2013-01-03 09:23:43 +00:00
Gerald Combs 430e97c866 Move the font preferences to the colors pane and change its name to
"Font and Colors". Use a GtkFontButton to select the font and update the
sample text accordingly. Instead of attempting to resize the sample
color text (which didn't appear to work) scroll to the text that matches
the current combo box selection.

svn path=/trunk/; revision=46909
2013-01-03 01:02:30 +00:00
Bill Meier 98c8897f26 Use ws_gtk_grid...() in place of gtk_table...();
Also: Fix a minor difference in window handling between Gtk2 & Gtk3:
  Use gtk_box_pack_start() instead of gtk_container_add(0 in one case.

svn path=/trunk/; revision=46908
2013-01-02 23:36:16 +00:00
Evan Huus 17a05dfae0 Remove unused file handle that appears to have been left over by
accident after a refactor.

svn path=/trunk/; revision=46907
2013-01-02 23:16:03 +00:00
Bill Meier 85d59a5509 Fix a minor window handling difference between GTK2 & GTK3:
Use gtk_box_pack_start() instead of gtk_container_add() in several places.

svn path=/trunk/; revision=46906
2013-01-02 22:59:34 +00:00
Guy Harris 844ee8059a Update TODO list - the first two items are done, and with stuff added to
support pcap-NG we might have a better way of doing the third item (more
stuff is needed, but that stuff belongs there for pcap-NG, too).

When parsing hex dump lines, skip leading white space, and skip lines
that have nothing but white space, rather than guessing where the hex
dump information ends based on the line length.  Parse the hex bytes
manually.

svn path=/trunk/; revision=46905
2013-01-02 22:56:24 +00:00