osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
55,755 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

52 Commits

Author SHA1 Message Date
Guy Harris 80e6f6251e Get rid of calls to ctype.h functions. 
They don't handle values outside the range -1 to 127, and their behavior
is locale-dependent.  Use g_ascii_isXXX() and g_ascii_toXXX() instead of
isXXX() and toXXX().

If you're checking for printable ASCII, don't use isascii() and don't
use iscntrl(), use g_ascii_isprint().  If you're checking for graphical
ASCII, i.e. printable ASCII except for a space, use g_ascii_isgraph().

Use ws_xton() to convert a hex digit character to the corresponding
numeric value.

Change-Id: Id3039bc586fbf66d8736c2df248c790c0d7a2330
Reviewed-on: https://code.wireshark.org/review/4851
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-10-20 06:15:19 +00:00
Bill Meier 2005fc6e78 Convert (what appear to be) "4 space tabs"; Adjust editor-modelines; Do some minor reformatting. 
Change-Id: Ie078c826ed38a0d682f61fb3e95450b47a9d2c31
Reviewed-on: https://code.wireshark.org/review/4499
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-10-06 17:10:35 +00:00
Michael Mann 14824e6adf Revert "Fixup: tvb_* -> tvb_captured" 
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html

This reverts commit 246fe2ca4c.

Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-19 18:25:59 +00:00
Dario Lombardo 246fe2ca4c Fixup: tvb_* -> tvb_captured 
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-06-18 14:14:58 +00:00
Dario Lombardo 971ffd683e Fixup: tvb_get_string(z) -> tvb_get_string(z)_enc 
Change-Id: I63a3704effe3fcab01a193dc39b6a22e9f1cf3fe
Reviewed-on: https://code.wireshark.org/review/2376
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-06-18 14:13:58 +00:00
Michael Mann 3d03216eda packet-bencode: proto_tree_add_text -> somthing filterable 
Also, cleanup dissector being called only with tree and a few tvb_new_subset calls.

Change-Id: I1dab1b42ef1a27fc85b05d126f51f1582d7e5c58
Reviewed-on: https://code.wireshark.org/review/1932
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-03 12:39:16 +00:00
Evan Huus 0ac1779822 Add cast to satisfy buildbot 
Change-Id: Ib0f66fb6e4a577da7381a75789b08a0d0371ddd2
Reviewed-on: https://code.wireshark.org/review/1709
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-05-21 03:02:57 +00:00
Peter Lemenkov 572e76bdf0 Don't panic in case of mediaproxy-ng/rtpengine extension 
Change-Id: Id0441ec3e68b594051930623c17f45e806b79616
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://code.wireshark.org/review/1633
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-05-20 22:01:43 +00:00
Alexis La Goutte 296591399f Remove all $Id$ from top of file 
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-03-04 14:27:33 +00:00
Peter Lemenkov 4c100fed02 Initial basic RTPproxy-ng dissector 
Initial basic RTPproxy-ng dissector which uses bencode packing.

Change-Id: I5b3e9f6e745977b3df12263c3a9f4ee9a3e1445e
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://code.wireshark.org/review/268
Reviewed-by: Evan Huus <eapache@gmail.com>
Tested-by: Evan Huus <eapache@gmail.com>
 2014-02-20 22:04:57 +00:00
Peter Lemenkov dd64517eda Add expert info about skipped notify IP address 
- Add expert info about skipped notify IP address
- Add a couple of comments (cosmetic)

Change-Id: I6caa904cf16b304724c5da1933531cf865daf619
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://code.wireshark.org/review/171
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-02-11 11:53:27 +00:00
Peter Lemenkov 3d9547a835 Use IP types instead of plain strings where possible 
Change-Id: Ia4a78e1ef3a7c45761cc271ecc17e7868b8456d9
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://code.wireshark.org/review/157
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
 2014-02-10 19:12:57 +00:00
Michael Mann 29f61a9deb Add numeric types instead of string where possible in the RTPproxy dissector. Bug 9561 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9561) 
From Peter Lemenkov

svn path=/trunk/; revision=54467
 2013-12-26 15:42:06 +00:00
Jakub Zawadzki deb2b236f2 Add missing includes 
svn path=/trunk/; revision=54332
 2013-12-21 17:23:17 +00:00
Jakub Zawadzki 3d6fdc55d0 New functions: str_to_ip6(), str_to_ip() 
This way we can avoid including lot of system header files in some dissectors
and it might fix bug #9581

svn path=/trunk/; revision=54330
 2013-12-21 16:16:56 +00:00
Bill Meier 09ce0cf43c From Peter Lemenkov: 
"This patch removes misleading dereferencing operator from the
  array's name. E.g. consider the following declaration:

  guint32 ipaddr[4];

  ipaddr points to the address of an array of guint32's, while &ipaddr
  points to the first' guint32 object. E.g. &ipaddr == &ipaddr[0]. The
  value is the same, but has different type which is necessary
  sometimes. However inet_pton treats latest argument as void*, and
  this information is left anyway. So no need to bother with types and
  let's just pass pointer to the array."

  https://bugs.wireshark.org/bugzilla/attachment.cgi?id=12304

From me: Remove dereferencing operator from 'ipaddr' in two calls to
         wmem_memdup().

svn path=/trunk/; revision=54156
 2013-12-16 20:38:20 +00:00
Alexis La Goutte c58f388fe3 From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9558 
Mark generated fields as generated in RTPproxy dissector

This patch is cosmetic. It just marks generated fields as generated (to avoid confusion)

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>

svn path=/trunk/; revision=54123
 2013-12-15 16:17:08 +00:00
Alexis La Goutte 18fe640e9b From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9556 
Cosmetic change in a LF field representation in the RTPproxy dissector

Don't display any value for LF field

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>

svn path=/trunk/; revision=54045
 2013-12-13 14:16:54 +00:00
Anders Broman 28e6aa4e8a Fix [-Wmissing-prototypes] 
svn path=/trunk/; revision=54025
 2013-12-13 06:55:20 +00:00
Anders Broman b781d6c99d - Make local functions static. 
- Forward declaration of register functions.

svn path=/trunk/; revision=53958
 2013-12-12 06:11:05 +00:00
Jakub Zawadzki 65db82872c When including <epan/prefs.h> don't force inclusion of <epan/uat.h> 
svn path=/trunk/; revision=53769
 2013-12-03 22:16:49 +00:00
Guy Harris 753811929d Clean up indentation. 
svn path=/trunk/; revision=53742
 2013-12-03 10:54:10 +00:00
Chris Maynard a9900375b4 Fix Coverity CID 1134045: Printf format string issue. (As documented in the printf man page for the ' option, "Note that many versions of gcc(1) cannot parse this option and will issue a warning." (r47940 reverted a similar change, so this keeps things consistent.) 
svn path=/trunk/; revision=53705
 2013-12-02 01:53:13 +00:00
Pascal Quantin 4e3d8291fe From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9490 : 
Couple packets in RTPproxy dissector not only with CookieID but also with Call-IDs

svn path=/trunk/; revision=53673
 2013-11-30 09:50:04 +00:00
Pascal Quantin 68c8c7ef0a From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9487 : 
Use RTP payload descriptions from RTP dissector in RTPproxy codec param value

svn path=/trunk/; revision=53658
 2013-11-29 22:56:34 +00:00
Michael Mann 3d9e55b8be RTPproxy dissector: Add expert info about timeouts. Bug 9484 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9484) 
From Peter Lemenkov

svn path=/trunk/; revision=53622
 2013-11-28 14:11:48 +00:00
Pascal Quantin ca8b7b1ad0 Reinitialize counter between loops to avoid an out of bound access found with fuzz testing. 
svn path=/trunk/; revision=53612
 2013-11-27 08:09:55 +00:00
Guy Harris cc538dbb6c Squelch a compiler warning. 
svn path=/trunk/; revision=53606
 2013-11-26 22:54:25 +00:00
Pascal Quantin f2d28c05bc From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9476 : 
Add DTMF dissector setup based on the information found in RTPproxy requests

svn path=/trunk/; revision=53605
 2013-11-26 22:40:52 +00:00
Pascal Quantin a955db9c0d From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9444 : 
Add initial parameter parser for commands in RTPproxy dissector

svn path=/trunk/; revision=53604
 2013-11-26 22:32:33 +00:00
Pascal Quantin dff6b2aecb From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9397 : 
Add RTP/RTCP dissector setup based on the replies found in rtpproxy dissector

svn path=/trunk/; revision=53603
 2013-11-26 22:05:33 +00:00
Pascal Quantin af892f0553 Fix typo errors 
svn path=/trunk/; revision=53585
 2013-11-25 22:25:03 +00:00
Martin Kaiser 7d39211e62 add a cast to fix compiler warning 
svn path=/trunk/; revision=53401
 2013-11-17 17:51:59 +00:00
Pascal Quantin 55a9182c00 From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9441 : 
Fix Notify IPv6 address parsing in RTPproxy dissector

svn path=/trunk/; revision=53394
 2013-11-17 14:48:55 +00:00
Pascal Quantin 3ddf37e930 From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9440 : 
RTPproxy: use proto_item_append_text instead of rewriting the entire item's text

svn path=/trunk/; revision=53393
 2013-11-17 14:32:40 +00:00
Pascal Quantin c25fab0718 From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9430 : 
Fix empty ToTag in RTPproxy's Offer/Update command

svn path=/trunk/; revision=53391
 2013-11-17 14:14:41 +00:00
Pascal Quantin 101c3cd268 From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9429 : 
Fix Notify info parsing in RTPproxy dissector

svn path=/trunk/; revision=53385
 2013-11-17 13:59:06 +00:00
Martin Kaiser 77e4c15615 replace proto_tree_add_string_format_value() with proto_tree_add_item() 
svn path=/trunk/; revision=53261
 2013-11-11 22:15:30 +00:00
Martin Kaiser 44d8b7f412 From Peter Lemenkov 
display a text description for the RTPProxy version request

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9416

svn path=/trunk/; revision=53249
 2013-11-11 16:36:16 +00:00
Michael Mann 5bebc2020c Decode more error replies in RTPproxy dissector. Bug 9408 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9408) 
From Peter Lemenkov

svn path=/trunk/; revision=53245
 2013-11-11 02:06:17 +00:00
Michael Mann 99e20da08e Add response time to the rtpproxy dissector. Bug 9380 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9380) 
From Peter Lemenkov.

svn path=/trunk/; revision=53115
 2013-11-06 20:39:10 +00:00
Guy Harris aa57e00210 Fix signed vs. unsigned comparison warnings. 
svn path=/trunk/; revision=52483
 2013-10-09 22:30:59 +00:00
Anders Broman f678c0fd49 Try to fix 
packet-rtpproxy.c:217: warning: comparison between signed and unsigned

svn path=/trunk/; revision=52477
 2013-10-09 20:30:18 +00:00
Anders Broman 6ca246c95d Make RTPProxy a newstyle dissector. 
svn path=/trunk/; revision=52476
 2013-10-09 20:14:12 +00:00
Pascal Quantin 5685440a64 Let's please fix-encoding-args.pl 
svn path=/trunk/; revision=52334
 2013-10-02 17:33:19 +00:00
Pascal Quantin 5d183ee5a2 From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9211 : 
Add basic conversation support for rtpproxy dissector

svn path=/trunk/; revision=52331
 2013-10-02 16:37:10 +00:00
Pascal Quantin a0c53ffaa1 emem -> wmem conversion: 
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
 2013-09-22 15:50:55 +00:00
Chris Maynard 5dee89a18a Fix Coverity CID 1063335: Unused pointer value. 
svn path=/trunk/; revision=51430
 2013-08-19 19:59:52 +00:00
Evan Huus bf9d434e56 One more 64/32-conversion fix for rtpproxy 
svn path=/trunk/; revision=51421
 2013-08-18 21:31:07 +00:00
Evan Huus 4dfcdcfba5 Take another stab at 
packet-rtpproxy.c:226: warning: implicit conversion shortens 64-bit value into a
32-bit value

svn path=/trunk/; revision=51420
 2013-08-18 20:09:05 +00:00