Chris Maynard
f88e871171
Fix some typos.
...
svn path=/trunk/; revision=40786
2012-02-01 01:41:11 +00:00
Chris Maynard
5cfa297971
Don't pass 'len' to the dissect routine since we know there's only 1 byte present. This fixes the buildbot complaint about using 'len' uninitialized.
...
svn path=/trunk/; revision=40008
2011-11-26 04:45:49 +00:00
Chris Maynard
6dc3290d68
Add a few casts to try to make the buildbots happy.
...
svn path=/trunk/; revision=40007
2011-11-26 04:31:40 +00:00
Chris Maynard
d51167076a
IP option improvements. While fixing bug 6561, I noticed some deficiencies in the IP options dissection capabilities. Testing of these changes primarily used the capture file attached to that bug report as there were several IP options present. Packet 222 is an interesting packet that illustrates some of the new filters available. Further work is needed, but hopefully this is a good first step. Fuzz testing was performed using my own "menagerie".
...
svn path=/trunk/; revision=40006
2011-11-26 04:16:11 +00:00
Chris Maynard
1f513638e0
Display protocol ID consistently in decimal throughout. Append each IP option to top-level Options field. Whitespace cleanup - the majority of the dissector used 2-space indentation, so that's the format chosen. Added modelines to match.
...
svn path=/trunk/; revision=39994
2011-11-23 18:33:45 +00:00
Chris Maynard
db39b3da06
For now, display the protocol in hexadecimal again so displaying it in decimal doesn't get backported to the 1.6 and 1.4 trunks at the request of Joerg.
...
svn path=/trunk/; revision=39986
2011-11-22 15:18:20 +00:00
Chris Maynard
f2e8579ba3
Fix potential infinite loop introduced with r39961 and find by the buildbot. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6599
...
svn path=/trunk/; revision=39963
2011-11-21 02:01:59 +00:00
Chris Maynard
3c8e31e055
Fix bug 6561: IPv4 UDP/TCP Checksum incorrect if routing header present.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6561
svn path=/trunk/; revision=39961
2011-11-20 15:47:14 +00:00
Bill Meier
54b72021bb
Fix encoding arg for various fcn calls:
...
- proto_tree_add_bits_item
- proto_tree_add_bits_ret_val
- proto_tree_add_bitmask
- tvb_get_bits
- tvb_get_bits16
- tvb_get_bits24
- tvb_get_bits32
- tvb_get_bits64
svn path=/trunk/; revision=39539
2011-10-24 19:57:53 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Gerald Combs
583ac864c0
Enable GeoIP lookups by default. Don't add GeoIP subtrees if we didn't
...
find any databases.
svn path=/trunk/; revision=39363
2011-10-11 17:57:09 +00:00
Bill Meier
4e57694d4a
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Stig Bjørlykke
1becef31f0
Use IPv4 as protocol name, to align with IPv6.
...
svn path=/trunk/; revision=37070
2011-05-12 10:27:02 +00:00
Jakub Zawadzki
38c2f2a151
Cleanup: replace sizeof(arr)/sizeof(arr[0]) with shorter array_length(arr)
...
svn path=/trunk/; revision=36986
2011-05-04 19:32:35 +00:00
Chris Maynard
ba9dc9f45f
Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in
...
the value="..." attribute. Fixes bug 1520.
svn path=/trunk/; revision=36378
2011-03-28 14:53:35 +00:00
Stig Bjørlykke
a07fff3b15
Corrected hack for TAPA by checking for "not IPv4".
...
Coverity 343.
svn path=/trunk/; revision=36244
2011-03-22 10:12:07 +00:00
Stig Bjørlykke
84bc28bd6a
Introduce "Fragment count" filter element for all protocols doing reassembly.
...
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
Guy Harris
158e9a3dae
Clean up indentation.
...
svn path=/trunk/; revision=35257
2010-12-23 21:22:55 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Stig Bjørlykke
8b21f50474
Added hint about "TCP segmentation offload" when IP length == 0.
...
Added expert info item for bogus IP length.
Added hint about "IP checksum offload" for invalid IP checksum.
Describe TSO in the preference setting.
svn path=/trunk/; revision=34830
2010-11-10 13:49:55 +00:00
Bill Meier
9675740701
Use value_string_ext fcns to access certain value_string arrays;
...
Sort several value_string arrays to be in ascending order.
Also: Minor whitespace cleanup.
svn path=/trunk/; revision=34766
2010-11-03 22:08:49 +00:00
Jaap Keuter
694383d4a8
From Simon Leinen:
...
The IP Timestamp Option (RFC 781) has three variants. One (flag=0) just stores
a sequence timestamps in the option, but the other two (flag=1 and flag=3)
store alternate IP addresses and timestamps.
From me:
Mark option full when offset (pointer) is set to one, as per RFC 781.
svn path=/trunk/; revision=34750
2010-11-02 08:48:06 +00:00
Gerald Combs
0e64b1749c
Enable "Support packet-capture from IP TSO-enabled hardware" by default.
...
Like checksum offloading this seems to be common on modern systems.
svn path=/trunk/; revision=34383
2010-10-05 16:32:12 +00:00
Stig Bjørlykke
2d93bc5e9a
Make "4 NOP in a row" work again after changing the NOP name for TCP and IP
...
in revisions 34095 and 34097.
svn path=/trunk/; revision=34134
2010-09-16 12:29:22 +00:00
Stig Bjørlykke
894941e532
Only check for 4 NOP in a row within a uint32 boundary.
...
svn path=/trunk/; revision=34100
2010-09-10 21:24:32 +00:00
Stig Bjørlykke
f2e302eee0
Follow TCP and expand description for "NOP" and "EOL" options to "No-Operation (NOP)"
...
and "End of Options List (EOL)" respectively.
svn path=/trunk/; revision=34097
2010-09-10 16:48:00 +00:00
Stig Bjørlykke
aca8a4d989
Update dsfield ECN according to RFC3168.
...
svn path=/trunk/; revision=34092
2010-09-10 11:16:29 +00:00
Stig Bjørlykke
e71daa1fc1
Revert revision 33780, because the checksum is only calculated
...
from the header and not the content.
svn path=/trunk/; revision=34080
2010-09-08 13:38:47 +00:00
Stig Bjørlykke
dfb24f48d8
From Chris Maynard via bug 5105:
...
IP should not compute the header checksum if within an error packet
such as ICMP.
svn path=/trunk/; revision=33780
2010-08-12 06:26:21 +00:00
Stig Bjørlykke
8aaa5b8ec7
Added description of ECT and ECN-CE, added TFS for the bit values
...
and some item cleanup.
svn path=/trunk/; revision=33313
2010-06-24 11:37:03 +00:00
Jaap Keuter
8bba8bf460
Fix for bug 4888:
...
Restore setting DSCP column value, when relevant.
svn path=/trunk/; revision=33270
2010-06-20 18:24:25 +00:00
Stig Bjørlykke
1069c8dccf
Added an expert info for "4 NOP in a row" in IP and TCP.
...
svn path=/trunk/; revision=33265
2010-06-20 16:22:51 +00:00
Stig Bjørlykke
d051e79a81
Revert back to the old Flags entry.
...
Add number of bits used for Flags in the description.
svn path=/trunk/; revision=33264
2010-06-20 16:17:10 +00:00
Gerald Combs
1bac7c2610
From Chris Maynard via bug 4014:
...
This trivial patch merely displays the ICMP ID and sequence # in the Info
column.
svn path=/trunk/; revision=33056
2010-06-02 18:13:00 +00:00
Anders Broman
2b90c98a1a
Use value_string_ext for ip protocol.
...
svn path=/trunk/; revision=32914
2010-05-22 22:04:18 +00:00
Anders Broman
3c51d54e83
Fix:
...
packet-ip.c:1311: warning: 'field_tree' may be used uninitialized in this function
svn path=/trunk/; revision=32635
2010-05-02 17:02:11 +00:00
Anders Broman
d528b62777
From Jakub Zawadzki:
...
patch for ip.flags (using proto_tree_add_bits_item).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413
svn path=/trunk/; revision=32633
2010-05-02 15:36:44 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Jaap Keuter
6e795990fb
The evil bit IS a security issue.... ;)
...
svn path=/trunk/; revision=31915
2010-02-18 20:58:04 +00:00
Jaap Keuter
c084355412
From Chris Maynard:
...
Take into account PIM protocol specifics with regards to TTL when colorizing packets.
svn path=/trunk/; revision=31807
2010-02-05 22:39:14 +00:00
Stig Bjørlykke
47e732e29e
Changed "reassembled_length" -> "reassembled.length".
...
svn path=/trunk/; revision=31776
2010-02-03 08:47:15 +00:00
Stig Bjørlykke
88b72356ad
Introduce "Reassembled length" filter element for all protocols doing
...
reassembly.
svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Bill Meier
e49599c588
Fix Bug #4177 : Analyze ! Expert... doesn't show IP "Bad Checksum" errors.
...
svn path=/trunk/; revision=31471
2010-01-08 23:53:46 +00:00
Stephen Fisher
c5fdb8edae
From Chris Maynard via bug #4287 : Display IP protocol number in decimal
...
instead of hexadecimal.
svn path=/trunk/; revision=31165
2009-12-03 19:10:43 +00:00
Stig Bjørlykke
005049bebb
Changed hf_ip_proto to use ipproto_val[].
...
Removed some unneeded includes.
svn path=/trunk/; revision=31017
2009-11-19 15:30:06 +00:00
Jaap Keuter
324b7484d9
Implement RFC 3514.
...
svn path=/trunk/; revision=30926
2009-11-10 21:46:14 +00:00
Jaap Keuter
03730e3bc1
From Filipe David Borba Manana:
...
Since it was named Ethereal and up to today, Wireshark wrongly parses
the IPv4 header flags field:
* it considers it as a 4 bits wide field - according to RFC 791 its a 3 bits
wide field (first 3 bits of the 6th octect of the IPv4 header).
* if for example the DF bit is set, Wireshark displays the flag value as 0x04
(0100) when it should be 0x02 (010), idem for the MF flag.
Attached to this bug report, you can find a patch to fix the issue.
svn path=/trunk/; revision=30855
2009-11-07 11:24:05 +00:00
Anders Broman
88bb44a51e
From Jakub Zawadzki:
...
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164
svn path=/trunk/; revision=30691
2009-10-25 11:43:30 +00:00
Jörg Mayer
8bd7ebc6a1
- Fix for bug 3965 as reported by Ivan Sy <ivan_jr@yahoo.com>
...
mDNS and LLMNR also deviate from the TTL=1 for 224.0.0.0/24
- Fix two warnings about removing const by casting.
svn path=/trunk/; revision=29644
2009-08-31 22:34:25 +00:00
Kovarththanan Rajaratnam
51ca1739ae
Custom columfication:
...
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield
svn path=/trunk/; revision=29518
2009-08-23 11:12:12 +00:00