Commit Graph

48869 Commits

Author SHA1 Message Date
Pascal Quantin 7d6899b96b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9155 :
Ensure that codec_str string is always initialized 

svn path=/trunk/; revision=52107
2013-09-16 21:26:03 +00:00
Gerald Combs 6079691af4 Convert each of the address.h macros to inline functions.
Document each function. Note that we now call tvb_get_ptr() before
modifying the address in tvb_set_address() and tvb_set_address_hf(). The
caller doesn't have to worry about doing that any more. Add
add_address_to_hash64().

svn path=/trunk/; revision=52106
2013-09-16 21:15:49 +00:00
Jörg Mayer 4e74f3a3c3 Don't print a warning about missing svn id when the argument is not
a file. Warn about the "wrong" filetype and continue

svn path=/trunk/; revision=52105
2013-09-16 20:30:34 +00:00
Anders Broman 038d3b0a56 Read the local services file.
svn path=/trunk/; revision=52104
2013-09-16 18:36:50 +00:00
Anders Broman 1821ed0404 Don't call getservbyport() on unresolved ports - it's expensive.
We should read the services file in initialize_services instead.

svn path=/trunk/; revision=52103
2013-09-16 17:53:41 +00:00
Gerald Combs f36c727fb0 Add stream information to the hint label. Update our hint more often.
Add a "to do" list.

svn path=/trunk/; revision=52102
2013-09-16 17:28:42 +00:00
Chris Maynard 6a1bd211fd Trivial: Fix typo.
svn path=/trunk/; revision=52101
2013-09-16 16:49:17 +00:00
Jeff Morriss cc7a3cf06c Remove a bunch more set-but-no-longer-used variables.
svn path=/trunk/; revision=52100
2013-09-16 14:08:43 +00:00
Jeff Morriss bf093ef1f6 Remove set-but-no-longer-used variable.
svn path=/trunk/; revision=52099
2013-09-16 14:05:31 +00:00
Michael Mann 346f803d42 Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was all manual inspection and most cases were either:
1. Case sensitivity differences between hf_ field name and formatted string.
2. Unnecessary whitespace between hf_ field name and colon in formatted string

There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed.

svn path=/trunk/; revision=52098
2013-09-16 10:39:06 +00:00
Alexis La Goutte 58e4750ecb Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=52097
2013-09-16 07:56:04 +00:00
Alexis La Goutte 9bde18734f From Peter Wu via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9144
Update TLS Ciphers

The attached trivial patch corrects the digest (SHA) length for TLS_DHE_DSS_EXPORT1024_WITH_DES_CBC_SHA

svn path=/trunk/; revision=52096
2013-09-16 07:54:28 +00:00
Gerald Combs 29b63a71e6 Make sure we don't tap our packets twice. Give the graph has focus after
we redraw it.

svn path=/trunk/; revision=52095
2013-09-16 02:04:52 +00:00
Gerald Combs 0f6baaa805 Fix graph type selection.
svn path=/trunk/; revision=52094
2013-09-16 01:19:14 +00:00
Gerald Combs 6b251c7219 Another attempt at axis scaling. Tweak the appearance a little.
svn path=/trunk/; revision=52093
2013-09-16 00:50:23 +00:00
Gerald Combs 98479b0b17 When caclulating throughput, only subtract what we've added. Try to fix
axis scaling.

svn path=/trunk/; revision=52092
2013-09-15 23:55:51 +00:00
Martin Kaiser ca637dec68 mark unused parameter
svn path=/trunk/; revision=52091
2013-09-15 22:42:58 +00:00
Evan Huus adb39445ee Apparently some platforms don't like $ in their macro names. Fix it.
svn path=/trunk/; revision=52090
2013-09-15 22:36:47 +00:00
Evan Huus 464bbb1275 Tweak mq macro and checkAPI to avoid false positives - "garbage"
(like a #define) at the beginning of a line before a value_string no longer
matches so a #define that includes the beginning of a value_string doesn't
confuse the script.

svn path=/trunk/; revision=52089
2013-09-15 22:34:36 +00:00
Anders Broman c05e9683fd unused variable 'conversation'
svn path=/trunk/; revision=52088
2013-09-15 21:42:13 +00:00
Pascal Quantin da8240ef60 emem -> wmem (except uat or init routines)
svn path=/trunk/; revision=52087
2013-09-15 21:36:37 +00:00
Evan Huus da27bad13b Comment out hf_ var whose use is also commented out at least for now.
svn path=/trunk/; revision=52086
2013-09-15 21:01:45 +00:00
Evan Huus 5bd199d8f5 From RobiOneKenobi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9072
Substantial enhancements to MQ protocol: all Structure, MSG_REQUEST/ASYNC_RESP,
MQ Multi Segment are decoded until version 7.1/7.5

svn path=/trunk/; revision=52085
2013-09-15 20:56:56 +00:00
Evan Huus 5d8143a6ab Our hash function is no longer commutative (yay!). However, this means that we
no longer get to check both conversation directions at once "for free" because
the two orderings actually result in different hashes. Do them one at a time.

Sorry Anders, this may or may not cancel out some of the performance gain you
were looking for. Either way, the new hash function is still an improvement.

Fixes bidirectional conversation lookup, which was conveniently showing up as
a DTLS decryption failure in the test suite. Go figure.

svn path=/trunk/; revision=52084
2013-09-15 20:47:45 +00:00
Gerald Combs dd88e1ab26 Make sure the RTT behavior matches the GTK+ port. Make sure we properly
select a graph type.

svn path=/trunk/; revision=52083
2013-09-15 20:44:57 +00:00
Evan Huus 432a064b0e Simplification I noticed while reviewing the wmem conversion: there's no need to
strdup the string built in a strbuf if the scope is the same. Remove the
thoroughly unnecessary temporary variable as well.

svn path=/trunk/; revision=52082
2013-09-15 20:18:56 +00:00
Evan Huus 82c63755ab Add the new hash algorithm to the macro we were already using. Create a
temporary address structure for the port-numbers so we can use the same macro,
reducing duplication further.

Add modelines.

svn path=/trunk/; revision=52081
2013-09-15 20:11:25 +00:00
Pascal Quantin 1359f55d9f From Roland Knall via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9145 :
openSAFETY: SSDO Abort codes are handled incorrectly 

svn path=/trunk/; revision=52080
2013-09-15 19:44:19 +00:00
Anders Broman 6653b82a98 Use a better hash algorithm and add a dialouge to get hastable data.
(missed a file)

svn path=/trunk/; revision=52079
2013-09-15 19:35:42 +00:00
Anders Broman 7f57fe3357 Use a better hash algorithm and add a dialouge to get hastable data.
svn path=/trunk/; revision=52078
2013-09-15 19:35:10 +00:00
Martin Kaiser 0e57edb890 emem -> wmem for radius
svn path=/trunk/; revision=52077
2013-09-15 18:43:04 +00:00
Martin Kaiser b1272cbca1 emem -> wmem
svn path=/trunk/; revision=52076
2013-09-15 18:27:07 +00:00
Martin Kaiser 04ec29b391 emem -> wmem
svn path=/trunk/; revision=52075
2013-09-15 18:20:25 +00:00
Pascal Quantin 8c7cb82470 No need to use the pinfo pool
svn path=/trunk/; revision=52074
2013-09-15 18:18:08 +00:00
Evan Huus 97659c67f3 From Michal Labedzki via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9119

Implement the majority of the remaining items from the PN532 spec.

svn path=/trunk/; revision=52073
2013-09-15 18:13:42 +00:00
Martin Kaiser f83c03db62 emem -> wmem
svn path=/trunk/; revision=52072
2013-09-15 18:13:02 +00:00
Pascal Quantin 20a40260d7 A few more dissectors converted to wmem
svn path=/trunk/; revision=52071
2013-09-15 18:03:32 +00:00
Martin Kaiser a54e67abce TABs -> spaces
add editor modelines

svn path=/trunk/; revision=52070
2013-09-15 18:01:01 +00:00
Jörg Mayer 61aced2d64 emem -> wmem
svn path=/trunk/; revision=52069
2013-09-15 17:50:35 +00:00
Jörg Mayer 98baf8ba18 Add help option
List options one by one

svn path=/trunk/; revision=52068
2013-09-15 17:50:18 +00:00
Martin Kaiser ed321d62c3 emem -> wmem
svn path=/trunk/; revision=52067
2013-09-15 17:12:54 +00:00
Martin Kaiser 62c3c0e1f0 emem -> wmem
svn path=/trunk/; revision=52066
2013-09-15 16:53:11 +00:00
Anders Broman 4269f3065b Fix a typo
svn path=/trunk/; revision=52065
2013-09-15 16:49:06 +00:00
Anders Broman 516f145eaa Use "cheaper" length check.
svn path=/trunk/; revision=52064
2013-09-15 16:47:31 +00:00
Pascal Quantin 7850883904 emem -> wmem
svn path=/trunk/; revision=52063
2013-09-15 15:11:11 +00:00
Jörg Mayer c5ffff76d8 Fix checkapi warnings (missing id)
Replace Makefile.{am,nmake,common} that did not conform by
their asn1/c133/ version.

svn path=/trunk/; revision=52062
2013-09-15 15:00:03 +00:00
Jörg Mayer 05ba7d3afc http://url is NOT a c++ style comment
svn path=/trunk/; revision=52061
2013-09-15 14:49:16 +00:00
Jörg Mayer 65ff43fada Finish asn1 emem -> wmem conversion.
Left are snmp and those functions that don't have wmem equivalents.

svn path=/trunk/; revision=52060
2013-09-15 14:37:46 +00:00
Jörg Mayer c65459c729 emem -> wmem (don't forget about .cnf)
svn path=/trunk/; revision=52058
2013-09-15 14:33:38 +00:00
Gerald Combs b936b046de [Automatic manuf, services and enterprise-numbers update for 2013-09-15]
svn path=/trunk/; revision=52056
2013-09-15 14:03:44 +00:00