Commit Graph

70866 Commits

Author SHA1 Message Date
Peter Wu 7c0c8189a6 Qt: fix "Follow stream" in Conversations dialog
If no stream is given to FollowStreamDialog::follow(), then it
overwrites the display filter with a conversation filter for the first
packet in the capture file.

Pass an explicit stream number and the "Follow stream" button will set a
correct display filter.

Test: open pcap with three TCP streams. Statistics -> Conversations.
Select last TCP conversation (expect "tcp.stream eq 2"). Select the
second conversation (expect "tcp.stream eq 1") and activate "Filter Out"
button (expect "!(tcp.stream eq 1)" and not "!(tcp.stream eq 2) and
!(tcp.stream eq 1)").

Bug: 14254
Change-Id: I28744d7f76f5034b07ea5660b45399566e3a7d2c
Reviewed-on: https://code.wireshark.org/review/26520
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-21 16:56:21 +00:00
Joakim Karlsson 83d028792a GPRSCDR: fix bitrates in EPCQoSInformation
Changed type for the bitrate fields, from signed32 to unsigned32.
This fixes the problem of getting "-1" values at G_MAXUINT32.

TS 32.298 refers to TS 29.212 regarding bitrates, in TS 29.212 the
corresponding AVPs are defined as Unsigned32.

Change-Id: I6e0083bf034c7254ab48ca3c2c405cc20f5d6394
Reviewed-on: https://code.wireshark.org/review/26585
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-21 10:44:54 +00:00
Peter Wu ca9976bec9 rsa: fix memleak and accept keys from certain PKCS#12 files
The "bag" was not deallocated when the key is successfully loaded.
Parse all bag elements rather than clearing the bag after the first
iteration (this restores previous behavior).

Change-Id: Ib52da6586f7435d18fa5b0660e7771436544b634
Fixes: v2.5.0rc0-613-gf63b68f707 ("Further cleanups.")
Reviewed-on: https://code.wireshark.org/review/26481
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-03-21 10:36:23 +00:00
Peter Wu af8ac43a1f tcp: preserve data source if a PDU uses it
If the previous TCP segments already form one or more PDUs, then the
data source of these segments must not be removed. Otherwise
get_field_data (epan/print.c) will fail to find the data source which
correspond to the fields within these PDUs.

Also tested with the capture referenced in v1.11.3-rc1-1525-g21e0a63b29
(bug 9169), the "tshark -Vr mem-leak.pcap" output remains unchanged.

Bug: 14472
Change-Id: Ia448a6b84dd2eb84b00e56d3fcde04f7bec05b9d
Reviewed-on: https://code.wireshark.org/review/26397
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-03-21 10:35:20 +00:00
Ivan Secerin 10c508ebf8 packet-wsp: fixed incorrect invalid header handling
In function 'add_header' coгple of if-statements didn't corespond
to comments above.

Change-Id: Idd846cebf7e17d0e2f49c7c7d3de466b899c73c6
Reviewed-on: https://code.wireshark.org/review/26573
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-21 09:14:59 +00:00
Alexis La Goutte 979808091d l16 (plugins/codecs): fix no previous prototype for ‘codec_register_l16’ [-Wmissing-prototypes]
Change-Id: I5f3bd624f2c5b327e40194fc29f34a11cfd48267
Reviewed-on: https://code.wireshark.org/review/26568
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-03-21 06:39:16 +00:00
Guy Harris 67416033b0 Fix case.
Change-Id: I328aae5396cdd071f2c87cded46b8eb747e61dec
Reviewed-on: https://code.wireshark.org/review/26582
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-21 05:35:17 +00:00
Joerg Mayer de18eff51b Add new dot3MauTypes from RFC 4836
Change-Id: I998efdfd065c17fce20eb1596d9a247015327ecb
Reviewed-on: https://code.wireshark.org/review/26578
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-03-20 19:12:08 +00:00
Guy Harris 032554fe3f Note that exit_application() has UI-specific implementations.
Change-Id: I79d51dd4301451d4158d172d0b05094cb3d5d61b
Reviewed-on: https://code.wireshark.org/review/26576
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-20 18:09:10 +00:00
Guy Harris ed3a9eb41c Remove redundant declaration of exit_application().
Change-Id: I60c9236a53083f14d1f7b94c7db66172944d17bf
Reviewed-on: https://code.wireshark.org/review/26575
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-20 17:57:54 +00:00
Alexis La Goutte f2ada50351 gui_utils(.c): fix no previous prototype for ‘exit_application’ [-Wmissing-prototypes]
Change-Id: I975fdc9ce7aa53208fc13cc76dcf0bb7a4a58bcd
Reviewed-on: https://code.wireshark.org/review/26569
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-20 17:50:44 +00:00
Gerald Combs 4bff0e6dd1 html2text: Wrap at 72 characters.
Change-Id: Id8c9d74b71cabce6bbfb25fd857f71c4b2a4e8ea
Reviewed-on: https://code.wireshark.org/review/26556
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-20 15:46:08 +00:00
Yuri Chislov 9c30b80f46 WCCP : fix mask assignment
Bug: 14538
Change-Id: I87afe01064e8940140d6fa8de3df778aad4e4dd7
Reviewed-on: https://code.wireshark.org/review/26550
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-03-20 13:40:45 +00:00
Peter Wu 3c1f26653d TLS13: fix decryption with KeyUpdate after draft -20
Draft -20 shortened the label used by Key Update, adjust accordingly.

Change-Id: I3761b94933165a65fd810eff7bef4373290346cd
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/26554
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-20 12:34:48 +00:00
Jim Walker bd8df9eb88 Update to couchbase dissector for 'flexible framing extras' on errors
The flexible framing extras can be on success and error packets, so
move the call to dissect out of the success path.

See:
https://github.com/couchbase/kv_engine/blob/master/docs/BinaryProtocol.md#response-header-with-flexible-framing-extras

Change-Id: I6fdadf4a90bd1e9c2b1e6e37793cc7a105fad3a6
Reviewed-on: https://code.wireshark.org/review/26566
Reviewed-by: Dave Rigby <daver@couchbase.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-20 12:14:52 +00:00
Pascal Quantin c75d49719f X2AP: include packet-x2ap.h
This should solve the missing prototypes warnings

Change-Id: Iaf2ac6c0a151cfb614f76c4a6bb103e0210d3808
Reviewed-on: https://code.wireshark.org/review/26567
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-20 10:48:25 +00:00
Guy Harris 5f739fb837 Handle Clang/C2.
Microsoft have a C/C++ compiler with a Clang front end and their code
generator:

	https://blogs.msdn.microsoft.com/vcblog/tag/clang/

Try to detect it.  (It's not too late.)

Change-Id: I574e3f985f376727df77081b429cad7f3d1f5d70
Reviewed-on: https://code.wireshark.org/review/26563
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-20 07:32:41 +00:00
Guy Harris 6401440932 Don't register the link-layer 802.11 dissector in the gre.proto table.
That dissector expects to be handed an 802.11 pseudoheader; the GRE
dissector passes the flags and version from the GRE header to
subdissectors registered in the gre.proto table, so they'd better either
expect the flags-and-version structure or ignore the pseudoheader.  (For
802.11, the pseudoheader has radio information, but that's not available
from GRE.)

Use the no-FCS 802.11 frame dissector instead.

Bug: 14544
Change-Id: I6515901dc3674eb36ec768fa4f9a7a4040a78365
Reviewed-on: https://code.wireshark.org/review/26560
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-20 06:48:54 +00:00
Peter Wu ff4a7a6e84 QUIC: ensure Initial Packet decryption at first pass
Change-Id: Ie17397feb646ae1dc7a53c1386c568ee11c29154
Ping-Bug: 13881
Reviewed-on: https://code.wireshark.org/review/26557
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-20 06:21:33 +00:00
Sake Blok 10b63fa684 Fix and update the vagrant build system
Fix a dependency issue for the vagrant build system and update
it to the latest Ubuntu LTS release (16.04 LTS). Also give it
more vCPU's and RAM by default.

Change-Id: I058e6a05356dba57a55ada7fe84f959e227a04b4
Reviewed-on: https://code.wireshark.org/review/26541
Reviewed-by: Sake Blok <sake.blok@SYN-bit.nl>
2018-03-19 22:22:55 +00:00
Peter Wu acba178546 wmem: ensure wmem_memdup(..., NULL, 0) returns NULL
Rather than requiring all callers to pass a non-null source argument,
explicitly allow a NULL source when the size is zero. This is consistent
with g_memdup behavior.

While at it, fix a memleak and avoid memset(0,0,0) in tests.

Change-Id: I86a092625a508544d180da959e4afdd0366539f4
Reviewed-on: https://code.wireshark.org/review/26496
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Mališa Vučinić <malishav@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Evan Huus <eapache@gmail.com>
2018-03-19 16:15:35 +00:00
Peter Wu 859c5bf836 wmem: fix random test failure due to key collision
Fixes sporadic test failure in buildbot:

    ERROR:epan/wmem/wmem_test.c:1170:wmem_test_tree: assertion failed: (wmem_tree_count(tree) == CONTAINER_ITERS)

Change-Id: Ia33b54d8f0a7afc37fa9356aa868c4a7b896e7da
Test: wmem_test --seed R02S674cddedb75a1db84fb9698ac51213c0
Reviewed-on: https://code.wireshark.org/review/26501
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Evan Huus <eapache@gmail.com>
2018-03-19 16:14:27 +00:00
Martin Heusse 98e711da1d GSMTAP: add the handle to dissect LTE NAS EPS messages
GSMTAP_TYPE_LTE_NAS has been set to 0x12 by osmocom:
https://gerrit.osmocom.org/5018

Change-Id: Ia248e54cd73eaa9b8ad02aa40145e5a87baca79e
Reviewed-on: https://code.wireshark.org/review/24554
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-19 15:51:13 +00:00
Pavel Strnad 18cd454da9 S1AP: fix filtering on cell-ID
Filter does not work due to same shared short name for cell-id being used for two different asn.1 defintions
  cell-ID OCTET STRING,
  cell-ID CellIdentity,

Change-Id: I5921bc82d46f38d43f9083e41d3a0558821042eb
Reviewed-on: https://code.wireshark.org/review/26545
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pavel Strnad <pavel_strnad@hotmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-19 14:37:04 +00:00
Pascal Quantin 4d3c8bc61e MAC-NR: unify BSR filters
Use a single filter for short/long (truncated) BS values to ease
filtering.
Rename other filters to the new mac-nr.bsr.* format.
Fill the missing entries in 8 bits buffer size levels array.

Change-Id: If150f9a951efb40e554c5ea18639cfd4539a1319
Reviewed-on: https://code.wireshark.org/review/26539
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-03-19 07:51:49 +00:00
Stig Bjørlykke 845bd4f728 6lowpan: Add option to toggle IID U/L bit
RFC 7668 section 3.2.2 states that IID formed from the 48-bit Bluetooth
device addresses does not toggle the Universal/Local bit, but Linux
kernel BT IPSP code before version 4.12 does toggle this bit.

Add an option to turn this on when needed.

Change-Id: I77f84a5d56e77bb2c61770237fe53367498cc194
Reviewed-on: https://code.wireshark.org/review/26533
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-03-18 22:26:24 +00:00
Guy Harris d8229ad6ed Make a function not used outside this file static.
Change-Id: I8e1a2b0655083403ee0e7efccc976a1a27db8fa4
Reviewed-on: https://code.wireshark.org/review/26540
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-18 20:55:43 +00:00
Peter Wu 56425fce7c Qt: allow keyboard navigation in Unsaved packets dialog
Currently the "Continue without Saving" button is visually highlighted
in the "Unsaved packets..." dialog, but pressing Enter triggers "Save"
instead. Even after changing button focus with arrow or tab keys,
pressing Enter will not confirm the action (but Spacebar does).
Restore the expected behavior for Linux and Windows, but preserve the
fix for macOS since (for which this was originally added).

Bug: 14531
Change-Id: Ic20fc5809b55949f6fd960bcb32618a4fa7fd1e9
Fixes: v2.3.0rc0-2672-gb0335359e5 ("Qt: Give discard button focus (but not as default)")
Reviewed-on: https://code.wireshark.org/review/26511
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-18 14:10:41 +00:00
Jaap Keuter dd8789036f QUIC: use GLib constant
Fix build failure: use G_MAXUINT64 instead of UINT64_MAX.

Change-Id: Ie4fc1c3398088863e5db320beeae2b93cd6823c3
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/26532
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-03-18 12:52:14 +00:00
Joerg Mayer b446ab2b69 ERSPAN: Remove redundant version check
Change-Id: I6f7601983c8bda52d6687a7e1f02e8611f468df3
Reviewed-on: https://code.wireshark.org/review/26531
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-03-18 11:12:35 +00:00
Joerg Mayer aeca321f36 ERSPAN: Various small cleanups and enhancements
Pass Type I vs. II/III via dissector data instead of pinfo
Append type to protocol name
Put vlan number into pinfo when appropriate
Put version 1 and version 2 dissection into separate blocks
Rename priority into cos (as per draft-rfc)
Add new subheader from draft-3

Change-Id: I6eb7fe7073a6cc92e2028b0491de5e0f3f036b4e
Reviewed-on: https://code.wireshark.org/review/26512
Petri-Dish: Jörg Mayer <jmayer@loplof.de>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-03-18 10:14:03 +00:00
Gerald Combs d9541236a3 [Automatic update for 2018-03-18]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I9424882cb781156d38c634b91defcd45cd3f4743
Reviewed-on: https://code.wireshark.org/review/26528
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-18 08:11:48 +00:00
Peter Wu c1b7c8f9d2 Qt: ensure field is visible on selection from bytes view
Ensure that a selected field (via selectedFieldChanged) becomes visible
in the packet details view when selected from the bytes view (or when
found via a search).

As making a field always visible seems a desirable feature (and in the
interest of simplifying preferences), enable this by default using the
smarter EnsureVisible hint.

Remove the associated preferences and mark them GTK+ only.

Change-Id: I05a918c1e09135c0b4e10f04024bff092756e55c
Fixes: v2.5.0rc0-2383-g6b2764a41e ("ProtoTree behavior fixes.")
Reviewed-on: https://code.wireshark.org/review/26509
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-18 00:30:49 +00:00
Dario Lombardo 401e335b7f tap-tcp-stream: fix indentation.
Change-Id: I9ec60866dc674d9ec682afc6d644d78255182cac
Reviewed-on: https://code.wireshark.org/review/26526
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 21:24:54 +00:00
Dario Lombardo 296cd7c91d tap-tcp-stream: replace some g_malloc with g_new.
Change-Id: I25414be8ea73b986ea84294686a1d97159e1e2c7
Reviewed-on: https://code.wireshark.org/review/26525
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 21:24:33 +00:00
Dario Lombardo c26f7daae3 tap-iax2-analysis: fix minor indentation issues.
Change-Id: I778fb32450e43a28b15e78e1e90ed7b69d4f341a
Reviewed-on: https://code.wireshark.org/review/26524
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 21:24:13 +00:00
Dario Lombardo 31425eac72 tap-sctp: replace g_malloc with g_new.
When allocating structs this increases a lot the code readability.

Change-Id: I86b26ea3debb400d6e1e8012206008740e528b23
Reviewed-on: https://code.wireshark.org/review/26523
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 21:23:48 +00:00
Dario Lombardo ecda3d0901 tap-sctp: remove guint32 unneeded allocations.
They've been replaced by direct cast.

Change-Id: I99fbc0463af724dc2592fbfe24a63c645902c703
Reviewed-on: https://code.wireshark.org/review/26522
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 21:23:35 +00:00
Pascal Quantin b4498c964f CQL: ensure that there is at least one column to display rows
Bug: 14530
Change-Id: Ie5729c00ea4d826dbae028b3a4653acf746b92b8
Reviewed-on: https://code.wireshark.org/review/26521
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 20:20:23 +00:00
Alexis La Goutte 05919f7af7 QUIC: Add dissection of Full Packet Number (PKN)
Bug: 13881
Change-Id: I84fdcd48529268c83d48dea633338ed84c647535
Reviewed-on: https://code.wireshark.org/review/26508
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-03-17 15:07:52 +00:00
Pascal Quantin 46819c88af MAC-NR: add BCCH BCH decoding
Change-Id: I7a3b99ce99c8589286a6e99728e809a9c9475977
Reviewed-on: https://code.wireshark.org/review/26519
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-17 11:38:36 +00:00
Pascal Quantin 07db1e95be MAC-NR: minor display adjustments
Change-Id: Ib599eb5ca979cb1214576e6932eb8b1bf3bdc560
Reviewed-on: https://code.wireshark.org/review/26518
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-03-17 10:50:51 +00:00
Graham Shanks 17a080cc4c The number of beams field has the wrong title: was System Data Length
which is the name of the field before it

Change-Id: I7661bcff58b8a1031dcde84dd46499b7b93b42df
Reviewed-on: https://code.wireshark.org/review/26517
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 07:26:01 +00:00
Gerald Combs 535dd5cb6a NSIS: Link to Npcap.
Mention Npcap on the WinPcap installer page and add a link to it.

Update some other text and tell developers to use NSIS 3.0 while we're
here.

Change-Id: I64728f014f518439ba4a38eda7a283274d40fcdc
Reviewed-on: https://code.wireshark.org/review/26515
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 05:05:54 +00:00
Gerald Combs 2d15d7d51b WSDG: More CMake updates.
Switch a build example to CMake + Ninja. Add syntax highlighting
annotations.

Change-Id: I5ee0af548f44ed5be6f6e8367f5167dc499df017
Reviewed-on: https://code.wireshark.org/review/26514
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 05:04:51 +00:00
Joerg Mayer 2e977276c4 colum-utils.h: Fix 325 million -Wdocumentation warnings
Change-Id: I5ce6fbf4a536ffe72ef7c83d8d4f4f3c79155a8e
Reviewed-on: https://code.wireshark.org/review/26513
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-03-16 20:28:25 +00:00
Pascal Quantin 6280c153bb F1AP: initial dissector submission based on v15.0.0
Change-Id: Icf5c128119afa86efddb87e744f7aecb8bf71e09
Reviewed-on: https://code.wireshark.org/review/26506
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-16 19:10:25 +00:00
Martin Mathieson b96f889e44 Tidy up LTE mac and RLC headers - trivial things seen while adding NR versions
Change-Id: I354dbf60daa3a4fb961d1f8411971bd892a735d2
Reviewed-on: https://code.wireshark.org/review/26502
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-16 18:04:42 +00:00
Gerald Combs 475daf767f More CMake documentation updates.
Change-Id: Ia568e0f46e7a38007bb9b8ea3d6c92233921cc46
Reviewed-on: https://code.wireshark.org/review/26504
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-16 17:35:47 +00:00
Gerald Combs 507d8211e9 CSS: Add a margin.
Change-Id: Ib6da6455f7af8a7cfd9dae3ef6a8511a100a184b
Reviewed-on: https://code.wireshark.org/review/26503
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-16 17:08:51 +00:00