osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
38605 commits 26 branches 0 tags 795 MiB
Commit graph

198 commits

Author SHA1 Message Date
Bill Meier
439adbdbcc Remove obsolete comments referring to mem_chunks. 
svn path=/trunk/; revision=40507
 2012-01-14 20:14:43 +00:00
Anders Broman
42b44648c8 Get rid of Warnings. 
svn path=/trunk/; revision=39954
 2011-11-20 08:59:19 +00:00
Guy Harris
8f06e3af4b The URI parameter parser always has to advance current_offset in the 
loop, otherwise you get stuck in an infinite loop.

(Where in RFC 3261 does it mention the use of commas in URI parameters?)

Should fix bug 6598.

svn path=/trunk/; revision=39952
 2011-11-19 22:57:13 +00:00
Guy Harris
00884a10f2 Clean up indentation. 
svn path=/trunk/; revision=39950
 2011-11-19 20:49:15 +00:00
Anders Broman
4b2aa811e1 Fix Warnings. 
svn path=/trunk/; revision=39948
 2011-11-19 17:21:35 +00:00
Anders Broman
8921bb17b5 Check the return value of dissect_sip_name_addr_or_addr_spec() 
Should fix the recent fuzz failures.
Thanks Chris for isolating the offending packet.

svn path=/trunk/; revision=39867
 2011-11-15 20:14:51 +00:00
Guy Harris
519b219ae8 Squelch a warning. (This code probably needs a review; we really need a 
better general framework for parsing text-based protocols.)

svn path=/trunk/; revision=39866
 2011-11-15 19:44:24 +00:00
Guy Harris
6dd27d049e More indentation cleanup. 
svn path=/trunk/; revision=39864
 2011-11-15 19:35:13 +00:00
Guy Harris
e102876289 Clean up indentation. 
svn path=/trunk/; revision=39863
 2011-11-15 19:33:14 +00:00
Anders Broman
a586241e06 packet-sip.c:1469: warning: unused variable 'contact_param_end_offset' 
svn path=/trunk/; revision=39862
 2011-11-15 19:25:17 +00:00
Anders Broman
f6f12af894 Restore dissection of contact parameters. 
svn path=/trunk/; revision=39861
 2011-11-15 19:03:39 +00:00
Anders Broman
fa5c7f85aa packet-sip.c:1412: warning: 'uri_param_end_offset' may be used uninitialized in this function 
svn path=/trunk/; revision=39828
 2011-11-14 17:27:18 +00:00
Anders Broman
c46bda538d From Johan Wåhl: 
- dissect Route and Via header.
- Dissect URI parameters.

svn path=/trunk/; revision=39827
 2011-11-14 17:10:49 +00:00
Guy Harris
ac507aa5e7 Add some checks for "character not found"; this should fix some 
fuzz-testing failures we're seeing.

svn path=/trunk/; revision=39795
 2011-11-11 19:07:11 +00:00
Anders Broman
e5de258768 packet-sip.c:1442: warning: 'c' may be used uninitialized in this function 
svn path=/trunk/; revision=39783
 2011-11-10 20:38:07 +00:00
Anders Broman
5d97a01889 -Improve dissection of auth items 
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6553)
- Add parameter items to the tree for some  often trunkated lines.

svn path=/trunk/; revision=39782
 2011-11-10 20:16:17 +00:00
Chris Maynard
647c5c0b27 packet_info's in_error_pkt is now a bitfield like in_gre_pkt. 
svn path=/trunk/; revision=39764
 2011-11-08 18:39:11 +00:00
Bill Meier
d6ac27ad42 Fix proto_tree_add_item() encoding args; 
Also: remove unneeded #include.

svn path=/trunk/; revision=39614
 2011-10-26 18:57:02 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier
126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Anders Broman
e925a84e7e From Horaci Macias: 
Parse User-to-User header 
http://tools.ietf.org/html/draft-ietf-cuss-sip-uui-02

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6432

svn path=/trunk/; revision=39402
 2011-10-13 05:15:50 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Anders Broman
ea6df29d7f Move stuff inside if(tree) 
svn path=/trunk/; revision=39038
 2011-09-19 08:37:59 +00:00
Bill Meier
5db6069274 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings. 
svn path=/trunk/; revision=38085
 2011-07-18 15:52:16 +00:00
Bill Meier
a2b58f051d Add #include <stdlib.h> to files which reference fcns declared in stdlib.h; 
(In many cases I previously incorrectly removed the #include <stdlib.h>).

svn path=/trunk/; revision=37334
 2011-05-20 19:00:09 +00:00
Bill Meier
0e95d4dbf5 Don't assign to a proto_item * if the value won't be used: Coverity 1036; 
Fix what appears to be a use of an incorrect tree: Coverity 1037;
Also:
- Remove uneeded #includes & re-order #includes;
- Do indentation and whitespace cleanup (e.g., "4 space tabs").

svn path=/trunk/; revision=36558
 2011-04-11 15:17:22 +00:00
Anders Broman
f5c1fc47af Use tvb_get_ephemeral_string() 
prefix hf vars with hf_sip

svn path=/trunk/; revision=36516
 2011-04-08 11:58:33 +00:00
Anders Broman
538b62429d Make it possible to have a sub dissector dissect the status line diagnostic string should it contain more than a string. 
svn path=/trunk/; revision=36509
 2011-04-07 21:39:49 +00:00
Tomas Kukosa
4e8c772d11 RFC5806 Diversion header 
svn path=/trunk/; revision=36489
 2011-04-06 06:20:50 +00:00
Stephen Fisher
32f6ab2248 Simply this: 
#define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN ((gint)strlen (SIP2_HDR))

To this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN 7


svn path=/trunk/; revision=35588
 2011-01-19 21:51:30 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Jeff Morriss
050d9379ef Remove a no-longer-used variable. 
svn path=/trunk/; revision=35072
 2010-11-29 22:11:39 +00:00
Anders Broman
623253b010 Change SIP TCP port preference to a range preference. 
svn path=/trunk/; revision=35070
 2010-11-29 21:40:49 +00:00
Anders Broman
6224708d6c Remove faulty return, probably forgotten during test. 
Fixing dissection on Via header.

svn path=/trunk/; revision=35004
 2010-11-22 15:02:06 +00:00
Bill Meier
b78ec52693 Use value_string_ext fcns to access certain value_string arrays; 
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.

svn path=/trunk/; revision=34794
 2010-11-05 22:44:03 +00:00
Jaap Keuter
198ecea896 Prevent false related packet information, which may be missing or ignored. 
svn path=/trunk/; revision=34779
 2010-11-04 20:53:02 +00:00
Bill Meier
f329864abf (Trivial): Fix up a comment. 
svn path=/trunk/; revision=34764
 2010-11-03 18:37:29 +00:00
Anders Broman
160fcdfd8b Update SIP headers. 
svn path=/trunk/; revision=34758
 2010-11-03 13:01:01 +00:00
Jaap Keuter
b4d195f256 Try to decode the unknown multipart subtype anyway. 
svn path=/trunk/; revision=34659
 2010-10-27 06:49:39 +00:00
Jeff Morriss
cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34230
 2010-09-24 02:51:40 +00:00
Tomas Kukosa
f5e1f23cac Fix wrong length of CSeq Method parameter 
svn path=/trunk/; revision=33920
 2010-08-25 14:10:58 +00:00
Gerald Combs
27fcf779ae Use the right array bounds. 
svn path=/trunk/; revision=33385
 2010-06-30 23:07:58 +00:00
Gerald Combs
ccd0726178 From Karl Heinz Wolf via bug 3571 (with minor changes): 
Patch for the SIP dissector: the raw SIP message can be shown with our without
the "\r\n". User may want to remove the \r\n for clarity (by selecting a
checkbox).

svn path=/trunk/; revision=33014
 2010-05-28 23:00:29 +00:00
Anders Broman
7436d04550 Only try header reassembly for TCP. 
svn path=/trunk/; revision=32952
 2010-05-25 21:00:55 +00:00
Anders Broman
5198a0b3de Fix a typo. 
svn path=/trunk/; revision=32926
 2010-05-24 04:03:45 +00:00
Anders Broman
1c8c410e22 - Remove check_col() 
- only read method string once.

svn path=/trunk/; revision=32677
 2010-05-05 17:22:40 +00:00
Gerald Combs
99005f40ad Un-C++-ify a comment. 
svn path=/trunk/; revision=32664
 2010-05-04 21:52:41 +00:00
Anders Broman
ec392a4c8e Remove unused variables. 
svn path=/trunk/; revision=32659
 2010-05-04 15:36:54 +00:00
Anders Broman
e75998789b Refactor the code to parse SIP contact parameters. 
svn path=/trunk/; revision=32658
 2010-05-04 15:12:44 +00:00
Anders Broman
3f9d9a766e Forgot a // 
svn path=/trunk/; revision=32605
 2010-04-29 20:41:35 +00:00