osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
38605 commits 26 branches 0 tags 795 MiB
Commit graph

47 commits

Author SHA1 Message Date
Anders Broman
56188e9d27 From Mike Morrin: 
GSM ENHANCED MEASUREMENT REPORT PDUs were not
dissected when present as L3_INFO in RSL MEAS_RES PDUs.

It seems that the RSL L3_INFO needs to be handled by a different dissector
depending on whether it contains a DTAP, SACCH or CCCH PDU, which fortunately
can be deduced from the RSL PDU type.  packet-rsl.c is updated to implement
this.

In packet-gsm_a_rr.c the dissection of PDUs with RR Short PD format is
improved, and also some items are renamed to make clearer the difference
between SACCH PDUs (which cna be normal or Short PD format) and RR Short PD
format PDUs (which can occur on SACCH, CCCH, or DCH).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6699

svn path=/trunk/; revision=40357
 2012-01-01 19:57:47 +00:00
Bill Meier
f52525e40c Use extended value strings. 
svn path=/trunk/; revision=39918
 2011-11-17 21:58:09 +00:00
Bill Meier
9f328a08d3 Remove some unneeded #includes; 
Move proto_reg_handoff...() to the end of the file as per convention;
Do some whitespace cleanup.

svn path=/trunk/; revision=39916
 2011-11-17 20:51:07 +00:00
Bill Meier
365ca9c805 Undo some incorrect (but benign) FALSE->ENC_BIG_ENDIAN conversions done in SVN 37080. 
svn path=/trunk/; revision=39905
 2011-11-17 16:42:18 +00:00
Stig Bjørlykke
a0cbfab6bf Fixed abbrev for "Channel rate and type". 
Bug reported by damker.

svn path=/trunk/; revision=39794
 2011-11-11 13:25:48 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Bill Meier
2bf572bc41 Remove unneeded #includes: proto.h,tvbuff.h,value_string.h,stdlib.h,... 
svn path=/trunk/; revision=38413
 2011-08-08 17:59:32 +00:00
Anders Broman
9363362f5f Channel Description includes the element identifier. 
svn path=/trunk/; revision=38310
 2011-08-02 12:52:59 +00:00
Bill Meier
fb54240c34 Fix some gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings; 
Also: misc minor cleanup: unneeded #include; whitespace, tvb_length-->tvb_reported_length

svn path=/trunk/; revision=37757
 2011-06-22 23:03:56 +00:00
Jeff Morriss
278caa12d9 Fix some (value) mistakes in value_strings. Found by Martin's patch on the -dev list. 
svn path=/trunk/; revision=37262
 2011-05-18 21:07:59 +00:00
Anders Broman
d9c5fa2537 Remove check_col, use ENC_BIG_ENDIAN. 
svn path=/trunk/; revision=37080
 2011-05-12 15:48:51 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Bill Meier
95402cf9de Fix bug: 'if ((octet & 0x80) == 80)' ==> 'if ((octet & 0x80) == 0x80)' 
Coverity 345

svn path=/trunk/; revision=36293
 2011-03-23 15:21:18 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Anders Broman
a9aca792c5 From Mike Morrin: 
Fix RSL Channel description and interference dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5479

svn path=/trunk/; revision=35169
 2010-12-10 12:39:59 +00:00
Bill Meier
03b57df5a0 Fix various typos and spelling errors. 
svn path=/trunk/; revision=35126
 2010-12-06 01:34:58 +00:00
Bill Meier
209109c2fd Define some fcns & vars as static ... 
svn path=/trunk/; revision=34458
 2010-10-10 20:07:06 +00:00
Bill Meier
055dd62063 #include <string.h> not needed. 
svn path=/trunk/; revision=32410
 2010-04-06 21:14:01 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Anders Broman
a5d39ef850 From Harald Welte: 
Correctly parse SYSTEM INFORMATION messages in RSL BCCH FILLING.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4268

svn path=/trunk/; revision=31112
 2009-11-29 09:33:22 +00:00
Jeff Morriss
88e7e2725c Add a couple of new hf_ entries to deal with the different bit positions 
for the MS Power Level and FPC in the L1 Information and MS Power IEs.

This should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4017

(though I don't have a sample capture to verify the fix and that I didn't
break anything.)

svn path=/trunk/; revision=29944
 2009-09-16 13:39:37 +00:00
Kovarththanan Rajaratnam
0a5b014cec Don't guard col_clear with col_check 
svn path=/trunk/; revision=29344
 2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Bill Meier
8ffaa3b880 Remove duplicate entry from ett[] 
svn path=/trunk/; revision=29293
 2009-08-04 18:46:51 +00:00
Michael Tüxen
9c6ee5cefd Add ip.access A-bis over IP dissector received from Harald Welte. 
Removed check_col() calls.

svn path=/trunk/; revision=29056
 2009-07-10 20:00:54 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00
Bill Meier
c0e92cbc04 Fix various typos and spelling errors (mostly in text strings) 
svn path=/trunk/; revision=27065
 2008-12-20 00:09:02 +00:00
Bill Meier
3e347bb88c Minor cleanups related to proto_reg_handoff 
svn path=/trunk/; revision=26277
 2008-09-26 17:04:01 +00:00
Anders Broman
96aa45646d First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy) 
rename the "old" one to gsm_a_common.

svn path=/trunk/; revision=25915
 2008-08-04 16:11:17 +00:00
Anders Broman
ce1abe9f3b Fix some typos etc. 
svn path=/trunk/; revision=25053
 2008-04-15 20:40:06 +00:00
Sake Blok
6bec9d3d9e From tmiller@hcjbtech.org : Spelling error on GDS DB protocol dissector: "Buffer lenght:" 
(recursively grepped through the source and corrected all occurences, even 
the ones just in comments)



svn path=/trunk/; revision=23211
 2007-10-16 23:42:33 +00:00
Stig Bjørlykke
93144c23b7 Added some forgotten return types. 
svn path=/trunk/; revision=23100
 2007-10-08 20:10:44 +00:00
Anders Broman
5be0a8cb98 All IE:s handled. 
svn path=/trunk/; revision=23098
 2007-10-08 19:58:35 +00:00
Ronnie Sahlberg
6ae363197c ifdef out a function that is not yet used 
svn path=/trunk/; revision=23055
 2007-10-02 21:21:55 +00:00
Anders Broman
3b092feb84 Fix comments 
svn path=/trunk/; revision=23054
 2007-10-02 20:28:11 +00:00
Anders Broman
9c15d7eca9 Dissect more IE's 
svn path=/trunk/; revision=23053
 2007-10-02 20:09:15 +00:00
Anders Broman
b70af70189 Fix unused functions. 
svn path=/trunk/; revision=22991
 2007-09-26 21:37:57 +00:00
Anders Broman
2e73f83c7e The unused pinfo strikes back (again). 
svn path=/trunk/; revision=22990
 2007-09-26 19:50:53 +00:00
Anders Broman
9920652ca5 Further IE dissection. 
svn path=/trunk/; revision=22989
 2007-09-26 19:01:29 +00:00
Anders Broman
797cf529eb Fix warnings. 
svn path=/trunk/; revision=22943
 2007-09-24 21:51:41 +00:00
Anders Broman
cbd2d1494c More IE:s 
svn path=/trunk/; revision=22941
 2007-09-24 21:26:31 +00:00
Bill Meier
149ff53c71 #if 0 dissect_rsl_ie_meas_res_no and dissect_rsl_ie_message_id so buildbot doesn't error out. 
svn path=/trunk/; revision=22928
 2007-09-24 00:42:34 +00:00
Anders Broman
6146d70f0e Fix a typo. 
svn path=/trunk/; revision=22927
 2007-09-23 22:30:08 +00:00
Anders Broman
283b16163c Decode more IE's 
svn path=/trunk/; revision=22925
 2007-09-23 20:57:00 +00:00
Gerald Combs
571ab2dec2 Fix compiler warnings. 
svn path=/trunk/; revision=22921
 2007-09-21 22:39:02 +00:00
Anders Broman
b3a1afa6ac Start of a Radio Signalling Link (RSL) dissector (3GPP TS 48.058). 
svn path=/trunk/; revision=22919
 2007-09-21 19:53:42 +00:00